From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.22771.1684764599986919154 for ; Mon, 22 May 2023 07:10:00 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=EnuSysH1; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: michael.d.kinney@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684764599; x=1716300599; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=IyCEaJKlKraLOqt/M76l3V/9/DNu5wW8FiJdpa2oUsE=; b=EnuSysH1CxFs20KOarujDeJ/BGDzbLqgYeoXnFOoLSH9N45uG+ctO2Y8 BniAPl8pDhk+XCF16eyqdpP7+9KCte/WKKqTHvX2E0ov02F4KODy80xVa ex16LS5amBnlJT2ZJvPC+c/m8J9E3rvLDHKjG9wwtpoa037KkghoI3MWq 7GCtnOejcs+KAySCHqizzCF1ioftHKZJ5yT1Tp6aWcqbfiNeJTon7cK9Y uaR2x/qrLYgA3OWZXlK8CoRg+z6iGBeh/gMqxwYdydE/J77dhZ7NbdUnO PiAfwCB0moyZVUAkTeNtikOt4OWkAhcG/Zvz8MBhTecYidsEcaFeZ04h4 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10718"; a="332542210" X-IronPort-AV: E=Sophos;i="6.00,184,1681196400"; d="scan'208";a="332542210" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2023 07:08:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10718"; a="680953761" X-IronPort-AV: E=Sophos;i="6.00,184,1681196400"; d="scan'208";a="680953761" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 22 May 2023 07:08:18 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 22 May 2023 07:08:18 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 22 May 2023 07:08:18 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 22 May 2023 07:08:18 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.44) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 22 May 2023 07:08:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TD6yDh/qbLsezJFp1bEtFxCZC8byv7ykPW1sEryOa67wLdV0SRXP8ukrYUU+W7Hoqi1FNEdJ8P7BvydqKJi5cCICi5wrf1kUP9lG5wLmu01p9WWCnCxc2AVbdN4iVON8Xm/uLhDuz3pawQZvnZtJmXk41iQBFW/I/xthGuys0DBQrcbAJ6/Rm0KWfhbBjEFl0HEg6RJ+cgJuovH4fH6QrypD/y90bOBxw09ihNHkRixWSHJ6wDwhtPqAZnpZ7zyzD9oIEGS9JJTtavCuMg5q5+40sGUDP+PEllnp/2ptL1kzzDD5DvXTlaczTPeOqojc4Kg0wPQ7aUOBP72WiB5e5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DlWNQB5fTqiZ0v9jMZlnVM/AWIahhsmuagSTFHyWMAk=; b=CIW0ByLoIBgSPEEzLKiXrupL/+1BWpsvxf1eqMDR7Mo62QXAhSue1sp2bMWRohvUB0cejS6kU6PxOgiH8boFOLVNZBY/k8rJCCLASfsvlDw4tuu0PPr/x48lRRWRdISabrtT0sHL5QNLXUfXHyn5zml4ShHtv1dhycizh3wCMUCfpHbRJv5tZhqTsaYTPyHEGrBo4NToV8C3ObkB0pp1yaxsEmD4QWkWL2nf/HUDY/P3Zz0mAHcoL36jTCahvZ4NF9Z/K+cbu5vaCxqVA2KjUXzI2zeUx3L2XTEBHNj/2PkPIPUahnnYZVOFFLh+NvdojsX9RGaeaJ3iS0qfjIn86A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by BY1PR11MB8055.namprd11.prod.outlook.com (2603:10b6:a03:530::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.21; Mon, 22 May 2023 14:08:15 +0000 Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::4752:67f2:9956:b277]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::4752:67f2:9956:b277%4]) with mapi id 15.20.6411.028; Mon, 22 May 2023 14:08:14 +0000 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "quic_llindhol@quicinc.com" , Ard Biesheuvel CC: "Gao, Liming" , Oliver Steffen , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH edk2-stable202305] ArmPkg/ArmMmuLib: Add missing ISB after page table update Thread-Topic: [edk2-devel] [PATCH edk2-stable202305] ArmPkg/ArmMmuLib: Add missing ISB after page table update Thread-Index: AQHZivxR6yAxFocq8kmDovAVji5B2K9mIgqAgAA1ekA= Date: Mon, 22 May 2023 14:08:14 +0000 Message-ID: References: <20230520091958.310712-1-ardb@kernel.org> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|BY1PR11MB8055:EE_ x-ms-office365-filtering-correlation-id: 79b75c53-c47c-492f-8222-08db5acdfc08 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +2n+Cc9f9VsMJqJwzH0GgSts0zSEEax857n99m4IFCVYDMa3MuOBBSt2BXj0kjzqD/MfDmUyR5dI21ji7WDfVaz3JsrNNXeS6hqrbBE1A7KKLwjCtJlIfoTpDZ24Pc5bgsNXbXJvxLeU0m3PG2+ztvQsWRcyGONhLQUNLLuwk1GAsa96LKIr7luXXOhO6uYjNAWlEVuWBqbMV0lct7cf+DCHMOThyO/+dgOx2RRqWIu9sVmbd1Awb6SqeHR5/xN5ijtXxMpIJTs9NwN1MrZJnLYVMxZTOQ1m/x1YZWiprXHaYyXC69+kRX4OARVD350bm8YiOvkbP8SbnB08vFAuLT97kuG+XFVAjwpYk5gV35C9WY0QtBQFyhD8A5tRS49gVOxYHBrfo3srVE4ulFp3DhSmAa+KhrCtcCfRQ+jsEt579IApzIwF251HuqbcrsyTwDp1uJBFqKwPgDln9PRRnDVZUCwkOShvdXFK/IelJq6aKv50B3jF0I/nJPZtmCDiEchv88vVuMQNHH6wmEBADcsEyYNOBC3s6e+vGwMvsxAzlqzwdNHihQyiX/WV0dnc/XR5HGy4Lg3VOSZGILF6o6ke9HxlsYGKFb+JIaFFEcRy/U5SWxeh9qpMZzOFyU1YXKPDfbTrhP4mwezhk+ipqg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4929.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(39860400002)(136003)(376002)(346002)(451199021)(66899021)(66556008)(64756008)(76116006)(478600001)(4326008)(966005)(66446008)(66946007)(54906003)(66476007)(110136005)(316002)(38070700005)(86362001)(33656002)(83380400001)(6506007)(26005)(9686003)(186003)(107886003)(53546011)(5660300002)(8676002)(7696005)(8936002)(71200400001)(55016003)(82960400001)(41300700001)(122000001)(2906002)(52536014)(38100700002)(15650500001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kX6AlTzXwlsn1pY64XB5UDINLdmKwumdGxJg4ULBGjknfhuRRMpdhrJWRRXg?= =?us-ascii?Q?PM2IW+kC+CHBEfnMvpd/P031FY7fBjPSWM5yUY8yDsqfh7wmwAkNuOv3ZcUl?= =?us-ascii?Q?MFcHIJ/CE5xZclB+7urP7UCA0S+qBNgy28MWO+VfjY5HywZWzQ+Df5+VxW0q?= =?us-ascii?Q?fcp1VwziPP72ssuWPQYN7J7iN/kptV3DOLLWnlSzWx1ib6/hzjswECRBi6Ne?= =?us-ascii?Q?8ttFsls29XQMj+KyrZ1F1OKFBHhe89Eyr6HpWsP+2i+OI0chN+gyIIp4Cizz?= =?us-ascii?Q?HJPr8OKMCHgd8UQxBBvD8CsX+gGsVbSxQ8yoVwrKrhyPCD46PjErZBrIdpXo?= =?us-ascii?Q?DsuqijB52qJ8kBmB7VruKeQdITqG4N0KhgviWiVq89LH/eUGoi5pzqevPKmd?= =?us-ascii?Q?7P99B27rkwwOqOLTPSvhn8KSHm0W60VViBgI/jL8BodXN/ckswn8Qu6weFT9?= =?us-ascii?Q?DvjoKDnWL+/jfy3PSA32+TNh41xQybqJ42qGE9SavXo/CMOrPhKqMe0vuzEY?= =?us-ascii?Q?59vDNIXJ+jEbFDQDdLl0mCPmg0K5ulJYi0df42NkUi8enViqrLHIR9QaiFVh?= =?us-ascii?Q?dG3szPjtraEltUJvrolzxi6lKLiMEDGM6N8soQenk28HJaZopvVxMiYujviM?= =?us-ascii?Q?z2yg1PX8hpM/5g2XfnhI8Meolb6X6hDMlQpeSj/4XmGb59s29V9Og2fIAFiQ?= =?us-ascii?Q?YJyfznAfXdPyMm005oOljNeUifaTPGnpsDSlccaR8PNxEao0NCjdtCDFU1ql?= =?us-ascii?Q?nIlX/G+rBFPaVj6xIjsXXqMpz5y7qyS6POqL23cE8R+rHdcmRWpAg3B634AG?= =?us-ascii?Q?I3+8NBK5/RJSlvNlRQWTkmajfq7XftWffJ0de76mF76grirIpHeFv7c/xn3B?= =?us-ascii?Q?051ObUxAzoWED1ev79FA9dTGtWFjUeriFlHzEroc41ZYlcrZ95WAzaQFWxnI?= =?us-ascii?Q?UJuOeRkaLWpYXlwceDwU0JAczyU4lfTCNcIYbXT6sJxnn7KjB53SFvEfdvdV?= =?us-ascii?Q?oiEJG6YFHM7Qb+I/+5NO7FOF8MUPFQcvxyMpF1K95RqdqrJgpscfsrFoQoar?= =?us-ascii?Q?n/CIiJIaey0vcLB33G3jPvK+zQ3ZcgMRJNGBEFYAug7/ZAXgcdrdsSZ7rVYL?= =?us-ascii?Q?nSTLuK+/LrheIYE5Ipbpg32X7sHaLTu/K2JVW8RMJPVOOvY11SXp3Qurkixm?= =?us-ascii?Q?lg7z7AlrmPo9/zw1DUR4pW2aTBooZ/mL52lr5vVlmfqpMgfomBEcfYOTX/oD?= =?us-ascii?Q?FZBG6kewZ/qWNRI2RsQqGkFpsUIOQuguQnBgWdEoF8txsitUhtoQucpL4FIJ?= =?us-ascii?Q?mDvhQgL4XAeq9cD6hODvTFKPm+0eZw9pvejrkqX79LWUIT6+9f2/n+P4IRZj?= =?us-ascii?Q?Nn/rud83PglwCq6ZvOPYvlt05GKOqQyp4aJxeohovGhq2Ifhnmsi3DDDDQ+M?= =?us-ascii?Q?Yf3WxQDkVzkrVZGgiZPrUdLt9SAYqOPXjIXBhpCmdxzTstAFZe+fBsGKw2Pa?= =?us-ascii?Q?4hUAiwkko5SU8lFxgYFFREp0sc8zh+Ux1fU6ic6/oyW4QrQ3pLrvph3ehsOT?= =?us-ascii?Q?37CgMze/7Yyvn+oqcAvsYNW31Rljopb1bGwu94RX?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 79b75c53-c47c-492f-8222-08db5acdfc08 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 May 2023 14:08:14.6140 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5t6aWXY6OsoaxDyrLOX0IqSQlGWoqZQa+LIX2ddRbGQafHtbO+J8sZyaICnAIQufguRJNOE9XIrUHwJkFnnNvSJPqtquy8OHLURMcalQb5g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR11MB8055 Return-Path: michael.d.kinney@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Acked-by: Michael D Kinney No objection to merging for the stable tag. Mike > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Leif > Lindholm > Sent: Monday, May 22, 2023 3:56 AM > To: Ard Biesheuvel > Cc: devel@edk2.groups.io; Gao, Liming ; > Kinney, Michael D ; Oliver Steffen > > Subject: Re: [edk2-devel] [PATCH edk2-stable202305] ArmPkg/ArmMmuLib: > Add missing ISB after page table update >=20 > On Sat, May 20, 2023 at 11:19:58 +0200, Ard Biesheuvel wrote: > > The helper that updates live page table entries writes a zero entry, > > invalidates the covered address range from the TLBs, and finally writes > > the actual entry. This ensures that no TLB conflicts can occur. > > > > Writing the final entry needs to complete before any translations can b= e > > performed, as otherwise, the zero entry, which describes an invalid > > translation, may be observed by the page table walker, resulting in a > > translation fault. For this reason, the final write is followed by a DS= B > > barrier instruction. > > > > However, this barrier will not stall the pipeline, and instruction > > fetches may still hit this invalid translation, as has been observed an= d > > reported by Oliver. To ensure that the new translation is fully active > > before returning from this helper, we have to insert an ISB barrier as > > well. > > > > Cc: Liming Gao > > Cc: Leif Lindholm > > Cc: Michael D Kinney > > Reported-by: Oliver Steffen > > Tested-by: Oliver Steffen > > Signed-off-by: Ard Biesheuvel >=20 > Reviewed-by: Leif Lindholm >=20 > We need this in the stable tag. >=20 > Note: the isb instruction forces the synchronization of certain > architectural events. It has no other effects. I.e., any issues > exposed by this addition would already have been present before it. >=20 > As such, I would suggest this addition need *not* affect the stable > tag schedule. >=20 > / > Leif >=20 > > --- > > ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibReplaceEntry.S | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git > a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibReplaceEntry.S > b/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibReplaceEntry.S > > index 887439bc042f0f16..1f0d8057926933d7 100644 > > --- a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibReplaceEntry.S > > +++ b/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibReplaceEntry.S > > @@ -65,6 +65,7 @@ > > // write updated entry > > str x1, [x0] > > dsb nshst > > + isb > > > > .L2_\@: > > .endm > > -- > > 2.39.2 > > >=20 >=20 >=20 >=20