public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"kuqin12@gmail.com" <kuqin12@gmail.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Sun, Zailiang" <zailiang.sun@intel.com>, "Qian, Yi" <yi.qian@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for VariableSmmRuntimeDxe
Date: Wed, 31 Mar 2021 02:06:21 +0000	[thread overview]
Message-ID: <CO1PR11MB49298A8CAA7FB9B9F5C12A25D27C9@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210316181038.1413-5-kuqin12@gmail.com>

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Kun Qin
> Sent: Tuesday, March 16, 2021 11:11 AM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for
> VariableSmmRuntimeDxe
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250
> 
> This change added NULL MmUnblockMemoryLib instance in PlatformPkg dsc
> file to resolve new dependency by VariableSmmRuntimeDxe. The library
> interface is consumed by variable module to better support variable
> runtime cache feature.
> 
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>> 
> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> ---
> 
> Notes:
>     v2:
>     - Added Michael K. to cc list [Zailiang]
> 
>  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
>  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc  | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> index 409f31c982d7..33e93b74800c 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> @@ -311,6 +311,7 @@ [LibraryClasses.IA32]
>    LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
>    EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf
>    HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf
> +  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
> 
>  [LibraryClasses.IA32.DXE_DRIVER]
>    DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> index 38bd825c8bdc..f7a876353649 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> @@ -313,6 +313,7 @@ [LibraryClasses.X64]
>    LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
>    EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf
>    HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf
> +  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
> 
>  [LibraryClasses.X64.DXE_DRIVER]
>    DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
> --
> 2.30.0.windows.1
> 
> 
> 
> 
> 


  reply	other threads:[~2021-03-31  2:06 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-16 18:10 [edk2-platforms][PATCH v2 0/5] Resolve dependency from MmUnblockMemoryLib Kun Qin
2021-03-16 18:10 ` [edk2-platforms][PATCH v2 1/5] MinPlatformPkg: CoreCommonLib: Added new library for VariableSmmRuntimeDxe Kun Qin
2021-03-17  7:52   ` [edk2-devel] " Zhiguang Liu
2021-03-17  8:10     ` Kun Qin
2021-03-17 14:32       ` Zhiguang Liu
2021-03-18  5:01         ` 回复: " gaoliming
2021-03-18  5:15           ` Zhiguang Liu
2021-03-16 18:10 ` [edk2-platforms][PATCH v2 2/5] MinPlatformPkg: Core Include Files: Added Tcg2Acpi driver after separation Kun Qin
2021-03-16 18:10 ` [edk2-platforms][PATCH v2 3/5] QuarkPlatformPkg: Quark DSC File: Added new library for VariableSmmRuntimeDxe Kun Qin
2021-03-16 18:10 ` [edk2-platforms][PATCH v2 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added " Kun Qin
2021-03-31  2:06   ` Michael D Kinney [this message]
2021-04-01 20:25     ` [edk2-devel] " Kun Qin
2021-04-05 22:48       ` Michael D Kinney
2021-03-16 18:10 ` [edk2-platforms][PATCH v2 5/5] Socionext: DeveloperBox DSC File: " Kun Qin
     [not found] ` <166CE5170DFC6296.20382@groups.io>
2021-03-18 17:51   ` [edk2-devel] [edk2-platforms][PATCH v2 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: " Kun Qin
     [not found]   ` <166D812F2F3DA6EF.24375@groups.io>
2021-03-30  5:34     ` Kun Qin
     [not found] ` <166CE5173C17A517.7039@groups.io>
2021-03-18 18:07   ` [edk2-devel] [edk2-platforms][PATCH v2 5/5] Socionext: DeveloperBox DSC File: " Kun Qin
2021-03-18 18:14     ` Ard Biesheuvel
2021-03-18 18:26       ` Kun Qin
2021-03-19  1:29         ` 回复: " gaoliming
2021-03-19  1:30           ` Kun Qin
2021-03-19  1:44 ` 回复: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Resolve dependency from MmUnblockMemoryLib gaoliming
2021-03-22 17:38   ` Kun Qin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB49298A8CAA7FB9B9F5C12A25D27C9@CO1PR11MB4929.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox