From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "rfc@edk2.groups.io" <rfc@edk2.groups.io>,
"ardb@kernel.org" <ardb@kernel.org>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Pedro Falcato <pedro.falcato@gmail.com>,
Leif Lindholm <leif@nuviainc.com>,
"Andrew Fish (afish@apple.com)" <afish@apple.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024
Date: Mon, 6 May 2024 15:11:09 +0000 [thread overview]
Message-ID: <CO1PR11MB49298DD294B4568BEB877438D21C2@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAMj1kXFbAp5yWCaC+Kw0B8y5eUUwQ6c+QgJcEazAR-yG8uJ19Q@mail.gmail.com>
That information is in GitHub in the PR conversation.
If you follow the link from the commit to the PR, the PR conversation shows
who set the 'push' label.
Mike
> -----Original Message-----
> From: rfc@edk2.groups.io <rfc@edk2.groups.io> On Behalf Of Ard
> Biesheuvel
> Sent: Monday, May 6, 2024 3:01 AM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Pedro Falcato <pedro.falcato@gmail.com>; rfc@edk2.groups.io; Leif
> Lindholm <leif@nuviainc.com>; Andrew Fish (afish@apple.com)
> <afish@apple.com>
> Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code
> Review from email to GitHub Pull Requests on 5-24-2024
>
> This reminds me: would it be possible to keep track of who merged a
> PR? (i.e., the person that set the 'push' label)
>
> Currently, commits just appear on the branch with the original author
> and the committer field set to something non-descript, e.g.,
>
> commit 275d0a39c42ad73a6e4929822f56f5d8c16ede96 (HEAD -> master,
> origin/master, origin/HEAD)
> Author: Gerd Hoffmann <kraxel@redhat.com>
> AuthorDate: Fri Mar 1 08:44:00 2024 +0100
> Commit: mergify[bot]
> <37929162+mergify[bot]@users.noreply.github.com>
> CommitDate: Fri Mar 1 18:47:27 2024 +0000
>
> which means we cannot tell from the git history which maintainer merged
> this.
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118600): https://edk2.groups.io/g/devel/message/118600
Mute This Topic: https://groups.io/mt/105873467/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-05-06 15:11 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 17:43 [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024 Michael D Kinney
2024-05-01 18:12 ` Leif Lindholm
2024-05-01 23:19 ` Dionna Glaze via groups.io
2024-05-02 15:59 ` Brian J. Johnson
2024-05-02 16:09 ` Dionna Glaze via groups.io
2024-05-02 16:30 ` [edk2-rfc] " Michael D Kinney
2024-05-06 16:41 ` Leara, William via groups.io
2024-05-02 1:28 ` Rebecca Cran
2024-05-02 10:21 ` Leif Lindholm
2024-05-02 3:08 ` Michael Kubacki
2024-05-02 10:57 ` Leif Lindholm
2024-05-02 16:37 ` Michael D Kinney
2024-05-03 16:58 ` Michael Kubacki
2024-05-03 16:54 ` Michael Kubacki
2024-05-02 6:33 ` Marcin Juszkiewicz
2024-05-02 10:34 ` Leif Lindholm
2024-05-02 15:21 ` Michael Kubacki
2024-05-02 16:24 ` Michael D Kinney
2024-05-03 17:21 ` Michael Kubacki
2024-05-03 19:16 ` [edk2-rfc] " Michael D Kinney
2024-05-02 9:37 ` Ard Biesheuvel
2024-05-02 15:14 ` Michael Kubacki
2024-05-03 0:35 ` [edk2-rfc] " Rebecca Cran
2024-05-02 17:50 ` Pedro Falcato
2024-05-02 18:17 ` [edk2-rfc] " Michael D Kinney
2024-05-03 17:38 ` Pedro Falcato
2024-05-03 20:12 ` Michael D Kinney
2024-05-03 20:38 ` Michael D Kinney
2024-05-04 0:57 ` Michael Kubacki
2024-05-05 18:10 ` Pedro Falcato
2024-05-06 10:00 ` Ard Biesheuvel
2024-05-06 15:11 ` Michael D Kinney [this message]
2024-05-06 15:30 ` Ard Biesheuvel
2024-05-06 15:56 ` Michael D Kinney
2024-05-06 16:09 ` Ard Biesheuvel
2024-05-10 20:57 ` Brian J. Johnson
2024-05-15 17:03 ` Michael D Kinney
2024-05-24 12:20 ` [edk2-devel] [edk2-rfc] " Rebecca Cran
2024-05-24 14:53 ` Michael Kubacki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB49298DD294B4568BEB877438D21C2@CO1PR11MB4929.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox