From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 793AAAC189C for ; Fri, 19 Apr 2024 16:47:46 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=S+SDzNI+6NEO7L2xp/SgklBe2suP7hA5wyrE/RDNhA8=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1713545265; v=1; b=dSw2bUK+Mpcd5B9sSmS2HpHExVZgpLmxE2Gt947KLzgLvEm6LBbH5UBKoPm7gqbEs1cudF3B oN9dl8FeUWoB0uQ+C5DmDU5c1P0EayqHzp03U/dtf4mfh7AW6BdQcnRNzOIVBnvrTVZ9EWjtjae eQjv7kURMCzfk6xeSVrBVuS5KsOWhBHSU+LxnF4lj+aSrUHxnBOatnGe/Qy03UgBP4nRNxYjnDB A623Irkl7Qa7Ehh6us68TLQzpt7xg8iZZqzsvNCfaIa1VXEnyv3nclqzuusOLXvHbPKeDum0Zyk hP1lOgBgRHqgbrV/EqXC0k62NESoraYmQlzJYM6JnLISQ== X-Received: by 127.0.0.2 with SMTP id n2UuYY7687511xOTHKNCmR1L; Fri, 19 Apr 2024 09:47:45 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mx.groups.io with SMTP id smtpd.web11.26327.1713545264220192017 for ; Fri, 19 Apr 2024 09:47:44 -0700 X-CSE-ConnectionGUID: Ao2Q96/sRJ2U7TNv7RDSVQ== X-CSE-MsgGUID: O7k/mj12QOqvdKCj9d2dhw== X-IronPort-AV: E=McAfee;i="6600,9927,11049"; a="19850803" X-IronPort-AV: E=Sophos;i="6.07,214,1708416000"; d="scan'208";a="19850803" X-Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2024 09:47:44 -0700 X-CSE-ConnectionGUID: 44y2BdC/SeSwapYmTFKTEQ== X-CSE-MsgGUID: B3kYcTLkRqqH5HUG4kc4sQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,214,1708416000"; d="scan'208";a="60823890" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 19 Apr 2024 09:47:44 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 19 Apr 2024 09:47:42 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 19 Apr 2024 09:47:42 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 19 Apr 2024 09:47:42 -0700 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by DM4PR11MB7758.namprd11.prod.outlook.com (2603:10b6:8:101::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.49; Fri, 19 Apr 2024 16:47:40 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::e34e:4d18:b93e:c368]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::e34e:4d18:b93e:c368%5]) with mapi id 15.20.7519.014; Fri, 19 Apr 2024 16:47:40 +0000 From: "Michael D Kinney" To: "Jayaprakash, N" , "devel@edk2.groups.io" CC: Rebecca Cran , "Kinney, Michael D" Subject: Re: [edk2-devel] [edk2-libc Patch v3 1/1] ek2-libc: wrmsr function available in edk2module is not working as expected Thread-Topic: [edk2-libc Patch v3 1/1] ek2-libc: wrmsr function available in edk2module is not working as expected Thread-Index: AQHakjh507xBCzc3qkqKlxQSTuLk+7Fvzg/g Date: Fri, 19 Apr 2024 16:47:40 +0000 Message-ID: References: <20240419090319.660-1-n.jayaprakash@intel.com> <20240419090319.660-2-n.jayaprakash@intel.com> In-Reply-To: <20240419090319.660-2-n.jayaprakash@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|DM4PR11MB7758:EE_ x-ms-office365-filtering-correlation-id: e96624c3-01bd-44b6-7bb9-08dc60906d0f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: wSX1pmFTTycYwVoXF2nO+urqkiwHUEYU364g9oOmufI2MGwK9DJsEib6wUwR6gdRYHyFV3BIrSxqYlcP11EisXN3JAs+sMZIMs7vY/ZpCKiS6k+qtGQp6/qfpJiiSwSpGe7RL2CojmTSBtly1UEK4YKGW/LMsJ17i78LxxtBXY1zpAN4oXVAiyv7yDNIGYJCUE27YEQA9ONg4bKgrFsDmB5Tw7itpEQ48Uc23ijFuB6ZojKcIOhemkBR3Z1IHhsSuJzZ2jgMk2iK52/SbSIO1JmDB48Chwa/HmdReoKqZwgzMOMkhSBkrLt4JmZMsHIJIV2pwxlRlFgOfisPW85yanOw2Uu9KiIxWuRRQxhAB59shBsWdj3yf7bo9YaGXvO9XfWmebcZcR+y5DpA060q+IDcRaPqIWJARJYCjRL+cTy64cFijMDTzFvOsXGeJQ6bdGiFwLqH36DA4NRDKeHe08H8V1fIDq+gFXa1y7FL/KuRSjUWudLDBaWcCChT3Iqv27MJfSd75S7PxTztSyFm+YniSv/aKWOmlebaeH5Io3b8wakqwcKceFc23oAJ/e4IvoqpynBX5ILyV1/aTxGdMNsY2T2PPG6tSMCSCf+5xV+0w5K24g9XrMsVinmnOD+pmzVfmqHNXzDhyXxouhaWyHMwyLv7zK9LN0GooCnfn6s= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OCbsKqRMlOPgPzsHMpAsWzMpq1Msi5zXbZaoCVl0n2wumkw7OCyIIOJ8IndS?= =?us-ascii?Q?zzD0AZ3s/PdHhBziEc9kjbbeTCEHVDUjmCfAHBThBjjXPMMMkzUBJX14ARbq?= =?us-ascii?Q?gVDsvKyuzVKZ/A3hkd+P2bg1Dg+KKiyOotQCFAcXFaCjlFv7TMclizA1I3KI?= =?us-ascii?Q?WtAbFzam8GuwrS/z2hgzCD14gwAjVkHoz21iSqIngRiVxAvdcgMH7EjNdfpu?= =?us-ascii?Q?ylPfyRrRQIWmv6LkVvy7eJI9kwXlWKbSLjSb0AcZJmf9eVKgkvpvMYjH6IMG?= =?us-ascii?Q?KEghTlKx2ZInLWV6RLeemcQbvd4upJQjKp8+vvcnt/Njd3fPySm3QHdoKnW/?= =?us-ascii?Q?jQ+PjHuMogrS/HoRQx9yfp7b11ACmSbaK3t2aGgx20r2TgOiR63IdW/wENvN?= =?us-ascii?Q?A77x9opfbaAqQyFCNzPYklBV3T/yYzG6l03z+til76N6apZdy3BqPSvQ2ENW?= =?us-ascii?Q?3p34a7Ek9G7mxLjNjlNElCr5Sj7wQT9bXtgo2Nqp82rsAxxk3bOguMxLLgvZ?= =?us-ascii?Q?Rz0PAmG8wKj93Xq9Q3kzc852dxBuvqkNsvBSM7ILI16tUlAPU0UhvD24MQSc?= =?us-ascii?Q?qInJP5KDQBr98YYjizcRvFuJsvO+iMk6yWHfm76HwVkFkrb3goaTnQhSqkIm?= =?us-ascii?Q?0/Lzns5lZTdO1Czw9YyZ+vztfpVUtgy6Fb5XDV1Tkt9mFFwX9BMk7wl5qWzk?= =?us-ascii?Q?2gECOP+Kw/VyirVO3wFFoOQBWGB0Gy5pDH/4KNpgDKziKLmrcYm96p/RstvC?= =?us-ascii?Q?NV78RZZAaCDjTgYrkpNJJTqkbz7gS5RyWeurEBsz4IwgNmwx/lJyk1Jg7kFq?= =?us-ascii?Q?l7e4iA6Tcd/IiLR0K9rv7K3YUJ2hzDB84Pgt+exnO2o26/LoCiGTUVYugepp?= =?us-ascii?Q?ZuIUrT0sP+B+ZTefcW9lwZ0cK6Cm+itrimzI9eAS8pLrYIghvxt8/Igm/WXS?= =?us-ascii?Q?vk0vDIUQqNssnT75g+OUaH/bgM8TldlB6CjaEmGszzHRW7oQPFvryAFP4eMN?= =?us-ascii?Q?jrewAd310g7Vw1ybekCq24h1jxQQlXukpayL0fJ+qd9IlqRgn33kywW0/7i5?= =?us-ascii?Q?mTvd/W3xLkPeIorJBo2vTBfEkei7HIj5rkZx0614WoiI5U5DbmPfxmRQD09r?= =?us-ascii?Q?+FZUzzCwZ1N706F4MDLh5a2obntoQXMzOn90a7mYzyO14QqmZ2BwscqWDu+r?= =?us-ascii?Q?diAKyVOqkbJOlcNEPvYK+Aa2LL42Kbs/9vXEnXPRlhCXbZYOmXvEa3kcGuc0?= =?us-ascii?Q?kqatr+SbLX7n8FkiJM3MNHPWm7zHfqxm+Yctu6q5qNWSwNCFXxc/MiQVa2X6?= =?us-ascii?Q?Hc6oJ37w+oeQmkEX6eZCjWE6mWJP3qL0ASVVChYGi5foefguEYXS+9L1OBri?= =?us-ascii?Q?bhCu3beZnFRLN6oUdUApvtiDlQ1YAKY0dp1HbNEDQ2eu6hhqPV58FNgKJ7m5?= =?us-ascii?Q?iH8jI2EKi9fLoxBDW1hO2uHfUP3rJ0DIUje/6Vx1e1jgj4kKBwkgVmisfPXG?= =?us-ascii?Q?7RFcuGzI2SGLPEOfkN/fJ1UkZf87DA3yF6gAhj/uZ4RztysSgjfr6IBfZrkv?= =?us-ascii?Q?MKQJEdps4z5DHYQe2Dw1E7wzx2swtK1ePftufAbR?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e96624c3-01bd-44b6-7bb9-08dc60906d0f X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2024 16:47:40.0515 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NXp0IZmmLMG0yZQp7ql0UYmX01Le7rZKqHcxLJcG4oiR+VVgSIkyzDN7q2FnfiwVF+ykI54iVZVjkYOmgbtBAu35VJja7OzejkDxoZO0FFU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7758 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 19 Apr 2024 09:47:44 -0700 Resent-From: michael.d.kinney@intel.com Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: BBZ5ZO1J1d9BWKDiT7GaQN6ux7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=dSw2bUK+; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Michael D Kinney > -----Original Message----- > From: Jayaprakash, N > Sent: Friday, April 19, 2024 2:01 AM > To: devel@edk2.groups.io > Cc: Jayaprakash, N ; Rebecca Cran > ; Kinney, Michael D > Subject: [edk2-libc Patch v3 1/1] ek2-libc: wrmsr function available > in edk2module is not working as expected >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4745 >=20 > This commit fixes the issue reported in the BZ4745. > The wrmsr was always writing 0 to the higher 32 bits of the msr > register. > This was due to a logical flaw in the code, where the input variable > of > type unsigned int was left shitted by 32 bits without explicitly > converting it to a 64 bit value. >=20 > The issue is with the below statement. > data =3D vedx << 32 | veax; > Where the vedx which is an unsigned int, after left shifting by 32 > bits > its value will be set to 0. Because of this the higher 32 bits of the > MSR > are always set to 0. This has been fixed by this commit. >=20 > Cc: Rebecca Cran > Cc: Michael D Kinney > Cc: Jayaprakash N > Signed-off-by: Jayaprakash N > --- > .../Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c | 2 > +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/AppPkg/Applications/Python/Python-3.6.8/PyMod- > 3.6.8/Modules/edk2module.c b/AppPkg/Applications/Python/Python- > 3.6.8/PyMod-3.6.8/Modules/edk2module.c > index d6af8da..f688b51 100644 > --- a/AppPkg/Applications/Python/Python-3.6.8/PyMod- > 3.6.8/Modules/edk2module.c > +++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod- > 3.6.8/Modules/edk2module.c > @@ -3886,7 +3886,7 @@ edk2_wrmsr(PyObject *self, PyObject *args) > UINT64 data =3D 0; > if (!PyArg_ParseTuple(args, "III", &vecx, &veax, &vedx)) > return NULL; > - data =3D vedx << 32 | veax; > + data =3D LShiftU64(vedx, 32) | veax; > Py_BEGIN_ALLOW_THREADS > AsmWriteMsr64(vecx, data); > Py_END_ALLOW_THREADS > -- > 2.44.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118035): https://edk2.groups.io/g/devel/message/118035 Mute This Topic: https://groups.io/mt/105614477/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-