From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2CDC0AC175F for ; Thu, 14 Sep 2023 17:48:31 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=zEn/Y9kdeDumTqsShsAD86FkHcHOhveVsfqPlc95Dxg=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694713709; v=1; b=VTAU/nKZxPc54dnAG7TrQhvPG0hF2Qj6PhnHvO/dJWF7+WqywBW8gK4m4XW64T8NlCh5OeiC kIFr/4WKeC/Aop2O6RyxPCwOUjxnRiBZJkB1GgNetEbYSCjedFupuR1xELFoadU8M7dp/ZTiCwu NOiasTGHDncFbhcaO4W1c4DI= X-Received: by 127.0.0.2 with SMTP id TRiZYY7687511xZnXBcdIgRX; Thu, 14 Sep 2023 10:48:29 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.1149.1694713708984579859 for ; Thu, 14 Sep 2023 10:48:29 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10833"; a="369328257" X-IronPort-AV: E=Sophos;i="6.02,146,1688454000"; d="scan'208";a="369328257" X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2023 10:48:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10833"; a="918329880" X-IronPort-AV: E=Sophos;i="6.02,146,1688454000"; d="scan'208";a="918329880" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 14 Sep 2023 10:48:21 -0700 X-Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Thu, 14 Sep 2023 10:48:20 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Thu, 14 Sep 2023 10:48:20 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Thu, 14 Sep 2023 10:48:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b3RMyxxQnnWiZNaRit0PHc2CyasNKn5MpudlPZjieH4vhw6EqxIxyLtOyb8hbvSd40jusaK47law/JXaNTwPTkZNWj1Dd8vL2FsD3+ihYgHCaHWwgmpIS4iAKI1Fy2rfPYZ0eyEd6E94Br/uwLTNFrqy68A3kveSUppnnXsEsv0nhpJmJumYUZ+9QSO+hvQNLgzwRN9VAigYcTZQ39CjYu/qfDoV3l3hP1FtvJ8jKn7NmINBUInEUsmcraPKP2sC9OoMA4iM6Ai1jmH/UIJ1IGMq4kSfshAeCkAWSjxXu8Pfk7GHKNaRhRtn5vnplwEAjLvP4o64QgAOIFWz97CqyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ag0OnYPdR93Ai1sBCsQuUr1/Oonq7ayPnw5f5t62XG4=; b=mJ34HFURcgYF9hNhxQ7vXaFqkAbhhOwAqa/9ZKLOgji49T00t4DWCrIAR9u/QZc0RGQicZWaZ4uZNBf5r4dcR5RxalLzIYDdNLZrEllfvNwrveTKEkZZzf4QJdFljMYEjRqiz6Xn/ytgGYphLZ7ibtLU4VHCU9NujZ7MPjnKRlGUHjUjjP/wM65ECc1jzgGO6ReaKGQ8EKVrVWEj8qcqp8FIrMa8urddCxZaG9VxvpyRK0AqODxUyCT/Iq17gvUHIB1xbruCWZpECLTi4cVRF7pNf4UYsQKz/F8y8f/+nS8X4as2NjQ88KF4kWkptOErKq/6fadnH+ckEuNq4JVj8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by CH3PR11MB8749.namprd11.prod.outlook.com (2603:10b6:610:1c9::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.36; Thu, 14 Sep 2023 17:48:18 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::eaa6:1c0:c33f:2a11]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::eaa6:1c0:c33f:2a11%2]) with mapi id 15.20.6768.036; Thu, 14 Sep 2023 17:48:18 +0000 From: "Michael D Kinney" To: "Lien, HoraceX" , "devel@edk2.groups.io" , "Gao, Liming" CC: "Liu, Zhiguang" , "Bi, Dandan" , "Zeng, Star" , "Gao, Zhichao" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is not match with SMBIOS version Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is not match with SMBIOS version Thread-Index: AQHZ22UDlonZ8eWV50a1a49r60TCnLAEkQEAgAD4/jCACZy7oIAA0LTwgADBUICACW1KgIAAie8Q Date: Thu, 14 Sep 2023 17:48:18 +0000 Message-ID: References: <0439b4b435989b2604d325451ae0fa6b70bb0a20.1693386097.git.horacex.lien@intel.com> <1780B48BF009A270.23790@groups.io> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|CH3PR11MB8749:EE_ x-ms-office365-filtering-correlation-id: c04f8580-1d5b-47ba-479d-08dbb54ac78e x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: J/ZZHQRVJUY2udR+iHtAQfItjEIRvxgU1uLOIraPYSuJGXA4wPMjoj+IiWdsa5vGJURp5tS72SD2hi+SyxQVHeHXBF9ZlrO/ABUlCfIu5MDzDmWHVMqE/Zjksw/Ly9ZanjraRXmzT3VF3Kkf0U08py5Xgt4bpZm2GjT/bpw+njMB3Kog6yIdsfmKGvXnsETaPi7pm0CYnCwN9G1SWaBvEYUVMBEukCCPpPDrVPWvYzUDDBpn69QChlmZhLJyKjfpdMBjXA8GseKj3Kw0SSz6tvA9SoFokJwVY0tDxe9yWY+0Hgbrk/VFFlt69oHN8QQq3OMuHSvA2GNIwDy+jtes4Afemwq+ASm2+FIyUEnIU/dCEMmOWau/XlkatuRmzv0XbcL3gKnHNBJOHvJY7paGM3L2qnJ+gWM/ZnSslbGMZOdmwG4Mk91T6R9C3cKMlyhXxa5loxDBuAPbi03REAG960FCwusUfKBYqXArjUtDL4ctXejs7J9VLHNmutdxq/CwS+AMpIpAjriTXfCbQ7xagCIFkOvqJKk4yl5Pa+dQ8l41XhYqZ5c8mjkkJU7rVYKDY9N55jaHN2TUCj52DXuTR/kHf1ePBvGlX4G6CmV88ZXvwy19iVOJMOlQGzTcy87uqHN8hQwOhdqIxk2Z9nEhCpNUQ6rmOHd7yuI3i8E12I0= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3LJ4jet5YjkMOL+1M1AUBvcCHZLSmHY/rbLW2nA0+tt3wd6qCZvebxwUrRhx?= =?us-ascii?Q?M4H5JV9+Ce3ghw88s+v3iZ6sxdYchC+v88+qqqaLYUQEFUFICbMCloAUCd6C?= =?us-ascii?Q?ChgaWpxqZSGrCssNUonJ/aUxJDNI8eOMlPysCodj9AXM09WRfRkA2ljjShm6?= =?us-ascii?Q?oBMRZhyiY6M4732dTYJGekNcL0JfRxni0+EuFt7aio1G0GBTjELOI+dYaKd1?= =?us-ascii?Q?gJsjtK0O+gLiRTzlLw4SZQegkp05hzAVuuyTyl4KdovxJ3VrWCs+Wl+g5DDS?= =?us-ascii?Q?jADYPC6DNv6SkfZQsM4p7YFH6ZcaKTPGQu4/dFwkjxzoJHSi+ZHrokVoppqM?= =?us-ascii?Q?ORRTJ/N7gDif26UNGgflHaJ0DjV+dFFJjnzsxUcUfANTySsZ2Tt+wyFGitxJ?= =?us-ascii?Q?oPiNElQi/4j1jaCSg+vyG+kAHeTeOdcvot95tH8mbDtdt3N9yzvIiIImsKkg?= =?us-ascii?Q?7YbP2bxcU88FqQVJ3MCmQMspLyirVWGrl0ekQZFHU1ncW02IObxxB0/3FMJK?= =?us-ascii?Q?MYxyX4Lm9srFRSaDlGCbgJxkRLETYzxW7YhFJ48g/EdeT5NviwInswAFEZgj?= =?us-ascii?Q?dCaX8feICfjfcuXORjvebWhuyp1uwp1OTHZ/MDgthNUWBx5FzRiPNzyDwGRS?= =?us-ascii?Q?smJzJ+mrxe5+93gar2ui5EglBuLRHuWF5YE5zvVjwmUUm4vk9Qa6YOdWhkCq?= =?us-ascii?Q?0nYtbUvognbh9K9ewxTzdE8pY4FZleAzQ6TLAZp4DEZannl4UcitZd9Lrbfz?= =?us-ascii?Q?DnGuV8nLIdh7GudoHlDhw3W7xoTD4anH7P74GXnAKm3+TSrL6fWlsoLpTYf8?= =?us-ascii?Q?FCI+mXl9YBYLY0V4K6s3RH4mDnbEsh9L8+Kc/u4bb1afCh2RWvc7cLcauihF?= =?us-ascii?Q?Q+pMRXnSJjcEdYHK1JJh0vDcdOa7sNvK5nd7pqAVQh9HAALQsp2bUL8NcjX5?= =?us-ascii?Q?b2P2iu4d5dqsFFbb+LmB18bDapLdG7RcVtM2d3ktU7W/i+dVQCm0uxzjdaRL?= =?us-ascii?Q?Phv7TOek/rjspjc9wdhvo/haei61Kbhdi9rm+RLXn4uoixNSMR19OabbyIi8?= =?us-ascii?Q?qHaeg/hHad8G6C+YgcAXEsqlwB6g696kQKlWpIXBmdi5H59RuRj7D5RAmyY2?= =?us-ascii?Q?joAq1f/7VGs7NxhmCW5NXSbzljR6VKAKa7crMC7+zyscMobj+/8W0mconmQH?= =?us-ascii?Q?EXtBCirt5FPWAXois9rT7YCEOcsHFdQ7AE+Vkf6f6PVDeVvhs/kyW/WcO+78?= =?us-ascii?Q?BqER8rjQuyLCvCp+BuO+37fId1k9b39AbyrQC6sOM9c6/bwXUlDYpjVqd/9n?= =?us-ascii?Q?JuywFd0qxFIpswqnGd6UbsfHTWz3qTL4uAjTyrHlDjU9Yw4Mm+rynBNu2vGZ?= =?us-ascii?Q?NZKx3SjJk/s1tBmGsx0fnStruzclo8FA2+vXLwCivePVWvk2JLJgJDwSZ+jh?= =?us-ascii?Q?0pq6VcVVRFf4vcj83b/KoPDFw5bXYbkMOgRaH9JulvVyWmJiLg4sVbdE1T9G?= =?us-ascii?Q?OOk14sjVfcpnQaEGBJczC+obc/6YPQzkuOKx/OZ2W1Ke3ro3xyhjGC6IG3Ub?= =?us-ascii?Q?bekKf5XLbCpSxPi0GaNZx5EXpBFNh2kDp9pFd9o7jgCZe2nM8XCM1b1vLUKJ?= =?us-ascii?Q?/A=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c04f8580-1d5b-47ba-479d-08dbb54ac78e X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2023 17:48:18.3070 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zvKhH3oxowgLsWvVR8dMtVJJsJcUtZr6lwmZVxqICZsu/oti/CpW+eJr87+dmMBatar0aVzGKSj9nSDob8Fe3lMqGZs4T+n1QXk3ijUKQYY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8749 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: nocVsCKFjaWp3cF6bXikAXyax7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="VTAU/nKZ"; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Forcing to 0 does not sound right. You did not answer my question about the property of the global variables. Without knowing the format of the information in the global variables you cannot safely use them. If they are in BCD then no need to check for out of range. If they are hex values, then you have to use conversion function= s. Mike > -----Original Message----- > From: Lien, HoraceX > Sent: Thursday, September 14, 2023 2:33 AM > To: Kinney, Michael D ; devel@edk2.groups.io; > Gao, Liming > Cc: Liu, Zhiguang ; Bi, Dandan > ; Zeng, Star ; Gao, Zhichao > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision > is not match with SMBIOS version >=20 > Hi Mike, >=20 > https://github.com/tianocore/edk2/pull/4771 > I have changed code following rule: It is only accept range 0-9 for Major > and Minor version to fill in SmbiosBcdRevision, if one of Major or Minor > is greater than 9 then fill in 00h. >=20 > Please help to review this, thanks :) >=20 > Thanks, > Horace Lien >=20 > -----Original Message----- > From: Lien, HoraceX > Sent: Friday, September 8, 2023 5:35 PM > To: Kinney, Michael D ; devel@edk2.groups.io; > Gao, Liming > Cc: Liu, Zhiguang ; Bi, Dandan > ; Zeng, Star ; Gao, Zhichao > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision > is not match with SMBIOS version >=20 > Hi Mike, >=20 > No, we didn't guarantee this before. Add comments to descript BCD field > is good point. > I have reviewed SMBIOS spec for SmbiosBcdRevision field, it mentions "If > the value is 00h, only the Major and Minor Versions in offsets 6 and 7 of > the Entry Point Structure provide the version information. ". So, I have > new idea to implement this, I will filter range 0-9 for Major/Minor > version to fill in SmbiosBcdRevision, if one of Major or Minor is greater > than 9 then fill in 00h. > Do you think it is ok? >=20 > Thanks for your reply. >=20 > Thanks, > Horace Lien >=20 > -----Original Message----- > From: Kinney, Michael D > Sent: Friday, September 8, 2023 6:05 AM > To: Lien, HoraceX ; devel@edk2.groups.io; Gao, > Liming > Cc: Liu, Zhiguang ; Bi, Dandan > ; Zeng, Star ; Gao, Zhichao > ; Kinney, Michael D > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision > is not match with SMBIOS version >=20 > I was asking about the property of the global variables being used in > this patch. Are they already guaranteed to be in BSD format and in range > 0..9. If so, then no additional code changes would be required. > However, it would be good to add comments about the properties of those > global variables and why they can be used to directly assign to fields > that are required to be in BSD format. >=20 > Mike >=20 > > -----Original Message----- > > From: Lien, HoraceX > > Sent: Thursday, September 7, 2023 2:41 AM > > To: devel@edk2.groups.io; Kinney, Michael D > > ; Gao, Liming > > Cc: Liu, Zhiguang ; Bi, Dandan > > ; Zeng, Star ; Gao, Zhichao > > ; Lien, HoraceX > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix > > BcdRevision is not match with SMBIOS version > > > > Hi Mike, > > > > Could you please reply for me? > > If you want to filter range 0-9, then I will send PR again. > > > > Thanks, > > Horace Lien > > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Lien, > > HoraceX > > Sent: Friday, September 1, 2023 3:06 PM > > To: Kinney, Michael D ; > > devel@edk2.groups.io > > Cc: Liu, Zhiguang ; Bi, Dandan > > ; Zeng, Star ; Gao, Zhichao > > > > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix > > BcdRevision is not match with SMBIOS version > > > > Hi Mike, > > > > I have change code to > > EntryPointStructureData.SmbiosBcdRevision =3D > > ((mPrivateData.Smbios.MajorVersion & 0x0f) << 4) | > > (mPrivateData.Smbios.MinorVersion & 0x0f); Add &0x0F to mask upper > > nibble bit, do we still need to guarantee that range is between 0-9? > > Because the old code only filtered 4 bits, instead of accurately > > filtering the number range 0-9. > > > > Thanks, > > Horace Lien > > > > -----Original Message----- > > From: Kinney, Michael D > > Sent: Thursday, August 31, 2023 11:56 PM > > To: devel@edk2.groups.io; Lien, HoraceX > > Cc: Liu, Zhiguang ; Bi, Dandan > > ; Zeng, Star ; Gao, Zhichao > > ; Kinney, Michael D > > > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix > > BcdRevision is not match with SMBIOS version > > > > Are mPrivateData.Smbios.MajorVersion and > > mPrivateData.Smbios.MinorVersion guaranteed to be in range 0..9? > > > > Mike > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of > > > horacex.lien@intel.com > > > Sent: Wednesday, August 30, 2023 2:13 AM > > > To: devel@edk2.groups.io > > > Cc: Lien, HoraceX ; Liu, Zhiguang > > > ; Bi, Dandan ; Zeng, > > > Star ; Gao, Zhichao > > > Subject: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix > > > BcdRevision is not match with SMBIOS version > > > > > > From: HoraceX Lien > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4544 > > > > > > These value of Major/Minor version are updated from SMBIOS memory > > > data, but BCD Revision is updated from PCD PcdSmbiosVersion. > > > We should also update PCD PcdSmbiosVersion from SMBIOS memory data, > > > to ensure that get consistent version value. > > > > > > Cc: Zhiguang Liu > > > Cc: Dandan Bi > > > Cc: Star Zeng > > > Cc: Zhichao Gao > > > Signed-off-by: HoraceX Lien > > > --- > > > MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c > > > b/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c > > > index 1a86e69d3c..e3f6215033 100644 > > > --- a/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c > > > +++ b/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c > > > @@ -1072,7 +1072,7 @@ SmbiosCreateTable ( > > > DEBUG ((DEBUG_INFO, "SmbiosCreateTable: Initialize 32-bit entry > > > point structure\n")); > > > > > > EntryPointStructureData.MajorVersion =3D > > > mPrivateData.Smbios.MajorVersion; > > > > > > EntryPointStructureData.MinorVersion =3D > > > mPrivateData.Smbios.MinorVersion; > > > > > > - EntryPointStructureData.SmbiosBcdRevision =3D (UINT8)((PcdGet16 > > > (PcdSmbiosVersion) >> 4) & 0xf0) | (UINT8)(PcdGet16 > > > (PcdSmbiosVersion) & 0x0f); > > > > > > + EntryPointStructureData.SmbiosBcdRevision =3D > > > (mPrivateData.Smbios.MajorVersion << 4) | > > > mPrivateData.Smbios.MinorVersion; > > > > > > PhysicalAddress =3D 0xffffffff; > > > > > > Status =3D gBS->AllocatePages= ( > > > > > > > > > AllocateMaxAddress, > > > > > > -- > > > 2.31.1.windows.1 > > > > > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > > Groups.io Links: You receive all messages sent to this group. > > > View/Reply Online (#108150): > > > https://edk2.groups.io/g/devel/message/108150 > > > Mute This Topic: https://groups.io/mt/101057293/1643496 > > > Group Owner: devel+owner@edk2.groups.io > > > Unsubscribe: https://edk2.groups.io/g/devel/unsub > > > [michael.d.kinney@intel.com] > > > -=3D-=3D-=3D-=3D-=3D-=3D > > > > > > > > > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108653): https://edk2.groups.io/g/devel/message/108653 Mute This Topic: https://groups.io/mt/101057293/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-