* [PATCH v5] MdePkg/Include: Add IPMI KCS definitions
@ 2023-03-24 9:14 Chang, Abner
2023-03-25 15:33 ` [edk2-devel] " Michael D Kinney
0 siblings, 1 reply; 4+ messages in thread
From: Chang, Abner @ 2023-03-24 9:14 UTC (permalink / raw)
To: devel
Cc: Michael D Kinney, Liming Gao, Zhiguang Liu, Nickle Wang,
Igor Kulchytskyy, Isaac Oram, Abdul Lateef Attar
From: Abner Chang <abner.chang@amd.com>
BZ #4354
This change adds definitions for IPMI KCS.
Spec ref:
https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html
Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
Acked-by: Isaac Oram <isaac.w.oram@intel.com>
---
MdePkg/MdePkg.dec | 6 ++
MdePkg/Include/IndustryStandard/IpmiKcs.h | 76 +++++++++++++++++++++++
2 files changed, 82 insertions(+)
create mode 100644 MdePkg/Include/IndustryStandard/IpmiKcs.h
diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
index 2d643bede1d..5cf04bc0cb6 100644
--- a/MdePkg/MdePkg.dec
+++ b/MdePkg/MdePkg.dec
@@ -9,6 +9,7 @@
# (C) Copyright 2016 - 2021 Hewlett Packard Enterprise Development LP<BR>
# Copyright (c) 2022, Loongson Technology Corporation Limited. All rights reserved.<BR>
# Copyright (c) 2021 - 2022, Arm Limited. All rights reserved.<BR>
+# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -2342,6 +2343,11 @@
# @Prompt Memory Address of GuidedExtractHandler Table.
gEfiMdePkgTokenSpaceGuid.PcdGuidedExtractHandlerTableAddress|0x1000000|UINT64|0x30001015
+ ## This value is the IPMI KCS Interface I/O base address used to transmit IPMI commands.
+ # The value of 0xca2 is the default I/O base address defined in IPMI specification.
+ # @Prompt IPMI KCS Interface I/O Base Address
+ gEfiMdePkgTokenSpaceGuid.PcdIpmiKcsIoBaseAddress|0xca2|UINT16|0x00000031
+
[PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
## This value is used to set the base address of PCI express hierarchy.
# @Prompt PCI Express Base Address.
diff --git a/MdePkg/Include/IndustryStandard/IpmiKcs.h b/MdePkg/Include/IndustryStandard/IpmiKcs.h
new file mode 100644
index 00000000000..7b3ba45bf9d
--- /dev/null
+++ b/MdePkg/Include/IndustryStandard/IpmiKcs.h
@@ -0,0 +1,76 @@
+/** @file
+ IPMI KCS Register Definitions
+
+ Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
+ @par Revision Reference:
+ IPMI Specification
+ Version 2.0, Rev. 1.1
+ https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html
+**/
+
+#ifndef IPMI_KCS_H_
+#define IPMI_KCS_H_
+
+#define IPMI_KCS_STATUS_REGISTER_OFFSET 1
+#define IPMI_KCS_COMMAND_REGISTER_OFFSET 1
+#define IPMI_KCS_DATA_OUT_REGISTER_OFFSET 0
+#define IPMI_KCS_DATA_IN_REGISTER_OFFSET 0
+
+///
+/// IPMI KCS Interface Status Bits
+///
+#define IPMI_KCS_OBF BIT0
+#define IPMI_KCS_IBF BIT1
+#define IPMI_KCS_SMS_ATN BIT2
+#define IPMI_KCS_COMMAND_DATA BIT3
+#define IPMI_KCS_OEM1 BIT4
+#define IPMI_KCS_OEM2 BIT5
+#define IPMI_KCS_S0 BIT6
+#define IPMI_KCS_S1 BIT7
+
+///
+/// IPMI KCS Interface Control Codes
+///
+#define IPMI_KCS_CONTROL_CODE_GET_STATUS_ABORT 0x60
+#define IPMI_KCS_CONTROL_CODE_WRITE_START 0x61
+#define IPMI_KCS_CONTROL_CODE_WRITE_END 0x62
+#define IPMI_KCS_CONTROL_CODE_READ 0x68
+
+///
+/// Status Codes
+///
+#define IPMI_KCS_STATUS_NO_ERROR 0x00
+#define IPMI_KCS_STATUS_ABORT 0x01
+#define IPMI_KCS_STATUS_ILLEGAL 0x02
+#define IPMI_KCS_STATUS_LENGTH_ERROR 0x06
+#define IPMI_KCS_STATUS_UNSPECIFIED 0xFF
+
+///
+/// KCS Interface State Bit
+///
+typedef enum {
+ IPMI_KCS_IDLE_STATE = 0,
+ IPMI_KCS_READ_STATE,
+ IPMI_KCS_WRITE_STATE,
+ IPMI_KCS_ERROR_STATE
+} IPMI_KCS_STATE;
+
+///
+/// IPMI KCS Interface Request Format
+///
+typedef struct {
+ UINT8 NetFunc;
+ UINT8 Command;
+ UINT8 Data[];
+} IPMI_KCS_REQUEST_HEADER;
+
+///
+/// IPMI KCS Interface Response Format
+///
+typedef struct {
+ UINT8 NetFunc;
+ UINT8 Command;
+} IPMI_KCS_RESPONSE_HEADER;
+#endif
--
2.37.1.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH v5] MdePkg/Include: Add IPMI KCS definitions
2023-03-24 9:14 [PATCH v5] MdePkg/Include: Add IPMI KCS definitions Chang, Abner
@ 2023-03-25 15:33 ` Michael D Kinney
2023-03-26 13:55 ` Chang, Abner
0 siblings, 1 reply; 4+ messages in thread
From: Michael D Kinney @ 2023-03-25 15:33 UTC (permalink / raw)
To: devel@edk2.groups.io, abner.chang@amd.com
Cc: Gao, Liming, Liu, Zhiguang, Nickle Wang, Igor Kulchytskyy,
Oram, Isaac W, Abdul Lateef Attar, Kinney, Michael D
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang, Abner via groups.io
> Sent: Friday, March 24, 2023 2:14 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>;
> Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Abdul Lateef Attar
> <AbdulLateef.Attar@amd.com>
> Subject: [edk2-devel] [PATCH v5] MdePkg/Include: Add IPMI KCS definitions
>
> From: Abner Chang <abner.chang@amd.com>
>
> BZ #4354
> This change adds definitions for IPMI KCS.
>
> Spec ref:
> https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html
>
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> Acked-by: Isaac Oram <isaac.w.oram@intel.com>
> ---
> MdePkg/MdePkg.dec | 6 ++
> MdePkg/Include/IndustryStandard/IpmiKcs.h | 76 +++++++++++++++++++++++
> 2 files changed, 82 insertions(+)
> create mode 100644 MdePkg/Include/IndustryStandard/IpmiKcs.h
>
> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
> index 2d643bede1d..5cf04bc0cb6 100644
> --- a/MdePkg/MdePkg.dec
> +++ b/MdePkg/MdePkg.dec
> @@ -9,6 +9,7 @@
> # (C) Copyright 2016 - 2021 Hewlett Packard Enterprise Development LP<BR>
> # Copyright (c) 2022, Loongson Technology Corporation Limited. All rights reserved.<BR>
> # Copyright (c) 2021 - 2022, Arm Limited. All rights reserved.<BR>
> +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> @@ -2342,6 +2343,11 @@
> # @Prompt Memory Address of GuidedExtractHandler Table.
> gEfiMdePkgTokenSpaceGuid.PcdGuidedExtractHandlerTableAddress|0x1000000|UINT64|0x30001015
>
> + ## This value is the IPMI KCS Interface I/O base address used to transmit IPMI commands.
> + # The value of 0xca2 is the default I/O base address defined in IPMI specification.
> + # @Prompt IPMI KCS Interface I/O Base Address
> + gEfiMdePkgTokenSpaceGuid.PcdIpmiKcsIoBaseAddress|0xca2|UINT16|0x00000031
> +
> [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
> ## This value is used to set the base address of PCI express hierarchy.
> # @Prompt PCI Express Base Address.
> diff --git a/MdePkg/Include/IndustryStandard/IpmiKcs.h b/MdePkg/Include/IndustryStandard/IpmiKcs.h
> new file mode 100644
> index 00000000000..7b3ba45bf9d
> --- /dev/null
> +++ b/MdePkg/Include/IndustryStandard/IpmiKcs.h
> @@ -0,0 +1,76 @@
> +/** @file
> + IPMI KCS Register Definitions
> +
> + Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
> + SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> + @par Revision Reference:
> + IPMI Specification
> + Version 2.0, Rev. 1.1
> + https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html
> +**/
> +
> +#ifndef IPMI_KCS_H_
> +#define IPMI_KCS_H_
> +
> +#define IPMI_KCS_STATUS_REGISTER_OFFSET 1
> +#define IPMI_KCS_COMMAND_REGISTER_OFFSET 1
> +#define IPMI_KCS_DATA_OUT_REGISTER_OFFSET 0
> +#define IPMI_KCS_DATA_IN_REGISTER_OFFSET 0
> +
> +///
> +/// IPMI KCS Interface Status Bits
> +///
> +#define IPMI_KCS_OBF BIT0
> +#define IPMI_KCS_IBF BIT1
> +#define IPMI_KCS_SMS_ATN BIT2
> +#define IPMI_KCS_COMMAND_DATA BIT3
> +#define IPMI_KCS_OEM1 BIT4
> +#define IPMI_KCS_OEM2 BIT5
> +#define IPMI_KCS_S0 BIT6
> +#define IPMI_KCS_S1 BIT7
> +
> +///
> +/// IPMI KCS Interface Control Codes
> +///
> +#define IPMI_KCS_CONTROL_CODE_GET_STATUS_ABORT 0x60
> +#define IPMI_KCS_CONTROL_CODE_WRITE_START 0x61
> +#define IPMI_KCS_CONTROL_CODE_WRITE_END 0x62
> +#define IPMI_KCS_CONTROL_CODE_READ 0x68
> +
> +///
> +/// Status Codes
> +///
> +#define IPMI_KCS_STATUS_NO_ERROR 0x00
> +#define IPMI_KCS_STATUS_ABORT 0x01
> +#define IPMI_KCS_STATUS_ILLEGAL 0x02
> +#define IPMI_KCS_STATUS_LENGTH_ERROR 0x06
> +#define IPMI_KCS_STATUS_UNSPECIFIED 0xFF
> +
> +///
> +/// KCS Interface State Bit
> +///
> +typedef enum {
> + IPMI_KCS_IDLE_STATE = 0,
> + IPMI_KCS_READ_STATE,
> + IPMI_KCS_WRITE_STATE,
> + IPMI_KCS_ERROR_STATE
> +} IPMI_KCS_STATE;
> +
> +///
> +/// IPMI KCS Interface Request Format
> +///
> +typedef struct {
> + UINT8 NetFunc;
> + UINT8 Command;
> + UINT8 Data[];
> +} IPMI_KCS_REQUEST_HEADER;
> +
> +///
> +/// IPMI KCS Interface Response Format
> +///
> +typedef struct {
> + UINT8 NetFunc;
> + UINT8 Command;
> +} IPMI_KCS_RESPONSE_HEADER;
> +#endif
> --
> 2.37.1.windows.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH v5] MdePkg/Include: Add IPMI KCS definitions
2023-03-25 15:33 ` [edk2-devel] " Michael D Kinney
@ 2023-03-26 13:55 ` Chang, Abner
2023-03-26 19:32 ` Michael D Kinney
0 siblings, 1 reply; 4+ messages in thread
From: Chang, Abner @ 2023-03-26 13:55 UTC (permalink / raw)
To: Kinney, Michael D, devel@edk2.groups.io, Nickle Wang,
Oram, Isaac W, Leif Lindholm, Andrew Fish
Cc: Gao, Liming, Liu, Zhiguang, Igor Kulchytskyy,
Attar, AbdulLateef (Abdul Lateef)
[-- Attachment #1: Type: text/plain, Size: 8292 bytes --]
[AMD Official Use Only - General]
Thanks Mike,
IPMI KCS: https://github.com/tianocore/edk2/pull/4184
MCTP: https://github.com/tianocore/edk2/pull/4183
We also fixed the ECC error in these two PRs, please also help to push it.
@Kinney, Michael D<mailto:michael.d.kinney@intel.com>, @Leif Lindholm<mailto:quic_llindhol@quicinc.com>, @Andrew Fish<mailto:afish@apple.com>
Hi stewards,
I would like to be the maintainer for *IPMI* and *MCTP* files under both MdePkg and MdeModulePkg. I will send the Maintainers.txt update for that if you have no concerns.
Will also invite Isaac @Oram, Isaac W<mailto:isaac.w.oram@intel.com> from Intel and Nickle @Nickle Wang<mailto:nicklew@nvidia.com> from Nvidia as reviewers.
Thanks
Abner
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Saturday, March 25, 2023 11:33 PM
> To: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>
> Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Nickle Wang <nicklew@nvidia.com>; Igor
> Kulchytskyy <igork@ami.com>; Oram, Isaac W <isaac.w.oram@intel.com>;
> Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] [PATCH v5] MdePkg/Include: Add IPMI KCS
> definitions
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
>
> > -----Original Message-----
> > From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Chang,
> > Abner via groups.io
> > Sent: Friday, March 24, 2023 2:14 AM
> > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Gao, Liming
> > <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Liu, Zhiguang <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>>;
> > Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>; Igor Kulchytskyy <igork@ami.com<mailto:igork@ami.com>>;
> > Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Abdul Lateef Attar
> > <AbdulLateef.Attar@amd.com<mailto:AbdulLateef.Attar@amd.com>>
> > Subject: [edk2-devel] [PATCH v5] MdePkg/Include: Add IPMI KCS
> > definitions
> >
> > From: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>
> >
> > BZ #4354
> > This change adds definitions for IPMI KCS.
> >
> > Spec ref:
> >
> https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/i<https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipm>
> pm<https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipm>
> > i-second-gen-interface-spec-v2-rev1-1.html
> >
> > Signed-off-by: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>>
> > Cc: Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>
> > Cc: Igor Kulchytskyy <igork@ami.com<mailto:igork@ami.com>>
> > Cc: Isaac Oram <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>
> > Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com<mailto:AbdulLateef.Attar@amd.com>>
> > Acked-by: Isaac Oram <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>
> > ---
> > MdePkg/MdePkg.dec | 6 ++
> > MdePkg/Include/IndustryStandard/IpmiKcs.h | 76
> > +++++++++++++++++++++++
> > 2 files changed, 82 insertions(+)
> > create mode 100644 MdePkg/Include/IndustryStandard/IpmiKcs.h
> >
> > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index
> > 2d643bede1d..5cf04bc0cb6 100644
> > --- a/MdePkg/MdePkg.dec
> > +++ b/MdePkg/MdePkg.dec
> > @@ -9,6 +9,7 @@
> > # (C) Copyright 2016 - 2021 Hewlett Packard Enterprise Development
> > LP<BR> # Copyright (c) 2022, Loongson Technology Corporation Limited.
> > All rights reserved.<BR> # Copyright (c) 2021 - 2022, Arm Limited.
> > All rights reserved.<BR>
> > +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
> > +reserved.<BR>
> > #
> > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -2342,6 +2343,11
> > @@
> > # @Prompt Memory Address of GuidedExtractHandler Table.
> >
> >
> gEfiMdePkgTokenSpaceGuid.PcdGuidedExtractHandlerTableAddress|0x1000
> 000
> > |UINT64|0x30001015
> >
> > + ## This value is the IPMI KCS Interface I/O base address used to transmit
> IPMI commands.
> > + # The value of 0xca2 is the default I/O base address defined in IPMI
> specification.
> > + # @Prompt IPMI KCS Interface I/O Base Address
> > +
> > +
> gEfiMdePkgTokenSpaceGuid.PcdIpmiKcsIoBaseAddress|0xca2|UINT16|0x00
> 00
> > + 0031
> > +
> > [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
> > ## This value is used to set the base address of PCI express hierarchy.
> > # @Prompt PCI Express Base Address.
> > diff --git a/MdePkg/Include/IndustryStandard/IpmiKcs.h
> > b/MdePkg/Include/IndustryStandard/IpmiKcs.h
> > new file mode 100644
> > index 00000000000..7b3ba45bf9d
> > --- /dev/null
> > +++ b/MdePkg/Include/IndustryStandard/IpmiKcs.h
> > @@ -0,0 +1,76 @@
> > +/** @file
> > + IPMI KCS Register Definitions
> > +
> > + Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
> > + reserved.<BR>
> > + SPDX-License-Identifier: BSD-2-Clause-Patent
> > +
> > + @par Revision Reference:
> > + IPMI Specification
> > + Version 2.0, Rev. 1.1
> > +
> >
> +https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/
> ip
> > +mi-second-gen-interface-spec-v2-rev1-1.html
> > +**/
> > +
> > +#ifndef IPMI_KCS_H_
> > +#define IPMI_KCS_H_
> > +
> > +#define IPMI_KCS_STATUS_REGISTER_OFFSET 1
> > +#define IPMI_KCS_COMMAND_REGISTER_OFFSET 1
> > +#define IPMI_KCS_DATA_OUT_REGISTER_OFFSET 0
> > +#define IPMI_KCS_DATA_IN_REGISTER_OFFSET 0
> > +
> > +///
> > +/// IPMI KCS Interface Status Bits
> > +///
> > +#define IPMI_KCS_OBF BIT0
> > +#define IPMI_KCS_IBF BIT1
> > +#define IPMI_KCS_SMS_ATN BIT2
> > +#define IPMI_KCS_COMMAND_DATA BIT3
> > +#define IPMI_KCS_OEM1 BIT4
> > +#define IPMI_KCS_OEM2 BIT5
> > +#define IPMI_KCS_S0 BIT6
> > +#define IPMI_KCS_S1 BIT7
> > +
> > +///
> > +/// IPMI KCS Interface Control Codes
> > +///
> > +#define IPMI_KCS_CONTROL_CODE_GET_STATUS_ABORT 0x60
> > +#define IPMI_KCS_CONTROL_CODE_WRITE_START 0x61
> > +#define IPMI_KCS_CONTROL_CODE_WRITE_END 0x62
> > +#define IPMI_KCS_CONTROL_CODE_READ 0x68
> > +
> > +///
> > +/// Status Codes
> > +///
> > +#define IPMI_KCS_STATUS_NO_ERROR 0x00
> > +#define IPMI_KCS_STATUS_ABORT 0x01
> > +#define IPMI_KCS_STATUS_ILLEGAL 0x02
> > +#define IPMI_KCS_STATUS_LENGTH_ERROR 0x06
> > +#define IPMI_KCS_STATUS_UNSPECIFIED 0xFF
> > +
> > +///
> > +/// KCS Interface State Bit
> > +///
> > +typedef enum {
> > + IPMI_KCS_IDLE_STATE = 0,
> > + IPMI_KCS_READ_STATE,
> > + IPMI_KCS_WRITE_STATE,
> > + IPMI_KCS_ERROR_STATE
> > +} IPMI_KCS_STATE;
> > +
> > +///
> > +/// IPMI KCS Interface Request Format /// typedef struct {
> > + UINT8 NetFunc;
> > + UINT8 Command;
> > + UINT8 Data[];
> > +} IPMI_KCS_REQUEST_HEADER;
> > +
> > +///
> > +/// IPMI KCS Interface Response Format /// typedef struct {
> > + UINT8 NetFunc;
> > + UINT8 Command;
> > +} IPMI_KCS_RESPONSE_HEADER;
> > +#endif
> > --
> > 2.37.1.windows.1
> >
> >
> >
> >
> >
[-- Attachment #2: Type: text/html, Size: 22798 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH v5] MdePkg/Include: Add IPMI KCS definitions
2023-03-26 13:55 ` Chang, Abner
@ 2023-03-26 19:32 ` Michael D Kinney
0 siblings, 0 replies; 4+ messages in thread
From: Michael D Kinney @ 2023-03-26 19:32 UTC (permalink / raw)
To: Chang, Abner, devel@edk2.groups.io, Nickle Wang, Oram, Isaac W,
Leif Lindholm, Andrew Fish
Cc: Gao, Liming, Liu, Zhiguang, Igor Kulchytskyy,
Attar, AbdulLateef (Abdul Lateef), Kinney, Michael D
[-- Attachment #1: Type: text/plain, Size: 9385 bytes --]
Both PRs have been merged.
Commit: https://github.com/tianocore/edk2/commit/2c93253c95dbbc161650dfaeccaa3d866a2e29f2
Commit: https://github.com/tianocore/edk2/commit/69e59545b14739e004d3f0452411e195d2a3c197
Mike
From: Chang, Abner <Abner.Chang@amd.com>
Sent: Sunday, March 26, 2023 6:56 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io; Nickle Wang <nicklew@nvidia.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Andrew Fish <afish@apple.com>
Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Igor Kulchytskyy <igork@ami.com>; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
Subject: RE: [edk2-devel] [PATCH v5] MdePkg/Include: Add IPMI KCS definitions
[AMD Official Use Only - General]
Thanks Mike,
IPMI KCS: https://github.com/tianocore/edk2/pull/4184
MCTP: https://github.com/tianocore/edk2/pull/4183
We also fixed the ECC error in these two PRs, please also help to push it.
@Kinney, Michael D<mailto:michael.d.kinney@intel.com>, @Leif Lindholm<mailto:quic_llindhol@quicinc.com>, @Andrew Fish<mailto:afish@apple.com>
Hi stewards,
I would like to be the maintainer for *IPMI* and *MCTP* files under both MdePkg and MdeModulePkg. I will send the Maintainers.txt update for that if you have no concerns.
Will also invite Isaac @Oram, Isaac W<mailto:isaac.w.oram@intel.com> from Intel and Nickle @Nickle Wang<mailto:nicklew@nvidia.com> from Nvidia as reviewers.
Thanks
Abner
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
> Sent: Saturday, March 25, 2023 11:33 PM
> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Chang, Abner <Abner.Chang@amd.com<mailto:Abner.Chang@amd.com>>
> Cc: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Liu, Zhiguang
> <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>>; Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>; Igor
> Kulchytskyy <igork@ami.com<mailto:igork@ami.com>>; Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>;
> Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com<mailto:AbdulLateef.Attar@amd.com>>; Kinney,
> Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
> Subject: RE: [edk2-devel] [PATCH v5] MdePkg/Include: Add IPMI KCS
> definitions
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
>
> > -----Original Message-----
> > From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Chang,
> > Abner via groups.io
> > Sent: Friday, March 24, 2023 2:14 AM
> > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Gao, Liming
> > <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Liu, Zhiguang <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>>;
> > Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>; Igor Kulchytskyy <igork@ami.com<mailto:igork@ami.com>>;
> > Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Abdul Lateef Attar
> > <AbdulLateef.Attar@amd.com<mailto:AbdulLateef.Attar@amd.com>>
> > Subject: [edk2-devel] [PATCH v5] MdePkg/Include: Add IPMI KCS
> > definitions
> >
> > From: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>
> >
> > BZ #4354
> > This change adds definitions for IPMI KCS.
> >
> > Spec ref:
> >
> https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/i<https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipm>
> pm<https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipm>
> > i-second-gen-interface-spec-v2-rev1-1.html
> >
> > Signed-off-by: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>>
> > Cc: Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>
> > Cc: Igor Kulchytskyy <igork@ami.com<mailto:igork@ami.com>>
> > Cc: Isaac Oram <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>
> > Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com<mailto:AbdulLateef.Attar@amd.com>>
> > Acked-by: Isaac Oram <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>
> > ---
> > MdePkg/MdePkg.dec | 6 ++
> > MdePkg/Include/IndustryStandard/IpmiKcs.h | 76
> > +++++++++++++++++++++++
> > 2 files changed, 82 insertions(+)
> > create mode 100644 MdePkg/Include/IndustryStandard/IpmiKcs.h
> >
> > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index
> > 2d643bede1d..5cf04bc0cb6 100644
> > --- a/MdePkg/MdePkg.dec
> > +++ b/MdePkg/MdePkg.dec
> > @@ -9,6 +9,7 @@
> > # (C) Copyright 2016 - 2021 Hewlett Packard Enterprise Development
> > LP<BR> # Copyright (c) 2022, Loongson Technology Corporation Limited.
> > All rights reserved.<BR> # Copyright (c) 2021 - 2022, Arm Limited.
> > All rights reserved.<BR>
> > +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
> > +reserved.<BR>
> > #
> > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -2342,6 +2343,11
> > @@
> > # @Prompt Memory Address of GuidedExtractHandler Table.
> >
> >
> gEfiMdePkgTokenSpaceGuid.PcdGuidedExtractHandlerTableAddress|0x1000
> 000
> > |UINT64|0x30001015
> >
> > + ## This value is the IPMI KCS Interface I/O base address used to transmit
> IPMI commands.
> > + # The value of 0xca2 is the default I/O base address defined in IPMI
> specification.
> > + # @Prompt IPMI KCS Interface I/O Base Address
> > +
> > +
> gEfiMdePkgTokenSpaceGuid.PcdIpmiKcsIoBaseAddress|0xca2|UINT16|0x00
> 00
> > + 0031
> > +
> > [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
> > ## This value is used to set the base address of PCI express hierarchy.
> > # @Prompt PCI Express Base Address.
> > diff --git a/MdePkg/Include/IndustryStandard/IpmiKcs.h
> > b/MdePkg/Include/IndustryStandard/IpmiKcs.h
> > new file mode 100644
> > index 00000000000..7b3ba45bf9d
> > --- /dev/null
> > +++ b/MdePkg/Include/IndustryStandard/IpmiKcs.h
> > @@ -0,0 +1,76 @@
> > +/** @file
> > + IPMI KCS Register Definitions
> > +
> > + Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
> > + reserved.<BR>
> > + SPDX-License-Identifier: BSD-2-Clause-Patent
> > +
> > + @par Revision Reference:
> > + IPMI Specification
> > + Version 2.0, Rev. 1.1
> > +
> >
> +https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/
> ip
> > +mi-second-gen-interface-spec-v2-rev1-1.html
> > +**/
> > +
> > +#ifndef IPMI_KCS_H_
> > +#define IPMI_KCS_H_
> > +
> > +#define IPMI_KCS_STATUS_REGISTER_OFFSET 1
> > +#define IPMI_KCS_COMMAND_REGISTER_OFFSET 1
> > +#define IPMI_KCS_DATA_OUT_REGISTER_OFFSET 0
> > +#define IPMI_KCS_DATA_IN_REGISTER_OFFSET 0
> > +
> > +///
> > +/// IPMI KCS Interface Status Bits
> > +///
> > +#define IPMI_KCS_OBF BIT0
> > +#define IPMI_KCS_IBF BIT1
> > +#define IPMI_KCS_SMS_ATN BIT2
> > +#define IPMI_KCS_COMMAND_DATA BIT3
> > +#define IPMI_KCS_OEM1 BIT4
> > +#define IPMI_KCS_OEM2 BIT5
> > +#define IPMI_KCS_S0 BIT6
> > +#define IPMI_KCS_S1 BIT7
> > +
> > +///
> > +/// IPMI KCS Interface Control Codes
> > +///
> > +#define IPMI_KCS_CONTROL_CODE_GET_STATUS_ABORT 0x60
> > +#define IPMI_KCS_CONTROL_CODE_WRITE_START 0x61
> > +#define IPMI_KCS_CONTROL_CODE_WRITE_END 0x62
> > +#define IPMI_KCS_CONTROL_CODE_READ 0x68
> > +
> > +///
> > +/// Status Codes
> > +///
> > +#define IPMI_KCS_STATUS_NO_ERROR 0x00
> > +#define IPMI_KCS_STATUS_ABORT 0x01
> > +#define IPMI_KCS_STATUS_ILLEGAL 0x02
> > +#define IPMI_KCS_STATUS_LENGTH_ERROR 0x06
> > +#define IPMI_KCS_STATUS_UNSPECIFIED 0xFF
> > +
> > +///
> > +/// KCS Interface State Bit
> > +///
> > +typedef enum {
> > + IPMI_KCS_IDLE_STATE = 0,
> > + IPMI_KCS_READ_STATE,
> > + IPMI_KCS_WRITE_STATE,
> > + IPMI_KCS_ERROR_STATE
> > +} IPMI_KCS_STATE;
> > +
> > +///
> > +/// IPMI KCS Interface Request Format /// typedef struct {
> > + UINT8 NetFunc;
> > + UINT8 Command;
> > + UINT8 Data[];
> > +} IPMI_KCS_REQUEST_HEADER;
> > +
> > +///
> > +/// IPMI KCS Interface Response Format /// typedef struct {
> > + UINT8 NetFunc;
> > + UINT8 Command;
> > +} IPMI_KCS_RESPONSE_HEADER;
> > +#endif
> > --
> > 2.37.1.windows.1
> >
> >
> >
> >
> >
[-- Attachment #2: Type: text/html, Size: 62586 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-26 19:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-24 9:14 [PATCH v5] MdePkg/Include: Add IPMI KCS definitions Chang, Abner
2023-03-25 15:33 ` [edk2-devel] " Michael D Kinney
2023-03-26 13:55 ` Chang, Abner
2023-03-26 19:32 ` Michael D Kinney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox