Re: [edk2-devel] 回复: [PATCH] MdePkg/Include: Add CET instructions to Nasm.inc

["Michael D Kinney" <michael.d.kinney@intel.com>]

Liming,

We can always install a newer version in CI agents,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming
> Sent: Monday, February 1, 2021 7:51 PM
> To: Sheng, W <w.sheng@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io
> Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; 'Andrew Fish' <afish@apple.com>; 'Laszlo
> Ersek' <lersek@redhat.com>; Feng, Roger <roger.feng@intel.com>
> Subject: [edk2-devel] 回复: [PATCH] MdePkg/Include: Add CET instructions to Nasm.inc
> 
> Sheng:
>   Can you check nasm version in ubuntu-18.04 and latest ubuntu OS? Those Oss are used in open CI.
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Sheng, W <w.sheng@intel.com>
> > 发送时间: 2021年2月2日 11:39
> > 收件人: gaoliming <gaoliming@byosoft.com.cn>; Kinney, Michael D
> > <michael.d.kinney@intel.com>; devel@edk2.groups.io
> > 抄送: Liu, Zhiguang <zhiguang.liu@intel.com>; Yao, Jiewen
> > <jiewen.yao@intel.com>; 'Andrew Fish' <afish@apple.com>; 'Laszlo Ersek'
> > <lersek@redhat.com>; Feng, Roger <roger.feng@intel.com>
> > 主题: RE: [PATCH] MdePkg/Include: Add CET instructions to Nasm.inc
> >
> > Hi Mike, Liming,
> > The latest NASM version is version 2.15.05.
> > The CET instructions is supported since NASM version 2.15.01, it is released at
> > 2020-06-27.
> > Do you think we need to request everyone to update the NASM tool now?
> > Or could I still use macros with DB for CET instructions in my patch ?
> > BR
> > Sheng Wei
> >
> > > -----Original Message-----
> > > From: gaoliming <gaoliming@byosoft.com.cn>
> > > Sent: 2021年2月2日 10:44
> > > To: Kinney, Michael D <michael.d.kinney@intel.com>; Sheng, W
> > > <w.sheng@intel.com>; devel@edk2.groups.io
> > > Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Yao, Jiewen
> > > <jiewen.yao@intel.com>; 'Andrew Fish' <afish@apple.com>; 'Laszlo Ersek'
> > > <lersek@redhat.com>
> > > Subject: 回复: [PATCH] MdePkg/Include: Add CET instructions to Nasm.inc
> > >
> > > Mike and Sheng:
> > >   Linux or Mac OS includes the pre-built nasm. Their nasm version may be
> > old.
> > > Can you evaluate the impact to update nasm version?
> > >
> > > Thanks
> > > Liming
> > > > -----邮件原件-----
> > > > 发件人: Kinney, Michael D <michael.d.kinney@intel.com>
> > > > 发送时间: 2021年1月30日 1:23
> > > > 收件人: Sheng, W <w.sheng@intel.com>; devel@edk2.groups.io; Kinney,
> > > > Michael D <michael.d.kinney@intel.com>
> > > > 抄送: Liming Gao <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> > > > <zhiguang.liu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
> > > > 主题: RE: [PATCH] MdePkg/Include: Add CET instructions to Nasm.inc
> > > >
> > > > Sheng,
> > > >
> > > > The following version of the NASM documentation shows support for
> > > > these instructions.
> > > >
> > > > 	https://nasm.us/doc/nasmdocb.html
> > > >
> > > > Do we need to increase the min NASM version requirements for EDK II to
> > > > avoid adding macros with DB?
> > > >
> > > > Thanks,
> > > >
> > > > Mike
> > > >
> > > > > -----Original Message-----
> > > > > From: Sheng, W <w.sheng@intel.com>
> > > > > Sent: Thursday, January 28, 2021 6:35 PM
> > > > > To: devel@edk2.groups.io
> > > > > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao
> > > > <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> > > > > <zhiguang.liu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
> > > > > Subject: [PATCH] MdePkg/Include: Add CET instructions to Nasm.inc
> > > > >
> > > > > This is to add instruction SAVEPREVSSP, CLRSSBSY and RSTORSSP_RAX in
> > > > Nasm,
> > > > > because these instructions are not supported yet.
> > > > >
> > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3192
> > > > >
> > > > > Signed-off-by: Sheng Wei <w.sheng@intel.com>
> > > > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > > > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > > > > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > > > > ---
> > > > >  MdePkg/Include/Ia32/Nasm.inc | 14 +++++++++++++-
> > > > > MdePkg/Include/X64/Nasm.inc  | 14 +++++++++++++-
> > > > >  2 files changed, 26 insertions(+), 2 deletions(-)
> > > > >
> > > > > diff --git a/MdePkg/Include/Ia32/Nasm.inc
> > > > b/MdePkg/Include/Ia32/Nasm.inc
> > > > > index 31ce861f1e..9c1b7796ea 100644
> > > > > --- a/MdePkg/Include/Ia32/Nasm.inc
> > > > > +++ b/MdePkg/Include/Ia32/Nasm.inc
> > > > > @@ -1,6 +1,6 @@
> > > > >
> > > > > ;-------------------------------------------------------------------
> > > > > -----------
> > > > >  ;
> > > > > -; Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> > > > > +; Copyright (c) 2019 - 2021, Intel Corporation. All rights
> > > > > +reserved.<BR>
> > > > >  ; SPDX-License-Identifier: BSD-2-Clause-Patent  ;  ; Abstract:
> > > > > @@ -20,3 +20,15 @@
> > > > >  %macro INCSSP_EAX      0
> > > > >      DB 0xF3, 0x0F, 0xAE, 0xE8
> > > > >  %endmacro
> > > > > +
> > > > > +%macro SAVEPREVSSP     0
> > > > > +    DB 0xF3, 0x0F, 0x01, 0xEA
> > > > > +%endmacro
> > > > > +
> > > > > +%macro CLRSSBSY_EAX    0
> > > > > +    DB 0x67, 0xF3, 0x0F, 0xAE, 0x30 %endmacro
> > > > > +
> > > > > +%macro RSTORSSP_EAX    0
> > > > > +    DB 0x67, 0xF3, 0x0F, 0x01, 0x28 %endmacro
> > > > > diff --git a/MdePkg/Include/X64/Nasm.inc
> > > > b/MdePkg/Include/X64/Nasm.inc
> > > > > index 42412735ea..c5189982bb 100644
> > > > > --- a/MdePkg/Include/X64/Nasm.inc
> > > > > +++ b/MdePkg/Include/X64/Nasm.inc
> > > > > @@ -1,6 +1,6 @@
> > > > >
> > > > > ;-------------------------------------------------------------------
> > > > > -----------
> > > > >  ;
> > > > > -; Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> > > > > +; Copyright (c) 2019 - 2021, Intel Corporation. All rights
> > > > > +reserved.<BR>
> > > > >  ; SPDX-License-Identifier: BSD-2-Clause-Patent  ;  ; Abstract:
> > > > > @@ -20,3 +20,15 @@
> > > > >  %macro INCSSP_RAX      0
> > > > >      DB 0xF3, 0x48, 0x0F, 0xAE, 0xE8  %endmacro
> > > > > +
> > > > > +%macro SAVEPREVSSP     0
> > > > > +    DB 0xF3, 0x0F, 0x01, 0xEA
> > > > > +%endmacro
> > > > > +
> > > > > +%macro CLRSSBSY_RAX    0
> > > > > +    DB 0xF3, 0x0F, 0xAE, 0x30
> > > > > +%endmacro
> > > > > +
> > > > > +%macro RSTORSSP_RAX    0
> > > > > +    DB 0xF3, 0x0F, 0x01, 0x28
> > > > > +%endmacro
> > > > > --
> > > > > 2.16.2.windows.1
> > >
> > >
> 
> 
> 
> 
> 
> 
>