From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id DFC5774005D for ; Thu, 8 Feb 2024 16:30:46 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=j0JJ7F2GGo/NO5wKXWe5kInAVqL9g263Y3hPIbf+Ttw=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1707409845; v=1; b=BbXo1gz/BckAOj2Hak6hv1UrccYomJab2EnlAItcskFQ2yOL/xLsVWrEaFemacodTcpxX4ld AVR+HfclDUb/XWDjfwjSI27sDXwri1qDirgmWEaUaVgEnVhKlPvA8LCnRTm9j8WQkeNBYUBsxwC foyCu85qlAG0THiWR2PN4k9Y= X-Received: by 127.0.0.2 with SMTP id rZxnYY7687511x63aObbRaSE; Thu, 08 Feb 2024 08:30:45 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by mx.groups.io with SMTP id smtpd.web10.11.1707409844835980637 for ; Thu, 08 Feb 2024 08:30:45 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10978"; a="12622820" X-IronPort-AV: E=Sophos;i="6.05,254,1701158400"; d="scan'208";a="12622820" X-Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2024 08:30:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,254,1701158400"; d="scan'208";a="6323121" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Feb 2024 08:30:44 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 8 Feb 2024 08:30:43 -0800 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 8 Feb 2024 08:30:43 -0800 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 8 Feb 2024 08:30:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bFKUCjmzfe8O8QarkLjmS4ZzhFVM7tnWbgrnyNJ285EA1UW+jmwvem/i9cNTcUX1s75AfymrLm5Ui9F7Rl47AR05tO0EJtAogCuLiGonPC7RrlZIDhAsZTd85HWVjNe2hlDREDuIP0oylMnw/6BnnbzxTP7BrRKdwxB44VpcRM+tBKvkZ0r/ZmKstEciXcqAy7x9SbQaYPpmn5sNoP9rmhPKMMKLElBK34NCGJwpLfjfyJs5wtHRhtWQnHkLQUNuexB4/+g1d+Zd5VyQLcm6TAVeOakY5wPfRntnmxobsEmqsOsTs0Ff+As2rmREoi00wQD3L7F7tRJO1lTQlUEj2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dW+UVTsHaoDJhGaO5TksyTtf80YJtKdgzr9pTCBFMhE=; b=UfRM8FgCulZrchepsGjPnOAbqbqVC9u0hd/EO3Lame2oDITfv7kWdb03PVKYEw4kP7DGkv2Gf9cXyqpukU13eCrhX0fw2CROFyYFW4D1W5QoMvc1StyNK7Foi4joHRwC2U9+5RTGBOaR5um7sa//Q+dKfCVNjs3BjxuOOS3Ka7dY0bajEke6eZ5I+5HiU4Yt9eRw00AHUU75jS61o4gxnxImEf2zHkMOpcTt/5hbhIyxVHrJu/3SckFg+xuWH8tDBu+PMroGI16PcbC7Nb5Vh2jCZCZ8iDVl4fsGGVx82kmshrK0u7RhNu93uiYblYtwbP84GPRMjz7T2B+5E3jeVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by DM4PR11MB5504.namprd11.prod.outlook.com (2603:10b6:5:39d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.36; Thu, 8 Feb 2024 16:30:40 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::7e42:1633:d0a6:9c00]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::7e42:1633:d0a6:9c00%6]) with mapi id 15.20.7249.037; Thu, 8 Feb 2024 16:30:39 +0000 From: "Michael D Kinney" To: "Chen, Christine" , "S, Ashraf Ali" , "Feng, Bob C" , "Chan, Amy" , "devel@edk2.groups.io" CC: Rebecca Cran , "Gao, Liming" , "Chaganty, Rangasai V" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuId from allskuset Thread-Topic: [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuId from allskuset Thread-Index: AQHaWlKc7fKrNwQbrkqVc0B2mgIUJ7D/8aLggAAMnQCAAKTXoA== Date: Thu, 8 Feb 2024 16:30:39 +0000 Message-ID: References: <2fcb6a95d99dffa093011850548712054ef7e813.1703518030.git.ashraf.ali.s@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|DM4PR11MB5504:EE_ x-ms-office365-filtering-correlation-id: b745fda1-ca88-4c82-a7d1-08dc28c349a4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 9rflSDkncGvcSBFq8nLDSJSaBx6hc1xJDMCPFkEoQzwFMUouLpdVZxdf365BorTQ0EUZuYWNlypHtL9I/fkk8W07pizshdGGd4rn1fsJo/yvQIJ/hZvWP+J0rtyxvcJQ5tjcUiUjCs179VfuMBVvYwEsxNk0VBOetadvEGpNrQeQJnodhpYr658m64Y+k63GORXHZn2Z0hqcGmmPBjtI4xrydSjViaQXJlv9vBPjx0m5HLuD5T/d27O5Fj/+4MwOzDAipJJtx1ZZajvZZ0XLUABJF/h6/Ee+o26tZa8+QcWgf2B1MuO/GA+B+1xkUozNM4e7Vf2RO4xcAC9hev7xV2goxtVtCImbSAhcPV6gn+1BU2WPRIqsIFlLaUYgkxDc0jtZDaWZSConkE2dpg72wCiGMkoNYNQNOsuIicg325IAU+P+Zr/jA7rJGiF3jvK6FhNAv1vOQ8Fva8Mw+1sF1tgj9GzzcgeQDPFYOKQ1P618zFL7M5Nzb9Ef+q231X3Ag6kR31cP0V5fksBXsUZ5g8AEYsAajiugzcr0beLeOK+JuzhuE5eb/ooOHq8rNwjJstwxbxgEHX25CiJ4c2sisR2ilHRjmcVWoic51JXBQ5p/3fm+nLb99ihRA0Ra3gwrj4iFmIHz4fyz2hxBGI1WOg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bJeGZ5oOKOjb/Z62wn2jcaqXkmDpFyULVsdjYF7hBJ9LvcM/awfgwVrTFLCE?= =?us-ascii?Q?pWV55Rj0xRAJEBrYEW9L+NIxzECZbwS4yb45ER0LSKyGRSOthcXWonel/LqU?= =?us-ascii?Q?zv+G6Rj6TPPNHgC/h65ygyaAj3ekr43IlHWbotXMDqdPldpX664ntwbhatAg?= =?us-ascii?Q?oTbNI8qdBf1Fb3tw6EVA5EowvXCpyvc1X/wQ8X8agZA6mrynuSlzWNCmTeWR?= =?us-ascii?Q?wo9tmjLIZryzlwdzqyovq/DwJWJwYj0rJIOc/1QmipUNORLfIRX36ZKOHOLx?= =?us-ascii?Q?RN7uPF+1zgGbLlfTRqRTy1iFXp9A+uL+skbB2WeVKOil47JFzM0CQY/s8Fww?= =?us-ascii?Q?cLck94MkeKVLgEJMY1sQxebWKedg4we1vqRsKyEjVGKbe5dj1SKD3c1hWm6h?= =?us-ascii?Q?VUnkr7gTIAmbUilbO8Tt6IR3AvTTa5UwVeTYpg93uwTwyoNqhDRjwkSnajO0?= =?us-ascii?Q?XI7hwTF/WJDgiCRDKn/QDB9bcjMThpOPsEyCM3HvAopbfeTraJH/H6IVDe5A?= =?us-ascii?Q?k4HLSa7o8x1gBiDQ+4WhNJdcZn8HOdAZTsB3Ygoc6MUL7Nop8RPrCMjvwUGH?= =?us-ascii?Q?fOR56uIO676joeC27eFQIj6/tkLM8iRWgJcTBy2AkGvO/k8/hNL6sDIrYA/0?= =?us-ascii?Q?PL1UFoitHIG4MI7aAZqbOKFFG9JFbFDXt4EWgo757UHxHZiYSW8+coPVYCKS?= =?us-ascii?Q?dkemBxiJDIVQQB0Owl+4qnjFxe/Xkl5o1W1Vck4EKJP6vS7Vv5k7JW22elwJ?= =?us-ascii?Q?NIMFOM/bUwr6cb18KIgdtGG1cSs2TgkMcMRpOKAYqvI0lxUVCU95snMfXryD?= =?us-ascii?Q?UflS21v5l7XgGudk1X+Z+tbkw6UB01C6JYk0Qj6z+kquU7k+E7ntru5o0N8a?= =?us-ascii?Q?jUVkA3UVFI3yuVSAEE6a0FoAE9qOuuC4xNVpMksn7NGn3gIrujh5yEZC9rEG?= =?us-ascii?Q?VmYPZbHvXFQcJBAhUlNJPTRByDrJ9x/VkwNA/jbmgiZlRvj6POW8LepJjnWb?= =?us-ascii?Q?wxLc4Pl+Mda5vhkcVSvSc1kHzms+TIC+lk3QfpoCd5elsEal03i/lfzCUX2i?= =?us-ascii?Q?pfTf8DU3GoQwiuYPZ4/JcqVotVoyJznMUlM/a6TtxaB4vZSe9YJ0YdgQjt9/?= =?us-ascii?Q?VNsVO+ls0pzzgQEesVHPjAIMQsfVDXfV6AhemDp46OINn7MR1G7vcLsKIEf4?= =?us-ascii?Q?Mcwdpj+QRHCOfW4hMgN+Ng6cznEWLKtTUFNeRGzYh9FRlqoAIBI+wJLaO1bY?= =?us-ascii?Q?G1eHcALqluNPZ0b4DGRImJwR1dDA6AxoNH+AfYLEFCmPVahBbwtxEpdE6T7h?= =?us-ascii?Q?IwR3Dhi3QOIbgtKST5SqNMg6q9stmeSvLj2Wr4atPDR987NDo5l6usevF8ui?= =?us-ascii?Q?TM9KbJ+LiuFukZbBv+v51+u/7Y1+mM7OFs0iHiAsEfVqNhajWO82aAPpaB5y?= =?us-ascii?Q?7Z658DPbyECoqQ5NXKLpxffj0pCfNyxXX6PcdK2erjrckW8C4pQmtXVMpUle?= =?us-ascii?Q?X9Hn5gRxQhGrJ+iCw1YHznOcGGJg2DxGxB4rwzdyLGpzkg2O/Vmj2BFc6W7e?= =?us-ascii?Q?xrKRkvIieDL3Zkw3jVacUFKnys8f/jGttkqGrFlx?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b745fda1-ca88-4c82-a7d1-08dc28c349a4 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2024 16:30:39.8542 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DQ6LFZGlFZmAhzaxxc47w1nPCfqK01nvdt/RG8vmnSivqd7xDZE4ssZVG0ELiWuXZ/J7ZkEjYh/1rPzk3Jaofo16OSeAwGSLDFJx5RE+OOY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5504 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: uKIdfMyr35jbR965vycpjCtPx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="BbXo1gz/"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi Christine, I will merge this change into edk2/BaseTools. We need to work in why the edk2-basetools CI is not working and fix that And get the set of BaseTools changes completed in edk2-basetools before the edk2-stable202402 release is completed, so edk2/BaseTools and edk2-basetools is aligned for that release and can stay aligned until edk2/BaseTools can be retired. Mike > -----Original Message----- > From: Chen, Christine > Sent: Wednesday, February 7, 2024 10:39 PM > To: Kinney, Michael D ; S, Ashraf Ali > ; Feng, Bob C ; Chan, Amy > ; devel@edk2.groups.io > Cc: Rebecca Cran ; Gao, Liming > ; Chaganty, Rangasai V > > Subject: RE: [PATCH] BaseTools: Remove Duplicate sets of SkuName and > SkuId from allskuset >=20 > Hi Mike, >=20 > We checked the PR Gate -Ubuntu / Windows log, and seems the error is > not raised by patch itself. In order to prove it, we submit a new PR > with exactly no changes(only and empty lines), and the tests are still > failure: https://github.com/tianocore/edk2-basetools/pull/114 >=20 > Could you help confirm that? > If it is not the code issue, can we merge the code directly or fix the > pipeline issue first? >=20 > Thanks, > Christine >=20 > > -----Original Message----- > > From: Kinney, Michael D > > Sent: Thursday, February 8, 2024 1:54 PM > > To: S, Ashraf Ali ; Feng, Bob C > > ; Chan, Amy ; Chen, > Christine > > ; devel@edk2.groups.io > > Cc: Rebecca Cran ; Gao, Liming > > ; Chaganty, Rangasai V > > ; Kinney, Michael D > > > > Subject: RE: [PATCH] BaseTools: Remove Duplicate sets of SkuName and > SkuId > > from allskuset > > > > I will merge it soon. > > > > Please work with Christine to get edk2-basetools CI working > correctly. > > > > Mike > > > > > -----Original Message----- > > > From: S, Ashraf Ali > > > Sent: Wednesday, February 7, 2024 9:50 PM > > > To: Feng, Bob C ; Chan, Amy > > > ; Chen, Christine ; > > > devel@edk2.groups.io > > > Cc: Rebecca Cran ; Gao, Liming > > > ; Chaganty, Rangasai V > > > ; Kinney, Michael D > > > > > > Subject: RE: [PATCH] BaseTools: Remove Duplicate sets of SkuName > and > > > SkuId from allskuset > > > > > > Hi > > > > > > Is this patch merged! > > > PR under base-tools repo : https://github.com/tianocore/edk2- > > > basetools/pull/112 > > > > > > Builds are failing, looks like it's not due to these changes. > > > > > > Thanks., > > > S, Ashraf Ali > > > > > > -----Original Message----- > > > From: Feng, Bob C > > > Sent: Tuesday, January 30, 2024 1:19 PM > > > To: Chan, Amy ; Chen, Christine > > > ; S, Ashraf Ali ; > > > devel@edk2.groups.io > > > Cc: Rebecca Cran ; Gao, Liming > > > ; Chaganty, Rangasai V > > > > > > Subject: RE: [PATCH] BaseTools: Remove Duplicate sets of SkuName > and > > > SkuId from allskuset > > > > > > Reviewed-by: Bob Feng > > > > > > -----Original Message----- > > > From: Chan, Amy > > > Sent: Monday, January 8, 2024 11:54 AM > > > To: Chen, Christine ; S, Ashraf Ali > > > ; devel@edk2.groups.io > > > Cc: Rebecca Cran ; Gao, Liming > > > ; Feng, Bob C ; > > > Chaganty, Rangasai V > > > Subject: RE: [PATCH] BaseTools: Remove Duplicate sets of SkuName > and > > > SkuId from allskuset > > > > > > Reviewed-by: Amy Chan > > > > > > > -----Original Message----- > > > > From: Chen, Christine > > > > Sent: Monday, January 8, 2024 8:29 AM > > > > To: S, Ashraf Ali ; devel@edk2.groups.io > > > > Cc: Rebecca Cran ; Gao, Liming > > > > ; Feng, Bob C ; > > > > Chan, Amy ; Chaganty, Rangasai V > > > > > > > > Subject: RE: [PATCH] BaseTools: Remove Duplicate sets of SkuName > and > > > > SkuId from allskuset > > > > > > > > Reviewed-by: Yuwei Chen > > > > > > > > > -----Original Message----- > > > > > From: S, Ashraf Ali > > > > > Sent: Monday, December 25, 2023 11:28 PM > > > > > To: devel@edk2.groups.io > > > > > Cc: S, Ashraf Ali ; Chen, Christine > > > > > ; Rebecca Cran ; Gao, > > > > Liming > > > > > ; Feng, Bob C ; > > > > > Chan, Amy ; Chaganty, Rangasai V > > > > > > > > > > Subject: [PATCH] BaseTools: Remove Duplicate sets of SkuName > and > > > > > SkuId from allskuset > > > > > > > > > > Currently when the platform has many SKUs then allskuset will > be > > > > > having so many duplicate. and while parsing the allskuset will > > > > > take longer time while assing Pcd.SkuInfoList. > > > > > This patch is to eliminate those duplicate entires to reduce > the > > > > > build time > > > > > > > > > > Cc: Yuwei Chen > > > > > Cc: Rebecca Cran > > > > > Cc: Liming Gao > > > > > Cc: Bob Feng > > > > > Cc: Amy Chan > > > > > Cc: Sai Chaganty > > > > > Signed-off-by: Ashraf Ali S > > > > > --- > > > > > BaseTools/Source/Python/AutoGen/PlatformAutoGen.py | 2 ++ > > > > > 1 file changed, 2 insertions(+) > > > > > > > > > > diff --git a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > > > > b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > > > > index 592d4824a4..dac81454a9 100644 > > > > > --- a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > > > > +++ b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > > > > @@ -707,6 +707,8 @@ class PlatformAutoGen(AutoGen): > > > > > self._DynamicPcdList.extend(list(OtherPcdArray)) > > > > > self._DynamicPcdList.sort() > > > > > allskuset =3D [(SkuName, Sku.SkuId) for pcd in > > > > > self._DynamicPcdList for (SkuName, Sku) in > > > > > pcd.SkuInfoList.items()] > > > > > + # Remove duplicate sets in the list > > > > > + allskuset =3D list(set(allskuset)) > > > > > for pcd in self._DynamicPcdList: > > > > > if len(pcd.SkuInfoList) =3D=3D 1: > > > > > for (SkuName, SkuId) in allskuset: > > > > > -- > > > > > 2.39.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115268): https://edk2.groups.io/g/devel/message/115268 Mute This Topic: https://groups.io/mt/103360241/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-