From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6247BAC08F9 for ; Sat, 20 Jan 2024 02:49:35 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=DR5xstBrGKI8Uli4PLAnUbEb2rC+uI+nYMYQprdgFdQ=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705718974; v=1; b=sqj3fFmGGwVKWKr9Uws81g5Yl4lbF7gtDX/bILYLZNJZ+wu9UfcgWvJNp3mP52ARBqdy82C9 muFCSfwxebCLVsnp3FD7a//2bs0XYUul79waIGBd970LR3K6mw+2cfbNh0EaJ1lIVRrBTYXkjWW BKCjscoyF3syUmNSXPgI0zss= X-Received: by 127.0.0.2 with SMTP id 2IbXYY7687511xaemAuOYB3N; Fri, 19 Jan 2024 18:49:34 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mx.groups.io with SMTP id smtpd.web10.13663.1705718973119897316 for ; Fri, 19 Jan 2024 18:49:33 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10957"; a="19477984" X-IronPort-AV: E=Sophos;i="6.05,206,1701158400"; d="scan'208";a="19477984" X-Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2024 18:49:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10957"; a="904322765" X-IronPort-AV: E=Sophos;i="6.05,206,1701158400"; d="scan'208";a="904322765" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 19 Jan 2024 18:49:31 -0800 X-Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 19 Jan 2024 18:49:31 -0800 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 19 Jan 2024 18:49:31 -0800 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 19 Jan 2024 18:49:30 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iEjPGe38RHYLmg5d52q631FFVBtPvygI0feyDBCCFn6ffaZFXkEhcmP+ZuE/77Hjnzvdon3QEV4XPpLhZfKxfS/TLJkepo8dwj13bzBugU4JfR8wTli2PdY5yZt/5B9uW/LVDIcGF9pyhde/Nh58OLb0KihxBIIdCeCkGTTRPmr/+leAM1cg580u8Bn3s+sjrD2fMxJQUfdsl7ErU2ps9P3iYe3d7lWpYbKBbonpiGvuYdRu+KVH9Q4d2W6MHQySZYanBE/jtCuGDjWGbs62wz6JrtFZP8HEUzs8jkacEE5eJb+yKqOhLCcHVvh8PY7HwgWkWfUWGffV1WxhjFgaVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZGv5cUYADNKr5jCM1XpzONpbp2o5wI38g6AAqkrgY4k=; b=eB8O1rb7N84YEYn57rcXFnqH9l9cli0BfvymWsXEsQ1zGDUEXaWhPc2YecVVNDJ+6Ip4hJCOfe+2c2zochRSmGjZ/oY6nVlIyXo5ukvArJrHCRvX07zv+FYn06xor/h+IM4Y5hzdqNg9uI2bUR8ju246clRcbhMVFGWVdqwRuYMb4ZjDD5SbTHxb8TmkYZRcPr8Es/f5GOUvCFoX3y1rZuCjmWMxX1rHyNcnVPQIBpOoozUDC8PaRMOy/b5zyQBq4JgNITb7zImPViLr1UsySz0YPyv7iMsVNGmOHNR/1xWD7RecF7Uexy+pumA1uXnw7SNGSXXA14oa495LfJDblw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by CH3PR11MB7915.namprd11.prod.outlook.com (2603:10b6:610:12f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.27; Sat, 20 Jan 2024 02:49:23 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::4382:5b03:f13:88ff]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::4382:5b03:f13:88ff%4]) with mapi id 15.20.7202.026; Sat, 20 Jan 2024 02:49:23 +0000 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "Li, Zhiquan1" CC: "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH] MdePkg: fix the types of casting for TD MMIO read Thread-Topic: [edk2-devel] [PATCH] MdePkg: fix the types of casting for TD MMIO read Thread-Index: AQHaRYwMB7HezaHn006ExvK/vKsoE7DiCxyA Date: Sat, 20 Jan 2024 02:49:23 +0000 Message-ID: References: <20240112060220.824280-1-zhiquan1.li@intel.com> In-Reply-To: <20240112060220.824280-1-zhiquan1.li@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|CH3PR11MB7915:EE_ x-ms-office365-filtering-correlation-id: 8944b6fe-df20-40c0-7260-08dc196268a6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: qPyJmiI+5Mx06jNWLkcuHyeiMtboqVfHtArlCw93z7uzk+LVjsi8tvUTei5Cx+EVB4BPuqydQXRNPg9u6HQUOKRPCTu0M/DwMAlXuZY41oiIjD/cNHwpffDfxNVHNRdgU3s8dK0IMtxw6KLiKa8kHnqwiuXkfzm+RZNd8gS33hun2DvsrXpDVAt2Q5ZnZSU5s4Ul880guhnAc0ucTmy5Jr/Oe4wr+ou8hPGvPJpnSZBKThtwKSC+9YCGfOwIEYWqUEw+Foer31bQbL36U9rh2Twb60KHG3ED/wzsBqig12wbQU7bo41R9Cn9YMa+uSzm7oWVolcWUaUqP9Ep6BZSEk6yhXeCrZkLkJAlpTCFZXhYrgO5w/3vbpidib8ocQyC6sLUj0SS9cjeEt+38hpnLA5ubtwGQZQ1LvrROo9Jp8TNAwvO0RRH7hDLzP87HGV0Ch4P5Jmg4haObZUTFHUoQnO75jwpuyEmexHdv48zWfB97gOE1Zb8zcrqhH1VgKGWIzrxJe+3lpYfIDGKaon/Tj84e2lkaNCUqDk2keSRLVhHRNIOlf535dfhuK0dBoF+0T4H9PAoQp/oNW20wpsPR8QtXfts7gBA1aPLOAD1ufHbR/fRW0//baBYzJcxePOVv8iIXeXQHO+T53I4CxIong== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Up7E+RRbwm4i1ijcpFZX1hytfgLdVw3pl9L581282G7NGRatMNzp9sYhApgO?= =?us-ascii?Q?sdx8o3uGApnoBRMdZNrFpLQnfEiUH5IUNwXclcfcf/SqKt4WGXcb2FJvgE7w?= =?us-ascii?Q?NTRgs5bStP8AJzXMZwWk6DRnEp3gsF8NoQhxK3oVsxAdCNRsuA+zPGxL15AD?= =?us-ascii?Q?vWaJcQlz57sTiX6XZMM/2B3k8cUyT6+roorNKPV2lxFJ5gMoQZJDSxoEcQZS?= =?us-ascii?Q?p4lWm1V9rOH5SY4mpUGVWAo/iGuX/jQ2QQcWkbD15gObtxyL6vUZkeRNyTBn?= =?us-ascii?Q?zFh4cJSGWrooqFzAbT6qRmT7uEEFoAxvT8uPNUecOofOehk1kBx7/4FwBaXD?= =?us-ascii?Q?rhVTnsv6vIl17+X81TJd1LkhwrXpk3kTrT4DIS01hRCEUkdKwO2tBch1ABtb?= =?us-ascii?Q?rFEaXkEEkX6ZiohBZI66h8O6UO3nhezgISy2TvZRoeml1BpmvdCjpRBD/Vhz?= =?us-ascii?Q?pRUW4EeUfNKsTyVL6QYqnqX7KbheZEOhb0dpWgHFMDMUCaa1e2B9rUUowSIU?= =?us-ascii?Q?ZuJoZZ4qVcs71m7jRxZJmNj5F4QiW4Ge5DC9ES6yBb0Z9xjH/Iy4bY6ldAkE?= =?us-ascii?Q?Y5TyoLTIAZPoHth/rvlt98uD/45IFxkRw8QM9+qonj6MhaJ2jy141JA5nU0s?= =?us-ascii?Q?W7HwWndfduOA5f04EaGJKjobOCTF0kL5vkamiOepYtdh3Ilb0by7vJW2cCuI?= =?us-ascii?Q?P2g0/BdHNN+TgdgHlsrykrwVBl4QTBoIVNSSVUBRizf3I4iR3Lgm1p3bveNQ?= =?us-ascii?Q?ZD9fnbQvkBMJOa6prUeq7QsKILLVEXv5p0cgvVCoxBmHeUfCMDlTAr4TrDbQ?= =?us-ascii?Q?kWoGlfAiyz2VRwGZwdRH/MBk/iwlNk1lRBFCGjqr8pMpiAl6e1fmEoDX94MB?= =?us-ascii?Q?T/ulevZihV65XtqN7FdBmNwxYIMaJtiyBgnSOx5DdiwW08PdkyUtyKt8Ynql?= =?us-ascii?Q?cVvbD6KahR2+jFA14bOCmaHcuZAWNOtAOCyaYucu+bI8Sl41DN7jKcQ8bGbh?= =?us-ascii?Q?zZE2xzZknqi91DIxxW8zfwXwaJVHS3s3mmlDrBZ2gwLv2XCfGpCcMX9/sdgy?= =?us-ascii?Q?jIJHz6ElLQ8/ip69dUZOS458Xime89x8c0WaH1r8k8sdqsPgCVo1fHqnApJI?= =?us-ascii?Q?W1C3qJrTZwQKGyWSE78OGEuQa/gkkbARCPcUV2AvojgMe3ZPysLeMYdmL1RB?= =?us-ascii?Q?ivflR4UvOJ8XOc10l0MJ/w7Jo9EFDkSImxrDqX5hXzYmIlp4B5uRtLzj+iDs?= =?us-ascii?Q?eQ2CyCQ+ZSKn1N/CHwpuNd98Re6G6RlDt/1xwRbMDPenAPQ6w6Ea4MdutuwX?= =?us-ascii?Q?q8eOFNm85ZsEJ7V0bZl3g3zenUekzFiMAvgNAXzNYiL/XmwLbHRzYGAMdlu2?= =?us-ascii?Q?sV164UQGTZ5x63kuDAjbQ/e5/mKp0v5220SDCuq8ZpBTrBLHeT1xpDd416E6?= =?us-ascii?Q?RasVbC/MoYTslW7WWs8B0hbWmNGk/4hYRSptOXDpxCHHqsq2XLok5U7bxI8v?= =?us-ascii?Q?D//jN2hw218GrpPXPumesm8viC30ji8P0So+gl/a2fKUPvbjF6H9NWtRaph1?= =?us-ascii?Q?63JhL8PCzv/zSBiM2WMog0QKtmsaMue+1ElQ/CBzi/KWTl+Dw3uBiDdTes34?= =?us-ascii?Q?8Q=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8944b6fe-df20-40c0-7260-08dc196268a6 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jan 2024 02:49:23.2466 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WyR/nkeCUrNO3AI4T5iuR06UK+xGWub8JclRdFshczYwChsaejY1AZRkvbmgDZgXY9Srxp/W44eEmuzYpR9flx7ufSYK7JiJpU2XOF1w4LE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7915 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: MCwA6hccfcQGOKOF7EEGfBvkx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=sqj3fFmG; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Michael D Kinney Please include Cc tags in commit message with the maintainers of the patch for review. Otherwise, the maintainers may miss the=20 email patches. Thanks, Mike > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Zhiquan > Li > Sent: Thursday, January 11, 2024 10:02 PM > To: devel@edk2.groups.io > Cc: Li, Zhiquan1 > Subject: [edk2-devel] [PATCH] MdePkg: fix the types of casting for TD > MMIO read >=20 > Currently the types of casting mismatch with TD MMIO read 1, 2 and 4 > bytes, that might introduce potential issues. So fix the types as > conventional MmioRead[8|16|32] does. >=20 > Signed-off-by: Zhiquan Li > --- > MdePkg/Library/BaseIoLibIntrinsic/IoLibInternalTdx.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/MdePkg/Library/BaseIoLibIntrinsic/IoLibInternalTdx.c > b/MdePkg/Library/BaseIoLibIntrinsic/IoLibInternalTdx.c > index ec837f5eb03e..1acc3b3d9638 100644 > --- a/MdePkg/Library/BaseIoLibIntrinsic/IoLibInternalTdx.c > +++ b/MdePkg/Library/BaseIoLibIntrinsic/IoLibInternalTdx.c > @@ -237,7 +237,7 @@ TdMmioRead8 ( >=20 >=20 > Status =3D TdVmCall (TDVMCALL_MMIO, TDVMCALL_ACCESS_SIZE_1, > TDVMCALL_ACCESS_READ, Address | TdSharedPageMask (), 0, &Value); >=20 > if (Status !=3D 0) { >=20 > - Value =3D *(volatile UINT64 *)Address; >=20 > + Value =3D *(volatile UINT8 *)Address; >=20 > } >=20 >=20 >=20 > return (UINT8)Value; >=20 > @@ -294,7 +294,7 @@ TdMmioRead16 ( >=20 >=20 > Status =3D TdVmCall (TDVMCALL_MMIO, TDVMCALL_ACCESS_SIZE_2, > TDVMCALL_ACCESS_READ, Address | TdSharedPageMask (), 0, &Value); >=20 > if (Status !=3D 0) { >=20 > - Value =3D *(volatile UINT64 *)Address; >=20 > + Value =3D *(volatile UINT16 *)Address; >=20 > } >=20 >=20 >=20 > return (UINT16)Value; >=20 > @@ -353,7 +353,7 @@ TdMmioRead32 ( >=20 >=20 > Status =3D TdVmCall (TDVMCALL_MMIO, TDVMCALL_ACCESS_SIZE_4, > TDVMCALL_ACCESS_READ, Address | TdSharedPageMask (), 0, &Value); >=20 > if (Status !=3D 0) { >=20 > - Value =3D *(volatile UINT64 *)Address; >=20 > + Value =3D *(volatile UINT32 *)Address; >=20 > } >=20 >=20 >=20 > return (UINT32)Value; >=20 > -- > 2.25.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#113765): > https://edk2.groups.io/g/devel/message/113765 > Mute This Topic: https://groups.io/mt/103689726/1643496 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [michael.d.kinney@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114110): https://edk2.groups.io/g/devel/message/114110 Mute This Topic: https://groups.io/mt/103689726/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-