Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Avoid efi memory allocation for SP type

["Michael D Kinney" <michael.d.kinney@intel.com>]

Liming,

It is here, but needs some commit message updates

https://github.com/tianocore/edk2/pull/5760

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming via
> groups.io
> Sent: Friday, June 14, 2024 8:05 PM
> To: devel@edk2.groups.io; dhaval@rivosinc.com
> Subject: 回复: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Avoid efi memory
> allocation for SP type
> 
> Can you create pull request for this change? I will add my review for it.
> 
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Dhaval Sharma
> > 发送时间: 2024年6月11日 12:09
> > 收件人: devel@edk2.groups.io
> > 抄送: Liming Gao <gaoliming@byosoft.com.cn>
> > 主题: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Avoid efi memory
> allocation
> > for SP type
> >
> > Most of the times it is desirable not to use special purpose
> > memory for regular edk2 usages. That memory (HBm/CXL) are
> > either meant for special purposes or are less reliable to
> > be used. So avoid using them as long as possible. We could
> > also introduce PCD for this control.
> >
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Signed-off-by: Dhaval Sharma <dhaval@rivosinc.com>
> > ---
> >  MdeModulePkg/Core/Dxe/Mem/Page.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/MdeModulePkg/Core/Dxe/Mem/Page.c
> > b/MdeModulePkg/Core/Dxe/Mem/Page.c
> > index 5a51d9df1a29..e4daa741b971 100644
> > --- a/MdeModulePkg/Core/Dxe/Mem/Page.c
> > +++ b/MdeModulePkg/Core/Dxe/Mem/Page.c
> > @@ -1183,6 +1183,13 @@ CoreFindFreePagesI (
> >        continue;
> >
> >      }
> >
> >
> >
> > +    //
> >
> > +    // Don't allocate out of Special-Purpose memory.
> >
> > +    //
> >
> > +    if ((Entry->Attribute & EFI_MEMORY_SP) != 0) {
> >
> > +      continue;
> >
> > +    }
> >
> > +
> >
> >      DescStart = Entry->Start;
> >
> >      DescEnd   = Entry->End;
> >
> >
> >
> > --
> > 2.40.1
> >
> >
> >
> > -=-=-=-=-=-=
> > Groups.io Links: You receive all messages sent to this group.
> > View/Reply Online (#119545): https://edk2.groups.io/g/devel/message/119545
> > Mute This Topic: https://groups.io/mt/106607739/4905953
> > Group Owner: devel+owner@edk2.groups.io
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub
> > [gaoliming@byosoft.com.cn]
> > -=-=-=-=-=-=
> >
> 
> 
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119584): https://edk2.groups.io/g/devel/message/119584
Mute This Topic: https://groups.io/mt/106683481/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-