From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 651E67803CC for ; Thu, 20 Jul 2023 00:26:46 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=gSif9ke9xKP9L0d+xtRF6pB41t4te7ePgsjcYTy9YaM=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-IronPort-AV:X-IronPort-AV:X-Received:X-ExtLoop1:X-IronPort-AV:X-IronPort-AV:X-Received:X-Received:X-Received:X-Received:X-Received:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:X-Received:X-Received:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:x-ms-publictraffictype:x-ms-traffictypediagnostic:x-ms-office365-filtering-correlation-id:x-ms-exchange-senderadcheck:x-ms-exchange-antispam-relay:x-microsoft-antispam-message-info:x-ms-exchange-antispam-messagedata-chunkcount:x-ms-exchange-antispam-messagedata-0:MIME-Version:X-MS-Exchange-CrossTenant-AuthAs:X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-Network-Message-Id:X-MS-Exchange-CrossTenant-originalarrivaltime:X-MS-Exchange-CrossTenant-fromentityheader:X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:X-MS-Exchange-CrossTenant-userprincipalname:X-MS-Exchange-Transport-CrossTe nantHeadersStamped:X-OriginatorOrg:Precedence:List-Unsubscribe:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:X-Gm-Message-State:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1689812805; v=1; b=ewGX0ElHxqknklPGc7s/cHJzIoxOcscpV5uQYoiH+PFDesWcktKJ15iPIcxo0h7GrPbQkz7v wZxYo2564ih+CE/HjXZviQw/7V17j41NyFh58Ct9jY9DRV64QrHyqb8Nze8pe4GLIskXpONrKxl 4WsD17yUPIsnDxa2k0tfXVGA= X-Received: by 127.0.0.2 with SMTP id wCe9YY7687511xfJSqaACYW0; Wed, 19 Jul 2023 17:26:45 -0700 X-Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.2591.1689812804208982649 for ; Wed, 19 Jul 2023 17:26:44 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10776"; a="452977574" X-IronPort-AV: E=Sophos;i="6.01,216,1684825200"; d="scan'208";a="452977574" X-Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2023 17:26:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10776"; a="674506593" X-IronPort-AV: E=Sophos;i="6.01,216,1684825200"; d="scan'208";a="674506593" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga003.jf.intel.com with ESMTP; 19 Jul 2023 17:26:38 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 19 Jul 2023 17:26:38 -0700 X-Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 19 Jul 2023 17:26:37 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Wed, 19 Jul 2023 17:26:37 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Wed, 19 Jul 2023 17:26:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MtAwfcM5pdWVLCFQ0m9Bcd8ocA3+XkpQ7R49foZuzI2Ei6SMx85otjLbZR8EPC8x0H7+cWcZ22JkeDIeqJ/dGoAfB7NPHEzqp2BLlT8s6d3m8v766epUoGH0pJ3dhJZvMAepAESEZJtHc3Z/25bbhcE63eIAg3E3O7FFHiXmyjJ9tTXn34fAb6+8j/OEer8kjoVV8gdFbJLdMdc4DUCweUGmn0X8Ei2bOYinvaD6kA7R0Kr5KXV4UJ0VlsmdjFnyWKq6eyqU5S4tENN5LExzUyoQVc0J2AwdMusXNrepJ7kRF+MZ0l/UzWiZFZ/i1nczUtTxs3at6JscZJNBAusb9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d9ATQGCKWX82/b2fAYNA83oIgCrBxLmzAf/DH1weGAQ=; b=hq0vQC64DAZ0r9BdX/sgUhjTUB3TyY9m64beNATZEbh0rhoLQrm3rrnpR8nUKIiwa60Y6atunLnkv9dJ42LSx7PDGB8F2s1EE6qRpiINovMnArY3gLUCEXq1HwBOFSXd61aITShI7HuGiopGEsXB3KlGa+X7VlFrwhBrRx8Oii6eyT8ZG/G51VtSvuxNLEceKpeVyoa6aU3FtOsj+ByYLu/JKPri2ro7XA3VGtWPLjbrHnn4ltSTABlFo0nPot5CDQ7eAGEaXvQJagMb9PJzbScEht93k9/b0VzUcalYOJdqyRhsgldcwEF7xL2zqgSkzE5lVewZFJtCtA2G8cs76g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by SJ0PR11MB5069.namprd11.prod.outlook.com (2603:10b6:a03:2ad::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Thu, 20 Jul 2023 00:26:30 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::9c86:9394:6bb1:2e83]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::9c86:9394:6bb1:2e83%5]) with mapi id 15.20.6609.024; Thu, 20 Jul 2023 00:26:30 +0000 From: "Michael D Kinney" To: "Kasbekar, Saloni" , Nickle Wang , "devel@edk2.groups.io" , "Clark-williams, Zachary" CC: Abner Chang , Igor Kulchytskyy , "Nick Ramirez" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue. Thread-Topic: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue. Thread-Index: AQHZPUwAuV9WkswkYkek1DFyHKnaxa+gO4QQgAEvnACAADfV0IABlBQQgBT7atCAAJx/sIAJ9/Vg Date: Thu, 20 Jul 2023 00:26:30 +0000 Message-ID: References: <174276A45CE2816B.5513@groups.io> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|SJ0PR11MB5069:EE_ x-ms-office365-filtering-correlation-id: 5834584a-6192-4c5f-9f90-08db88b7f6b2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: RBz0zP9t7hIXb4AI04dnbyOXo0Q6CRJdiZp+iX3zpq+jdFVQ1ayMMs0Lq/mzVml4XL97DJfWqsGwzIZ+6a5YE4YmjmKqyu9ADGSBaXGYfp7aiyffVbd3lQgAgeQmv7mO6i8UrIE+D/yq4vAFAUMTRWJcvLadoRiaMbBUyAfdg4v72NKMhX6DuD8nws5PSrrKzqxP9+26sU0GPh1+JJzm7eXWxOwL8vn0zA1uqrztJV1cjGGumVL7Xb4JsgqBUId871eklP3xv2x5wpF/FWnJ3VpdinAKDRQ/EoEJIqZ2NW8cqWkWqSDCO4rZttmBYaKtAw7Um7iLPdmRK4eZLh530B2d/CBB4ju3L6HUu2NubUH60gJw3H5Z/cZprcNeiWFpxbzhfq06U0J2dgbgC6vD5hDkkS9kJG+xSKTVgSPbBIiUY/7Y+oGM0CE92G8x+xUS/HDpM7C5WeY7E7uA30bsFdcqBi1+stlFlbM0b/ssNcwLtxqG6Itu8LVnLOxFdwF9v5W9lhoMQ11weo6ip5yoQLbIl43rEppB8AZyl0xPXM+dZyLZDhr40siOIDxFK57I+TWmdWaHNiHrqtozdCwv2mlRUH+8GzwASo2FP6JCe4VnIsOY+5t4WFmI5nQC0a0AwNdrSIJ7FHfedemHolNppCrBWbeAmpiIpZy55o45lPg= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qevbAROQjJ2ryHwdxGXdZTIIkV2rhS6ozgE/LaxHOmvlXvYgSEiJGIO5r073?= =?us-ascii?Q?ZtSvab3HhUFY+5S9H8FZbOzxhvUFfrYjciP4RG5I1xr7+Q0XJuwtzUcBzNWl?= =?us-ascii?Q?oamRqh/YxBa/6n23MySZopC60ZbNqAsGoY7yLRme+w/daoQ4fTRpEphAlixr?= =?us-ascii?Q?pdbdY0UtOBwvqFrSE9M39bOXkXiIVcBlnVwRKt0YnbSlySkRywoMgXsPCZCq?= =?us-ascii?Q?3VHN04MEBqP5/9q4dNZKt1wvaXvPDOevW4itM31vqNwfGCHXmYUNXyQMUzqr?= =?us-ascii?Q?onwlHVroz0yHYbaCpwXPuZT/jd6FOJ7MPw7UniYlIzQfp1CVDNbupZAtcmy+?= =?us-ascii?Q?2hkHh0aHVC82UORALn+1dVkk3pI9wz+n7DVUHdVtwWx6JZ6HJTsa8bPjDrWx?= =?us-ascii?Q?c0zMKYM6wjpmXpc5MCIMPR0eaI/3RRl5i5N5Tp+LqYLsBzbBvn+ZOkAfvRQU?= =?us-ascii?Q?ALVedU9qUOVa1YT96m5jabf+FQO5Z4CrYKbvnycbMIyEti3objnHKF+0kWV1?= =?us-ascii?Q?bD9OkrMXteAqzP3OnnPKeB2vGw+1CnEVv9bjodKdt2vtZAAxE/vzE2SWNIUR?= =?us-ascii?Q?VGnDSzMrKG33OhUqTnelZAl3oqWV3Fvpgxh1Es0J3rVuF3kRwvFMA7W2NA/1?= =?us-ascii?Q?PnHha5MHIRQ/DFwof5eLzh3RZZUw59GrkhSs8kne2lm3BJr/8ABUWqoSAMrn?= =?us-ascii?Q?b2dRPUH3RHgv7NZ46O+Hjgd0zKLNTVAa74b1tf1yQRzqdcC/HmcdmkI7yGyS?= =?us-ascii?Q?yWTmrBCyQO2P7Yvr/DD4UxyG3aqtwNB2ojVgQOQ2TtrGT4ZrPVdYjVtaWKKL?= =?us-ascii?Q?MZC0UkZYv7WCNxoonS459+U1FUwSIRLsoPHqX8rSnrH+XwOZNrWANR+6Rqv1?= =?us-ascii?Q?aKSl7W5dKWNQ+0RoB3eamSPF8ZzI8A3L8RKKfONZI4Wt1vEhKg3uCtuhJVn5?= =?us-ascii?Q?vpgE8KQz5DUEnn+iI7CJ5vvVxIOYt9F96pfD1ZbJ6J7AjM2XBNda83M+jOwz?= =?us-ascii?Q?ajpa+CudBOySa1FNI2zFLSo/rgwUtSfErsnysn/kToutL9F0Ws5m/knlVdUn?= =?us-ascii?Q?KoPGZ8wEXyFae0Zo4h0sTwyQwJ1Ib9aWvNZNgeWgE7zBkNifpfF7GO8aoupw?= =?us-ascii?Q?K+Ua7xfkOx6CsWuO7hrO7RhXdU+wcLpXiuDT7a1fUDu8tu6BpsueZ5WkmzJV?= =?us-ascii?Q?zRoNo3VZu+XMM6DpH6mlLHjDqGNKcBLI6u0k82uCfEvzWpFzBp+1uGOo3qsB?= =?us-ascii?Q?dSqlbSTuMujLHd/37rAHM/HJ/ohZTQtJkdzI2Mdb7baBIAUo62b/CN+A/Syy?= =?us-ascii?Q?/vmQJzua6ql/or6jqiwnbJuOsuLqM5iRSLQFGJRSZeX74st7dt0EuQ0Tktep?= =?us-ascii?Q?CzTvCMhuRWJlts2PIZ5rdgajEHwgG5fcR6La0tRBCG94EEPmeoTDaLY84i31?= =?us-ascii?Q?/pFeadLbazFxaDx50w4uGmn3FwFyb94PZzPkw+cwU5zvjGvglpXjyJmNmW4S?= =?us-ascii?Q?LGB8uzfZq6V4Y1BKAdmHaNM/3b2tu4pNJ3UHm0wA674VjdPhKfOg7gjS7N8a?= =?us-ascii?Q?9R39/grJSwx6MghnD88gdI1fWPSSiuk0Cozr/z34xZFdQzOgdiWt1mi/qM+q?= =?us-ascii?Q?Gw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5834584a-6192-4c5f-9f90-08db88b7f6b2 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2023 00:26:30.2261 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: N4UFxLUTqvPJ03T8Aj58M194JmoVcQLdAUY0Lu9wSmBWEI7Gq7E082QT1GvXfJBZqxHhHQANrrZwpBxY847pEuaFaBYnF5yamgj+rjZ2KwA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5069 X-OriginatorOrg: intel.com Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click X-Gm-Message-State: 8bjlVB7yyBoltKdoPqX9fPwwx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ewGX0ElH; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Acked-by: Michael D Kinney > -----Original Message----- > From: Kasbekar, Saloni > Sent: Thursday, July 13, 2023 9:13 AM > To: Nickle Wang ; devel@edk2.groups.io; Clark- > williams, Zachary ; Kinney, Michael D > > Cc: Abner Chang ; Igor Kulchytskyy ; > Nick Ramirez > Subject: RE: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver > binding start issue. >=20 > Mike, >=20 > Would you be able to help us merge the patch? >=20 > Thanks, > Saloni >=20 > -----Original Message----- > From: Nickle Wang > Sent: Wednesday, July 12, 2023 11:54 PM > To: devel@edk2.groups.io; Kasbekar, Saloni ; > Clark-williams, Zachary > Cc: Abner Chang ; Igor Kulchytskyy ; > Nick Ramirez > Subject: RE: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver > binding start issue. >=20 > Hi Saloni, >=20 > Could you please help to merge this fix since there is no objection > during past weeks? >=20 > Thanks, > Nickle >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Saloni > > Kasbekar via groups.io > > Sent: Friday, June 30, 2023 6:28 AM > > To: Nickle Wang ; devel@edk2.groups.io > > Cc: Maciej Rabeda ; Siyuan Fu > > ; Abner Chang ; Igor > > Kulchytskyy ; Nick Ramirez > > Subject: Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver > > binding start issue. > > > > External email: Use caution opening links or attachments > > > > > > Hi Nickle, > > > > That makes sense. Thanks for the clarification. > > > > Reviewed-by: Saloni Kasbekar > > > > Thanks, > > Saloni > > > > -----Original Message----- > > From: Nickle Wang > > Sent: Wednesday, June 28, 2023 3:30 PM > > To: Kasbekar, Saloni ; devel@edk2.groups.io > > Cc: Maciej Rabeda ; Siyuan Fu > > ; Abner Chang ; Igor > > Kulchytskyy ; Nick Ramirez > > Subject: RE: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver > > binding start issue. > > > > Hi Saloni, > > > > Thanks for your review. > > > > When uninstall fails, per UEFI specification, the protocol will be > > installed again and will be visible to UEFI drivers. > > > > Page 190, UEFI spec. 2.10: > > "If any errors are generated while the protocol interfaces are being > > uninstalled, then the protocols uninstalled prior to the error will be > > reinstalled with the boot service > > EFI_BOOT_SERVICES.InstallProtocolInterface() and the status code > > EFI_INVALID_PARAMETER is returned." > > > > In this case, if we do FreePool while driver still can locate > > gEfiHttpServiceBindingProtocolGuid. Driver will access to the memory > > that is released to system. Memory issue may happen. > > > > Regards, > > Nickle > > > > > -----Original Message----- > > > From: Kasbekar, Saloni > > > Sent: Thursday, June 29, 2023 3:07 AM > > > To: devel@edk2.groups.io; Nickle Wang > > > Cc: Maciej Rabeda ; Siyuan Fu > > > ; Abner Chang ; Igor > > > Kulchytskyy ; Nick Ramirez > > > Subject: RE: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver > > > binding start issue. > > > > > > External email: Use caution opening links or attachments > > > > > > > > > Hi Nickle, > > > > > > We would want to do the FreePool even if the Uninstall fails (like > > > in the case where we failed to install the multiple protocol > > > interfaces and then went to ON_ERROR). Do you think it's better if > > > we change it to - > > > > > > if (HttpService !=3D NULL) { > > > HttpCleanService (HttpService, UsingIpv6); > > > Status =3D gBS->UninstallMultipleProtocolInterfaces ( > > > &ControllerHandle, > > > &gEfiHttpServiceBindingProtocolGuid, > > > &HttpService->ServiceBinding, > > > NULL > > > ); > > > if ((HttpService->Tcp4ChildHandle =3D=3D NULL) && > > > (HttpService->Tcp6ChildHandle =3D=3D NULL)) { > > > FreePool (HttpService); > > > } > > > } > > > > > > Thanks, > > > Saloni > > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of > > > Nickle Wang via groups.io > > > Sent: Tuesday, June 27, 2023 5:56 PM > > > To: devel@edk2.groups.io; Nickle Wang > > > Cc: Maciej Rabeda ; Siyuan Fu > > > ; Abner Chang ; Igor > > > Kulchytskyy ; Nick Ramirez > > > Subject: Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver > > > binding start issue. > > > > > > May I know if someone can help to review this patch? > > > > > > Thanks, > > > Nickle > > > > > > > -----Original Message----- > > > > From: devel@edk2.groups.io On Behalf Of > > > > Nickle Wang via groups.io > > > > Sent: Friday, February 10, 2023 8:34 PM > > > > To: devel@edk2.groups.io > > > > Cc: Maciej Rabeda ; Siyuan Fu > > > > ; Abner Chang ; Igor > > > > Kulchytskyy ; Nick Ramirez > > > > Subject: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver > > > > binding start issue. > > > > > > > > External email: Use caution opening links or attachments > > > > > > > > > > > > When failure happens in HttpDxeStart, the error handling code > > > > release the memory buffer but it does not uninstall HTTP service > > > > bindnig protocol. As the result, application can still locate this > > > > protocol and invoke service binding fucntions in released memory > pool. > > > > > > > > Signed-off-by: Nickle Wang > > > > Cc: Maciej Rabeda > > > > Cc: Siyuan Fu > > > > Cc: Abner Chang > > > > Cc: Igor Kulchytskyy > > > > Cc: Nick Ramirez > > > > --- > > > > NetworkPkg/HttpDxe/HttpDriver.c | 13 +++++++++++-- > > > > 1 file changed, 11 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/NetworkPkg/HttpDxe/HttpDriver.c > > > > b/NetworkPkg/HttpDxe/HttpDriver.c index 5d918d3c4d..f6d1263cad > > > > 100644 > > > > --- a/NetworkPkg/HttpDxe/HttpDriver.c > > > > +++ b/NetworkPkg/HttpDxe/HttpDriver.c > > > > @@ -3,6 +3,7 @@ > > > > > > > > Copyright (c) 2015 - 2018, Intel Corporation. All rights > reserved.
> > > > (C) Copyright 2016 Hewlett Packard Enterprise Development > > > > LP
> > > > + Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights > > reserved. > > > > > > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > > > @@ -464,8 +465,16 @@ ON_ERROR: > > > > > > > > if (HttpService !=3D NULL) { > > > > HttpCleanService (HttpService, UsingIpv6); > > > > - if ((HttpService->Tcp4ChildHandle =3D=3D NULL) && (HttpService= - > > > > >Tcp6ChildHandle =3D=3D NULL)) { > > > > - FreePool (HttpService); > > > > + Status =3D gBS->UninstallMultipleProtocolInterfaces ( > > > > + &ControllerHandle, > > > > + &gEfiHttpServiceBindingProtocolGuid, > > > > + &HttpService->ServiceBinding, > > > > + NULL > > > > + ); > > > > + if (!EFI_ERROR (Status)) { > > > > + if ((HttpService->Tcp4ChildHandle =3D=3D NULL) && (HttpServi= ce- > > > > >Tcp6ChildHandle =3D=3D NULL)) { > > > > + FreePool (HttpService); > > > > + } > > > > } > > > > } > > > > > > > > -- > > > > 2.39.1.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107076): https://edk2.groups.io/g/devel/message/107076 Mute This Topic: https://groups.io/mt/99821789/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-