From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"rebecca@bsdio.com" <rebecca@bsdio.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>,
"Jiang, Guomin" <guomin.jiang@intel.com>,
"Xu, Wei6" <wei6.xu@intel.com>, "Dong, Guo" <guo.dong@intel.com>,
"Ni, Ray" <ray.ni@intel.com>,
"Rhodes, Sean" <sean@starlabs.systems>,
"Lu, James" <james.lu@intel.com>, "Guo, Gua" <gua.guo@intel.com>,
Andrew Fish <afish@apple.com>, "Wu, Hao A" <hao.a.wu@intel.com>,
Maciej Rabeda <maciej.rabeda@linux.intel.com>,
"Siyuan Fu" <siyuan.fu@intel.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Lu, Xiaoyu1" <xiaoyu1.lu@intel.com>,
"Ard Biesheuvel" <ardb+tianocore@kernel.org>,
Sami Mujawar <sami.mujawar@arm.com>,
Supreeth Venkatesh <supreeth.venkatesh@arm.com>,
Michael Kubacki <mikuback@linux.microsoft.com>,
"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
Sean Brogan <sean.brogan@microsoft.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>,
Abner Chang <abner.chang@amd.com>,
Nickle Wang <nicklew@nvidia.com>,
Igor Kulchytskyy <igork@ami.com>,
Daniel Schaefer <git@danielschaefer.me>,
"Xu, Min M" <min.m.xu@intel.com>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
Peter Grehan <grehan@freebsd.org>,
"Aktas, Erdem" <erdemaktas@google.com>,
James Bottomley <jejb@linux.ibm.com>,
"Tom Lendacky" <thomas.lendacky@amd.com>,
Michael Roth <michael.roth@amd.com>,
Sunil V L <sunilvl@ventanamicro.com>,
"Warkentin, Andrei" <andrei.warkentin@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH 01/18] ArmPkg: Update code to be more C11 compliant by using __func__
Date: Fri, 7 Apr 2023 20:18:30 +0000 [thread overview]
Message-ID: <CO1PR11MB49299CC0DFD3D16E6260C884D2969@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230406222319.2281263-2-rebecca@bsdio.com>
Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran
> Sent: Thursday, April 6, 2023 3:23 PM
> To: devel@edk2.groups.io; Gao, Liming <gaoliming@byosoft.com.cn>; Kinney, Michael D <michael.d.kinney@intel.com>; Jiang, Guomin
> <guomin.jiang@intel.com>; Xu, Wei6 <wei6.xu@intel.com>; Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Rhodes, Sean
> <sean@starlabs.systems>; Lu, James <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com>; Andrew Fish <afish@apple.com>; Wu, Hao A
> <hao.a.wu@intel.com>; Maciej Rabeda <maciej.rabeda@linux.intel.com>; Siyuan Fu <siyuan.fu@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Sami Mujawar <sami.mujawar@arm.com>; Supreeth Venkatesh <supreeth.venkatesh@arm.com>; Michael
> Kubacki <mikuback@linux.microsoft.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Sean Brogan
> <sean.brogan@microsoft.com>
> Cc: Rebecca Cran <rebecca@bsdio.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Abner Chang <abner.chang@amd.com>; Nickle Wang
> <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>; Daniel Schaefer <git@danielschaefer.me>; Xu, Min M <min.m.xu@intel.com>;
> Justen, Jordan L <jordan.l.justen@intel.com>; Gerd Hoffmann <kraxel@redhat.com>; Peter Grehan <grehan@freebsd.org>; Aktas, Erdem
> <erdemaktas@google.com>; James Bottomley <jejb@linux.ibm.com>; Tom Lendacky <thomas.lendacky@amd.com>; Michael Roth
> <michael.roth@amd.com>; Sunil V L <sunilvl@ventanamicro.com>; Warkentin, Andrei <andrei.warkentin@intel.com>
> Subject: [edk2-devel] [PATCH 01/18] ArmPkg: Update code to be more C11 compliant by using __func__
>
> __FUNCTION__ is a pre-standard extension that gcc and Visual C++ among
> others support, while __func__ was standardized in C99.
>
> Since it's more standard, replace __FUNCTION__ with __func__ throughout
> ArmPkg.
>
> Visual Studio versions before VS 2015 don't support __func__ and so
> will fail to compile. A workaround is to define __func__ as
> __FUNCTION__ :
>
> #define __func__ __FUNCTION__
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
> ArmPkg/Drivers/ArmGic/ArmGicCommonDxe.c | 4 +--
> ArmPkg/Drivers/CpuDxe/MemoryAttribute.c | 10 +++---
> ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c | 4 +--
> ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSystemLib.c | 2 +-
> ArmPkg/Library/LinuxBootBootManagerLib/LinuxBootBm.c | 2 +-
> ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 32 ++++++++++----------
> ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 2 +-
> ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c | 2 +-
> ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c | 2 +-
> ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c | 2 +-
> ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c | 2 +-
> ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c | 2 +-
> ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c | 2 +-
> 13 files changed, 34 insertions(+), 34 deletions(-)
>
> diff --git a/ArmPkg/Drivers/ArmGic/ArmGicCommonDxe.c b/ArmPkg/Drivers/ArmGic/ArmGicCommonDxe.c
> index cd12fcda27e9..d560c42fc9f3 100644
> --- a/ArmPkg/Drivers/ArmGic/ArmGicCommonDxe.c
> +++ b/ArmPkg/Drivers/ArmGic/ArmGicCommonDxe.c
> @@ -137,7 +137,7 @@ CpuArchEventProtocolNotify (
> DEBUG ((
> DEBUG_ERROR,
> "%a: Cpu->RegisterInterruptHandler() - %r\n",
> - __FUNCTION__,
> + __func__,
> Status
> ));
> return;
> @@ -153,7 +153,7 @@ CpuArchEventProtocolNotify (
> DEBUG ((
> DEBUG_ERROR,
> "%a: Cpu->RegisterInterruptHandler() - %r\n",
> - __FUNCTION__,
> + __func__,
> Status
> ));
> }
> diff --git a/ArmPkg/Drivers/CpuDxe/MemoryAttribute.c b/ArmPkg/Drivers/CpuDxe/MemoryAttribute.c
> index cbc8261a68b7..61ba8fbbae4e 100644
> --- a/ArmPkg/Drivers/CpuDxe/MemoryAttribute.c
> +++ b/ArmPkg/Drivers/CpuDxe/MemoryAttribute.c
> @@ -92,7 +92,7 @@ GetMemoryAttributes (
> DEBUG ((
> DEBUG_VERBOSE,
> "%a: BaseAddress == 0x%lx, Length == 0x%lx\n",
> - __FUNCTION__,
> + __func__,
> BaseAddress,
> Length
> ));
> @@ -113,7 +113,7 @@ GetMemoryAttributes (
> DEBUG ((
> DEBUG_VERBOSE,
> "%a: RegionAddress == 0x%lx, RegionLength == 0x%lx, RegionAttributes == 0x%lx\n",
> - __FUNCTION__,
> + __func__,
> (UINT64)RegionAddress,
> (UINT64)RegionLength,
> (UINT64)RegionAttributes
> @@ -130,7 +130,7 @@ GetMemoryAttributes (
> DEBUG ((
> DEBUG_VERBOSE,
> "%a: Union == %lx, Intersection == %lx\n",
> - __FUNCTION__,
> + __func__,
> (UINT64)Union,
> (UINT64)Intersection
> ));
> @@ -188,7 +188,7 @@ SetMemoryAttributes (
> DEBUG ((
> DEBUG_INFO,
> "%a: BaseAddress == 0x%lx, Length == 0x%lx, Attributes == 0x%lx\n",
> - __FUNCTION__,
> + __func__,
> (UINTN)BaseAddress,
> (UINTN)Length,
> (UINTN)Attributes
> @@ -272,7 +272,7 @@ ClearMemoryAttributes (
> DEBUG ((
> DEBUG_INFO,
> "%a: BaseAddress == 0x%lx, Length == 0x%lx, Attributes == 0x%lx\n",
> - __FUNCTION__,
> + __func__,
> (UINTN)BaseAddress,
> (UINTN)Length,
> (UINTN)Attributes
> diff --git a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c b/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
> index 7acfd2e89a92..7ed758fbbc69 100644
> --- a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
> +++ b/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
> @@ -139,7 +139,7 @@ ReplaceTableEntry (
> (((RegionStart ^ (UINTN)Entry) & ~BlockMask) == 0))
> {
> DisableMmu = TRUE;
> - DEBUG ((DEBUG_WARN, "%a: splitting block entry with MMU disabled\n", __FUNCTION__));
> + DEBUG ((DEBUG_WARN, "%a: splitting block entry with MMU disabled\n", __func__));
> }
>
> mReplaceLiveEntryFunc (Entry, Value, RegionStart, DisableMmu);
> @@ -233,7 +233,7 @@ UpdateRegionMappingRecursive (
> DEBUG ((
> DEBUG_VERBOSE,
> "%a(%d): %llx - %llx set %lx clr %lx\n",
> - __FUNCTION__,
> + __func__,
> Level,
> RegionStart,
> RegionEnd,
> diff --git a/ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSystemLib.c
> b/ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSystemLib.c
> index 7bcd34849507..02b0c27e4df3 100644
> --- a/ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSystemLib.c
> +++ b/ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSystemLib.c
> @@ -65,7 +65,7 @@ LibResetSystem (
> ArmCallSmc (&ArmSmcArgs);
>
> // We should never be here
> - DEBUG ((DEBUG_ERROR, "%a: PSCI Reset failed\n", __FUNCTION__));
> + DEBUG ((DEBUG_ERROR, "%a: PSCI Reset failed\n", __func__));
> CpuDeadLoop ();
> return EFI_UNSUPPORTED;
> }
> diff --git a/ArmPkg/Library/LinuxBootBootManagerLib/LinuxBootBm.c b/ArmPkg/Library/LinuxBootBootManagerLib/LinuxBootBm.c
> index 5a44af5a755d..75998eabb1c6 100644
> --- a/ArmPkg/Library/LinuxBootBootManagerLib/LinuxBootBm.c
> +++ b/ArmPkg/Library/LinuxBootBootManagerLib/LinuxBootBm.c
> @@ -151,7 +151,7 @@ PlatformBootManagerAfterConsole (
> LOAD_OPTION_ACTIVE
> );
> } else {
> - DEBUG ((DEBUG_ERROR, "%a: PcdLinuxBootFileGuid was not set!\n", __FUNCTION__));
> + DEBUG ((DEBUG_ERROR, "%a: PcdLinuxBootFileGuid was not set!\n", __func__));
> }
> }
>
> diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
> index 2fb1a4aa4fb8..08998ffe4d17 100644
> --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
> +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
> @@ -195,7 +195,7 @@ FilterAndProcess (
> DEBUG ((
> DEBUG_VERBOSE,
> "%a: %g: %r\n",
> - __FUNCTION__,
> + __func__,
> ProtocolGuid,
> Status
> ));
> @@ -266,7 +266,7 @@ IsPciDisplay (
> &Pci
> );
> if (EFI_ERROR (Status)) {
> - DEBUG ((DEBUG_ERROR, "%a: %s: %r\n", __FUNCTION__, ReportText, Status));
> + DEBUG ((DEBUG_ERROR, "%a: %s: %r\n", __func__, ReportText, Status));
> return FALSE;
> }
>
> @@ -330,7 +330,7 @@ Connect (
> DEBUG ((
> EFI_ERROR (Status) ? DEBUG_ERROR : DEBUG_VERBOSE,
> "%a: %s: %r\n",
> - __FUNCTION__,
> + __func__,
> ReportText,
> Status
> ));
> @@ -356,7 +356,7 @@ AddOutput (
> DEBUG ((
> DEBUG_ERROR,
> "%a: %s: handle %p: device path not found\n",
> - __FUNCTION__,
> + __func__,
> ReportText,
> Handle
> ));
> @@ -368,7 +368,7 @@ AddOutput (
> DEBUG ((
> DEBUG_ERROR,
> "%a: %s: adding to ConOut: %r\n",
> - __FUNCTION__,
> + __func__,
> ReportText,
> Status
> ));
> @@ -380,7 +380,7 @@ AddOutput (
> DEBUG ((
> DEBUG_ERROR,
> "%a: %s: adding to ErrOut: %r\n",
> - __FUNCTION__,
> + __func__,
> ReportText,
> Status
> ));
> @@ -390,7 +390,7 @@ AddOutput (
> DEBUG ((
> DEBUG_VERBOSE,
> "%a: %s: added to ConOut and ErrOut\n",
> - __FUNCTION__,
> + __func__,
> ReportText
> ));
> }
> @@ -547,7 +547,7 @@ GetPlatformOptions (
> DEBUG ((
> DEBUG_ERROR,
> "%a: failed to register \"%s\": %r\n",
> - __FUNCTION__,
> + __func__,
> BootOptions[Index].Description,
> Status
> ));
> @@ -575,7 +575,7 @@ GetPlatformOptions (
> DEBUG ((
> DEBUG_ERROR,
> "%a: failed to register hotkey for \"%s\": %r\n",
> - __FUNCTION__,
> + __func__,
> BootOptions[Index].Description,
> Status
> ));
> @@ -757,7 +757,7 @@ HandleCapsules (
> BOOLEAN NeedReset;
> EFI_STATUS Status;
>
> - DEBUG ((DEBUG_INFO, "%a: processing capsules ...\n", __FUNCTION__));
> + DEBUG ((DEBUG_INFO, "%a: processing capsules ...\n", __func__));
>
> Status = gBS->LocateProtocol (
> &gEsrtManagementProtocolGuid,
> @@ -785,7 +785,7 @@ HandleCapsules (
> DEBUG ((
> DEBUG_ERROR,
> "%a: failed to process capsule %p - %r\n",
> - __FUNCTION__,
> + __func__,
> CapsuleHeader,
> Status
> ));
> @@ -800,7 +800,7 @@ HandleCapsules (
> DEBUG ((
> DEBUG_WARN,
> "%a: capsule update successful, resetting ...\n",
> - __FUNCTION__
> + __func__
> ));
>
> gRT->ResetSystem (EfiResetCold, EFI_SUCCESS, 0, NULL);
> @@ -868,7 +868,7 @@ BootDiscoveryPolicyHandler (
> DEBUG ((
> DEBUG_INFO,
> "%a - Unexpected DiscoveryPolicy (0x%x). Run Minimal Discovery Policy\n",
> - __FUNCTION__,
> + __func__,
> DiscoveryPolicy
> ));
> return EFI_SUCCESS;
> @@ -884,14 +884,14 @@ BootDiscoveryPolicyHandler (
> DEBUG_INFO,
> "%a - Failed to locate gEfiBootManagerPolicyProtocolGuid."
> "Driver connect will be skipped.\n",
> - __FUNCTION__
> + __func__
> ));
> return Status;
> }
>
> Status = BMPolicy->ConnectDeviceClass (BMPolicy, Class);
> if (EFI_ERROR (Status)) {
> - DEBUG ((DEBUG_ERROR, "%a - ConnectDeviceClass returns - %r\n", __FUNCTION__, Status));
> + DEBUG ((DEBUG_ERROR, "%a - ConnectDeviceClass returns - %r\n", __func__, Status));
> return Status;
> }
>
> @@ -1096,7 +1096,7 @@ PlatformBootManagerUnableToBoot (
> DEBUG ((
> DEBUG_WARN,
> "%a: rebooting after refreshing all boot options\n",
> - __FUNCTION__
> + __func__
> ));
> gRT->ResetSystem (EfiResetCold, EFI_SUCCESS, 0, NULL);
> }
> diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
> b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
> index 3b12e26abf6e..905058850056 100644
> --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
> +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
> @@ -741,7 +741,7 @@ AddSmbiosProcessorTypeTable (
> DEBUG ((
> DEBUG_ERROR,
> "[%a]:[%dL] Smbios Type04 Table Log Failed! %r \n",
> - __FUNCTION__,
> + __func__,
> DEBUG_LINE_NUMBER,
> Status
> ));
> diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c
> b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c
> index c9f25b750254..38f3864b160e 100644
> --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c
> +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c
> @@ -287,7 +287,7 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBiosVendor) {
> DEBUG ((
> DEBUG_ERROR,
> "[%a]:[%dL] Smbios Type00 Table Log Failed! %r \n",
> - __FUNCTION__,
> + __func__,
> DEBUG_LINE_NUMBER,
> Status
> ));
> diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c
> b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c
> index 22fb5eccaa63..8867de4815a2 100644
> --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c
> +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c
> @@ -184,7 +184,7 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscSystemManufacturer) {
> DEBUG ((
> DEBUG_ERROR,
> "[%a]:[%dL] Smbios Type01 Table Log Failed! %r \n",
> - __FUNCTION__,
> + __func__,
> DEBUG_LINE_NUMBER,
> Status
> ));
> diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c
> b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c
> index 3441e7798860..feb42e6f5dee 100644
> --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c
> +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c
> @@ -214,7 +214,7 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBaseBoardManufacturer) {
> DEBUG ((
> DEBUG_ERROR,
> "[%a]:[%dL] Smbios Type02 Table Log Failed! %r \n",
> - __FUNCTION__,
> + __func__,
> DEBUG_LINE_NUMBER,
> Status
> ));
> diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c
> b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c
> index d161970c023e..6b3b63b0e8d5 100644
> --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c
> +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c
> @@ -179,7 +179,7 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscChassisManufacturer) {
> DEBUG ((
> DEBUG_ERROR,
> "[%a]:[%dL] Smbios Type03 Table Log Failed! %r \n",
> - __FUNCTION__,
> + __func__,
> DEBUG_LINE_NUMBER,
> Status
> ));
> diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c
> b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c
> index 386b8800e29b..951ac2a905b6 100644
> --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c
> +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c
> @@ -161,7 +161,7 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscNumberOfInstallableLanguages) {
> DEBUG ((
> DEBUG_ERROR,
> "[%a]:[%dL] Smbios Type13 Table Log Failed! %r \n",
> - __FUNCTION__,
> + __func__,
> DEBUG_LINE_NUMBER,
> Status
> ));
> diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c
> b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c
> index fdf6262aa7f5..fa1ea95f2bc3 100644
> --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c
> +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c
> @@ -69,7 +69,7 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBootInformation) {
> DEBUG ((
> DEBUG_ERROR,
> "[%a]:[%dL] Smbios Type32 Table Log Failed! %r \n",
> - __FUNCTION__,
> + __func__,
> DEBUG_LINE_NUMBER,
> Status
> ));
> --
> 2.34.1
>
>
>
>
>
next prev parent reply other threads:[~2023-04-07 20:18 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 22:23 [PATCH 00/18] Replace pre-standard macro __FUNCTION__ with C99 __func__ throughout edk2 Rebecca Cran
2023-04-06 22:23 ` [PATCH 01/18] ArmPkg: Update code to be more C11 compliant by using __func__ Rebecca Cran
2023-04-07 20:18 ` Michael D Kinney [this message]
2023-04-06 22:23 ` [PATCH 02/18] ArmVirtPkg: " Rebecca Cran
2023-04-06 22:23 ` [PATCH 03/18] UefiCpuPkg: " Rebecca Cran
2023-04-07 3:09 ` Ni, Ray
2023-04-07 11:24 ` Sunil V L
2023-04-06 22:23 ` [PATCH 04/18] OvmfPkg: " Rebecca Cran
2023-04-07 11:19 ` Sunil V L
2023-04-06 22:23 ` [PATCH 05/18] MdeModulePkg: " Rebecca Cran
2023-04-06 22:23 ` [PATCH 06/18] SecurityPkg: " Rebecca Cran
2023-04-06 22:23 ` [PATCH 07/18] EmbeddedPkg: " Rebecca Cran
2023-04-07 8:25 ` Chang, Abner
2023-04-06 22:23 ` [PATCH 08/18] RedfishPkg: " Rebecca Cran
2023-04-07 5:39 ` Nickle Wang
2023-04-06 22:23 ` [PATCH 09/18] ArmPlatformPkg: " Rebecca Cran
2023-04-06 22:23 ` [PATCH 10/18] UnitTestFrameworkPkg: Update " Rebecca Cran
2023-04-06 22:23 ` [PATCH 11/18] PrmPkg: Update code " Rebecca Cran
2023-04-06 22:23 ` [PATCH 12/18] StandaloneMmPkg: " Rebecca Cran
2023-04-06 22:23 ` [PATCH 13/18] CryptoPkg: " Rebecca Cran
2023-04-06 22:23 ` [PATCH 14/18] NetworkPkg: " Rebecca Cran
2023-04-06 22:23 ` [PATCH 15/18] SourceLevelDebugPkg: " Rebecca Cran
2023-04-07 3:08 ` Ni, Ray
2023-04-06 22:23 ` [PATCH 16/18] EmulatorPkg: " Rebecca Cran
2023-04-07 3:08 ` Ni, Ray
2023-04-07 8:23 ` Chang, Abner
2023-04-06 22:23 ` [PATCH 17/18] UefiPayloadPkg: " Rebecca Cran
2023-04-07 5:57 ` Guo, Gua
2023-04-07 7:55 ` Lu, James
2023-04-06 22:23 ` [PATCH 18/18] FmpDevicePkg: " Rebecca Cran
2023-04-10 1:05 ` Xu, Wei6
2023-04-07 10:09 ` [edk2-devel] [PATCH 00/18] Replace pre-standard macro __FUNCTION__ with C99 __func__ throughout edk2 Ard Biesheuvel
2023-04-10 14:21 ` Rebecca Cran
2023-04-11 9:15 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB49299CC0DFD3D16E6260C884D2969@CO1PR11MB4929.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox