Re: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for VariableSmmRuntimeDxe

["Michael D Kinney" <michael.d.kinney@intel.com>]

Hi Kun,

I will take care of this. 

Thanks,

Mike

> -----Original Message-----
> From: Kun Qin <kuqin12@gmail.com>
> Sent: Thursday, April 1, 2021 1:26 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io
> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>
> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for
> VariableSmmRuntimeDxe
> 
> Thanks for your review, Michael.
> 
> Could any maintainer please help merging this specific patch? All other
> patches in this series are already merged into mainline by Liming here
> (https://edk2.groups.io/g/devel/message/73035).
> 
> Please let me know if it is preferable for me to send this single patch
> in a v3 after rewriting the commit message with reviewed-by tag.
> 
> Thanks in advance!
> 
> Regards,
> Kun
> 
> On 03/30/2021 19:06, Kinney, Michael D wrote:
> > Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> >
> > Mike
> >
> >> -----Original Message-----
> >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Kun Qin
> >> Sent: Tuesday, March 16, 2021 11:11 AM
> >> To: devel@edk2.groups.io
> >> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> >> Subject: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for
> >> VariableSmmRuntimeDxe
> >>
> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250
> >>
> >> This change added NULL MmUnblockMemoryLib instance in PlatformPkg dsc
> >> file to resolve new dependency by VariableSmmRuntimeDxe. The library
> >> interface is consumed by variable module to better support variable
> >> runtime cache feature.
> >>
> >> Cc: Zailiang Sun <zailiang.sun@intel.com>
> >> Cc: Yi Qian <yi.qian@intel.com>
> >> Cc: Michael D Kinney <michael.d.kinney@intel.com>>
> >> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> >> ---
> >>
> >> Notes:
> >>      v2:
> >>      - Added Michael K. to cc list [Zailiang]
> >>
> >>   Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
> >>   Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc  | 1 +
> >>   2 files changed, 2 insertions(+)
> >>
> >> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> >> index 409f31c982d7..33e93b74800c 100644
> >> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> >> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> >> @@ -311,6 +311,7 @@ [LibraryClasses.IA32]
> >>     LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
> >>     EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf
> >>     HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf
> >> +  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
> >>
> >>   [LibraryClasses.IA32.DXE_DRIVER]
> >>     DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
> >> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> >> index 38bd825c8bdc..f7a876353649 100644
> >> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> >> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> >> @@ -313,6 +313,7 @@ [LibraryClasses.X64]
> >>     LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
> >>     EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf
> >>     HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf
> >> +  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
> >>
> >>   [LibraryClasses.X64.DXE_DRIVER]
> >>     DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
> >> --
> >> 2.30.0.windows.1
> >>
> >>
> >>
> >> 
> >>
> >