public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: Pedro Falcato <pedro.falcato@gmail.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Chang, Abner" <Abner.Chang@amd.com>,
	"Ni, Ray" <ray.ni@intel.com>,
	"Gao, Liming" <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section 5.4.2.2 STATIC
Date: Tue, 22 Nov 2022 22:39:25 +0000	[thread overview]
Message-ID: <CO1PR11MB4929A08B584FC7358DC9A2BED20D9@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAKbZUD0=_01zrZtNMz2a24QHL0KrwmWwr8PYQJXOOSbXypOUag@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]

Hi Pedro,

CONST and VOID are defined in Section 2.3 of the UEFI Specification.
So we need to keep them to consume .h files based on UEF Spec contents.

STATIC is not part of any industry standard spec.

Mike


From: Pedro Falcato <pedro.falcato@gmail.com>
Sent: Tuesday, November 22, 2022 2:12 PM
To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Chang, Abner <Abner.Chang@amd.com>; Ni, Ray <ray.ni@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section 5.4.2.2 STATIC

On Tue, Nov 22, 2022 at 6:10 PM Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> wrote:
Hi Abner,

Removing that section 5.4.2.2 is required to close this bug.

Meaning of 'static' is covered by the ANSI C standards.

Mike,

Sorry for spinning off a bit, but if we're dropping STATIC, can we also drop the other defines (like CONST, VOID, etc)?
Potentially culminating into adopting C99 (does any EDK2-relevant C compiler not support it?).

Pedro

[-- Attachment #2: Type: text/html, Size: 41264 bytes --]

  reply	other threads:[~2022-11-22 22:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22  4:47 [PATCH] edk II C Coding Standard: Remove section 5.4.2.2 STATIC Chang, Abner
2022-11-22  5:48 ` [edk2-devel] " Ni, Ray
2022-11-22  6:07   ` Chang, Abner
2022-11-22 16:31     ` Michael D Kinney
2022-11-22 22:12       ` Pedro Falcato
2022-11-22 22:39         ` Michael D Kinney [this message]
2022-11-26  7:44       ` Chang, Abner
2022-11-28  9:08       ` Ard Biesheuvel
2022-11-28 15:41         ` Michael D Kinney
2022-12-12  5:30           ` Chang, Abner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB4929A08B584FC7358DC9A2BED20D9@CO1PR11MB4929.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox