From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>,
Leif Lindholm <leif@nuviainc.com>,
"Ard Biesheuvel" <ardb+tianocore@kernel.org>,
Laszlo Ersek <lersek@redhat.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
"Wang, Jian J" <jian.j.wang@intel.com>,
Sami Mujawar <Sami.Mujawar@arm.com>,
Alexei Fedorov <Alexei.Fedorov@arm.com>,
Andrew Fish <afish@apple.com>, "Ni, Ray" <ray.ni@intel.com>,
"Chiu, Chasel" <chasel.chiu@intel.com>,
"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"Zeng, Star" <star.zeng@intel.com>,
"Gao, Zhichao" <zhichao.gao@intel.com>,
"Wu, Hao A" <hao.a.wu@intel.com>,
"Ma, Maurice" <maurice.ma@intel.com>,
"Dong, Guo" <guo.dong@intel.com>,
"You, Benjamin" <benjamin.you@intel.com>,
"Dong, Eric" <eric.dong@intel.com>,
Maciej Rabeda <maciej.rabeda@linux.intel.com>,
"Wu, Jiaxin" <jiaxin.wu@intel.com>,
"Fu, Siyuan" <siyuan.fu@intel.com>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
Supreeth Venkatesh <supreeth.venkatesh@arm.com>,
Abner Chang <abner.chang@hpe.com>,
Nickle Wang <nickle.wang@hpe.com>,
"Liming Gao" <gaoliming@byosoft.com.cn>,
"Liu, Zhiguang" <zhiguang.liu@intel.com>
Subject: Re: [patch V4 00/29] Add a new library class RegisterFilterLib in edk2 to filter/trace port IO/MMIO/MSR access
Date: Tue, 30 Mar 2021 01:55:52 +0000 [thread overview]
Message-ID: <CO1PR11MB4929A147A8061B1D6DB509CED27D9@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210328120229.24828-1-dandan.bi@intel.com>
Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Mike
> -----Original Message-----
> From: Bi, Dandan <dandan.bi@intel.com>
> Sent: Sunday, March 28, 2021 5:02 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Laszlo Ersek
> <lersek@redhat.com>; Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Sami Mujawar
> <Sami.Mujawar@arm.com>; Alexei Fedorov <Alexei.Fedorov@arm.com>; Andrew Fish <afish@apple.com>; Ni, Ray
> <ray.ni@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng,
> Star <star.zeng@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Ma, Maurice
> <maurice.ma@intel.com>; Dong, Guo <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>; Dong, Eric
> <eric.dong@intel.com>; Maciej Rabeda <maciej.rabeda@linux.intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan
> <siyuan.fu@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>; Supreeth Venkatesh <supreeth.venkatesh@arm.com>;
> Abner Chang <abner.chang@hpe.com>; Nickle Wang <nickle.wang@hpe.com>; Liming Gao <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> <zhiguang.liu@intel.com>
> Subject: [patch V4 00/29] Add a new library class RegisterFilterLib in edk2 to filter/trace port IO/MMIO/MSR access
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
> RFC: https://edk2.groups.io/g/devel/message/72530
> Branch for this change: https://github.com/dandanbi/edk2/tree/RegisterFilterLibV3
>
> Patch 1 is to add RegisterFilterLib Library Class in edk2 to filter/trace port IO/MMIO/MSR access and add a
> RegisterFilterLibNull instance.
> Patch 2 is to add the MdeLibs.dsc.inc file to MdePkg for some default libraries provided by MdePkg and add
> RegisterFilterLib into it as the first version of MdeLibs.dsc.inc.
> Last 2 patches are to update APIs in IoLib and BaseLib to filter/trace port IO/MMIO/MSR access.
> Remaining patches are to update related dsc files to consume MdeLibs.dsc.inc for RegisterFilterLib.
> Will submit patch 1 and 2 firstly.
> And then update related dsc files in edk2 and edk2platform repo to consume MdeLibs.dsc.inc for RegisterFilterLib.
> At last will submit the patches to update IoLib and BaseLib to filter/trace port IO/MMIO/MSR access.
>
> ---
> V4:
> Consume the MdeLibs.dsc.inc for RegisterFilterLibNull in dsc file rather than in xxx.dsc.inc.
> Following 2 patchws were updated for consuming MdeLibs.dsc.inc in platform dsc file.
> ArmVirtPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> UnitTestFrameworkPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> Other patches are the same with V3.
> ---
> V3:
> 1. Don't assume Library instances in MdeLibs.dsc.inc are must in common [LibraryClasses] section.
> Can specify different [LibraryClasses] section for the libary instances in MdeLibs.dsc.inc.
> 2. Update plaftom dsc to consume the MdeLibs.dsc outside the [LibraryClasses] section.
> 3. Pick up the R-B for patch 1, patch 28, patch 29.
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Sami Mujawar <Sami.Mujawar@arm.com>
> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: Benjamin You <benjamin.you@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
>
> Dandan Bi (29):
> MdePkg: Add RegisterFilterLib class and NULL instance
> MdePkg: Add MdeLibs.dsc.inc file to MdePkg
> ArmPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> ArmPlatformPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> ArmVirtPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> CryptoPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> DynamicTablesPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> EmbeddedPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> EmulatorPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> FatPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> FmpDevicePkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> IntelFsp2Pkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> IntelFsp2WrapperPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> MdeModulePkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> MdePkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> NetworkPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> OvmfPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> PcAtChipsetPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> RedfishPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> SecurityPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> ShellPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> SignedCapsulePkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> SourceLevelDebugPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> StandaloneMmPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> UefiCpuPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> UefiPayloadPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> UnitTestFrameworkPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> MdePkg/IoLib: Filter/trace port IO/MMIO access
> MdePkg/Baseib: Filter/trace MSR access for IA32/X64
>
> ArmPkg/ArmPkg.dsc | 2 +
> ArmPlatformPkg/ArmPlatformPkg.dsc | 2 +
> ArmVirtPkg/ArmVirt.dsc.inc | 4 +-
> CryptoPkg/CryptoPkg.dsc | 5 +-
> DynamicTablesPkg/DynamicTablesPkg.dsc | 2 +
> EmbeddedPkg/EmbeddedPkg.dsc | 5 +-
> EmulatorPkg/EmulatorPkg.dsc | 4 +-
> FatPkg/FatPkg.dsc | 4 +-
> FmpDevicePkg/FmpDevicePkg.dsc | 4 +-
> IntelFsp2Pkg/IntelFsp2Pkg.dsc | 4 +-
> IntelFsp2Pkg/Tools/Tests/QemuFspPkg.dsc | 2 +
> IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc | 4 +-
> MdeModulePkg/MdeModulePkg.dsc | 4 +-
> MdePkg/Include/Library/RegisterFilterLib.h | 243 ++++++++++++++++
> .../BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf | 3 +-
> .../BaseIoLibIntrinsicArmVirt.inf | 3 +-
> .../BaseIoLibIntrinsicInternal.h | 3 +-
> .../BaseIoLibIntrinsicSev.inf | 3 +-
> MdePkg/Library/BaseIoLibIntrinsic/IoLib.c | 95 ++++--
> .../Library/BaseIoLibIntrinsic/IoLibArmVirt.c | 82 +++++-
> MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c | 58 +++-
> MdePkg/Library/BaseIoLibIntrinsic/IoLibMsc.c | 81 ++++--
> MdePkg/Library/BaseIoLibIntrinsic/IoLibNoIo.c | 74 ++++-
> MdePkg/Library/BaseLib/BaseLib.inf | 5 +-
> MdePkg/Library/BaseLib/Ia32/GccInlinePriv.c | 38 ++-
> MdePkg/Library/BaseLib/Ia32/ReadMsr64.c | 38 ++-
> MdePkg/Library/BaseLib/Ia32/WriteMsr64.c | 22 +-
> MdePkg/Library/BaseLib/X64/GccInlinePriv.c | 43 ++-
> MdePkg/Library/BaseLib/X64/ReadMsr64.c | 15 +-
> MdePkg/Library/BaseLib/X64/WriteMsr64.c | 13 +-
> .../RegisterFilterLibNull.c | 271 ++++++++++++++++++
> .../RegisterFilterLibNull.inf | 23 ++
> .../RegisterFilterLibNull.uni | 13 +
> MdePkg/MdeLibs.dsc.inc | 15 +
> MdePkg/MdePkg.dec | 7 +-
> MdePkg/MdePkg.dsc | 6 +-
> NetworkPkg/NetworkPkg.dsc | 4 +-
> OvmfPkg/AmdSev/AmdSevX64.dsc | 5 +-
> OvmfPkg/Bhyve/BhyveX64.dsc | 5 +-
> OvmfPkg/OvmfPkgIa32.dsc | 5 +-
> OvmfPkg/OvmfPkgIa32X64.dsc | 5 +-
> OvmfPkg/OvmfPkgX64.dsc | 5 +-
> OvmfPkg/OvmfXen.dsc | 5 +-
> PcAtChipsetPkg/PcAtChipsetPkg.dsc | 4 +-
> RedfishPkg/RedfishPkg.dsc | 4 +-
> SecurityPkg/SecurityPkg.dsc | 4 +-
> ShellPkg/ShellPkg.dsc | 4 +-
> SignedCapsulePkg/SignedCapsulePkg.dsc | 4 +-
> SourceLevelDebugPkg/SourceLevelDebugPkg.dsc | 4 +-
> StandaloneMmPkg/StandaloneMmPkg.dsc | 5 +-
> UefiCpuPkg/UefiCpuPkg.dsc | 4 +-
> UefiPayloadPkg/UefiPayloadPkg.dsc | 5 +-
> .../UnitTestFrameworkPkgTarget.dsc.inc | 4 +-
> 53 files changed, 1131 insertions(+), 145 deletions(-)
> create mode 100644 MdePkg/Include/Library/RegisterFilterLib.h
> create mode 100644 MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.c
> create mode 100644 MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
> create mode 100644 MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.uni
> create mode 100644 MdePkg/MdeLibs.dsc.inc
>
> --
> 2.18.0.windows.1
prev parent reply other threads:[~2021-03-30 1:55 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-28 12:02 [patch V4 00/29] Add a new library class RegisterFilterLib in edk2 to filter/trace port IO/MMIO/MSR access Dandan Bi
2021-03-28 12:02 ` [patch V4 01/29] MdePkg: Add RegisterFilterLib class and NULL instance Dandan Bi
2021-03-28 12:02 ` [patch V4 02/29] MdePkg: Add MdeLibs.dsc.inc file to MdePkg Dandan Bi
2021-03-28 12:02 ` [patch V4 03/29] ArmPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib Dandan Bi
2021-03-30 20:55 ` [edk2-devel] " Sami Mujawar
2021-03-28 12:02 ` [patch V4 04/29] ArmPlatformPkg: " Dandan Bi
2021-03-30 20:55 ` [edk2-devel] " Sami Mujawar
2021-03-28 12:02 ` [patch V4 05/29] ArmVirtPkg: " Dandan Bi
2021-03-28 12:02 ` [patch V4 06/29] CryptoPkg: " Dandan Bi
2021-03-28 13:02 ` Yao, Jiewen
2021-03-28 12:02 ` [patch V4 07/29] DynamicTablesPkg: " Dandan Bi
2021-03-30 20:25 ` Sami Mujawar
2021-03-28 12:02 ` [patch V4 08/29] EmbeddedPkg: " Dandan Bi
2021-03-28 12:02 ` [patch V4 09/29] EmulatorPkg: " Dandan Bi
2021-03-28 12:02 ` [patch V4 10/29] FatPkg: " Dandan Bi
2021-03-28 12:02 ` [patch V4 11/29] FmpDevicePkg: " Dandan Bi
2021-03-28 12:02 ` [patch V4 12/29] IntelFsp2Pkg: " Dandan Bi
2021-03-29 0:26 ` Chiu, Chasel
2021-03-28 12:02 ` [patch V4 13/29] IntelFsp2WrapperPkg: " Dandan Bi
2021-03-29 0:26 ` Chiu, Chasel
2021-03-28 12:02 ` [patch V4 14/29] MdeModulePkg: " Dandan Bi
2021-03-29 3:12 ` Wu, Hao A
2021-03-28 12:02 ` [patch V4 15/29] MdePkg: " Dandan Bi
2021-03-28 12:02 ` [patch V4 16/29] NetworkPkg: " Dandan Bi
2021-03-30 1:28 ` Wu, Jiaxin
2021-04-01 14:27 ` [edk2-devel] " Maciej Rabeda
2021-03-28 12:02 ` [patch V4 17/29] OvmfPkg: " Dandan Bi
2021-03-28 12:02 ` [patch V4 18/29] PcAtChipsetPkg: " Dandan Bi
2021-03-28 12:02 ` [patch V4 19/29] RedfishPkg: " Dandan Bi
2021-03-29 1:55 ` Abner Chang
2021-03-28 12:02 ` [patch V4 20/29] SecurityPkg: " Dandan Bi
2021-03-28 13:02 ` Yao, Jiewen
2021-03-28 12:02 ` [patch V4 21/29] ShellPkg: " Dandan Bi
2021-03-29 5:30 ` Gao, Zhichao
2021-03-28 12:02 ` [patch V4 22/29] SignedCapsulePkg: " Dandan Bi
2021-03-28 12:02 ` [patch V4 23/29] SourceLevelDebugPkg: " Dandan Bi
2021-03-29 3:12 ` Wu, Hao A
2021-03-29 3:14 ` [edk2-devel] " Wu, Hao A
2021-03-29 3:12 ` Wu, Hao A
2021-03-28 12:02 ` [patch V4 24/29] StandaloneMmPkg: " Dandan Bi
2021-03-28 13:01 ` Yao, Jiewen
2021-03-30 20:55 ` Sami Mujawar
2021-03-28 12:02 ` [patch V4 25/29] UefiCpuPkg: " Dandan Bi
2021-03-28 12:02 ` [patch V4 26/29] UefiPayloadPkg: " Dandan Bi
2021-03-29 3:52 ` Ma, Maurice
2021-03-28 12:02 ` [patch V4 27/29] UnitTestFrameworkPkg: " Dandan Bi
2021-03-28 12:02 ` [patch V4 28/29] MdePkg/IoLib: Filter/trace port IO/MMIO access Dandan Bi
2021-03-30 16:47 ` [edk2-devel] " Sami Mujawar
2021-03-31 1:14 ` Dandan Bi
2021-03-28 12:02 ` [patch V4 29/29] MdePkg/Baseib: Filter/trace MSR access for IA32/X64 Dandan Bi
2021-03-30 1:55 ` Michael D Kinney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB4929A147A8061B1D6DB509CED27D9@CO1PR11MB4929.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox