From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id EE048D80553 for ; Tue, 12 Dec 2023 23:27:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=lctODMP0g96hiQsw5VHMDrxDSnpmLcDzuqNkwkvCyzE=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702423674; v=1; b=Qk/0dDzFh56xY5peiDIcv48BjwzG4h2c8dB3wyjfORZMrdh2oWACD0dtev5iJwExDOsu1IGp mKVIZLdwJAfbIBzj1UYnhvwcjRLBJHf5Nnto5c3VSRRiA6ZqrlwheljnJCiuM63HXUMMFpcuObS aBADPrmFU3uU5bJOhSv3qPFU= X-Received: by 127.0.0.2 with SMTP id 2XxpYY7687511xg5a2ksIpVr; Tue, 12 Dec 2023 15:27:54 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.11160.1702423673968825656 for ; Tue, 12 Dec 2023 15:27:54 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10922"; a="375038179" X-IronPort-AV: E=Sophos;i="6.04,271,1695711600"; d="scan'208";a="375038179" X-Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Dec 2023 15:27:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10922"; a="777261511" X-IronPort-AV: E=Sophos;i="6.04,271,1695711600"; d="scan'208";a="777261511" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 12 Dec 2023 15:27:52 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 12 Dec 2023 15:27:51 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 12 Dec 2023 15:27:51 -0800 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 12 Dec 2023 15:27:51 -0800 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 12 Dec 2023 15:27:50 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PxG+PEsId9n0M3lx87VpsFa/WsCbuKPD/NlvOJvL4isU94jtbbrbA5BWvPHFtf0I7HcxvTVHBy7BPLmsW2QasDopMHh0vcrfsRSsACT9/0PDXeAbmXB3CGQmJ7Wbe3BBHrMPNH0kaP1LnVxtiWMWEfaLJVMhuAm4E/cpS2mP6AUVQV3UeiA/WVwauQd0iQvD9S5/9Qqe8dBadE6HpdVlw21XZPizq14xHqrK5nuu31Vpb1LgcDTblJ5udRW60i1rOICadyv5rRJZa3RROVVm4qI6bPGAy3tvkeN91dQ2xf9WPCK0I+JqrJsgHnKE4ATV/a+X+rztJPrURxMzsdttZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jim0iXNoqu07Ru2/OQe5fAWrwlbJ0P6GxMKkxxjMpCc=; b=Dasjj3AmO7cZcXXCiqvheAxvPEUzqG72jKPdhUaOqwxpLxA5Q/RngYLBrqry3LIPnFXDTr8GUv5G6dlRL43X3xFOvfakuHNq/kpigcuUKN9ry4CDYV72FMV1N4b3yMEKSD+XHuECQGuqJvK4w492ebdgfzqidODfvt/1tCGZJmCASoYSCQ5lB1GK5dmwiNp5OFeWJ/70nTnnqs2n9tWdByj5Kuxwz2y7wc+GKYWS4jwvzufsfzakB2wUEbrueGw0S2aY/FzTp62IOEd+1mh8UHDqzV+cgp6Ullel35yA7XoJrpDlL4GNdrdvSgVnM2ZEGKfqkT2cW6K66b3pKnSWnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by MW4PR11MB5869.namprd11.prod.outlook.com (2603:10b6:303:168::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.33; Tue, 12 Dec 2023 23:27:49 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::4382:5b03:f13:88ff]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::4382:5b03:f13:88ff%4]) with mapi id 15.20.7068.033; Tue, 12 Dec 2023 23:27:49 +0000 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "mikuback@linux.microsoft.com" CC: "Ni, Ray" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH v1 1/1] FatPkg/FatPei: Check array offset before use Thread-Topic: [edk2-devel] [PATCH v1 1/1] FatPkg/FatPei: Check array offset before use Thread-Index: AQHaLTE1HBkIHsk78UC+Ji5ynLoSc7CmSyQw Date: Tue, 12 Dec 2023 23:27:49 +0000 Message-ID: References: <20231212192336.1917-1-mikuback@linux.microsoft.com> In-Reply-To: <20231212192336.1917-1-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|MW4PR11MB5869:EE_ x-ms-office365-filtering-correlation-id: d82210c6-d9fe-4a57-107a-08dbfb69f43b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: TG515at0SKe60rkimqThw0Dsg3kcP7qs8gZENDMNQwCAsIJdGWs2yAlL8tQ71L+HtUT8bQqV2uW+G0DStOTbhKD8OOh9a0cjM1x6OLLC5nJQtw/kfbZir9QI8TvN7Fc1gk63RvpG43O1hNz2JkrTRb++VNm3B0H5/Z4ViFQ6dH6rB+c7o/rNdI1LV5TmDUqeRcLtdipBwCaTXkwgTz1B9sXl9bsAXxKTlZbisBVRBSpVm8JS2s1NGVo/B9K+a18J9QtEAihJJtMdnFQHU2zw1u4yKQlXLPZUfc05xB8RWDbv3RuDG9voZ2rwi4a4GrqKnruu69tudPwpHL8rB75LzMPc6j+Ez/UNAcW3Q4LQWNAJe/gGyW7StcH+XdOrw6bU3c4vgK6D6WwejemTA/WX9W6PpYi1nAn5TDlt9HWG3BLlmiJ6GZGRl2banRgKk5PoMxnoXyhGKS3RTSFdj615PDyc5DXCX+smoU9yEtgGrZHSX89ZIeLxv8k9wQUyyHDQDPRfRlatPYy3zKUy8erq/WVAggy28WiEeXmiuCirYhYPaMTuCacj7a3aG3re7RQkRUAhQRCgWUVxwdLNPOZVp2WLbT9P282GXtQIeorGlWaHUgYYRzpmNKTaT7KHQPj0tz08JR2NDdz155raVIYdmA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6WAhbDQ/NFVE+nirHQr17TWI1Y6YIo1PozIuj37p9xhcbL1J7NKPHfQyzxmW?= =?us-ascii?Q?evDU7hm0nncxuWgdFaPt1qJQocCWU+4wJ5QSQZbMNfOSLC4MV5a4x9d/ferU?= =?us-ascii?Q?zWMa2Cpnvc5yxuvSaTDWWY57UVgoxLbGhAlkpzxaqLd68Vjgo6soRPcuG5gS?= =?us-ascii?Q?KeIrmOCq03qECwhKCLseQbABESzgX+OnoNb1yd0RIUAkI6iq79wbPbX9GjGX?= =?us-ascii?Q?PIkPD2BpAVlnEwyhdwtW/UoiE9Kmksajp+K0HQBcNjZdG9T2Pw/ikcJyDr71?= =?us-ascii?Q?9tJkpOdAlMhNgw0n6TO9JzL+jqRsP+XEMSGnwvBTApOUPv1efo4J3F++KTSO?= =?us-ascii?Q?RRoko4ZvxIb8ssb7SxrFe4r5pp+Xr4UBToJFI7zb1BkHJQbuNga1mvn5/yj+?= =?us-ascii?Q?hBNHE2HgEi2RxPrgL+oP7dDqu12lZ4LFtywl3MrSLrhnjusnYCKpimnBdw+E?= =?us-ascii?Q?J6a5szo/BtZAiF1S+A63+cu1BxsZU9+hkUFA9izkWXi1BpuueI5cw/JLQAi/?= =?us-ascii?Q?97QsmkvJXnQyZA4gPdvuDbrOq402mMEzpOpFwMYRF/J+xxfJLgPiV2WXHt9d?= =?us-ascii?Q?EID3go+t7wZ2S6pa7jPl2mSdRfULWFKHu1B/fHnir2EbuIKjRtnU6OGy9UTR?= =?us-ascii?Q?Umt2l+tLgxVTqDD1QMpnsUm9vThtFHbtZwUvXH3wfHfwW9DY3cszZzgYIYxe?= =?us-ascii?Q?gQllKYuT0mlSvdDWQNQirI4s/B0kTko4Rv1COm4kUwTNOHrVVTJlbBTvT4sI?= =?us-ascii?Q?e0QQ7vjsOEZZN32wxORepmL1hFx7WYB6QTdDnBYajhPDaZ5DqdUugmIoJ2xH?= =?us-ascii?Q?48aJnE0/fiVx29KbF50/maTBe6NIcgZU3HqARKlhOomfuC7+jTZmpnJxXiWg?= =?us-ascii?Q?/OUJIr5BQnwfejqhJkP51z5FkTZe0Az6SoAMHv2SY1CwF8omlHUwJKD6rEk5?= =?us-ascii?Q?XpjZBYjf3JNIgTX2OEatvAErZRICendi/eDgKvNk/28gykX0ou0Ew9TgzR3n?= =?us-ascii?Q?9dEPBA+9/rlUMTk+yDl9KReWOiho2aECJkBbixoJe5pygovHagPZwi5SPFxp?= =?us-ascii?Q?itjdHgtdPR+aySNF4ifoUqGv8uzrIiGQMr/DOKho0yLNkuEopRRO/A5wDFpU?= =?us-ascii?Q?mZfXKxxz15c7YwoNVjl8Zv4jHFsWnjlxg15lJBHhacmNflnqc0j7ru9LnYmi?= =?us-ascii?Q?m0TMctwQwuZRcw0jY2OWwWHOca/cq1iGqWq+wXUybkzcbe+DBvE1I9jo5BDf?= =?us-ascii?Q?02yKebjAtroKLx6yRA7odVdvqcZB8dW6c32iG0MHem9z5vMF4wYYKxbGvG68?= =?us-ascii?Q?e6Wb0a2WTKV5bXuKLdKFZHwrcnZU/nhc1svko/cOdNFvETkx/NCkBsZUmJrG?= =?us-ascii?Q?fwcOVzotdFB6nQN0L/Zlaf/JXoX647y9jCUvJrGj8KLqh/FmVVrRyejyNymi?= =?us-ascii?Q?60ADmaJRyzCmdREvfFdxJjiQMwGKhMv4TV+KkzONx/k2XN6FthwoLktti8xp?= =?us-ascii?Q?hNywCe2KvdLTFV+tGlk1nZtyZqehEOTJBJwEB3EDgRAjWD563a5mhu/AGJtZ?= =?us-ascii?Q?Fj8KuglE2xsYTLNdMOd5x3zEItd3Yc7TnfEDJaXtOe7bwTFhnWmHtBGlQHPP?= =?us-ascii?Q?5w=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d82210c6-d9fe-4a57-107a-08dbfb69f43b X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2023 23:27:49.0300 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7lBsweQUKOiNUucRLdmIjrci9U5176gRFMeuzbP/J4mCEVJt6CLWhKjQfE1pVQ0lh4coi2fIgUw1lFEWj7wcz9msjVdKq0DsdQHL14PMGpQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5869 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 9nNbMLQIvIP85IGn0oBESicLx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="Qk/0dDzF"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Michael D Kinney > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Tuesday, December 12, 2023 11:24 AM > To: devel@edk2.groups.io > Cc: Ni, Ray > Subject: [edk2-devel] [PATCH v1 1/1] FatPkg/FatPei: Check array offset > before use >=20 > From: Michael Kubacki >=20 > Move the range check before array access to enforce the bounds > as expected. >=20 > Cc: Ray Ni > Signed-off-by: Michael Kubacki > --- > FatPkg/FatPei/FatLiteApi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/FatPkg/FatPei/FatLiteApi.c b/FatPkg/FatPei/FatLiteApi.c > index cc48c4c66b7b..b89ab7009da0 100644 > --- a/FatPkg/FatPei/FatLiteApi.c > +++ b/FatPkg/FatPei/FatLiteApi.c > @@ -459,7 +459,7 @@ GetRecoveryCapsuleInfo ( > // Find corresponding physical block device > // > BlockDeviceNo =3D PrivateData->Volume[Index].BlockDeviceNo; > - while (PrivateData->BlockDevice[BlockDeviceNo].Logical && > BlockDeviceNo < PrivateData->BlockDeviceCount) { > + while (BlockDeviceNo < PrivateData->BlockDeviceCount && > PrivateData->BlockDevice[BlockDeviceNo].Logical) { > BlockDeviceNo =3D PrivateData- > >BlockDevice[BlockDeviceNo].ParentDevNo; > } >=20 > -- > 2.43.0.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#112453): > https://edk2.groups.io/g/devel/message/112453 > Mute This Topic: https://groups.io/mt/103136267/1643496 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [michael.d.kinney@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112460): https://edk2.groups.io/g/devel/message/112460 Mute This Topic: https://groups.io/mt/103136267/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-