public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "Ren, SuqiangX" <suqiangx.ren@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Liming Gao <gaoliming@byosoft.com.cn>,
	"Tan, Ming" <ming.tan@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH V2 2/5] MdeModulePkg: Update some Runtime Service functions header
Date: Fri, 2 Feb 2024 02:40:50 +0000	[thread overview]
Message-ID: <CO1PR11MB4929A7DF868AB287C9BAC6A8D2422@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CO1PR11MB4916175C24F53BD2F1F3309296422@CO1PR11MB4916.namprd11.prod.outlook.com>

I think Leif's feedback on the commit message applies to
all patches in the series.

Please review and update based on that feedback.

Thanks,

Mike

> -----Original Message-----
> From: Ren, SuqiangX <suqiangx.ren@intel.com>
> Sent: Thursday, February 1, 2024 5:24 PM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>; Ren, SuqiangX
> <suqiangx.ren@intel.com>; Tan, Ming <ming.tan@intel.com>
> Subject: RE: [edk2-devel] [PATCH V2 2/5] MdeModulePkg: Update some Runtime
> Service functions header
> 
> Hi Mike,
> 
> 	Do you have any comment about this package's change?
> 
> 	If yes, I will sent a V3 patch change both this package and
> ArmPlatformPkg.
> 
> 	If no, I will only change ArmPlatformPkg's commit message suggested by
> Leif.
> 
> 
> Thanks
> Ren, Suqiang
> 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ren, Suqiang
> Sent: Monday, January 29, 2024 10:30 AM
> To: devel@edk2.groups.io
> Cc: Liming Gao <gaoliming@byosoft.com.cn>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: [edk2-devel] [PATCH V2 2/5] MdeModulePkg: Update some Runtime
> Service functions header
> 
> Update some Runtime Service functions header to align with UEFI spec 2.10.
> 
> REF: UEFI spec 2.10 section 8 Services — Runtime Services
> 
> Signed-off-by: Suqiang Ren <suqiangx.ren@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  MdeModulePkg/Core/RuntimeDxe/Runtime.c        | 10 +-
>  MdeModulePkg/Core/RuntimeDxe/Runtime.h        | 10 +-
>  .../CapsuleRuntimeDxe/CapsuleService.c        | 13 +++
>  .../MonotonicCounter.c                        |  3 +
>  .../Universal/Variable/RuntimeDxe/Variable.c  | 40 ++++++--
> .../Universal/Variable/RuntimeDxe/Variable.h  | 40 ++++++--
>  .../RuntimeDxe/VariableSmmRuntimeDxe.c        | 99 +++++++++++++++----
>  7 files changed, 174 insertions(+), 41 deletions(-)
> 
> diff --git a/MdeModulePkg/Core/RuntimeDxe/Runtime.c
> b/MdeModulePkg/Core/RuntimeDxe/Runtime.c
> index de8f2bfce0f8..c66ed71e35e1 100644
> --- a/MdeModulePkg/Core/RuntimeDxe/Runtime.c
> +++ b/MdeModulePkg/Core/RuntimeDxe/Runtime.c
> @@ -117,7 +117,12 @@ RuntimeDriverCalculateEfiHdrCrc (
>    @retval  EFI_SUCCESS              The pointer pointed to by Address was
> modified.
>    @retval  EFI_NOT_FOUND            The pointer pointed to by Address was
> not found to be part
>                                      of the current memory map. This is
> normally fatal.
> -  @retval  EFI_INVALID_PARAMETER    One of the parameters has an invalid
> value.
> +  @retval  EFI_INVALID_PARAMETER    1) Address is NULL.
> +                                    2) *Address is NULL and DebugDisposition
> does
> +                                    not have the EFI_OPTIONAL_PTR bit set.
> +  @retval  EFI_UNSUPPORTED          This call is not supported by this
> platform at the time the call is made.
> +                                    The platform should describe this
> runtime service as unsupported at runtime
> +                                    via an EFI_RT_PROPERTIES_TABLE
> configuration table.
> 
>  **/
>  EFI_STATUS
> @@ -227,6 +232,9 @@ RuntimeDriverConvertInternalPointer (
>                                    map that requires a mapping.
>    @retval  EFI_NOT_FOUND          A virtual address was supplied for an
> address that is not found
>                                    in the memory map.
> +  @retval  EFI_UNSUPPORTED        This call is not supported by this
> platform at the time the call is made.
> +                                  The platform should describe this runtime
> service as unsupported at runtime
> +                                  via an EFI_RT_PROPERTIES_TABLE
> configuration table.
> 
>  **/
>  EFI_STATUS
> diff --git a/MdeModulePkg/Core/RuntimeDxe/Runtime.h
> b/MdeModulePkg/Core/RuntimeDxe/Runtime.h
> index cc422e783f65..1e28b98d78e8 100644
> --- a/MdeModulePkg/Core/RuntimeDxe/Runtime.h
> +++ b/MdeModulePkg/Core/RuntimeDxe/Runtime.h
> @@ -59,7 +59,12 @@ RuntimeDriverCalculateCrc32 (
>    @retval  EFI_SUCCESS              The pointer pointed to by Address was
> modified.
>    @retval  EFI_NOT_FOUND            The pointer pointed to by Address was
> not found to be part
>                                      of the current memory map. This is
> normally fatal.
> -  @retval  EFI_INVALID_PARAMETER    One of the parameters has an invalid
> value.
> +  @retval  EFI_INVALID_PARAMETER    1) Address is NULL.
> +                                    2) *Address is NULL and DebugDisposition
> does
> +                                    not have the EFI_OPTIONAL_PTR bit set.
> +  @retval  EFI_UNSUPPORTED          This call is not supported by this
> platform at the time the call is made.
> +                                    The platform should describe this
> runtime service as unsupported at runtime
> +                                    via an EFI_RT_PROPERTIES_TABLE
> configuration table.
> 
>  **/
>  EFI_STATUS
> @@ -86,6 +91,9 @@ RuntimeDriverConvertPointer (
>                                    map that requires a mapping.
>    @retval  EFI_NOT_FOUND          A virtual address was supplied for an
> address that is not found
>                                    in the memory map.
> +  @retval  EFI_UNSUPPORTED        This call is not supported by this
> platform at the time the call is made.
> +                                  The platform should describe this runtime
> service as unsupported at runtime
> +                                  via an EFI_RT_PROPERTIES_TABLE
> configuration table.
> 
>  **/
>  EFI_STATUS
> diff --git a/MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleService.c
> b/MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleService.c
> index 50968a839e84..f8047c23e17c 100644
> --- a/MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleService.c
> +++ b/MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleService.c
> @@ -53,6 +53,9 @@ UINT32  mMaxSizeNonPopulateCapsule = 0;
>                                  in runtime. The caller may resubmit the
> capsule prior to ExitBootServices().
>    @retval EFI_OUT_OF_RESOURCES  When ExitBootServices() has not been
> previously called then this error indicates
>                                  the capsule is compatible with this platform
> but there are insufficient resources to process.
> +  @retval EFI_UNSUPPORTED       This call is not supported by this platform
> at the time the call is made.
> +                                The platform should describe this runtime
> service as unsupported at runtime
> +                                via an EFI_RT_PROPERTIES_TABLE configuration
> table.
> 
>  **/
>  EFI_STATUS
> @@ -247,6 +250,16 @@ UpdateCapsule (
>                                  MaximumCapsuleSize and ResetType are
> undefined.
>    @retval EFI_INVALID_PARAMETER MaximumCapsuleSize is NULL, or ResetTyep is
> NULL,
>                                  Or CapsuleCount is Zero, or CapsuleImage is
> not valid.
> +  @retval EFI_OUT_OF_RESOURCES  When ExitBootServices() has been previously
> called this error indicates
> +                                the capsule is compatible with this platform
> but is not capable of
> +                                being submitted or processed in runtime.
> +                                The caller may resubmit the capsule prior to
> ExitBootServices().
> +  @retval EFI_OUT_OF_RESOURCES  When ExitBootServices() has not been
> previously called then this error
> +                                indicates the capsule is compatible with
> this platform but there are
> +                                insufficient resources to process.
> +  @retval EFI_UNSUPPORTED       This call is not supported by this platform
> at the time the call is made.
> +                                The platform should describe this runtime
> service as unsupported at runtime
> +                                via an EFI_RT_PROPERTIES_TABLE configuration
> table.
> 
>  **/
>  EFI_STATUS
> diff --git
> a/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounter.c
> b/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounter.c
> index 60b6e9350b7f..3e74713cc5be 100644
> --- a/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounter.c
> +++ b/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounter
> +++ .c
> @@ -125,6 +125,9 @@ MonotonicCounterDriverGetNextMonotonicCount (
>    @retval EFI_DEVICE_ERROR      The variable could not be saved due to a
> hardware failure.
>    @retval EFI_OUT_OF_RESOURCES  If variable service reports that not enough
> storage
>                                  is available to hold the variable and its
> data.
> +  @retval EFI_UNSUPPORTED       This call is not supported by this platform
> at the time the call is made.
> +                                The platform should describe this runtime
> service as unsupported at runtime
> +                                via an EFI_RT_PROPERTIES_TABLE configuration
> table.
> 
>  **/
>  EFI_STATUS
> diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
> b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
> index 3c360481f482..d394d237a53f 100644
> --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
> +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
> @@ -2385,10 +2385,19 @@ Done:
>    @param Data                       The buffer to return the contents of the
> variable. May be NULL
>                                      with a zero DataSize in order to
> determine the size buffer needed.
> 
> -  @return EFI_INVALID_PARAMETER     Invalid parameter.
> -  @return EFI_SUCCESS               Find the specified variable.
> -  @return EFI_NOT_FOUND             Not found.
> -  @return EFI_BUFFER_TO_SMALL       DataSize is too small for the result.
> +  @retval EFI_SUCCESS               The function completed successfully.
> +  @retval EFI_NOT_FOUND             The variable was not found.
> +  @retval EFI_BUFFER_TOO_SMALL      The DataSize is too small for the
> result.
> +  @retval EFI_INVALID_PARAMETER     VariableName is NULL.
> +  @retval EFI_INVALID_PARAMETER     VendorGuid is NULL.
> +  @retval EFI_INVALID_PARAMETER     DataSize is NULL.
> +  @retval EFI_INVALID_PARAMETER     The DataSize is not too small and Data
> is NULL.
> +  @retval EFI_DEVICE_ERROR          The variable could not be retrieved due
> to a hardware error.
> +  @retval EFI_SECURITY_VIOLATION    The variable could not be retrieved due
> to an authentication failure.
> +  @retval EFI_UNSUPPORTED           After ExitBootServices() has been
> called, this return code may be returned
> +                                    if no variable storage is supported. The
> platform should describe this
> +                                    runtime service as unsupported at
> runtime via an EFI_RT_PROPERTIES_TABLE
> +                                    configuration table.
> 
>  **/
>  EFI_STATUS
> @@ -2479,6 +2488,11 @@ Done:
>                                      GUID of an existing variable.
>    @retval EFI_INVALID_PARAMETER     Null-terminator is not found in the
> first VariableNameSize bytes of
>                                      the input VariableName buffer.
> +  @retval EFI_DEVICE_ERROR          The variable could not be retrieved due
> to a hardware error.
> +  @retval EFI_UNSUPPORTED           After ExitBootServices() has been
> called, this return code may be returned
> +                                    if no variable storage is supported. The
> platform should describe this
> +                                    runtime service as unsupported at
> runtime via an EFI_RT_PROPERTIES_TABLE
> +                                    configuration table.
> 
>  **/
>  EFI_STATUS
> @@ -2576,11 +2590,19 @@ VariableServiceGetNextVariableName (
>                                            data, this value contains the
> required size.
>    @param Data                             Data pointer.
> 
> -  @return EFI_INVALID_PARAMETER           Invalid parameter.
> -  @return EFI_SUCCESS                     Set successfully.
> -  @return EFI_OUT_OF_RESOURCES            Resource not enough to set
> variable.
> -  @return EFI_NOT_FOUND                   Not found.
> -  @return EFI_WRITE_PROTECTED             Variable is read-only.
> +  @retval EFI_SUCCESS                     The function completed
> successfully.
> +  @retval EFI_NOT_FOUND                   The variable was not found.
> +  @retval EFI_BUFFER_TOO_SMALL            The DataSize is too small for the
> result.
> +  @retval EFI_INVALID_PARAMETER           VariableName is NULL.
> +  @retval EFI_INVALID_PARAMETER           VendorGuid is NULL.
> +  @retval EFI_INVALID_PARAMETER           DataSize is NULL.
> +  @retval EFI_INVALID_PARAMETER           The DataSize is not too small and
> Data is NULL.
> +  @retval EFI_DEVICE_ERROR                The variable could not be
> retrieved due to a hardware error.
> +  @retval EFI_SECURITY_VIOLATION          The variable could not be
> retrieved due to an authentication failure.
> +  @retval EFI_UNSUPPORTED                 After ExitBootServices() has been
> called, this return code may be returned
> +                                          if no variable storage is
> supported. The platform should describe this
> +                                          runtime service as unsupported at
> runtime via an EFI_RT_PROPERTIES_TABLE
> +                                          configuration table.
> 
>  **/
>  EFI_STATUS
> diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.h
> b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.h
> index a668abb82b15..033c0625afb8 100644
> --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.h
> +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.h
> @@ -446,10 +446,19 @@ GetFvbInfoByAddress (
>    @param Data                       The buffer to return the contents of the
> variable. May be NULL
>                                      with a zero DataSize in order to
> determine the size buffer needed.
> 
> -  @return EFI_INVALID_PARAMETER     Invalid parameter.
> -  @return EFI_SUCCESS               Find the specified variable.
> -  @return EFI_NOT_FOUND             Not found.
> -  @return EFI_BUFFER_TO_SMALL       DataSize is too small for the result.
> +  @retval EFI_SUCCESS            The function completed successfully.
> +  @retval EFI_NOT_FOUND          The variable was not found.
> +  @retval EFI_BUFFER_TOO_SMALL   The DataSize is too small for the result.
> +  @retval EFI_INVALID_PARAMETER  VariableName is NULL.
> +  @retval EFI_INVALID_PARAMETER  VendorGuid is NULL.
> +  @retval EFI_INVALID_PARAMETER  DataSize is NULL.
> +  @retval EFI_INVALID_PARAMETER  The DataSize is not too small and Data is
> NULL.
> +  @retval EFI_DEVICE_ERROR       The variable could not be retrieved due to
> a hardware error.
> +  @retval EFI_SECURITY_VIOLATION The variable could not be retrieved due to
> an authentication failure.
> +  @retval EFI_UNSUPPORTED        After ExitBootServices() has been called,
> this return code may be returned
> +                                 if no variable storage is supported. The
> platform should describe this
> +                                 runtime service as unsupported at runtime
> via an EFI_RT_PROPERTIES_TABLE
> +                                 configuration table.
> 
>  **/
>  EFI_STATUS
> @@ -485,6 +494,11 @@ VariableServiceGetVariable (
>                                      GUID of an existing variable.
>    @retval EFI_INVALID_PARAMETER     Null-terminator is not found in the
> first VariableNameSize bytes of
>                                      the input VariableName buffer.
> +  @retval EFI_DEVICE_ERROR          The variable could not be retrieved due
> to a hardware error.
> +  @retval EFI_UNSUPPORTED           After ExitBootServices() has been
> called, this return code may be returned
> +                                    if no variable storage is supported. The
> platform should describe this
> +                                    runtime service as unsupported at
> runtime via an EFI_RT_PROPERTIES_TABLE
> +                                    configuration table.
> 
>  **/
>  EFI_STATUS
> @@ -513,11 +527,19 @@ VariableServiceGetNextVariableName (
>                                            data, this value contains the
> required size.
>    @param Data                             Data pointer.
> 
> -  @return EFI_INVALID_PARAMETER           Invalid parameter.
> -  @return EFI_SUCCESS                     Set successfully.
> -  @return EFI_OUT_OF_RESOURCES            Resource not enough to set
> variable.
> -  @return EFI_NOT_FOUND                   Not found.
> -  @return EFI_WRITE_PROTECTED             Variable is read-only.
> +  @retval EFI_SUCCESS                     The function completed
> successfully.
> +  @retval EFI_NOT_FOUND                   The variable was not found.
> +  @retval EFI_BUFFER_TOO_SMALL            The DataSize is too small for the
> result.
> +  @retval EFI_INVALID_PARAMETER           VariableName is NULL.
> +  @retval EFI_INVALID_PARAMETER           VendorGuid is NULL.
> +  @retval EFI_INVALID_PARAMETER           DataSize is NULL.
> +  @retval EFI_INVALID_PARAMETER           The DataSize is not too small and
> Data is NULL.
> +  @retval EFI_DEVICE_ERROR                The variable could not be
> retrieved due to a hardware error.
> +  @retval EFI_SECURITY_VIOLATION          The variable could not be
> retrieved due to an authentication failure.
> +  @retval EFI_UNSUPPORTED                 After ExitBootServices() has been
> called, this return code may be returned
> +                                          if no variable storage is
> supported. The platform should describe this
> +                                          runtime service as unsupported at
> runtime via an EFI_RT_PROPERTIES_TABLE
> +                                          configuration table.
> 
>  **/
>  EFI_STATUS
> diff --git
> a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c
> b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c
> index 4aaeb5ba8806..6930875e9fe0 100644
> --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c
> +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c
> @@ -831,10 +831,19 @@ Done:
>                                       data, this value contains the required
> size.
>    @param[out]     Data               Data pointer.
> 
> -  @retval EFI_INVALID_PARAMETER      Invalid parameter.
> -  @retval EFI_SUCCESS                Find the specified variable.
> -  @retval EFI_NOT_FOUND              Not found.
> -  @retval EFI_BUFFER_TO_SMALL        DataSize is too small for the result.
> +  @retval EFI_SUCCESS                The function completed successfully.
> +  @retval EFI_NOT_FOUND              The variable was not found.
> +  @retval EFI_BUFFER_TOO_SMALL       The DataSize is too small for the
> result.
> +  @retval EFI_INVALID_PARAMETER      VariableName is NULL.
> +  @retval EFI_INVALID_PARAMETER      VendorGuid is NULL.
> +  @retval EFI_INVALID_PARAMETER      DataSize is NULL.
> +  @retval EFI_INVALID_PARAMETER      The DataSize is not too small and Data
> is NULL.
> +  @retval EFI_DEVICE_ERROR           The variable could not be retrieved due
> to a hardware error.
> +  @retval EFI_SECURITY_VIOLATION     The variable could not be retrieved due
> to an authentication failure.
> +  @retval EFI_UNSUPPORTED            After ExitBootServices() has been
> called, this return code may be returned
> +                                     if no variable storage is supported.
> The platform should describe this
> +                                     runtime service as unsupported at
> runtime via an EFI_RT_PROPERTIES_TABLE
> +                                     configuration table.
> 
>  **/
>  EFI_STATUS
> @@ -876,10 +885,22 @@ RuntimeServiceGetVariable (
>    @param[in, out] VariableName       Pointer to variable name.
>    @param[in, out] VendorGuid         Variable Vendor Guid.
> 
> -  @retval EFI_INVALID_PARAMETER      Invalid parameter.
> -  @retval EFI_SUCCESS                Find the specified variable.
> -  @retval EFI_NOT_FOUND              Not found.
> -  @retval EFI_BUFFER_TO_SMALL        DataSize is too small for the result.
> +  @retval EFI_SUCCESS                The function completed successfully.
> +  @retval EFI_NOT_FOUND              The next variable was not found.
> +  @retval EFI_BUFFER_TOO_SMALL       The VariableNameSize is too small for
> the result.
> +                                     VariableNameSize has been updated with
> the size needed to complete the request.
> +  @retval EFI_INVALID_PARAMETER      VariableNameSize is NULL.
> +  @retval EFI_INVALID_PARAMETER      VariableName is NULL.
> +  @retval EFI_INVALID_PARAMETER      VendorGuid is NULL.
> +  @retval EFI_INVALID_PARAMETER      The input values of VariableName and
> VendorGuid are not a name and
> +                                     GUID of an existing variable.
> +  @retval EFI_INVALID_PARAMETER      Null-terminator is not found in the
> first VariableNameSize bytes of
> +                                     the input VariableName buffer.
> +  @retval EFI_DEVICE_ERROR           The variable could not be retrieved due
> to a hardware error.
> +  @retval EFI_UNSUPPORTED            After ExitBootServices() has been
> called, this return code may be returned
> +                                     if no variable storage is supported.
> The platform should describe this
> +                                     runtime service as unsupported at
> runtime via an EFI_RT_PROPERTIES_TABLE
> +                                     configuration table.
> 
>  **/
>  EFI_STATUS
> @@ -951,10 +972,22 @@ GetNextVariableNameInRuntimeCache (
>    @param[in, out] VariableName       Pointer to variable name.
>    @param[in, out] VendorGuid         Variable Vendor Guid.
> 
> -  @retval EFI_INVALID_PARAMETER      Invalid parameter.
> -  @retval EFI_SUCCESS                Find the specified variable.
> -  @retval EFI_NOT_FOUND              Not found.
> -  @retval EFI_BUFFER_TO_SMALL        DataSize is too small for the result.
> +  @retval EFI_SUCCESS                The function completed successfully.
> +  @retval EFI_NOT_FOUND              The next variable was not found.
> +  @retval EFI_BUFFER_TOO_SMALL       The VariableNameSize is too small for
> the result.
> +                                     VariableNameSize has been updated with
> the size needed to complete the request.
> +  @retval EFI_INVALID_PARAMETER      VariableNameSize is NULL.
> +  @retval EFI_INVALID_PARAMETER      VariableName is NULL.
> +  @retval EFI_INVALID_PARAMETER      VendorGuid is NULL.
> +  @retval EFI_INVALID_PARAMETER      The input values of VariableName and
> VendorGuid are not a name and
> +                                     GUID of an existing variable.
> +  @retval EFI_INVALID_PARAMETER      Null-terminator is not found in the
> first VariableNameSize bytes of
> +                                     the input VariableName buffer.
> +  @retval EFI_DEVICE_ERROR           The variable could not be retrieved due
> to a hardware error.
> +  @retval EFI_UNSUPPORTED            After ExitBootServices() has been
> called, this return code may be returned
> +                                     if no variable storage is supported.
> The platform should describe this
> +                                     runtime service as unsupported at
> runtime via an EFI_RT_PROPERTIES_TABLE
> +                                     configuration table.
> 
>  **/
>  EFI_STATUS
> @@ -1052,10 +1085,22 @@ Done:
>    @param[in, out] VariableName       Pointer to variable name.
>    @param[in, out] VendorGuid         Variable Vendor Guid.
> 
> -  @retval EFI_INVALID_PARAMETER      Invalid parameter.
> -  @retval EFI_SUCCESS                Find the specified variable.
> -  @retval EFI_NOT_FOUND              Not found.
> -  @retval EFI_BUFFER_TO_SMALL        DataSize is too small for the result.
> +  @retval EFI_SUCCESS                The function completed successfully.
> +  @retval EFI_NOT_FOUND              The next variable was not found.
> +  @retval EFI_BUFFER_TOO_SMALL       The VariableNameSize is too small for
> the result.
> +                                     VariableNameSize has been updated with
> the size needed to complete the request.
> +  @retval EFI_INVALID_PARAMETER      VariableNameSize is NULL.
> +  @retval EFI_INVALID_PARAMETER      VariableName is NULL.
> +  @retval EFI_INVALID_PARAMETER      VendorGuid is NULL.
> +  @retval EFI_INVALID_PARAMETER      The input values of VariableName and
> VendorGuid are not a name and
> +                                     GUID of an existing variable.
> +  @retval EFI_INVALID_PARAMETER      Null-terminator is not found in the
> first VariableNameSize bytes of
> +                                     the input VariableName buffer.
> +  @retval EFI_DEVICE_ERROR           The variable could not be retrieved due
> to a hardware error.
> +  @retval EFI_UNSUPPORTED            After ExitBootServices() has been
> called, this return code may be returned
> +                                     if no variable storage is supported.
> The platform should describe this
> +                                     runtime service as unsupported at
> runtime via an EFI_RT_PROPERTIES_TABLE
> +                                     configuration table.
> 
>  **/
>  EFI_STATUS
> @@ -1112,11 +1157,23 @@ RuntimeServiceGetNextVariableName (
>                                            data, this value contains the
> required size.
>    @param[in] Data                         Data pointer.
> 
> -  @retval EFI_INVALID_PARAMETER           Invalid parameter.
> -  @retval EFI_SUCCESS                     Set successfully.
> -  @retval EFI_OUT_OF_RESOURCES            Resource not enough to set
> variable.
> -  @retval EFI_NOT_FOUND                   Not found.
> -  @retval EFI_WRITE_PROTECTED             Variable is read-only.
> +  @retval EFI_SUCCESS                     The firmware has successfully
> stored the variable and its data as
> +                                          defined by the Attributes.
> +  @retval EFI_INVALID_PARAMETER           An invalid combination of
> attribute bits, name, and GUID was supplied, or the
> +                                          DataSize exceeds the maximum
> allowed.
> +  @retval EFI_INVALID_PARAMETER           VariableName is an empty string.
> +  @retval EFI_OUT_OF_RESOURCES            Not enough storage is available to
> hold the variable and its data.
> +  @retval EFI_DEVICE_ERROR                The variable could not be
> retrieved due to a hardware error.
> +  @retval EFI_WRITE_PROTECTED             The variable in question is read-
> only.
> +  @retval EFI_WRITE_PROTECTED             The variable in question cannot be
> deleted.
> +  @retval EFI_SECURITY_VIOLATION          The variable could not be written
> due to
> +
> EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACESS being set,
> +                                          but the AuthInfo does NOT pass the
> validation check carried out by the firmware.
> +
> +  @retval EFI_NOT_FOUND                   The variable trying to be updated
> or deleted was not found.
> +  @retval EFI_UNSUPPORTED                 This call is not supported by this
> platform at the time the call is made.
> +                                          The platform should describe this
> runtime service as unsupported at runtime
> +                                          via an EFI_RT_PROPERTIES_TABLE
> configuration table.
> 
>  **/
>  EFI_STATUS
> --
> 2.26.2.windows.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115005): https://edk2.groups.io/g/devel/message/115005
Mute This Topic: https://groups.io/mt/104111192/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      reply	other threads:[~2024-02-02  2:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-29  2:29 [edk2-devel] [PATCH V2 0/5] Add EFI_UNSUPPORTED return for some Runtime Service functions Ren, Suqiang
2024-01-29  2:29 ` [edk2-devel] [PATCH V2 1/5] MdePkg: " Ren, Suqiang
2024-01-29  3:48   ` Michael D Kinney
2024-01-29  2:29 ` [edk2-devel] [PATCH V2 2/5] MdeModulePkg: Update some Runtime Service functions header Ren, Suqiang
2024-01-29  2:29 ` [edk2-devel] [PATCH V2 3/5] EmbeddedPkg: " Ren, Suqiang
2024-01-29  2:46   ` Chang, Abner via groups.io
2024-01-29  2:29 ` [edk2-devel] [PATCH V2 4/5] ArmPlatformPkg: " Ren, Suqiang
2024-01-29  2:29 ` [edk2-devel] [PATCH V2 5/5] OvmfPkg: " Ren, Suqiang
2024-01-29  2:39   ` Yao, Jiewen
2024-01-30  1:36 ` 回复: [edk2-devel] [PATCH V2 0/5] Add EFI_UNSUPPORTED return for some Runtime Service functions gaoliming via groups.io
     [not found] ` <17AEB08976789B0D.21687@groups.io>
     [not found]   ` <CO1PR11MB49166BBE9770EA9FB2113FD9967D2@CO1PR11MB4916.namprd11.prod.outlook.com>
2024-01-31 19:13     ` FW: [edk2-devel] [PATCH V2 4/5] ArmPlatformPkg: Update some Runtime Service functions header Leif Lindholm
2024-01-31 20:04       ` Michael D Kinney
2024-02-01 18:35         ` Leif Lindholm
     [not found] ` <17AEB088A9F5F269.10155@groups.io>
2024-02-02  1:23   ` [edk2-devel] [PATCH V2 2/5] MdeModulePkg: " Ren, Suqiang
2024-02-02  2:40     ` Michael D Kinney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB4929A7DF868AB287C9BAC6A8D2422@CO1PR11MB4929.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox