public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: Ayush Singh <ayushdevel1325@gmail.com>,
	edk2-devel-groups-io <devel@edk2.groups.io>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>,
	"Gaibusab, Jabeena B" <jabeena.b.gaibusab@intel.com>,
	"Yao, Jiewen" <jiewen.yao@intel.com>
Subject: Re: Dealing with CRLF in Rust printing
Date: Tue, 28 Jun 2022 03:03:39 +0000	[thread overview]
Message-ID: <CO1PR11MB4929ACAA3AA8EC73F29F84C2D2B89@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CA+Yfj7tccqAx=5+er8YC93CNv8OZygShNaagMJ9CparWzuOSfg@mail.gmail.com>

Hi Ayush,

Your proposal looks right to me.

If \r is printed from Rust, it should not be modified.  Only if
a \n is printed from Rust should it be expanded to \r\n.

So your example of '\r\r\n' from Rust would be expanded to '\r\r\r\n'.

Mike

> -----Original Message-----
> From: Ayush Singh <ayushdevel1325@gmail.com>
> Sent: Monday, June 27, 2022 12:17 PM
> To: edk2-devel-groups-io <devel@edk2.groups.io>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gaibusab, Jabeena B
> <jabeena.b.gaibusab@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
> Subject: Dealing with CRLF in Rust printing
> 
> Hello everyone, I have been somewhat successful in implementing Rust
> stdio for UEFI.
> 
> This means it is now possible to do things like this:
> ```rust
> let s = 10;
> println!("ConOut: {}", s);
> eprintl!("StdErr: {}", s);
> ```
> 
> However, Rust uses LF on all platforms currently, which means that the
> `println!`, `eprintln!` and other macros only output LF at the end.
> 
> After discussion in zulipchat [1], it seems that rather than changing
> the macro, it would be better to change what is printed as output.
> This means changing: `\n` to `\r\n`, when we go for printing to
> screen.
> 
> Note: This means that the LF will be changed to CRLF only when using
> stdio and not when writing to say an external file.
> 
> Firstly, I wanted to ask other people's opinions about doing this.
> Secondly, I wanted to ask if `\r\r\n` is the same as `\r\n` or if the
> extra CR should be trimmed.
> 
> Ayush Singh
> 
> [1]: https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/.60println!.60.20for.20CRLF.20console

      reply	other threads:[~2022-06-28  3:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-27 19:17 Dealing with CRLF in Rust printing Ayush Singh
2022-06-28  3:03 ` Michael D Kinney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB4929ACAA3AA8EC73F29F84C2D2B89@CO1PR11MB4929.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox