From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 38D82D8003E for ; Sat, 20 Jan 2024 01:53:58 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=GYCFJsjjrUIOXNBu+9Nv7bYN+6t3XrtRhB8QrsJyqLo=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705715637; v=1; b=nju0fB1WcdwOAyxyt5fnEZ9TjR5cJss4tsEuXddjPl9uv6QIfICYa7BKYpsqWLhnQDZb6/Pv 8JEcIoqD0v0v8+nd2qGnavJEf9UkLTdI4Nxm1x6GB0Xp9QeV6skcBol/XKkXdR5bsPlAZk32Hm+ kUQtJudEXvaZpO9QAHFHYeyQ= X-Received: by 127.0.0.2 with SMTP id Xtz4YY7687511xVMn6l9AhBg; Fri, 19 Jan 2024 17:53:57 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mx.groups.io with SMTP id smtpd.web11.12534.1705715636750569106 for ; Fri, 19 Jan 2024 17:53:57 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10957"; a="14249505" X-IronPort-AV: E=Sophos;i="6.05,206,1701158400"; d="scan'208";a="14249505" X-Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2024 17:53:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10957"; a="788507650" X-IronPort-AV: E=Sophos;i="6.05,206,1701158400"; d="scan'208";a="788507650" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 19 Jan 2024 17:53:55 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 19 Jan 2024 17:53:55 -0800 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 19 Jan 2024 17:53:54 -0800 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 19 Jan 2024 17:53:54 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 19 Jan 2024 17:53:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LiU6gz1gXGaW4HTGUU8ZGFatUguiVC7s9GjEJ/pRcOKWNc2w2zsn3d6wt7XJCeuYkUQ7JlcIb0LVf0lzPElifqdG+PPdT3UJ1ql/YIAf9IAyZ9Z/XD7/5NW9Bu5dMn4+BUshHlAmAzNkLqAfSx+MMfzIIfUrNbev28nz4fod+5TuX34iflieYPavO7JpOsSDl1EPcUm2XYkO2h/QRZK1DbKXMcoP1qJ9fdFaqolU+RmI8dxLRzGov7TmnSzBDyzwNdiMjrRMafPLfeZ6Zbx9cImkInqqG5lkrcvCUg1h5jjnTxwECZo2D1dYvooc3I7t4p1i4llnw9yU+MVJ8HWC8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7Anuf9+vmXr4f8amKYhUPClFAn597nIk10TVr3i50qo=; b=UyFkVCs2bnVCnfQNM4L8/6W8YnTo1aWgAfkK9ENttlYOkGdn5kBzpyFLAZSUtXkEIEW5iyOFLVGvFKQJ7E4VY3zaa3nF/tqQtZjQbghzB2Nr4UgYFrioA0mJRnm6DPm35TtEy3BseR+jV6tK7RJ+lwUw1ycGCsMFoiSs+bPoCu5CnuMQsQG6IB3Z/k3pDXbTQbyYQGKLgnVcL5ro9pfPEyvWy9L3SNLtJlPg9rFZVpv1NBZEaiUf8NvAkdG5b+HFQ6hlyzcLNJnJxc18+eSufU0l/jW1pm3fXDPUiPHWHBxMDhhcNPIH47Eh9tKdZuAgRHWhWP68WieixoSxkuVg+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by IA0PR11MB8304.namprd11.prod.outlook.com (2603:10b6:208:48b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.24; Sat, 20 Jan 2024 01:53:51 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::4382:5b03:f13:88ff]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::4382:5b03:f13:88ff%4]) with mapi id 15.20.7202.026; Sat, 20 Jan 2024 01:53:51 +0000 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "Jin, Zhi" CC: Liming Gao , "Ni, Ray" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH 2/2] MdeModulePkg: Optimize CoreConnectSingleController Thread-Topic: [edk2-devel] [PATCH 2/2] MdeModulePkg: Optimize CoreConnectSingleController Thread-Index: AQHaSRCzvPfy65MZMkKhRYAVsvZBJLDh9JLg Date: Sat, 20 Jan 2024 01:53:51 +0000 Message-ID: References: <20240117064510.390499-1-zhi.jin@intel.com> <20240117064510.390499-2-zhi.jin@intel.com> In-Reply-To: <20240117064510.390499-2-zhi.jin@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|IA0PR11MB8304:EE_ x-ms-office365-filtering-correlation-id: 9757b259-4850-4643-fe4c-08dc195aa6a5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: fNVJ0Hz0kaiQH+ZWsU+DEBJXm7t7VdLvkTHJASzRn0TOUWLYWWkZrpYb0walpUMmNyJiP3xZy83lgY6auder6Uk0UksmT24rahaz27k37kt9+8AZipMPtW1pwxeNKSLnbrx6+52Np+bWI8tZob5iwcGTWPM3kJv/xf2H6nzF0niXU92qnAAlqW8fFACBrogDIyUQSJFRAjf96PDHPmJdNK13imB5QoCX+9fJkDGS2iMxJcheXsE9EZw12+sXAr3TUWXO2YdOBT2giueq0/ZvKkXMiIvLR/jcvJdcTih7oH5rZlqcbk8sGRbrrFhB+esPw4XnBTtMUa6C02y3uIGzxg2HFe2Ce2QzDp+OC2zUnyFHZht8JlvjUZOaM+IlCa7+IEuzYfV8jzKj6Li0Q0A4sTqmL/5NF/Yy/3obD7ELCtSAoJFFGI6QlWQv7NZO68648z4i5RmKiYzjN6auPtoMoWPCSXKrqveX1fKJVoickNrBGdLCG+mBT8KpoR8DtYNbJf4MPXXHl72duJUiMUws1IxtTVkkRTP82dN+n+wH8Boqgc/8hVzIzj7N1Zq1OYmo7ZUpWYzEnFF+Z7rGMSc5G7SELDKmtSEJ4V9FHzyF4ExVg73Px1AXJO7iDa2kkoc6JZaSLH8aQLii96wAuBIUVw== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rJsjp0rJifEzaICKFz4RaH5OTuiFAs/YxennOQ7jP0OyQ4W12XHNg4f9Gnlm?= =?us-ascii?Q?L/yNHGyW4ZvNzvidJwHx9dHw2c+O9a80ETBaZ90PdmFq6kR+XUoJBFJJ+M0A?= =?us-ascii?Q?kBTXSzZw8Qj8jZRp6qLKNZ+WIHYbRefLvidFRjNQT6NpeNmXtgC7wMoioilV?= =?us-ascii?Q?OsA9VAQqHpWTgMZEaSavKsrQusWByj50sQX+biChqcKE5AJbuB05txKBgt/3?= =?us-ascii?Q?teUtRbmjG0azEcMPMHODQvRsgRl/5CYf/3uyzumOhbLQGhoQf42pRPY3jHzh?= =?us-ascii?Q?TJ6NrGjDbLmC19lD0UljgoadzrCyIPIkSWh4kzKFUuPXr0IDDZLYGG0KE1Uy?= =?us-ascii?Q?VwNvtAv1gKA8SOlcKXjv//ofEnOFo+SrdYZz94r0GIvM2UTp7D7itA10QAB8?= =?us-ascii?Q?392+E0VwX755X3RztCN3PO/F8tSrQyYl7FIoaXNVGR67/HDrTgCYodxEdWWk?= =?us-ascii?Q?cmQyKv3ixB64ZMts4pIKtk2Rban0m/Qk/5t378CGIju7TAjzaPHJJEAvRKWD?= =?us-ascii?Q?VvmQ1jl6eoLTSpYyTgAltMyZp7uHSpqVOJni2o6GNUXQet9f3HE7d8SuLZgb?= =?us-ascii?Q?PHuyiCmLP16oVOmhnYye7JM1SohAGigcjBV4Wq0fOEHe14ij5kZsK+phBU6D?= =?us-ascii?Q?q8mEQd7orDwsuXr/K2nXYmHCCAWQ6Ef+mpolrSNNWBBPLSc6UKPWf1FqO0g/?= =?us-ascii?Q?oKV3m0FfPOi4ivJSQJGO6htfSSKDYlvt/lS9Ud7Mcr2c6YhLfzk6hpKR3Elt?= =?us-ascii?Q?1fm+YqxCwa2mAndfxuXrLAjEYpecCCfy9WXyHlgfoOH479qTozvbCIxWwQDa?= =?us-ascii?Q?SVLP81bVsN/RMFH6INulyuUbyWBr+cR2jOIVg7vDiQ/jrd/8ldsGo+6Ipy2q?= =?us-ascii?Q?V2+Ppx/B8UrM1d6In+LyInIQassoAMsU2hd7fRrhQ1oYVaEU9Z44HHlschPP?= =?us-ascii?Q?WCTTiZ9AWYO9sTQwiAS3KL4UTxLEaYlePCLJQM+JDGjxH5vEHhuchi8LmCmJ?= =?us-ascii?Q?vQZ+vCBFvGD1X5GrKt530GkN6+Vge3Ugd9ERZnxG3cu3zixBeAlLXL9vm0kz?= =?us-ascii?Q?eANXXqTXcgsNgv2zPC4xpzvvv2wQsjB+nWoME+122F5p3XkptQZu7+mkidxB?= =?us-ascii?Q?NSs9ONrSAr1/VcdAvBZllmatsaO2dnzNTXM9JBKfsKUilJvacuOcpVjXkeYw?= =?us-ascii?Q?uPBvR3TaHfZtTlGcqZ1laCzCw41TM8ASvbnaMao3Vy/0wP36u1sbb6lAaq7e?= =?us-ascii?Q?w56Vj0GlM8WIcRpyq1sqHwoUML9JVZOFYEcHoZqOsnqy/pI/oONmq96VQbhy?= =?us-ascii?Q?kvH2t8W6S6iy34EhTt6ILeodrrrqEmCstuHwOR3e1F6qp9w+WlCXalKiZ485?= =?us-ascii?Q?PQuJZAS9JrPmOYe1zhRZgWELZiYzo9z04qcaErWBsVKouWvSoo0XYOkEYyA4?= =?us-ascii?Q?UBIVOHVcS3JEPggKaVICCQ5rfBVKNjRLHJeZg5nKjUi7ZJFcE4xVyyrEaW4b?= =?us-ascii?Q?FBbCCdr/mdbojAYdjFpFCw2RBke1DCMTqZpyV3oDSYrG/yXKoaY6NvZO786Z?= =?us-ascii?Q?Kn+XScH3X5PfVWNs5ovQuNH9ufSAQOdcli/Ot6LUQc2l+JiDj+TQA09BbwN2?= =?us-ascii?Q?AA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9757b259-4850-4643-fe4c-08dc195aa6a5 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jan 2024 01:53:51.3318 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DVQnAk4CMzWfY0ipxEJsdNcbaBzlKluxrGTbMo7LIbjoxv+p6nlHPgtod2zkUKMqk/Vs0JaVvrZtuKGri1tOG8x4V5SZMKlMIca2lBUnu34= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB8304 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: UE1GIKU4ecZx6i9JeagWNIhmx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=nju0fB1W; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") I agree that this implements the similar check as other=20 optional protocols to adjust driver binding order to skip checks for which where are no instances of the optional protocol. Reviewed-by: Michael D Kinney > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Zhi Jin > Sent: Tuesday, January 16, 2024 10:45 PM > To: devel@edk2.groups.io > Cc: Jin, Zhi ; Liming Gao ; > Ni, Ray > Subject: [edk2-devel] [PATCH 2/2] MdeModulePkg: Optimize > CoreConnectSingleController >=20 > CoreConnectSingleController() searches for the Driver Family Override > Protocol drivers by looping and checking each Driver Binding Handles. > This loop can be skipped by checking if any Driver Family Override > Protocol installed in the platform first, to improve the performance. >=20 > Cc: Liming Gao > Cc: Ray Ni > Signed-off-by: Zhi Jin > --- > MdeModulePkg/Core/Dxe/Hand/DriverSupport.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Core/Dxe/Hand/DriverSupport.c > b/MdeModulePkg/Core/Dxe/Hand/DriverSupport.c > index 0b824c62b7..64d7474f15 100644 > --- a/MdeModulePkg/Core/Dxe/Hand/DriverSupport.c > +++ b/MdeModulePkg/Core/Dxe/Hand/DriverSupport.c > @@ -497,7 +497,12 @@ CoreConnectSingleController ( > // > // Add the Driver Family Override Protocol drivers for > ControllerHandle > // > - while (TRUE) { > + Status =3D CoreLocateProtocol ( > + &gEfiDriverFamilyOverrideProtocolGuid, > + NULL, > + (VOID **)&DriverFamilyOverride > + ); > + while (!EFI_ERROR (Status) && (DriverFamilyOverride !=3D NULL)) { > HighestIndex =3D DriverBindingHandleCount; > HighestVersion =3D 0; > for (Index =3D 0; Index < DriverBindingHandleCount; Index++) { > -- > 2.39.2 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114106): https://edk2.groups.io/g/devel/message/114106 Mute This Topic: https://groups.io/mt/103781274/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-