Re: [edk2-devel] GitHub PR Code Review process now active

["Michael D Kinney" <michael.d.kinney@intel.com>]

Hi Gerd,

We can clarify the Wiki.  A Maintainer has to be involved in every
code review.  The first action a Maintainer does is verify that the
code change should be considered at all or rejected.  Then add 
maintainers for the ones that look like good submissions.

I agree that this may add a bit of delay.  You are welcome to add
a comment with @<githubid> tags to the maintainers and reviewers so
they know to look at it and do the assignments.  If you like that
idea we can add that to the Wiki as well.

Since PRs can be also opened by outside contributors that have 
limited access, maintainers have to be involved in reviewing newly
submitted PRs.

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gerd Hoffmann
> Sent: Wednesday, May 29, 2024 9:38 AM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
> 
> On Wed, May 29, 2024 at 03:00:13PM GMT, Michael D Kinney wrote:
> > Hi Gerd,
> >
> > You are in the EDK II Reviewers team.
> >
> > The current settings only allow members of the EDK II Maintainers
> > team to assign reviewers.
> 
> That contradicts the wiki instructions which say I should assign
> reviewers myself.  And I think it makes sense to allow that for my
> own PRs, at least as long as there is no automatic process which
> consults Maintainers.txt and auto-assigns reviewers.
> 
> take care,
>   Gerd
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119357): https://edk2.groups.io/g/devel/message/119357
Mute This Topic: https://groups.io/mt/106355103/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-