From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 48EF27803CE for ; Wed, 29 May 2024 18:09:25 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=C2WY2osAQ2ybLzbX52gZMREJ+ZMG/C9thmkzZHdf8Cw=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1717006165; v=1; b=N7RzHC8OhImdqTrAM+pib4XL3LFdtkpvZRGphrjctVr40VNGnxM7AEh3oP7queTi/KjAol5E UvppHqNBZJ70mxtAspJJwsT5niWsx6LUkWGh1NArj9878ScfI/oNXYTHpdjZOIE3A8ibQ8XFHyz hxht5JpVqZ6FSbux/YKa34msWOXbRPEMbWUrdCun+0mbn6t32OVuz+UkxzLciBgWS3x24wqKyCJ MFa20wN2SlIkYD1ePSQux26ZSnVAYdO6E+kBxkhMm2vVWZAUi3D96Vm3+J3IgMKxtOb39OABTOE LArp5ltq+iOtdgnvSLCvECWPMVJqBQuS+NDReWxD2gHgQ== X-Received: by 127.0.0.2 with SMTP id dr2EYY7687511xZBm83LYmZr; Wed, 29 May 2024 11:09:23 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by mx.groups.io with SMTP id smtpd.web10.22680.1717006157827997229 for ; Wed, 29 May 2024 11:09:18 -0700 X-CSE-ConnectionGUID: 7wqOmtJcRoyq5TLQKqEjdQ== X-CSE-MsgGUID: qlWiNhxrTNu3P/Q0Ldy6+Q== X-IronPort-AV: E=McAfee;i="6600,9927,11087"; a="13383670" X-IronPort-AV: E=Sophos;i="6.08,199,1712646000"; d="scan'208";a="13383670" X-Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2024 11:09:17 -0700 X-CSE-ConnectionGUID: y9km/s0cRBm5jwE/J7O7lg== X-CSE-MsgGUID: u0xVsrqxSoC71PcnzZ3rSA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,199,1712646000"; d="scan'208";a="35590221" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa009.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 29 May 2024 11:09:18 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 29 May 2024 11:09:17 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 29 May 2024 11:09:16 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 29 May 2024 11:09:16 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 29 May 2024 11:09:16 -0700 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by PH0PR11MB5141.namprd11.prod.outlook.com (2603:10b6:510:3c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.19; Wed, 29 May 2024 18:09:14 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::a886:6510:729d:f9d0]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::a886:6510:729d:f9d0%5]) with mapi id 15.20.7611.030; Wed, 29 May 2024 18:09:14 +0000 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "kraxel@redhat.com" , "Kubacki, Michael" CC: "Kinney, Michael D" Subject: Re: [edk2-devel] GitHub PR Code Review process now active Thread-Topic: [edk2-devel] GitHub PR Code Review process now active Thread-Index: AdqxKDms81p5Mq2lRy6LTkfbwilSAQAap3YAABD/77AAA/KyAAADAEOA Date: Wed, 29 May 2024 18:09:14 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|PH0PR11MB5141:EE_ x-ms-office365-filtering-correlation-id: 4b378174-7b79-4ad1-cc0b-08dc800a72a4 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?FwmL9CGMFUx8QiRpqKaporcAalf9H77UAiBqAXxbDZMbQsOv/MC5yw+FUsh2?= =?us-ascii?Q?BWI2GQNHy8rJ7BsfSS2utR2ZY+YKyX0So774LnZNH+OH7GSGDWJrEEhbIU0T?= =?us-ascii?Q?cbB8T63nWoUGnWyVk+RUqyR7iDnD6pzMgiJhOU13hpB7Wj4SuZSH96f0XZGe?= =?us-ascii?Q?+1iCjf10KmW17qpu2WZDamET2Ve9lzXYJCsUexs8HmdrIvyxw5DtLr7NUXEA?= =?us-ascii?Q?hd70/MCDHadtRv10ckvrljsIlBdzh/pyLmqSaNpj5YyLF9Qr792zpgfyphIT?= =?us-ascii?Q?LqzSmrQJmfQV1fTJZhXKvE+0rQ1wX56xwnl0d0JX4JEpNWbFfr1Z/+IGDWRn?= =?us-ascii?Q?wktW/mlDt05VMowWqD8oCYEXYPzeCmKLC8AXAp2IxXxwfaPfUPZ7D5MceZ4d?= =?us-ascii?Q?PcAgcXPdj+hSxG/NCzd5JEjao4Ta9FoGttYAiWR0kuY4zf2JJmV5egkpSvt5?= =?us-ascii?Q?Z/c7RM4fOiS2zVe/+vYZ/63C6WQaRNFMow0ZO5gdNjrU9F7M692aybYrp0EJ?= =?us-ascii?Q?O7aafNC6TAeUcrj9HIWgfJTVr9XqspQ43sZuHK3tVj6Qi8AzRe5U6Nb5VS5T?= =?us-ascii?Q?DRpauuU65gBB9Ah5Pq/nD4vJn+nhwJvJpClrXRql7LLuoTDUmhHWjV748Smg?= =?us-ascii?Q?a8mlBWkRtxD2LFfebRQakvhUdNAtg8+8OP1Zv9PLMVv9TMsSh8MvrTtG4Oc0?= =?us-ascii?Q?Say5PDQc/Uu9jt8TEMb7lpf4TZAdzpEQ5H5bho56kY02d3YZ/p8oqSBOl2ah?= =?us-ascii?Q?pA2CjL+sTLLtq+wY/V3ctZrY0XXNz2JX2/xX993EtMZOdD/OTH7jlPu4Phk5?= =?us-ascii?Q?U4b+b/w+6zfvCbmR9WaNs5IaObz9wzdh3m7BvcbI6lw6q1FyMgFflE2wZ8EZ?= =?us-ascii?Q?UBzcVKYq2tRi/Eu7qaxJQg6BdXC/BpirsGsZmswRA8590UQ0nELGrh1btkb1?= =?us-ascii?Q?XUdFCyhg1BazmZ+dKPf3IF/0qYl9BEoxZlKC9ddEn+35vnN0eJ0kSLGnnBbe?= =?us-ascii?Q?zBeWgOCsnaIl7Lkwmf9DPzdaTNyXKp832PgZzefo76LE4TlFxDAxaxdqx7mU?= =?us-ascii?Q?6KoxoqVa7XelU4Z87hBaL/o4+tC4fcmIzHPcKsmRY/zQd5JsKvOpAYjalDZj?= =?us-ascii?Q?IiYhm9utiXGEq+YMI/pOWUxh6gTOBBoqd4TpTf4SXLwTTuUCsRptQ+dPIMA+?= =?us-ascii?Q?Kxk+lloHIGDtRxUwnowxWrKNM59VA2s4HeueRTl9F1tHGgDD2Kfj49dOSokv?= =?us-ascii?Q?TZd/UmGmuYMTkK6H/0EFuKSAVRXCJ67ki3LkClShoBsobwLOcIGeQivQMn19?= =?us-ascii?Q?67Q=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5rJoFSWKR8RhcVVMCRCENkpOUp/RXhSZz6pgokxHKjNIq4sOTH+UBZuFCC4k?= =?us-ascii?Q?IHK75s0SStnnn9tefNCQRbSBOL94F8iCA92MIRN9S6SI4kVaRlCoJAWxkLCf?= =?us-ascii?Q?8bCY+NPiSfVzAZJcZzQiwzXcsFd4Xce5Oj98B/BYfxj+tuXN158UcDMBnLJX?= =?us-ascii?Q?m1JeEtj+BjPQyYVQ6Ws6dPybbr/cJvSsrK7doFQaCkIybHOjVLlIQCaP5yzJ?= =?us-ascii?Q?Fo4UaXqH34Tj/QX5SM5b9SbSQBngDFqEswtYHBzSQTXGUtBKmjWG39mgg4jH?= =?us-ascii?Q?eUD72L6/xQnAN33+S6PMCQ+AkGWwovj4klKi8FPR+kRBHcqbFKFEMOlNw5I2?= =?us-ascii?Q?CL544ykgw2PZruqH7/lzjv+A8bD42wjVR6Lc0XyfAV28GBxhK/mh7a7pfzoj?= =?us-ascii?Q?wcvni5TaHSRew8xNGxibEqmj7moV4+KCtxhnTZMxGYzIkwiExKT2wc3YvbSb?= =?us-ascii?Q?0/28a6go+gamnKaEXAyK5YwwKRWTQQK4JWxK8KJeheDltdvBFgnqYZm2sJUH?= =?us-ascii?Q?dW3BTJW7K2C17zOY4Tfq5GGPBfjsb+LwJnbteUkynVagwhFuh4E+8ow+1W3Z?= =?us-ascii?Q?4JiqpaiSc53jqzI+1KR1jt0xAH57QSN1puFiyqirx8CJSKmXpm0NDd70TPLl?= =?us-ascii?Q?0Fx3dylZzAE4da15jZBs9oU+KzMCzr89vhYeextiupujA6xjwhfCLbY1Mj19?= =?us-ascii?Q?3XIvZZn2gJipF44WUfDU3jHCXjDTiXP7kLdK2wxdMJuq7Px3w0jf7UDqyxbz?= =?us-ascii?Q?7ZRjqODJAZ/FlxJDZlTovo+G3KNAeYDGQAogSkUTP47kcCEgDu6GvP4ntezA?= =?us-ascii?Q?l8J2geekv+GOTnfB3xHVAlHq/24SCBnNPceuLek74HqWwYd+/AfogZniHFMd?= =?us-ascii?Q?7ELQPqtybPWFvfuOmctt3mAqoRpjaBC1LhI4SuGQUpQP9K7qbTrFhfSquvKS?= =?us-ascii?Q?lP3ZTDdEjjatw9hISZD84FtGw7dAqvLQJUkXz+1zkGKe6CkRMhWudkbRyTvz?= =?us-ascii?Q?g/qphuG+1bx317qf4qSgfNvymFnUBS8Uyr0qcLb4QCsgQ65b2cmoWjuMtLXD?= =?us-ascii?Q?Yr7V2wHHkbbSnnKNOa8DvXbs3SvDGcx/W7T2njCpFxeBcqc5FisGruZx9ALZ?= =?us-ascii?Q?oOmTva2gbSdHB+/kaf2xcn2mmqjzQNryMXFA8Au4hdFyzSvsAVNKWD3/Hods?= =?us-ascii?Q?PUr5xyrikW0re/r7SGwqZA9RAB0ljnPTUVEoCDh2C03/M6GeMLuoyVLlwvbc?= =?us-ascii?Q?/i2lMPHZOqU5xkgyqHRnzJt6wx6bPRQfiflWY7VQBydl+IsehjkaPT//oM6C?= =?us-ascii?Q?NjX2T/gudxwQs0HrmrIlU0YPO9vu/DBRJiMjUyun2M9e85iFjAP4KjYomHuu?= =?us-ascii?Q?TWVB7odNN7g9p8M31kVGROaRVeSoozEwooi+PfjdcSkrLL+hUnIVX2GjqdUj?= =?us-ascii?Q?8HCp4R+/DbETm6BQrj07Yr7cTxvkAJHEfrz0OvWF6lEYGSV2Ym1WcCI2+QxF?= =?us-ascii?Q?l2sqRWlJjxr0Uk1qCxfeA8QSTOk7b6MPCrjjK26r7PN3qVIGXaDKsqyDRFcR?= =?us-ascii?Q?O4BLUaXHup80VgLq3dFbdl9F0oXVXsQNQGx1PZYgInJN4hb8XnRPNSCJfXw+?= =?us-ascii?Q?lg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b378174-7b79-4ad1-cc0b-08dc800a72a4 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 May 2024 18:09:14.0893 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hpM3rtHC3NZhsZuhbimN0UgnOyaBERsNuMl/gevvApBBhkupxtsqW7j+giBeS4ckMYxoT8+JBZ6BTvB0bjbvkMYkTYBN9ZfvwOxyvrKWqAc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5141 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 29 May 2024 11:09:18 -0700 Resent-From: michael.d.kinney@intel.com Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 4NOPomI8VDlfFMJddX7aWY0Gx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=N7RzHC8O; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Gerd, We can clarify the Wiki. A Maintainer has to be involved in every code review. The first action a Maintainer does is verify that the code change should be considered at all or rejected. Then add=20 maintainers for the ones that look like good submissions. I agree that this may add a bit of delay. You are welcome to add a comment with @ tags to the maintainers and reviewers so they know to look at it and do the assignments. If you like that idea we can add that to the Wiki as well. Since PRs can be also opened by outside contributors that have=20 limited access, maintainers have to be involved in reviewing newly submitted PRs. Mike > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Gerd Hoffm= ann > Sent: Wednesday, May 29, 2024 9:38 AM > To: devel@edk2.groups.io; Kinney, Michael D > Subject: Re: [edk2-devel] GitHub PR Code Review process now active >=20 > On Wed, May 29, 2024 at 03:00:13PM GMT, Michael D Kinney wrote: > > Hi Gerd, > > > > You are in the EDK II Reviewers team. > > > > The current settings only allow members of the EDK II Maintainers > > team to assign reviewers. >=20 > That contradicts the wiki instructions which say I should assign > reviewers myself. And I think it makes sense to allow that for my > own PRs, at least as long as there is no automatic process which > consults Maintainers.txt and auto-assigns reviewers. >=20 > take care, > Gerd >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119357): https://edk2.groups.io/g/devel/message/119357 Mute This Topic: https://groups.io/mt/106355103/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-