public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Gao, Liming" <gaoliming@byosoft.com.cn>,
	"Liu, Zhiguang" <zhiguang.liu@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH v1 0/2] MdePkg: Add missing status codes
Date: Mon, 31 Jul 2023 20:39:48 +0000	[thread overview]
Message-ID: <CO1PR11MB4929B43BBC9B2FCEC8795D19D205A@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230731184314.1253-1-nathaniel.l.desimone@intel.com>

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>


> -----Original Message-----
> From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Sent: Monday, July 31, 2023 11:43 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>
> Subject: [PATCH v1 0/2] MdePkg: Add missing status codes
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4514
> 
> Upon review it has been found that MdePkg is missing two
> status code definitions:
> 
>  1. EFI_IP_ADDRESS_CONFLICT - Added in UEFI Spec v2.5
>  2. EFI_WARN_RESET_REQUIRED - Added in UEFI Spec v2.6
> 
> Moreover, PrintLib does not correctly decode the follow status codes:
> 
>  1. EFI_IP_ADDRESS_CONFLICT
>  2. EFI_HTTP_ERROR
>  3. EFI_WARN_FILE_SYSTEM
>  4. EFI_WARN_RESET_REQUIRED
> 
> These missing status codes and the missing decodings have been added.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> 
> Nate DeSimone (2):
>   MdePkg: Add missing status codes
>   MdePkg: Add new status codes to PrintLib
> 
>  MdePkg/Include/Base.h                          | 10 ++++++++++
>  MdePkg/Include/Uefi/UefiBaseType.h             |  2 ++
>  MdePkg/Library/BasePrintLib/PrintLibInternal.c | 10 +++++++---
>  3 files changed, 19 insertions(+), 3 deletions(-)
> 
> --
> 2.30.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107409): https://edk2.groups.io/g/devel/message/107409
Mute This Topic: https://groups.io/mt/100468025/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  parent reply	other threads:[~2023-07-31 20:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-31 18:43 [edk2-devel] [PATCH v1 0/2] MdePkg: Add missing status codes Nate DeSimone
2023-07-31 18:43 ` [edk2-devel] [PATCH 1/2] " Nate DeSimone
2023-07-31 18:43 ` [edk2-devel] [PATCH 2/2] MdePkg: Add new status codes to PrintLib Nate DeSimone
2023-07-31 20:39 ` Michael D Kinney [this message]
     [not found] <1777080A4EA7576A.12785@groups.io>
2023-08-07 23:06 ` [edk2-devel] [PATCH v1 0/2] MdePkg: Add missing status codes Nate DeSimone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB4929B43BBC9B2FCEC8795D19D205A@CO1PR11MB4929.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox