public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: Ard Biesheuvel <ardb@kernel.org>,
	Michael Kubacki <mikuback@linux.microsoft.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Abner Chang <abner.chang@amd.com>,
	Daniel Schaefer <git@danielschaefer.me>
Subject: Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI
Date: Thu, 15 Sep 2022 20:51:58 +0000	[thread overview]
Message-ID: <CO1PR11MB4929B49BB802718E92F69F53D2499@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAMj1kXFW-xO+aoNE54P2x8EZXxvNQ-FVsqTWwnv-1n7FYVU8NQ@mail.gmail.com>

Ard,

Why would you want to do that?  The whole point of CI is to establish a minimum quality level for all code in the project.

They can be disabled with updates to the YAML file.  Checks can be disabled completely and may of the checks support exception lists.

Mike

> -----Original Message-----
> From: Ard Biesheuvel <ardb@kernel.org>
> Sent: Thursday, September 15, 2022 1:47 PM
> To: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: devel@edk2.groups.io; Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Abner Chang
> <abner.chang@amd.com>; Daniel Schaefer <git@danielschaefer.me>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI
> 
> On Thu, 15 Sept 2022 at 21:46, Michael Kubacki
> <mikuback@linux.microsoft.com> wrote:
> >
> > Hi Ard,
> >
> > I haven't seen any action items for the v1 series.
> >
> > Can you please check the series again and let me know if you have any
> > further concerns?
> >
> 
> The only thing I'd like to know is how I can override the CI and merge
> a PR that was rejected by the checks you are enabling here.
> 
> 
> 
> 
> > On 9/7/2022 11:16 AM, Ard Biesheuvel wrote:
> > > On Wed, 7 Sept 2022 at 17:00, Michael Kubacki
> > > <mikuback@linux.microsoft.com> wrote:
> > >>
> > >> When would you like to have that discussion?
> > >>
> > >> The Tianocore Tool, CI, Codebase meeting is every week. In that meeting
> > >> we've discussed getting all edk2 packages to at least run CI.
> > >>
> > >> https://github.com/tianocore/edk2/discussions/2614
> > >>
> > >> If you prefer to have it here, that's fine as well.
> > >>
> > >
> > > In a nutshell, I am fine with enabling this, as long as I can override
> > > the CI and merge PRs that the CI thinks have issues.
> > >
> > >
> > > 
> > >

  reply	other threads:[~2022-09-15 20:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07  2:36 [PATCH v1 0/3] EmbeddedPkg: Enable CI Michael Kubacki
2022-09-07  2:36 ` [PATCH v1 1/3] EmbeddedPkg/AcpiLib: Fix code formatting errors Michael Kubacki
2022-09-07  2:36 ` [PATCH v1 2/3] EmbeddedPkg: Add CI YAML file Michael Kubacki
2022-09-07  2:36 ` [PATCH v1 3/3] EmbeddedPkg: Only run in CI for GCC5 Michael Kubacki
     [not found] ` <1712738C00A60617.17907@groups.io>
2022-09-07  3:27   ` [edk2-devel] " Michael Kubacki
2022-09-09  1:37     ` Michael D Kinney
2022-09-07  7:37 ` [PATCH v1 0/3] EmbeddedPkg: Enable CI Ard Biesheuvel
2022-09-07 15:00   ` [edk2-devel] " Michael Kubacki
2022-09-07 15:16     ` Ard Biesheuvel
2022-09-15 19:46       ` Michael Kubacki
2022-09-15 20:47         ` Ard Biesheuvel
2022-09-15 20:51           ` Michael D Kinney [this message]
2022-09-15 21:02             ` Ard Biesheuvel
2022-09-15 21:54               ` Michael D Kinney
2022-09-23  1:09                 ` Michael Kubacki
2022-09-23 11:47                   ` Ard Biesheuvel
2022-09-23 15:30                     ` Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB4929B49BB802718E92F69F53D2499@CO1PR11MB4929.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox