Re: [edk2-devel] [PATCH edk2-platforms v3 0/1] Move to the GitHub Pull Request workflow

["Michael D Kinney" <michael.d.kinney@intel.com>]

Here is the guide I used that includes the GitHub App approach

* https://michaelheap.com/ultimate-guide-github-actions-authentication/

Mike

> -----Original Message-----
> From: Rebecca Cran <rebecca@bsdio.com>
> Sent: Monday, August 19, 2024 4:31 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io;
> Leif Lindholm <quic_llindhol@quicinc.com>; Kubacki, Michael
> <michael.kubacki@microsoft.com>
> Subject: Re: [edk2-devel] [PATCH edk2-platforms v3 0/1] Move to the GitHub
> Pull Request workflow
> 
> Sorry, I should have explained: I'd like to set it up on
> https://github.com/bcran/edk2-platforms to test it before having the
> changes merged into https://github.com/tianocore/edk2-platforms.
> 
> 
> --
> 
> Rebecca
> 
> 
> On 8/19/2024 5:01 PM, Kinney, Michael D wrote:
> > You do not need a new app.
> >
> > We can use the app that is already available.
> >
> > The main update that is needed is adding secrets to edk2-platforms repo
> >
> > Mike
> >
> >> -----Original Message-----
> >> From: Rebecca Cran <rebecca@bsdio.com>
> >> Sent: Monday, August 19, 2024 3:15 PM
> >> To: Kinney, Michael D <michael.d.kinney@intel.com>;
> devel@edk2.groups.io;
> >> Leif Lindholm <quic_llindhol@quicinc.com>; Kubacki, Michael
> >> <michael.kubacki@microsoft.com>
> >> Subject: Re: [edk2-devel] [PATCH edk2-platforms v3 0/1] Move to the
> GitHub
> >> Pull Request workflow
> >>
> >> Could you explain what you entered into the New GitHub App page when
> >> setting up tianocore to use
> >> https://github.com/marketplace/actions/create-github-app-token please?
> >>
> >>
> >> --
> >>
> >> Rebecca
> >>
> >>
> >> On 8/6/24 1:14 PM, Kinney, Michael D wrote:
> >>> I suspect you will run into the same permissions issues that required
> >>> the use of a GitHub App credentials to run the AssignReviewers.yml.
> >>>
> >>> See this change for reference:
> >>>
> >>> 	https://github.com/tianocore/edk2/pull/6050
> >>>
> >>>
> >>> Mike
> >>>
> >>>> -----Original Message-----
> >>>> From: Rebecca Cran <rebecca@bsdio.com>
> >>>> Sent: Tuesday, August 6, 2024 10:36 AM
> >>>> To: devel@edk2.groups.io; Leif Lindholm <quic_llindhol@quicinc.com>;
> >> Kinney,
> >>>> Michael D <michael.d.kinney@intel.com>
> >>>> Subject: Re: [edk2-devel] [PATCH edk2-platforms v3 0/1] Move to the
> >> GitHub
> >>>> Pull Request workflow
> >>>>
> >>>> Could I get some reviews on this please?
> >>>>
> >>>>
> >>>> --
> >>>>
> >>>> Rebecca
> >>>>
> >>>>
> >>>> On 8/1/24 3:43 PM, Rebecca Cran wrote:
> >>>>> Changes from v2 to v3:
> >>>>>
> >>>>> Added note to AssignReviewers.yml to say where it was copied from.
> >>>>>
> >>>>> Sorted platforms in CODEOWNERS and REVIEWERS alphabetically.
> >>>>> Sorted entries in CONTRIBUTORS.md by first name.
> >>>>>
> >>>>> Updated CONTRIBUTORS.md with some more GitHub usernames.
> >>>>> Updated Readme.md to clarify that people own _areas_ of the repo, not
> >>>>> specifically packages.
> >>>>>
> >>>>> Rebecca Cran (1):
> >>>>>      Move to the GitHub Pull Request workflow
> >>>>>
> >>>>>     .github/workflows/AssignReviewers.yml |  31 ++
> >>>>>     CODEOWNERS                            | 146 +++++++
> >>>>>     CONTRIBUTORS.md                       |  68 +++
> >>>>>     Maintainers.txt                       | 445 --------------------
> >>>>>     REVIEWERS                             |  92 ++++
> >>>>>     Readme.md                             |  33 +-
> >>>>>     6 files changed, 365 insertions(+), 450 deletions(-)
> >>>>>     create mode 100644 .github/workflows/AssignReviewers.yml
> >>>>>     create mode 100644 CODEOWNERS
> >>>>>     create mode 100644 CONTRIBUTORS.md
> >>>>>     delete mode 100644 Maintainers.txt
> >>>>>     create mode 100644 REVIEWERS
> >>>>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120372): https://edk2.groups.io/g/devel/message/120372
Mute This Topic: https://groups.io/mt/107675097/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-