Re: [edk2-devel] [PATCH v1 1/1] Update to CodeQL 2.16.1

["Michael D Kinney" <michael.d.kinney@intel.com>]

Go ahead and add the push label.

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael
> Kubacki
> Sent: Wednesday, April 24, 2024 2:55 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Rebecca Cran <rebecca@bsdio.com>; Sean
> Brogan <sean.brogan@microsoft.com>; Chen, Christine
> <yuwei.chen@intel.com>
> Subject: Re: [edk2-devel] [PATCH v1 1/1] Update to CodeQL 2.16.1
> 
> Thanks for reviews. I've updated the PR
> (https://github.com/tianocore/edk2/pull/5597) to include them.
> 
> Although it has not been 24 hours, I suggest we merge the patch soon to
> ensure CI is unblocked. Please feel free to add the push tag or let me
> know if you'd like me to.
> 
> Thanks,
> Michael
> 
> On 4/24/2024 1:37 PM, Michael Kubacki wrote:
> > From: Michael Kubacki <michael.kubacki@microsoft.com>
> >
> > Fixes current CI CodeQL failures due to old CodeQL CLI version.
> >
> > Updates CodeQL to work with the latest queries. Includes functional
> > and security fixes within the CodeQL CLI binary.
> >
> > For more information on release details see:
> >
> > https://github.com/github/codeql-cli-binaries/releases
> >
> > For changes between the previous version (2.14.5) and 2.16.1 see:
> >
> > https://github.com/github/codeql-cli-
> binaries/compare/v2.14.5...v2.16.1
> >
> > Cc: Bob Feng <bob.c.feng@intel.com>
> > Cc: Joey Vagedes <joey.vagedes@gmail.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Rebecca Cran <rebecca@bsdio.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Yuwei Chen <yuwei.chen@intel.com>
> > Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> > ---
> >
> > Notes:
> >      Tested in https://github.com/tianocore/edk2/pull/5597
> >
> >   BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml         | 6 +++---
> >   BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml   | 6 +++---
> >   BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml | 6 +++---
> >   3 files changed, 9 insertions(+), 9 deletions(-)
> >
> > diff --git a/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml
> b/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml
> > index 37c7c9f595ca..5ec56c6bf06f 100644
> > --- a/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml
> > +++ b/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml
> > @@ -16,9 +16,9 @@
> >     "scope": "codeql-ext-dep",
> >     "type": "web",
> >     "name": "codeql_cli",
> > -  "source": "https://github.com/github/codeql-cli-
> binaries/releases/download/v2.12.4/codeql.zip",
> > -  "version": "2.12.4",
> > -  "sha256":
> "f682f1155d627ad97f10b1bcad97f682011986717bd3823e9cf831ed83ac96e7",
> > +  "source": "https://github.com/github/codeql-cli-
> binaries/releases/download/v2.16.1/codeql.zip",
> > +  "version": "2.16.1",
> > +  "sha256":
> "86a98f6ebb8fd49efadf367f3275c438669fcb8426962c33415129aad8e093e6",
> >     "compression_type": "zip",
> >     "internal_path": "/codeql/",
> >     "flags": ["set_shell_var", ],
> > diff --git a/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml
> b/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml
> > index a6ca5d0f34cc..5b4a919f1de4 100644
> > --- a/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml
> > +++ b/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml
> > @@ -14,9 +14,9 @@
> >     "scope": "codeql-linux-ext-dep",
> >     "type": "web",
> >     "name": "codeql_linux_cli",
> > -  "source": "https://github.com/github/codeql-cli-
> binaries/releases/download/v2.14.5/codeql-linux64.zip",
> > -  "version": "2.14.5",
> > -  "sha256":
> "72aa5d748ff9ab57cfd86045560683bdc4897e0fe6d9f9a2786d9394674ae733",
> > +  "source": "https://github.com/github/codeql-cli-
> binaries/releases/download/v2.16.1/codeql-linux64.zip",
> > +  "version": "2.16.1",
> > +  "sha256":
> "40dbb6c0c4064bd14601a02e60c61661fdc0271469f90eb91a2e7d51d4cbc171",
> >     "compression_type": "zip",
> >     "internal_path": "/codeql/",
> >     "flags": ["set_shell_var", ],
> > diff --git a/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml
> b/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml
> > index e706a7cabf9f..c0c018c9538f 100644
> > --- a/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml
> > +++ b/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml
> > @@ -14,9 +14,9 @@
> >     "scope": "codeql-windows-ext-dep",
> >     "type": "web",
> >     "name": "codeql_windows_cli",
> > -  "source": "https://github.com/github/codeql-cli-
> binaries/releases/download/v2.14.5/codeql-win64.zip",
> > -  "version": "2.14.5",
> > -  "sha256":
> "861fcb38365cc311efee0c3a28c77494e93c69a969885b72e53173ad473f61aa",
> > +  "source": "https://github.com/github/codeql-cli-
> binaries/releases/download/v2.16.1/codeql-win64.zip",
> > +  "version": "2.16.1",
> > +  "sha256":
> "9ebe5ea8a7d0a77425428d50d49912319117fccee24ecb62f6219c12584f4f28",
> >     "compression_type": "zip",
> >     "internal_path": "/codeql/",
> >     "flags": ["set_shell_var", ],
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118235): https://edk2.groups.io/g/devel/message/118235
Mute This Topic: https://groups.io/mt/105714919/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-