From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "Guo, Gua" <gua.guo@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"fernald, chris" <chfernal@microsoft.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>,
Michael Kubacki <mikuback@linux.microsoft.com>,
Oliver Steffen <osteffen@redhat.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 2/2] .azurepipelines: Install code coverage tool
Date: Sun, 23 Apr 2023 16:45:58 +0000 [thread overview]
Message-ID: <CO1PR11MB4929BE3D1157FF9C4341618AD2669@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <BL1PR11MB54783E0859D4B470DF3203C1EF669@BL1PR11MB5478.namprd11.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 5081 bytes --]
Hi Sean,
I agree the container image needs to be updated.
Is this also required for local developer runs of the stuart tools? Or should this be part of the setup that developers do before running stuart?
Thanks,
Mike
From: Guo, Gua <gua.guo@intel.com>
Sent: Sunday, April 23, 2023 1:44 AM
To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>; fernald, chris <chfernal@microsoft.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Michael Kubacki <mikuback@linux.microsoft.com>; Oliver Steffen <osteffen@redhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 2/2] .azurepipelines: Install code coverage tool
I know maybe I need to update https://github.com/tianocore/containers but add these step, i f have any guidelines for me that will be great.
________________________________
寄件者: 「devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>」代表「Sean <spbrogan@outlook.com<mailto:spbrogan@outlook.com>>」
寄件日期: 2023年4月23日 星期日 下午2:13
收件者: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; fernald, chris <chfernal@microsoft.com<mailto:chfernal@microsoft.com>>
副本: Sean Brogan <sean.brogan@microsoft.com<mailto:sean.brogan@microsoft.com>>; Michael Kubacki <mikuback@linux.microsoft.com<mailto:mikuback@linux.microsoft.com>>; Oliver Steffen <osteffen@redhat.com<mailto:osteffen@redhat.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
主旨: Re: [edk2-devel] [PATCH v2 2/2] .azurepipelines: Install code coverage tool
Sorry a little late to review this. It looks like these are container based builds. If that is the case we should handle this by updating the container. The whole point of the container is to get the requirements all included in the container. @Chris Fernald<mailto:chfernal@microsoft.com> can you share details.
Thanks
Sean
________________________________
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> on behalf of Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
Sent: Saturday, April 22, 2023 8:15:56 PM
To: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>
Cc: Sean Brogan <sean.brogan@microsoft.com<mailto:sean.brogan@microsoft.com>>; Michael Kubacki <mikuback@linux.microsoft.com<mailto:mikuback@linux.microsoft.com>>; Oliver Steffen <osteffen@redhat.com<mailto:osteffen@redhat.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
Subject: Re: [edk2-devel] [PATCH v2 2/2] .azurepipelines: Install code coverage tool
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
> -----Original Message-----
> From: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>
> Sent: Saturday, April 22, 2023 6:22 PM
> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> Cc: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Sean Brogan <sean.brogan@microsoft.com<mailto:sean.brogan@microsoft.com>>;
> Michael Kubacki <mikuback@linux.microsoft.com<mailto:mikuback@linux.microsoft.com>>; Oliver Steffen <osteffen@redhat.com<mailto:osteffen@redhat.com>>
> Subject: [PATCH v2 2/2] .azurepipelines: Install code coverage tool
>
> From: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>>
>
> Azure should install code coverage tool (lcov), it didn't
> exist on Fedora and Ubuntu by default.
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
> Cc: Sean Brogan <sean.brogan@microsoft.com<mailto:sean.brogan@microsoft.com>>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com<mailto:mikuback@linux.microsoft.com>>
> Cc: Oliver Steffen <osteffen@redhat.com<mailto:osteffen@redhat.com>>
> Signed-off-by: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>>
> ---
> .azurepipelines/Ubuntu-GCC5.yml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/.azurepipelines/Ubuntu-GCC5.yml b/.azurepipelines/Ubuntu-GCC5.yml
> index b9a3b851cf..d884256148 100644
> --- a/.azurepipelines/Ubuntu-GCC5.yml
> +++ b/.azurepipelines/Ubuntu-GCC5.yml
> @@ -24,3 +24,7 @@ jobs:
> container: ${{ variables.default_linux_image }}
>
> arch_list: "IA32,X64,ARM,AARCH64,RISCV64,LOONGARCH64"
>
> usePythonVersion: '' # use Python from the container image
>
> + extra_install_step:
>
> + - bash: sudo dnf install -y lcov
>
> + displayName: Install Code Coverage Tools
>
> + condition: and(gt(variables.pkg_count, 0), succeeded())
>
> --
> 2.39.2.windows.1
[-- Attachment #2: Type: text/html, Size: 50282 bytes --]
next prev parent reply other threads:[~2023-04-23 16:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-23 1:22 [PATCH v2 1/2] BaseTools/Plugin: Report error if code coverage failure Guo, Gua
2023-04-23 1:22 ` [PATCH v2 2/2] .azurepipelines: Install code coverage tool Guo, Gua
2023-04-23 3:15 ` Michael D Kinney
2023-04-23 6:13 ` [edk2-devel] " Sean
2023-04-23 8:44 ` Guo, Gua
2023-04-23 16:45 ` Michael D Kinney [this message]
2023-04-24 1:56 ` Guo, Gua
2023-04-23 3:13 ` [PATCH v2 1/2] BaseTools/Plugin: Report error if code coverage failure Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB4929BE3D1157FF9C4341618AD2669@CO1PR11MB4929.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox