From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6CF41941CEC for ; Tue, 30 Jan 2024 17:44:10 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=gYndsPX23KOTaSvpjNU22PGwEtEbYUCWY7eslXDBcDk=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706636648; v=1; b=BQTLfDqoThK2JsPgwFRrbNZnVDqFCMOh2iufJgt34adiPDrrjxDXnQ5M9bvh63XMHbk8DMqU 4kgQ1MJoz+FzeCDBmMpVbyihlqJbAi8ie6D4nOd+5jy0qzdh88Lhxw+a4DV9DNFuwX3acLeKdij iL5O3IHI36kK8137rPykyU6g= X-Received: by 127.0.0.2 with SMTP id Y5XCYY7687511xvF7AjwF0V2; Tue, 30 Jan 2024 09:44:08 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by mx.groups.io with SMTP id smtpd.web11.2652.1706636647813374983 for ; Tue, 30 Jan 2024 09:44:08 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10969"; a="2287742" X-IronPort-AV: E=Sophos;i="6.05,230,1701158400"; d="scan'208";a="2287742" X-Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2024 09:44:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,230,1701158400"; d="scan'208";a="3772868" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 30 Jan 2024 09:44:03 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 30 Jan 2024 09:44:02 -0800 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 30 Jan 2024 09:44:02 -0800 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 30 Jan 2024 09:44:02 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EdQ1qnZ3k3snVeoC0EjZyv/1te6z0YdY+cdHuIH6iFTA/24qdFvJMmdHk4DzhhVks2SjEPXODO2owYBkkF8QGMcvkzpZwcgdxbjlPknIiRwxcoNAl49K8ykzs7VmC83oSYCCEy85ud/YyR2Z0ukptgePGkBVu+XH1LkrEVmDqxGyHZJ5kJaGmuhifJwQOvdehLJ84DXLTf6gRFjmWpMJbxbWdXGlqZj2wQDXJAeuV2rbhWL55/SXnJGTcZEIGuUJSylFeNbr43J9s8frG+kVXcuSvIVWggz0H27wtN2ILedvVRlt2VCFD3wSzkiTn2838grJ8cyXZthWbLqUwnszzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9zl+S9KjYwYWjwI8Jhg9QDbfVods18qdGwjdhZ3LFdY=; b=gsil5JbxtkYL/AxvMO8ayM1vzrQY7EPJnY4UHc+a4JauMc5BKzOV65CpupeW9hcYnDRsoBNx3NhLifJEW3j6YistznLD3D1bkEosHyjtCK+C8lXpehBKihoue/e8KY4vSPvNphaeFOsqgVFsAnkmQsuO50Gc7zB+c92sOuh6w/F7/IoGbc5SX3Zxf69GgpI7uXMz425o2mm/IJII4TVVqAcyJGPSLR9AKpuP1oyvfNCp+8xk3BFAyQQPHSCnb4HFJT9CZy7s8Dt1XBFyJSnlMUZ8jbXEGNI7sqNC1oEVdKkZsbAOcDt+cfdlEnay+O1iMu129yPvLkIljMgGPoHF1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by SJ0PR11MB4896.namprd11.prod.outlook.com (2603:10b6:a03:2dd::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.32; Tue, 30 Jan 2024 17:43:51 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::7e42:1633:d0a6:9c00]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::7e42:1633:d0a6:9c00%6]) with mapi id 15.20.7228.029; Tue, 30 Jan 2024 17:43:51 +0000 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "Shang, Qingyu" CC: "Tan, Ming" , "Li, Yi1" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Update ReceiveData and SendData function description Thread-Topic: [edk2-devel] [PATCH v2 1/1] MdePkg: Update ReceiveData and SendData function description Thread-Index: AQHaU5pcemCVEgprskiQZ6QtyRpP27DyoAnA Date: Tue, 30 Jan 2024 17:43:51 +0000 Message-ID: References: <592acf92fa66c6fbfc7d9268ec7c8d4cfe6bad87.1706585875.git.qingyu.shang@intel.com> In-Reply-To: <592acf92fa66c6fbfc7d9268ec7c8d4cfe6bad87.1706585875.git.qingyu.shang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|SJ0PR11MB4896:EE_ x-ms-office365-filtering-correlation-id: 35b05047-54b3-4c04-7331-08dc21bb0549 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: s4mzrKZaUqlE2SpYbk4S2ARxHnmsQVlLF3YsW7ncSMi/+SPfDG92Hd0lOeJuunkbBAnyijyh5CWf0p3on0Fj0kTqwRr7XxiGXIsvHbWjcYHfC3Q6l14q9wxeSpXxXMP8z194OB/R6CK9/sagfKa35wq3dUIhzYhEKGYv05fE06X4m+Yz7hxgaRf1LMVclW1pTPbaVmxt7wdzS9tJiYrhJ//T7mNyn/bihCAXcdghk/3ngicBCXqGPXWhASyQINYxTWhgEyoKHpGAaJPNbeazesban3r+063LPe080UMItmh/b1AVFmfJBruXxJQo2fxUEskLiN+QNYa7zhUlqMg1cs+Phypw+bXx/AwT6/NuzfUXnps3MWaBNO37xqy8D0s/Ya3buT7M83EK74j+6oLowWfUgzl3t/2rxTsn+uiNKaSRKkMEh3832OicIJcQnbgj4FA/TR5nt6dj81nnJ91YJvJMjRLoYIgBE4PRdyU+tC60+9xOQW8iKSdx5KbgKNM64sBoq88/zZ+Yzvm1UHG5c4TtQX4oM1cyLMMp/TaFWFedD15bL/3hp1cUr4ZGbWl4vDoYcj01wreCyT2s0LWCPrSj43kck26TQ/dH8bVJ1nOV13bYA9o8risY7LmNTfI80UvQ0nc5jxojSwrEHRaLKg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oWTO6+yBTwziqvUEQIfZwwaBe0Ddu7TuWV6QXzEoEnFUhOSso/j42OIrM6wn?= =?us-ascii?Q?X4GHhrfTsR0bP77oStA3EqyySBbMikKTUDSXXYMBJhMxf89Fd7AqFxXzw17v?= =?us-ascii?Q?WrsTkh6W5HrPGcAnLro9bZEzGCRRyPqesur86LSwXgfXjtXHnDJU/ucs8Ohk?= =?us-ascii?Q?P9LjbgcNLqnQ0KWWylDtq/JoLmn6cPoAX8Bq4QxBmg7nrToBrzmL4Ju6tI6g?= =?us-ascii?Q?6geDJxp+vjlIV+uFhbBEtApjIvFIexotXDOJda+2RYisNt5EdeWooiuqcshq?= =?us-ascii?Q?lr6ElsL9CVTt7VhglWEbCHFQymbG9wYTQQ/NW1PkFi0CdhSGgwNJnNbZnhsi?= =?us-ascii?Q?egmxkZvfrKAHLJcejFk+BDt6S23uPoWYHxFbQY2Ec+o48vizoCMm8IPta9K+?= =?us-ascii?Q?JzkiascugU7WHNEmmqfKwm6Bv4DjjSg+6YXl/9rWiSid3oq2BHZ0poNT1vN/?= =?us-ascii?Q?4SHVJS8/djweiqlqoST8cNL76yJr+cpzAWaSvv3337n7mBNioRaBoh3Woeda?= =?us-ascii?Q?yDc5HzSUyo3bvjFNp73IYtgQTzX2EtAttSBUjknCSVBib+5ZcgPdfPOT72KW?= =?us-ascii?Q?ZinH4SrNgBP52ccKg0IgNfC1d478yKkGMfW5acJLdzhUkG4BKY9KJIbOmICN?= =?us-ascii?Q?kAY4L6J7Px7XP0MHI8uCJ9qoUktHMqYYS0IG3GD7FyPfWXFmBArhuYsysfBo?= =?us-ascii?Q?6gcP8AfBM0Cioz7OaTy4BWC+ZE632K4LsjXY+jcA4m1ODxI+CpN9Dmyeu+S+?= =?us-ascii?Q?b9cFN6TzckFrahSnPuxhsonzdjqRxWIzw2vzjyPOkp7b435SPrmXSTmARIbT?= =?us-ascii?Q?wWqv7omViX5WC6c15J47ZK//89lugvfT3uzXV4IHb2zCTAbWo3koTEkafogu?= =?us-ascii?Q?lhyfOLIgFBz9lQllEuW/k3u33dzT8pX5VV6bD5nKztztXwU8T/QRjXcMtpSI?= =?us-ascii?Q?jatVh8CGUYSPmlj7AdNFCUBNaoYDzYj23B2Yzsih5aSTjCiLn6fZgIOeRRuZ?= =?us-ascii?Q?p+QnCTNYQXyiJqLvL+Xz4za25AQlVou8CsT7Qs3H7wUAlOGQJ1zMswDYrliJ?= =?us-ascii?Q?kePbAWUI1CCDBBbPMR8CakqSZ7qryt6Zni0wtXTvbb+1wK3C+vg8VEj2qiEV?= =?us-ascii?Q?oHop2SbjkSiKiRQ2+2A5gi7aqjNzZgPHTaSCnYpsnUsgEntgvIUVytiJI124?= =?us-ascii?Q?l/i72tSiRbW42lQkeDHqjuNU0nI+cYQ6x5NWWtBJ4RYaWRRd+St/F0nBkcPF?= =?us-ascii?Q?g8i4ztxRlB7bOxpzhrZhlYtg8TWDOECMcTMlCr4atHYDdI+wzVDqInukForQ?= =?us-ascii?Q?sfdASHaPeo8+vGwS5hEscp7fT38LDNfUHNGNrEmBDtZSF23RILrraUFNYDN6?= =?us-ascii?Q?Q3WKdbVVwxfKoP9Y84ybwGPll3F64EKrjUSFhPE5opuEFEBTjXFANcqCQyGv?= =?us-ascii?Q?DcVisl73xrAnvsLYa400JyMOLpRf8WfwKgen3jJ5f4MHygDMxQWhGUdMw1e7?= =?us-ascii?Q?oXhVha+WXL/3sCZlljDpmWO2fQJz/l5l5o1RtsLHDaTw7Ms4NKyTMqgF1Xlv?= =?us-ascii?Q?vC9cy6HSF/OmCLNV9NWpQPaL1+1FhmRdFZgLos+tAyUePI60vCnGp4dzP6pl?= =?us-ascii?Q?Ew=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 35b05047-54b3-4c04-7331-08dc21bb0549 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jan 2024 17:43:51.0857 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: d5KjWIFVs9Oh9qEsht1+GMu9JUwLtnFub3OW+mIWMO6tdbOwJKXwv2DS/yWi3bVUw5DHgG2UzEy/5Ko3vi8USbPiYZefJA3RC5+G5IV7qXs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4896 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: EYRwppmK6TWygLWxpF6NJNWVx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=BQTLfDqo; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Qingyu, Please split patch so there is one patch per package and=20 make sure the commit message for each commit has Cc: lines for the maintainers of the associated package. Thanks, Mike > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Qingyu > Sent: Monday, January 29, 2024 8:59 PM > To: devel@edk2.groups.io > Cc: Shang, Qingyu ; Tan; Tan, Ming > ; Li; Li, Yi1 > Subject: [edk2-devel] [PATCH v2 1/1] MdePkg: Update ReceiveData and > SendData function description >=20 > From: Qingyu Shang >=20 > Refer to Uefi spec 2.10 section 13.14, update the parameter 'MediaId' > description for EFI_STORAGE_SECURITY_COMMAND_PROTOCOL function > ReceiveData > and SendData. >=20 > Cc: Tan, Ming > Cc: Li, Yi1 > Signed-off-by: Qingyu Shang > --- > MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c | 8 ++++++-- > MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h | 8 ++++++-- > .../Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c | 8 ++++++-- > .../Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h | 8 ++++++-- > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 8 ++++++-- > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h | 8 ++++++-- > MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c | 12 +++++++++--- > MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h | 12 +++++++++--- > MdePkg/Include/Protocol/StorageSecurityCommand.h | 8 ++++++-- > SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c | 8 ++++++-- > 10 files changed, 66 insertions(+), 22 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c > b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c > index a729c087ff5a..67c6389bb8b3 100644 > --- a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c > +++ b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c > @@ -1483,7 +1483,9 @@ AtaDiskInfoWhichIde ( > function shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > @@ -1600,7 +1602,9 @@ AtaStorageSecurityReceiveData ( > shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > diff --git a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h > b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h > index 6bc345f7e777..8906947e28b3 100644 > --- a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h > +++ b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h > @@ -927,7 +927,9 @@ AtaDiskInfoWhichIde ( > function shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > @@ -1007,7 +1009,9 @@ AtaStorageSecurityReceiveData ( > shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c > b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c > index b6ed7f7031b3..e0a85c1cb34e 100644 > --- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c > +++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c > @@ -1699,7 +1699,9 @@ TrustTransferNvmeDevice ( > function shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > @@ -1812,7 +1814,9 @@ NvmeStorageSecurityReceiveData ( > shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h > b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h > index 8cad15efd33a..5547e057e77a 100644 > --- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h > +++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h > @@ -289,7 +289,9 @@ NvmeBlockIoFlushBlocksEx ( > function shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > @@ -369,7 +371,9 @@ NvmeStorageSecurityReceiveData ( > shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > index 670f70caf41f..e79110c14e11 100644 > --- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > +++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > @@ -1897,7 +1897,9 @@ Done: > function shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > @@ -2119,7 +2121,9 @@ Done: > shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h > b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h > index 5a25b55c4952..49a00403695f 100644 > --- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h > +++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h > @@ -677,7 +677,9 @@ ScsiDiskEraseBlocks ( > function shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > @@ -751,7 +753,9 @@ ScsiDiskReceiveData ( > shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > diff --git a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c > b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c > index 39b7c7ce6ef1..61fa740be505 100644 > --- a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c > +++ b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c > @@ -1267,7 +1267,9 @@ EmmcFlushBlocksEx ( > function shall return EFI_DEVICE_ERROR. >=20 > @param[in] This Indicates a pointer to the > calling context. > - @param[in] MediaId ID of the medium to receive > data from. > + @param[in] MediaId ID of the medium to receive > data from. If there is no > + block IO protocol supported > by the physical device, the > + value of MediaId is > undefined. > @param[in] Timeout The timeout, in 100ns units, > to use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function > will wait indefinitely for the > @@ -1454,7 +1456,9 @@ EmmcSecurityProtocolInOut ( > function shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > @@ -1555,7 +1559,9 @@ EmmcSecurityProtocolIn ( > shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > diff --git a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h > b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h > index 2568f0359df3..8c7e5d2675ff 100644 > --- a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h > +++ b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h > @@ -250,7 +250,9 @@ EmmcFlushBlocksEx ( > function shall return EFI_DEVICE_ERROR. >=20 > @param[in] This Indicates a pointer to the > calling context. > - @param[in] MediaId ID of the medium to receive > data from. > + @param[in] MediaId ID of the medium to receive > data from. If there is no > + block IO protocol supported > by the physical device, the > + value of MediaId is > undefined. > @param[in] Timeout The timeout, in 100ns units, > to use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function > will wait indefinitely for the > @@ -337,7 +339,9 @@ EmmcSecurityProtocolInOut ( > function shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > @@ -417,7 +421,9 @@ EmmcSecurityProtocolIn ( > shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > diff --git a/MdePkg/Include/Protocol/StorageSecurityCommand.h > b/MdePkg/Include/Protocol/StorageSecurityCommand.h > index 810af59b85c3..206ae79aff8d 100644 > --- a/MdePkg/Include/Protocol/StorageSecurityCommand.h > +++ b/MdePkg/Include/Protocol/StorageSecurityCommand.h > @@ -59,7 +59,9 @@ typedef struct _EFI_STORAGE_SECURITY_COMMAND_PROTOCOL > EFI_STORAGE_SECURITY_COMMA > function shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > @@ -138,7 +140,9 @@ EFI_STATUS > shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c > b/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c > index 0fb6b1bf41d5..1ee55105e435 100644 > --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c > +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c > @@ -49,7 +49,9 @@ EFI_GUID mOpalDeviceLockBoxGuid =3D > OPAL_DEVICE_LOCKBOX_GUID; > function shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > @@ -148,7 +150,9 @@ SecurityReceiveData ( > shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > -- > 2.39.1.windows.1 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114807): https://edk2.groups.io/g/devel/message/114807 Mute This Topic: https://groups.io/mt/104056966/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-