From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id AFE26740035 for ; Mon, 19 Feb 2024 03:18:56 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=msOarGWx7f1bxtFXoImMscMNel2ek2lL4mgp3xZNfgE=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708312735; v=1; b=KXznWFwIYnCPrUBEJwSbojgDzJzKJPSFEvgsc85rowr5zKImp0V9O6JtWPPmRvXDx2q452BT HWc9Duzl2pgGCNe3OCPPrSeGrEI0X316PeJGw6wGjuRZem8hQrZm77AGioeZ0qeFOgT+pmB47wX 3MWXRdoZapvDxNgXSBEcwlD4= X-Received: by 127.0.0.2 with SMTP id LOfnYY7687511xlT08HXlnDr; Sun, 18 Feb 2024 19:18:55 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mx.groups.io with SMTP id smtpd.web10.33698.1708312734293376659 for ; Sun, 18 Feb 2024 19:18:54 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10988"; a="13087531" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="13087531" X-Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2024 19:18:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="4722073" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa006.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Feb 2024 19:18:53 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 18 Feb 2024 19:18:52 -0800 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sun, 18 Feb 2024 19:18:52 -0800 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 18 Feb 2024 19:18:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TlC+2KbJY9UEH+P4tq5Qv98yrcjQmck6iRx+Z6TyZANUYicsIkQ6UwsMxxIgQF5nlFgKcWYSdTRWgxV0ikxMyQ3rI4zC9kM5EDKq65nIDgzOEC3159V6GMSaOuiPK1QcRdw0XIxrNrdc0i7hTpD0CxNQUJ4k2OGvfXxxdAzq3Kqwua8J611TZz1865MSuZcF68G+2u7Z0LTphRDnFo4xqX6L8DhutdT4VB5ViX7KI5OxZrWEtm2cmNjbv9yPUl52wfUw+j9ZnPs9hnRLu9t+5Xdjo0QZLuXedOGSnPoOQ7612N63OP8grlxLtmtbwmhJBKoi3bOB9d/CibsauPeCtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7B17HJwrxH0SNnf97DyHG1D2gZh5zDR5XOPY4fiqA9g=; b=cIepDf2AouHG8uh32zoBCXSrSQQi67IDxEVG5dwVES2KNAy05AEfrIC1shs9NVAc9Ecn68NhhtWqs8R4ZnBv150i+NU+12ieENzevlVE2itX+S8/rhircsqzBqAa0P6YUz1lOljoLFi/Nc5Ac5Mm40ak4CMt88DDPGm3ebfnQzcLH22t5tBsSwCjhYDHKPnefBGwMT1oWXbifsot10O71savfl6HNknbXw3TPTCTifdcWRZfHOAA9ErruEWDlLtH+N71x5FxTqevk8fF05F4tZkpX3dXYXloyLWehgS2gChZqHYYHsNaWlBQZNnxhT9+3aBqpT0dxWXQuRMAC/ABVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by SJ1PR11MB6201.namprd11.prod.outlook.com (2603:10b6:a03:45c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.32; Mon, 19 Feb 2024 03:18:45 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::7e42:1633:d0a6:9c00]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::7e42:1633:d0a6:9c00%6]) with mapi id 15.20.7292.033; Mon, 19 Feb 2024 03:18:44 +0000 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "Ni, Ray" , "Zhou, Jianfeng" CC: Laszlo Ersek , "Kumar, Rahul R" , Gerd Hoffmann , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: code refine Thread-Topic: [edk2-devel] [PATCH] UefiCpuPkg: code refine Thread-Index: AQHaWjVP4vRqybY9Vka4P19bvT9H77ERDLOAgAADURA= Date: Mon, 19 Feb 2024 03:18:44 +0000 Message-ID: References: <20240208021957.15302-1-jianfeng.zhou@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|SJ1PR11MB6201:EE_ x-ms-office365-filtering-correlation-id: a156b410-8d7c-4ab2-6cb5-08dc30f97b08 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: RqknDjlRBHSRAlHZIcWlmGGjgRz8kxH5OANSE7nh/KWvdDaPzqKmqEOpUXwF8Jp6vRZnrwlnqx3oecf44tiH6JSMrDU8A+u2EI/svT0pMWtn4jWiIX0Y08LBIrS0A40oJTozLB5Fux1xKX9mllgQ9H/smkzzkNyElw5Xfz2b08sicTPiSOuiRM6a66eVTu3KHHXEyWSAa9SV3rCV4IEJdAOMTH+SqLGdvuyGuHDRzbUB8cMxX0kGjhrti0EiJzoDERbt5D2RZSshejNfcGdxTnRsgwniQaCSDOdkzYcGTSOwOvcrGaVgkjXRo7kGQPJy74qARX17X59NzMbj80pJMYNPHO2LJJeVwAC8mDFJMCQvNX14ehw7effXOLHWP9bCFqw0Wo39InyiEEZqmcid8D0oTQufr3pEGSy0yBPe1WdR1F9HAutoi3NEXzoHRTXTEvoKHX0cQP76AsEaxeLvUKkcMlfXtSg+zS7PSIy4hO16T/FrvrUHAGUlBp7kvEV9nxwREfgwD+JLZ8ZCeUks6hIj9ROdKjBtuvTo3A2aZsXwUe3gQHE86EIG/0EMIESuOn4w+p4bhRtFDc+SDBaEdtFwkDUeveH/f8PCixjg4T8= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1xPcpeN0RG6qLHUrC11HmwJV5aShDnhevME+zXUhHRHdv1+jJwIb7wzErEPP?= =?us-ascii?Q?D0y1YMPUl9TcNspDbtGnhvG19m8ThPi307JrzafTcMy08/mN6CXbE0fUQFM4?= =?us-ascii?Q?1qsmesQSlceEfZUUfB9+cKz8gyJGaOeclrp0lKXGVVkwRi1yT04KoW32qQIC?= =?us-ascii?Q?Lqneoz3526Sa2Qn46fSnqDwUPAmpd/0HFhjh4gMIHYFwulauMmc3d4fs540B?= =?us-ascii?Q?3KTSEFAS0oDgpM5OC1rvqPkxSGLeX5Hsy+/tVL9bY9yNfIi6tbtd8WVCWNOr?= =?us-ascii?Q?XrBv+tSUgjSwKZcrvod8BB7pltX+kTXK6DoleBiG8RnrwbBeuqhAnJnvajhJ?= =?us-ascii?Q?X+ZwCTvS7uEsX7xNLm7uXpCu+LkAg0KVClLTtteIZY+baoW1ZfHqCu1+QQCR?= =?us-ascii?Q?37kTOxiLVZq/WAfIKUGYQ5JdVwSNVIiHdxDzPgvAZAaRuOyYqKAHVN/S7qIj?= =?us-ascii?Q?gzMlc0MFnu2mmB842CQRcBqfGbGLrI+GE+2yFDHSpABdwnTbGnuO9lTwzgIb?= =?us-ascii?Q?UZ2oyjgNqdgXbfFTAgEm8fAjItm5Be6qo3JppK1ZsvCteyPwBzxRXowZZGu2?= =?us-ascii?Q?JyGvWXIqsylNdITDpiWJbk6q4vTSjAPTwoad/zCOu4sCrdM6ZfvlCKmDLS7y?= =?us-ascii?Q?jSDZA3rcQTCN6/KjBEp8i4wyAoi33wtdtpCyuD+NGAfVtV9Cko/vYW6PEnyU?= =?us-ascii?Q?7lBzifGKPZRLqqR/ejNpQPucmMyJ3BlpJAQpleaVDBnVAq4UlKfv7cC+yClV?= =?us-ascii?Q?++xI8ERad3gc7jrGFWJd78WyhcMOXsY29RlL83QKiFkN6ZIlT9h0NwAHU8fV?= =?us-ascii?Q?RvHZ9TaJokTsl50Ld5fVs/ceR0wFL2rkcjXLoZhPqdUB+kZTrcVJs3snr79N?= =?us-ascii?Q?HSzVm43UtDYVp1ZiDtmYDE+OM6G9ZXuKJWsdp4OTuBnkGAYub1+70YMxRA6o?= =?us-ascii?Q?VYwUrTPeS+j6m1B/O7qCzwMlMWv3k50ZoytPRr/zo/RjYjKuDx167lpP08TZ?= =?us-ascii?Q?/3dCJhf9W+oXzdZ3qaz4zPNWW8/x483pcxQKXK9JUYSfGO3bqKQtQDFnj11Z?= =?us-ascii?Q?D05Hz4aaL5VS+xNsgqyt8JKk8jKksAsK1Z9/BGjK1ao4uud4uNtOcIrqWTa2?= =?us-ascii?Q?+FpplEeUjvIrxmKD1cr+AqLT7JC9Wene4YAbt2d4Xk84WFAcXHdgylA+QCx3?= =?us-ascii?Q?4czgabWWYaqZqJFo6q4+MdG76H5EjrcZQ7oPAsIdqnD+pkkQK8FHv1I8R3ck?= =?us-ascii?Q?gonRuRKAu8z9Wk5eEbwXwS/q1hnoJyduZudpsGjEJ3riDZ/ulyuyPe7KHdmn?= =?us-ascii?Q?pzXr/nnipYsFmt3emwmiSOCxSvsjI2vQvkSIWWXqz0uMxv/0VBll2DxGN5pN?= =?us-ascii?Q?Ko/Po0PhtS4MwYVb5Gv2HTDSWp4lD9rU/FhNBfSZ/v8e0bZlGyRY4x41NL3k?= =?us-ascii?Q?VZeyTXaj9f6UwSbghyBVyaYixefxevKirHXV+C6/0kZZduSs5Ls/r5SUHSpj?= =?us-ascii?Q?cfQz+Trrzkbb5MBYyVLJc0to4ryQZ5LlbixVxMfO3CStiej9pvedtlNcVHDJ?= =?us-ascii?Q?+KBQHv1QXftrhhrfRUUixBJy4L2ZTyizA7fZKp7m?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a156b410-8d7c-4ab2-6cb5-08dc30f97b08 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Feb 2024 03:18:44.8291 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4pWpm8qI/9YPP/8yHHGRzCCZVgInBQtpf/tyiEaY4UF455Vgnq3NfdE/2KEcFRJI2Neh4k08bM12qr2OddKhi3XtoNRbfwg0uAUH8ylgC/Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6201 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: iSg06mNiWmrvc7AbMDrFnZcyx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=KXznWFwI; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") volatile means do not optimize into a register. The compiler must perform = the actual memory access every time. Mike > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Sunday, February 18, 2024 7:06 PM > To: Zhou, Jianfeng ; devel@edk2.groups.io > Cc: Laszlo Ersek ; Kumar, Rahul R > ; Gerd Hoffmann > Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: code refine >=20 >=20 > > - PleB->Uint64 =3D LocalPleB.Uint64; > > > > + *(volatile UINT64 *)&(PleB->Uint64) =3D LocalPleB.Uint64; >=20 > Jianfeng, > If "volatile" is to tell compiler to generate single "mov" instruction > for > the assignment. >=20 > I am curious how it works in 32bit env where the general purpose > registers are > 32bit width? >=20 > Thanks, > Ray >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115582): https://edk2.groups.io/g/devel/message/115582 Mute This Topic: https://groups.io/mt/104256295/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-