From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id AD7B4D800EA for ; Sat, 15 Jun 2024 01:41:46 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=9umjhrMHKliyASCjuLzKj/N67slcLnr1yEDxycv8Qmo=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1718415706; v=1; b=QdUwjmPaa3b29ZaWqFGIQ2j4GXHDulb4Av3HoORiUnjI0YAUdgmnDHVvXW6jIdDfjmKBsW1Z 2RBUBLuxgGxt5g3iECle8PTrIk4OO+TlQB2/tE0bMCpidjZATcFD+6UruNNHE7tgcuORCN8+vY9 zeeYcVjQgegtSwQeM11it28CCUkJGgAWmQqVtZBnXR4W8dPHk4yJNcbOUhmmv9FosHIkB3DjloZ jXqoGNcDc9ofrxTjZYVyNEfn2OqYvjBCs1jSZYqzPV3qSlbvfxjVbjV4x9wfmuI2jwt1h7EfP2j cBpl0NQspWjoDjvXiWWZf9lknoYVoqM7dW/divDb5ao3A== X-Received: by 127.0.0.2 with SMTP id a1X8YY7687511xNAT8eF0ybu; Fri, 14 Jun 2024 18:41:45 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by mx.groups.io with SMTP id smtpd.web11.4282.1718415703924979178 for ; Fri, 14 Jun 2024 18:41:44 -0700 X-CSE-ConnectionGUID: 0SjTIFwySAmx7zZtZYR0BQ== X-CSE-MsgGUID: LmOVKgTgQ+G8JPAnpHb0lA== X-IronPort-AV: E=McAfee;i="6700,10204,11103"; a="15472932" X-IronPort-AV: E=Sophos;i="6.08,239,1712646000"; d="scan'208";a="15472932" X-Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2024 18:41:43 -0700 X-CSE-ConnectionGUID: skwxoFKDQQeqKuWnOnEPKw== X-CSE-MsgGUID: 7YdgrTt+SI23BEbqlGZj5w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,239,1712646000"; d="scan'208";a="41349269" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 14 Jun 2024 18:41:43 -0700 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 14 Jun 2024 18:41:42 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 14 Jun 2024 18:41:42 -0700 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 14 Jun 2024 18:41:42 -0700 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.44) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 14 Jun 2024 18:41:42 -0700 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by SN7PR11MB7538.namprd11.prod.outlook.com (2603:10b6:806:32b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.25; Sat, 15 Jun 2024 01:41:35 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::a886:6510:729d:f9d0]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::a886:6510:729d:f9d0%4]) with mapi id 15.20.7677.024; Sat, 15 Jun 2024 01:41:35 +0000 From: "Michael D Kinney" To: "Jayaprakash, N" , "devel@edk2.groups.io" CC: Rebecca Cran , "Kinney, Michael D" Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc : add github actions workflow to build PyUEFI using VS2019 Thread-Topic: [edk2-libc Patch 1/1] edk2-libc : add github actions workflow to build PyUEFI using VS2019 Thread-Index: AQHavny89mT5HG1x4UuB6+QDsDVk8bHICzgg Date: Sat, 15 Jun 2024 01:41:34 +0000 Message-ID: References: <20240614170247.1201-1-n.jayaprakash@intel.com> <20240614170247.1201-2-n.jayaprakash@intel.com> In-Reply-To: <20240614170247.1201-2-n.jayaprakash@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|SN7PR11MB7538:EE_ x-ms-office365-filtering-correlation-id: b1c038e6-14bd-4afa-af92-08dc8cdc4a7d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?TgDnpQ67Ua508sw4AtxpH1Ug0PCsb7wp1+b4jgAFhPozVD9sV75Q1/w1B7ai?= =?us-ascii?Q?J16HNnjQn9IKS4oWG+DhVwHtXFgd9vEJ0CTl3Eahus1hKRL/p2dZv1yThmgy?= =?us-ascii?Q?DlTwvbE8Doz8hzHNdH5Mf6KFQhm6w6QecHdbXsaqcVHu0jCfyJfsJdFa09uC?= =?us-ascii?Q?0T0+fEGexU4qBhXo+1hcoWwtnUrlfWZWR6uWgMcxatSfxquNsWy6t/CxG7fw?= =?us-ascii?Q?yY8TP/StuCN79fOBc3zAkw4Z9LAZM+5OSxMyGiyh/JPNSJx5bImXC8OUJAgO?= =?us-ascii?Q?xoAxKK9rstdziUk9UGXL+xUF9ZgrxwY4Fn+EKwSBNxC0ppojxmJRobsSwZom?= =?us-ascii?Q?71XATI74zxEKb0b+maULH8gpdeDMOtx5fIV3DeMfzYIOg/n8h6Olku47o8rW?= =?us-ascii?Q?W4/hjnwlrJDkiaVZ/Tv4v/qD+jEHJvLARHuNXMZUv9bZVfQREJw75iTT8Z7x?= =?us-ascii?Q?/TJQY1XXEGS15eTL+Wybr23hfb1MbTS7AtF4BPJ7JfrxBZv9J7knvZRGo8Ex?= =?us-ascii?Q?oxXHq/HllXOmFg1djPrCIMlZP9NouGzaU7oKYE/MBDxbfJm72uaXmIN8HGD9?= =?us-ascii?Q?a6iUlifHBsBrJL142f7DT0F1pl6guvPbwzsHUilS/e9lH/a3WzZPGDWbv4u/?= =?us-ascii?Q?MUxBrRemRQQTZNlmdHer8N8FjXg+XcW8Md/T3qZiY6zpl42gqa3L4Ccr58vD?= =?us-ascii?Q?PLfZ5BgBOLhQbUu0ef3hhy8uZHpa6iGQf/oc6dM/SEDYDEkNPkNgaK0/+81g?= =?us-ascii?Q?MHsMWEBENpdKGlMIjazRYSsfw8WO+sniKVt4U4+eumPSr72gPSV0rX9VCocw?= =?us-ascii?Q?VTTl1OT2qfhQQOd9Qhupur/a+Ume2d4HxZHCbBlAwCzgNPGWcMn18tmj9yVr?= =?us-ascii?Q?71T+dtFkgvnKmf+97eXykIzQh/w2uqQcDRtt7uIg+67b8uEwJW2bMT22LMhB?= =?us-ascii?Q?Ne10kesTMmeX8+ptld+zJxjb7XSr2BKvyzbhQTi0hBPpYuvuHOhSz4TUIvw8?= =?us-ascii?Q?qS0Ue7TK6XB49MAnqkHRLXo5j8fM7coMwVK4ZrwGTSzoITqdsk1uYhQOoUaz?= =?us-ascii?Q?T4J2GiyeMkVvd6RUoeEiH9qBYzFWYtprnDwMSGVsKI350rEX4Eu5L9yrmzVO?= =?us-ascii?Q?tPA/st4BUreHy79fh4J7Lwu/e5kucYjUZQailq5bMfhQ/xjyXzow03oWV2RZ?= =?us-ascii?Q?23/oIlXQwDG7SC63wTXlTRy4MZHbf3PTokwkP5Du6fXuEzSDCAW+FrwWSzA0?= =?us-ascii?Q?Pnr7dD28UcO9AwCcztc78f/gSedCBYHPxOqNifTJjiUq8W90fNzi6sbAZLH8?= =?us-ascii?Q?JhwXurX31FIj37f9U1Qloa6R?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8OmwJ4x34a6QjJpUE9hHJNbD4bGCaZRIQLxCDAEIDPzjAmDvl3/Ld01q67oY?= =?us-ascii?Q?to6Ij2K7lhKnHkYdzI4JxLHpkX8VOAjzgfUb922mSP4HUrb3olYaCwx2v1hd?= =?us-ascii?Q?Sd1DuVNy5yeiBzvV6EZXsIMG5vairQINUxqLlk8tHStaDoD+GfZCaqd1KygR?= =?us-ascii?Q?JRFbDwUrWdCEEtqAsjoeURZxB7yZAff2kDIIs/Y/5PnHfu8YtkV+Uw0ApnhN?= =?us-ascii?Q?zy2/pjVkHIE4cNhzg2iktLjzMHpXtuTWakKECPUewbIVnT4vYqE02aTDAJDl?= =?us-ascii?Q?m70rDUfcNjXOohI2wAzc39pMceef2XejjFiV6PHkmzCfwLFTmo/AVN5KVH2z?= =?us-ascii?Q?ZDM6xfdrF+g1GZUqhoOj/Llw9pIY6sKjvtPT+aYnq/0f+Zje6r91KHaWFXqA?= =?us-ascii?Q?sQonYlQoO47fd0NU0Qd7EmFgzop3Tx4xby5Xhnc1qgsPSRWRLTULOk7RemoC?= =?us-ascii?Q?y3KvOSYOm8u8uifWBOV/8binLaE7/SbRh84tsGzEQfvfkTtdlpEDAQnOwK/l?= =?us-ascii?Q?pcQuV8ur9UAH0DuknvHcundfe3cnhdTOsQ/t64S42Nr9rOjWdsb/3ESXnxeg?= =?us-ascii?Q?CyWVn7YSOv7n8TCJrYdmrkN1v3fRNjlDwKB8w+4SNGrqUkldx9XJvuH9kst7?= =?us-ascii?Q?oCrW+b7cuoymAjgc7upzJbWZie5VNiQ0d3+y1RLEY4cbjjiVrvUgD/ajk57L?= =?us-ascii?Q?Jl7LAowQ+iMauLY8MueaXruOT3AMf/mgVYVKjCqNjBDTPrUT4dXthVgRvHkx?= =?us-ascii?Q?oJxHB6gujd8aMNCVZu7dz104QNHARFs6M6CLX78wetEm2B/8KJ8sy+JS4Rzb?= =?us-ascii?Q?eHEgYlRcmrN9f4P4iXX7kM5sq+jOeiTg9utPQabYI6ju7VESidSJ2CZlO5re?= =?us-ascii?Q?T2WgVw8mzL4JKryTAMW2epiHVa2GdwWW0p9xqEGsaMD5O5IMXxPOv6sCLuXS?= =?us-ascii?Q?PZJGkzKQSRoTFntHUdY9K+fuzMuEYksffETCbN8IlSfdfiX+3bojxp+jC6Up?= =?us-ascii?Q?EAsc/CSmPsd9sTMTxBxlpvbvONFlxQj/oj1kGOcjOC8kr7+v5vDmJ2PbuMgf?= =?us-ascii?Q?oAQY/bAOtwbt4OsAylmwII/xlOhDp6FCyHEO7NeRaTMmI8epuFttW9cbMEJ3?= =?us-ascii?Q?qMi9ZCCZAYDj5KcMpb7Hx4mkEb+J1mbbN4yo8KJYDuE1BadMFr669g8Bqk6J?= =?us-ascii?Q?K8BpIxbpJlnUCkCv0DFkwmzEgGcrXQpMZMH+vRwRemaH/G5ykcz6S6KCLEO+?= =?us-ascii?Q?iM5IHcIW2fxuFKIELpl4XDfi8xD1IsvsZRzHmxtmUP+gNqjRrBaSb/WbuNeq?= =?us-ascii?Q?Plbw+FU1Au92mHRgL0p/LriK5bjoEH+/q8xD6weqhXw7JmbtDnsmF+eU2IQd?= =?us-ascii?Q?gW55DiE78tnYfH5xfoWae5JB5VcRvenV6aEhfuVChA1HNy8g0f1lZNLdxhXJ?= =?us-ascii?Q?zGN/dRcHsLcyQuF08ziPpEMGyU7EGClCWSman2n3/Tiq9bPG16kD6ut2GK9B?= =?us-ascii?Q?zJLFW+S1oGJ0q40ELZZoiqTPjs3e2Qv35/ciWZLP0+vn7S1qTwqzqljhjRuE?= =?us-ascii?Q?qZGhd/it/PlfimK3Xv/aRWdZRnBRXZsQGHQaLQSZ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1c038e6-14bd-4afa-af92-08dc8cdc4a7d X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2024 01:41:34.9826 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: t3ZcWoH0ccgPg+JieZexW6kjKJ+N99OtYk9w/A1gwrth8RihvngJeOXc9L30zXUSA84YaEzjRKCE9SPcrdDklVi4+UhQFFQbQYMxVCtzZ6c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7538 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 14 Jun 2024 18:41:44 -0700 Resent-From: michael.d.kinney@intel.com Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: YJpi8QqZgo9QQB5P0ujKthkJx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=QdUwjmPa; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) Comments below. Mike > -----Original Message----- > From: Jayaprakash, N > Sent: Friday, June 14, 2024 10:02 AM > To: devel@edk2.groups.io > Cc: Jayaprakash, N ; Rebecca Cran > ; Kinney, Michael D > Subject: [edk2-libc Patch 1/1] edk2-libc : add github actions workflow to > build PyUEFI using VS2019 >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4788 >=20 > This commit adds github actions workflow to build python uefi > interpreter with visual studio 2019 tool chain. > The build-python-uefi-vs.yaml file under .github/workflows > implements the build action for building the pyuefi interpreter > with VS2019 tool chain. There is also a supporting python script > under .github/scripts folder which is used to uncomment the python > uefi related .inf file in AppPkg.dsc file. >=20 > Cc: Rebecca Cran > Cc: Michael D Kinney > Cc: Jayaprakash N > Signed-off-by: Jayaprakash N > --- > .github/scripts/enable_pyuefi_apppkg.py | 31 ++++++++ > .github/workflows/build-python-uefi-vs.yaml | 84 +++++++++++++++++++++ > 2 files changed, 115 insertions(+) > create mode 100644 .github/scripts/enable_pyuefi_apppkg.py > create mode 100644 .github/workflows/build-python-uefi-vs.yaml >=20 > diff --git a/.github/scripts/enable_pyuefi_apppkg.py > b/.github/scripts/enable_pyuefi_apppkg.py > new file mode 100644 > index 0000000..37b9e0a > --- /dev/null > +++ b/.github/scripts/enable_pyuefi_apppkg.py > @@ -0,0 +1,31 @@ > +'''Script to enable the build of python UEFI interpreter > + in AppPkg.dsc file > +''' Copyright and License missing > +import os > + > + > +script_path =3D os.path.abspath(__file__) > +script_dir =3D os.path.dirname(script_path) > + > +# path to the AppPkg.dsc file > +path_to_AppPkg_dsc =3D os.path.join(script_dir, '..', '..', 'edk2', 'App= Pkg', > 'AppPkg.dsc') > +print('Path to AppPkg dsc file : ', path_to_AppPkg_dsc) > + > +# Check if the file exists > +if not os.path.isfile(path_to_AppPkg_dsc): > + print(f"The file {path_to_AppPkg_dsc} does not exist.") > +else: > + # Read the content of the file > + with open(path_to_AppPkg_dsc, 'r') as file: > + lines =3D file.readlines() > + > + # Uncomment the line containing "Python368.inf" > + with open(path_to_AppPkg_dsc, 'w') as file: > + for line in lines: > + if 'Python368.inf' in line and line.strip().startswith('#'): > + # Uncomment the line > + file.write(line.lstrip('#')) > + else: > + file.write(line) This is complicated to edit a DSC file. Can this INF be uncommented in thi= s DSC file or add another DSC files that is only used for this workflow to build python that has this INF uncommented. Then this extra python script can be removed. > + > + print(f"The file {path_to_AppPkg_dsc} has been updated.") > diff --git a/.github/workflows/build-python-uefi-vs.yaml > b/.github/workflows/build-python-uefi-vs.yaml > new file mode 100644 > index 0000000..aa5c317 > --- /dev/null > +++ b/.github/workflows/build-python-uefi-vs.yaml > @@ -0,0 +1,84 @@ Copyright and License missing > +name: Build Python Interpreter for UEFI using VS2019 > + > +on: [push, pull_request] > + > +jobs: > + build: > + runs-on: windows-2019 > + env: > + NASM_PREFIX: "C:\\Program Files\\NASM\\" > + defaults: > + run: > + shell: cmd > + > + steps: > + - name: Checkout repository > + uses: actions/checkout@v4 > + > + - name: Setup Python > + uses: actions/setup-python@v5 > + with: > + python-version: '3.10' > + > + - name: Install NASM > + run: choco install nasm > + > + - name: VSWhere > + run: | > + "C:\Program Files (x86)\Microsoft Visual > Studio\Installer\vswhere.exe" > + > + - name: Setup environment for Visual Studio 2019 Build Tools > + run: | > + "C:\Program Files (x86)\Microsoft Visual > Studio\2019\Professional\VC\Auxiliary\Build\vcvarsall.bat" x86 > + set > + > + - name: Clone EDK2 > + run: | > + git clone https://github.com/tianocore/edk2.git" > + cd edk2 > + git submodule update --init > + > + - name: Copy edk2-libc contents to edk2 > + run: | > + dir > + cmd /c xcopy /E /I /Y AppPkg edk2\AppPkg > + cmd /c xcopy /E /I /Y StdLib edk2\StdLib > + cmd /c xcopy /E /I /Y StdLibPrivateInternalFiles > edk2\StdLibPrivateInternalFiles Use PACKAGES_PATH instead of copying files into edk2 repo > + > + - name: Build EDK2 Base Tools > + run: | > + cd edk2 > + dir > + edksetup.bat ForceRebuild > + > + - name: Enable python368.inf file in AppPkg.dsc > + run: | > + cd .github\scripts > + dir > + python enable_pyuefi_apppkg.py See comment above to remove this script. > + > + - name: Build Python UEFI > + run: | > + cd edk2 > + call edksetup.bat > + cd AppPkg\Applications\Python\Python-3.6.8\ > + python srcprep.py > + cd ..\..\..\..\..\ > + build -t VS2019 -a X64 -b RELEASE -p AppPkg\AppPkg.dsc > + > + - name: Create Python UEFI package > + run: | > + dir > + cd edk2\AppPkg\Applications\Python\Python-3.6.8\ > + dir > + call create_python_pkg.bat VS2019 RELEASE X64 myUEFIPy > + > + - name: List build artifacts > + run: | > + dir /S edk2\myUEFIPy > + > + - name: Upload build output as artifact > + uses: actions/upload-artifact@v4 > + with: > + name: myUEFIPy-build-VS2019-output > + path: edk2\myUEFIPy\**\* > -- > 2.45.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119580): https://edk2.groups.io/g/devel/message/119580 Mute This Topic: https://groups.io/mt/106674325/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-