Re: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to ADDDEBUGFLAG in tools_def.txt

["Michael D Kinney" <michael.d.kinney@intel.com>]

Hi Liming,

Potentially.  I have not observed a failure with that one.  It may be an OBJCOPY specific issue.

Mike

> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Friday, May 5, 2023 10:40 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io
> Cc: 'Rebecca Cran' <rebecca@bsdio.com>; Feng, Bob C
> <bob.c.feng@intel.com>; Chen, Christine <yuwei.chen@intel.com>
> Subject: 回复: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to
> ADDDEBUGFLAG in tools_def.txt
> 
> Mike:
>   I also see GCC_DLINK2_FLAGS_COMMON option uses / as the file path. Does
> it bring the same problem in Windows OS?
> 
> DEFINE GCC_DLINK2_FLAGS_COMMON     = -Wl,--
> script=$(EDK_TOOLS_PATH)/Scripts/GccBase.lds
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Kinney, Michael D <michael.d.kinney@intel.com>
> > 发送时间: 2023年5月6日 12:55
> > 收件人: Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> > 抄送: 'Rebecca Cran' <rebecca@bsdio.com>; Feng, Bob C
> > <bob.c.feng@intel.com>; Chen, Christine <yuwei.chen@intel.com>; Kinney,
> > Michael D <michael.d.kinney@intel.com>
> > 主题: RE: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to
> > ADDDEBUGFLAG in tools_def.txt
> >
> > The issue I saw was a mix of / and \ in the file path.  On Windows
> > $(DEBUG_DIR) would
> > Have '\' in path and then a '/' before $(MODULE_NAME).  Without the
> > quotes, this
> > would generate an error.  With quotes, it would get the full filename
> correct.
> >
> > On Linux, only '/' are used for the whole path and everything works with
> and
> > Without quotes.
> >
> > Mike
> >
> > > -----Original Message-----
> > > From: gaoliming <gaoliming@byosoft.com.cn>
> > > Sent: Friday, May 5, 2023 8:01 PM
> > > To: devel@edk2.groups.io; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > > Cc: 'Rebecca Cran' <rebecca@bsdio.com>; Feng, Bob C
> > > <bob.c.feng@intel.com>; Chen, Christine <yuwei.chen@intel.com>
> > > Subject: 回复: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to
> > > ADDDEBUGFLAG in tools_def.txt
> > >
> > > Mike:
> > >   Do you mean $(DEBUG_DIR)/$(MODULE_NAME).debug file path may
> > have
> > > space on
> > > windows OS? Does the workspace directory include the space?
> > >
> > > Thanks
> > > Liming
> > > > -----邮件原件-----
> > > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Michael
> > D
> > > > Kinney
> > > > 发送时间: 2023年5月6日 10:47
> > > > 收件人: devel@edk2.groups.io
> > > > 抄送: Rebecca Cran <rebecca@bsdio.com>; Liming Gao
> > > > <gaoliming@byosoft.com.cn>; Bob Feng <bob.c.feng@intel.com>; Yuwei
> > > Chen
> > > > <yuwei.chen@intel.com>
> > > > 主题: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to
> > > > ADDDEBUGFLAG in tools_def.txt
> > > >
> > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4448
> > > >
> > > > Update tools_def.txt to add quotes around the file target in
> > > > OBJCOPY_ADDDEBUGFLAGS for compatibility with GCC like tool
> > > > chains used on Windows.
> > > >
> > > > Cc: Rebecca Cran <rebecca@bsdio.com>
> > > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > > Cc: Bob Feng <bob.c.feng@intel.com>
> > > > Cc: Yuwei Chen <yuwei.chen@intel.com>
> > > > Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> > > > ---
> > > >  BaseTools/Conf/tools_def.template | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/BaseTools/Conf/tools_def.template
> > > > b/BaseTools/Conf/tools_def.template
> > > > index 1b3a9e7a540a..535dda1d5d99 100755
> > > > --- a/BaseTools/Conf/tools_def.template
> > > > +++ b/BaseTools/Conf/tools_def.template
> > > > @@ -731,9 +731,9 @@ NOOPT_VS2019_AARCH64_DLINK_FLAGS   =
> > > > /NOLOGO /NODEFAULTLIB /IGNORE:4001 /OPT:REF
> > > >  *_*_*_OBJCOPY_FLAGS             = objcopy not needed for
> > > >  *_*_*_SYMRENAME_PATH            = echo
> > > >  *_*_*_SYMRENAME_FLAGS           = Symbol renaming not
> > needed for
> > > > -DEBUG_*_*_OBJCOPY_ADDDEBUGFLAG     =
> > > > --add-gnu-debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug
> > > > +DEBUG_*_*_OBJCOPY_ADDDEBUGFLAG     =
> > > > --add-gnu-debuglink="$(DEBUG_DIR)/$(MODULE_NAME).debug"
> > > >  RELEASE_*_*_OBJCOPY_ADDDEBUGFLAG   =
> > > > -NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG     =
> > > > --add-gnu-debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug
> > > > +NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG     =
> > > > --add-gnu-debuglink="$(DEBUG_DIR)/$(MODULE_NAME).debug"
> > > >  *_*_*_OBJCOPY_STRIPFLAG            = --strip-unneeded
> > -R .eh_frame
> > > >  *_*_*_DTC_FLAGS                    = -H epapr
> > > >  *_*_*_DTCPP_PATH                   = DEF(DTCPP_BIN)
> > > > --
> > > > 2.40.1.windows.1
> > > >
> > > >
> > > >
> > > > 
> > > >
> > >
> > >
> 
>