From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id AF929740035 for ; Sun, 29 Oct 2023 17:22:41 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=rDsFao5bQFEv1VOhfPLUme2A0orKaT1oiDMrOqcAAew=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698600160; v=1; b=JYb4eH2lLArVP7oeqJo0cNB27TPGyRUL8+BWcKcSN7CVJt37PuM/KTrlq8JYSBfCUfY/tLBF MsGHjz7kVd0fh2lHinX0vHZYhe+2SDEFWqJUe1qHr32j2l28Yt5DB0M2kWBf5PsjSdyk6+0gwv3 pasOb3sBXUtEXfErBLqs3w+k= X-Received: by 127.0.0.2 with SMTP id CqgcYY7687511xe4D3RJuI8C; Sun, 29 Oct 2023 10:22:40 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.76639.1698600159392860864 for ; Sun, 29 Oct 2023 10:22:39 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10878"; a="368182512" X-IronPort-AV: E=Sophos;i="6.03,261,1694761200"; d="scan'208";a="368182512" X-Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2023 10:22:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,261,1694761200"; d="scan'208";a="1265578" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 29 Oct 2023 10:22:01 -0700 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Sun, 29 Oct 2023 10:22:37 -0700 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Sun, 29 Oct 2023 10:22:37 -0700 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Sun, 29 Oct 2023 10:22:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ahB5G2NtEw9yoCB9zL4Dsu8q7f93kyXgbgE4b4R7MhweIyKi7FWQQYahzqNtWaVEg2Q3+xAGGbokzf9Q7DhCpM2KB+tuYltUl7lLeW3/uKz6GszXqFZAYFvjO0xlLGQlVBJrrwpIIPwo8Fr8AZVTy7xZhNfe2qFj9Ts+peFH9xnuDO04WDTo0ToqbWG9XmfxRL3/SLv8nh6ILW6mmUv1ojOY6hMvyn7Xc03AD6TGloAEPYSfl7UpwyRsz68AtteNSY0AMqmQXINaRB0YTf9Oukqg3CHgSGHr1Mw1QDIqDXzKuvyB1rDCaQMNYtoDjIkRegy1ruidQomjhBYHm7QV3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B/UsiAsrw4XtYMSNQwCYDrwwkR8S+3X1bwBP4VvVFg4=; b=DRhaEFLm3p5cB9Eob6VQpRu5sGWqDo1Fy9i9TvfMg+rh5boPb4kOEkO6DrctTZn9VqthVYQVPcpgfx4mUeZHyXXcDJy5dEd76jnQ9dXrleQEWZGYbjigXYqZyuZN89k9hMu+/uq/cvX6iVDwUjHiBgxoqdqUtArxVEg3jkHozcVOsg10tuSLkPnC5lLuWWPfVNnUbe91ToIUqJiGaj+ocQON98wyYZk7ZlxAl41L5k9sse9VrhXQDoq138rg0dZTrQS5d5qG/e/xhvwxa47mg2VEFiGbRPJIM970eLpCGtO5RAMhsexWnLUh0m61MQWRqV86rn0d3urBhKG/WOAM0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by PH0PR11MB4869.namprd11.prod.outlook.com (2603:10b6:510:41::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.26; Sun, 29 Oct 2023 17:22:35 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::5f:5822:ba16:efe5]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::5f:5822:ba16:efe5%7]) with mapi id 15.20.6933.027; Sun, 29 Oct 2023 17:22:35 +0000 From: "Michael D Kinney" To: "Yao, Jiewen" , "jejb@linux.ibm.com" , Laszlo Ersek , "devel@edk2.groups.io" , "pedro.falcato@gmail.com" CC: Andrew Fish , Leif Lindholm , "Warkentin, Andrei" , "West, Catharine" , "Bi, Dandan" , "Daniel Schaefer" , David Woodhouse , "De, Debkumar" , "Dong, Eric" , "Jiang, Guomin" , "Wu, Hao A" , "Wang, Jian J" , "Justen, Jordan L" , Julien Grall , Peter Grehan , "Zhang, Qi1" , "Ng, Ray Han Lim" , Stefan Berger , "Hou, Wenxing" , "Lu, Xiaoyu1" , "Kinney, Michael D" Subject: Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members Thread-Topic: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members Thread-Index: AQHaCeM1zTQPTedGNkOdIhsjQrMDwrBgCBiAgABhb4CAAF/YgIAAH/mAgAAFQgCAAAa2gIAAD0ag Date: Sun, 29 Oct 2023 17:22:34 +0000 Message-ID: References: <20231028192330.1031-1-michael.d.kinney@intel.com> <99615ab9-f669-5ac8-fafd-f154e8af5da8@redhat.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|PH0PR11MB4869:EE_ x-ms-office365-filtering-correlation-id: 4fa26767-bb4d-4563-b27e-08dbd8a3a3e0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: EUlcmKNgntqMezvZZxmk12DVftNIW9zcHbljWbONw/j0O0xpo93nQm2luYJqOMgHc7IYp6erPUXRBHS2AZfzVUrCL5KatTX044HUbBdPesn7Ixn0Rz3m9eXdwKLeoH0ztNxOgVr31/gU+PZuooT/HYnYB5zDCs4ztE3Wn70eLbajIh/rYUaxYTdzKF89nZqkKQcJIsACaFY8pR/oo3N4SZMXMQsl6ftRj7Z1tn6R3oWhSNTfQx1ST+E8/nkK1+v9XKPXa0LwRrz08eEOqwDQOhiF+VPtpe/BLuSgek6rGnnIIJycZvA+whqM0ukPYUDCdf5oFeJDZ5dsuuSMrtR+C+n6TfHf352rGuPLa7TR5srWemAUtPW7n4YUT5QF+Mpc15l05oetRuGIohL3ycAp715MjFLiV4eupxIzqagyh3EV0v0CmqPP6en/25IOtAMJIrcfERtBFIqXSiNQgjlas0G4FZKZwHRsDBSlQzvnBBgRt6PyDTCheAePZA+uY2k/NrZE6lVXoSQk8IgTjJlYNR6nynpjDrVXTNs/+pd7r1clG8/SU6bpaEmhe4W3ZPIpGdonbuxgFak9vx44zU2oxbmFvx5KheI4EhcweQbmQQk= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?B8qnRL0cqfWlS3mErTpShAOKuB8mrwNWYR2edbYUPDwKAzVaM32wHMfGukpw?= =?us-ascii?Q?cMoHmrZBO76JpX/GfJbrly33sNnEDVpIRNRXhWoa3OOd4WePlj/yycdUlrGP?= =?us-ascii?Q?laKQDManNuVwpCMFs92bwWhEPbAVtJiwV8kx8vPBchPVTbhzczoP4M3w13+2?= =?us-ascii?Q?5zWuZCURV1l2CzFcHyeYhuO0rbdr7KxbvUzmJPdVGlswfwfses3I1hzUbUn2?= =?us-ascii?Q?7NCivLVt/PlMemdpCDhthC6eVxcmyvGBwFT8xx3NjtEUM8V2PB/Gov1N540X?= =?us-ascii?Q?sjIYnJiBqOEp5zTbF0dBvprWIy8rQfKBga0PuRQnrFN4+xomSGgbxea6FNgZ?= =?us-ascii?Q?kp3gt/hsc/m2TUb8Qdfvb2j+liIlPNOYRgrRFZt6KJ5V28DIzhO+utmidOO2?= =?us-ascii?Q?J3pj5hMYtl+7WyAJcGGx0ixaqPkS20UnMpFjRJr1CJM5qweSSXSQ1/m2nglS?= =?us-ascii?Q?hk0/1Mi09CLjfEagypry9uX0T2CT2jn2tVy44l6hbJSfwgWP190n8ASYH0sK?= =?us-ascii?Q?izstj4tL9P8SYVlQ2YL7F3ZwtkWuPFE6mUvhf+nZQzGvCJ5/Q573zVpS3ZSY?= =?us-ascii?Q?ke83XPI1NWpBYN0PrQ5p0Gdkw9HvLoGYa34LHRSKTqqsXL8Ak9TSNbNJPZ0E?= =?us-ascii?Q?8Af8LXNvudOHDwXTsGB4rSEI8Rc1j7ix+s/au487xLdmKzZwFTMR95aZ6o2w?= =?us-ascii?Q?JIOuyFBehAm8iHxUsoiy35c5bI953To9XodmoFgqP//DuJJ8vIA5ZsC27Ymz?= =?us-ascii?Q?2QpuNAsX//FgmjqI8oFsOuif2F9D6z0eBFO6fh+uwbol78y6h3Po0vOS+C97?= =?us-ascii?Q?XcURr4usDGkINPUpfur6omLhujmqh1rLPw+9UAW9bzRdkpS829AH0oJkxi++?= =?us-ascii?Q?NFZcsW7ZZCjlsBmQmi+aA7IxgX0qRz/jYSLcvUPCl7wmza7QSpq8g/8Nw6Es?= =?us-ascii?Q?tmtVb64amMFg9vv9ZL7sqwLQ4GNCGzsGdTrY6YcUe55OwE1J0YpX6msQYPqz?= =?us-ascii?Q?uX147zqcN8o+oGQE3Nr9NWu1SMD+b4SHkIb2k1cLEIgNkTSXaKaGOU1URoNK?= =?us-ascii?Q?xRShh5Zzod9q6P/p+vo+SN53+d7M8FynQkDg1VdE8vcLdatO0tC6x7+0cB6L?= =?us-ascii?Q?0Hd6Bvi7o22kQacEiYYGMavMyq8yrP9l6i/inOoS+XKBQbGsgEELrgaNbswJ?= =?us-ascii?Q?42zAMtQD4BELpLuam/RbwmIoWY2px0yfY4tgax1wd/25Vq4/iN4ROKKed2Un?= =?us-ascii?Q?YzY7C1/mNKE4HRDNhgphCaO4uaqKiki+piVCodjZZVXuwW18g3uLhC8enC2o?= =?us-ascii?Q?RFF51FId52OgjjbPqgMfczmqovkA77LA+R5b8vWmyMQnKTxlRJnW4QMgXzfT?= =?us-ascii?Q?wkQj6pXu2L1vS9ANyakpMAaqjAYVWek9GzAantN8fcwJBRcQWem1zRkh/CTe?= =?us-ascii?Q?N+qFuS6IZZC3Vv6cetabCHCoOaWHsvmy3c7mhBAFt/xLg8q8Qw6dHhBEVLQv?= =?us-ascii?Q?99w2EVX2qZi3MDLKgOw484sVTuj268ISliDT8YGMFPUhLREBN8NBnUeSGNKY?= =?us-ascii?Q?3uyeXiSehLsMSPrGvGMWJv4dB27oYvXk7XYQiUtT?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4fa26767-bb4d-4563-b27e-08dbd8a3a3e0 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2023 17:22:34.3247 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0hh43A868Fh4Jfey0NbtjXCMEY4XWssxo/SmanXXfSrnnlZ7YLHRY0dT4/38qdYeE9d6P5zstwH2kAdwxDPykCFA3tN5FXtKj9dqi6q7Oy0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4869 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 8L8mGgvHxjvG55c5gEiI7QQgx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=JYb4eH2l; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") This is the Wiki page where TianoCore documents the TianoCore community member roles. https://github.com/tianocore/tianocore.github.io/wiki/TianoCore-Who-we-are We can update/edit as needed to accurately reflect what all the Maintainers and Reviewers agree are their roles and responsibilities as assigned in Maintainers.txt. Thanks, Mike > -----Original Message----- > From: Yao, Jiewen > Sent: Sunday, October 29, 2023 9:26 AM > To: jejb@linux.ibm.com; Laszlo Ersek ; > devel@edk2.groups.io; pedro.falcato@gmail.com; Kinney, Michael D > > Cc: Andrew Fish ; Leif Lindholm > ; Warkentin, Andrei > ; West, Catharine > ; Bi, Dandan ; Daniel > Schaefer ; David Woodhouse > ; De, Debkumar ; Dong, > Eric ; Jiang, Guomin ; > Wu, Hao A ; Wang, Jian J ; > Justen, Jordan L ; Julien Grall > ; Peter Grehan ; Zhang, Qi1 > ; Ng, Ray Han Lim ; > Stefan Berger ; Hou, Wenxing > ; Lu, Xiaoyu1 > Subject: RE: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on > active community members >=20 > OK. Maintainer should do code review. I have no doubt on that. >=20 > My confusion is about "reviewer" role. What is criteria and what is > responsibility? >=20 > Are you saying that "reviewer" just means that someone raised the hand > and said: "I want to be notified", and there is no expectation that > he/she would review the patch? >=20 > I would like to understand more on how that works and what that means. > Would you please give a URL for the reviewer definition in Linux > Kernel? >=20 > Thank you > Yao, Jiewen >=20 >=20 >=20 > > -----Original Message----- > > From: James Bottomley > > Sent: Monday, October 30, 2023 12:02 AM > > To: Yao, Jiewen ; Laszlo Ersek > ; > > devel@edk2.groups.io; pedro.falcato@gmail.com; Kinney, Michael D > > > > Cc: Andrew Fish ; Leif Lindholm > ; > > Warkentin, Andrei ; West, Catharine > > ; Bi, Dandan ; Daniel > > Schaefer ; David Woodhouse > ; > > De, Debkumar ; Dong, Eric > ; > > Jiang, Guomin ; Wu, Hao A > ; > > Wang, Jian J ; Justen, Jordan L > > ; Julien Grall ; Peter > Grehan > > ; Zhang, Qi1 ; Ng, Ray Han > Lim > > ; Stefan Berger ; > Hou, > > Wenxing ; Lu, Xiaoyu1 > > Subject: Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based > on active > > community members > > > > On Sun, 2023-10-29 at 15:42 +0000, Yao, Jiewen wrote: > > > > I'd say that's pretty close. A reviewer role is a request for > > > > keeping > > > > the reviewer in the loop. > > > > > > [Jiewen] I am disappointed on that. > > > To me, that is NOT a real reviewer. See below description on what > is > > > "code review". > > > https://google.github.io/eng-practices/review/ > > > https://about.gitlab.com/topics/version-control/what-is-code- > review/ > > > > Well, that's what someone's view of what a patch review should > consist > > of, not what a reviewer's role in MAINTAINERS should be. > > > > In general, you really don't want to force people to review patches, > > because you'd like a reviewer to be familiar with the area and > > comfortable with the patch. So are you saying that anyone listed as > a > > reviewer in a particular area should be capable of reviewing any > patch? > > and further that they should be expected to review every patch? > > Because that's definitely not what the R role in the Linux Kernel > would > > mean. > > > > I know that's not what happened to me in Confidential Computing, > > because I had a very specific area around SEV and SEV-ES secret > > injection and really had no familiarity at all with say the memory > > acceptance patches. > > > > > Our definition seems more like *a notification receiver*, instead > of > > > a real code reviewer. I would say, it is a very misleading > > > definition. > > > > Actually, I wouldn't, but then I'm more coming from a Linux Kernel > > background. To us, the reviewer list is simply a list of people git > > blame might not find who might have the expertise to review the > patch > > but on whom there would be no expectation that they would review the > > patch. > > > > James -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110272): https://edk2.groups.io/g/devel/message/110272 Mute This Topic: https://groups.io/mt/102245264/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-