public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: Rebecca Cran <rebecca@bsdio.com>, Sean <spbrogan@outlook.com>,
	"Michael Kubacki" <mikuback@linux.microsoft.com>,
	Joey Vagedes <joeyvagedes@microsoft.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] Fixing edk2-basetools CI
Date: Mon, 12 Feb 2024 06:03:28 +0000	[thread overview]
Message-ID: <CO1PR11MB4929CA619F82973179347C6FD2482@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <f92f2b03-8578-449e-b996-b5bddc26eb95@bsdio.com>

Hi Rebecca,

Thank you for working on this.

If pyproject.toml is added, then can setup.py be removed completely?

Also, the CLI commands for pyproject.toml are listed as edk2_build and
edk2_ecc.  Can't we use this feature of pyproject.toml to add build
and ecc to the command set and remove the need for the command 
wrappers? Perhaps an additional change after we have CI working?

Thanks,

Mike

> -----Original Message-----
> From: Rebecca Cran <rebecca@bsdio.com>
> Sent: Sunday, February 11, 2024 8:15 PM
> To: Sean <spbrogan@outlook.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Michael Kubacki
> <mikuback@linux.microsoft.com>; Joey Vagedes
> <joeyvagedes@microsoft.com>
> Cc: devel@edk2.groups.io
> Subject: Fixing edk2-basetools CI
> 
> Hi everyone,
> 
> 
> I've created a couple of PRs in the edk2-basetools project which I'm
> hoping will go towards fixing the CI and allowing releases to be
> published again.
> 
> I'd appreciate any reviews.
> 
> 
> Disable flake8: https://github.com/tianocore/edk2-basetools/pull/115
> 
> Add pyproject.toml and update setup.py:
> https://github.com/tianocore/edk2-basetools/pull/116
> 
> 
> Once CI is working again, I'll start working through the backlog of
> open
> PRs.
> 
> 
> --
> Rebecca Cran



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115348): https://edk2.groups.io/g/devel/message/115348
Mute This Topic: https://groups.io/mt/104306226/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2024-02-12  6:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-12  4:14 [edk2-devel] Fixing edk2-basetools CI Rebecca Cran
2024-02-12  6:03 ` Michael D Kinney [this message]
2024-02-12 11:26   ` Rebecca Cran
2024-02-12 16:08     ` Joey Vagedes via groups.io
2024-02-12 16:42       ` Rebecca Cran via groups.io
2024-02-12 17:06         ` Joey Vagedes via groups.io
2024-02-13 19:27           ` Rebecca Cran
2024-02-13 19:42             ` Joey Vagedes via groups.io
2024-02-13 19:46               ` Rebecca Cran
2024-02-16  7:51               ` Rebecca Cran
2024-02-16 17:24                 ` Michael D Kinney
2024-02-23  7:55                   ` Yuwei Chen
2024-02-23 14:48                     ` Rebecca Cran
     [not found]                     ` <17B6855E281DBF07.24621@groups.io>
2024-02-23 22:40                       ` Rebecca Cran
2024-02-27  1:49               ` Rebecca Cran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB4929CA619F82973179347C6FD2482@CO1PR11MB4929.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox