public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"ardb@kernel.org" <ardb@kernel.org>,
	"Palomino Sosa,
	Guillermo A" <guillermo.a.palomino.sosa@intel.com>
Cc: "Ni, Ray" <ray.ni@intel.com>,
	"Chen, Christine" <yuwei.chen@intel.com>,
	"Feng, Bob C" <bob.c.feng@intel.com>,
	"Gao, Liming" <gaoliming@byosoft.com.cn>,
	"Oram, Isaac W" <isaac.w.oram@intel.com>,
	"Sean Brogan" <sean.brogan@microsoft.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report
Date: Mon, 27 Feb 2023 22:35:39 +0000	[thread overview]
Message-ID: <CO1PR11MB4929CAE3368D912F37EB18C3D2AF9@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAMj1kXEGhDyFUGUOuJVwQZMimSafPJ9k+Li+bQ4gJbG1SDJKFA@mail.gmail.com>

Hi Guillermo,

Can you please look at Ards PR and make sure his fix is included in your PR.

Also, please work with Christine and Bob to see what is going on with the
Code Coverage check.  We do want it to be easy for all community members to
submit change requests.  We may need support from the edk2-bastools maintainers
to help with CI issues and help with changes to address.

Thanks,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard Biesheuvel
> Sent: Monday, February 27, 2023 10:58 AM
> To: devel@edk2.groups.io; Palomino Sosa, Guillermo A <guillermo.a.palomino.sosa@intel.com>
> Cc: Ni, Ray <ray.ni@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Chen, Christine <yuwei.chen@intel.com>; Feng,
> Bob C <bob.c.feng@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Oram, Isaac W <isaac.w.oram@intel.com>; Sean Brogan
> <sean.brogan@microsoft.com>
> Subject: Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report
> 
> On Mon, 27 Feb 2023 at 18:40, Guillermo Antonio Palomino Sosa
> <guillermo.a.palomino.sosa@intel.com> wrote:
> >
> > Hi. I have submitted a pull request to edk2-basetools repository: https://github.com/tianocore/edk2-basetools/pull/88
> > This is the feature request for it: https://github.com/tianocore/edk2-basetools/issues/87
> > I'm also attaching the patch here: (0001-BaseTools-Generate-compile-information-in-build-repo.patch)
> >
> > On a side note, seems like tip of edk2-basetools is broken due this commit that makes direct import of Common package:
> > https://github.com/tianocore/edk2-basetools/commit/8e6018d3ea4c1aae7185f589d129cea14a5d89fd
> > edk2-basetools\edk2basetools\GenFds\SubTypeGuidSection.py:
> > import Common.LongFilePathOs as os
> >
> >
> 
> I sent a fix and a PR for this about a month ago:
> 
> https://github.com/tianocore/edk2-basetools/pull/86
> 
> but CodeCov seems to take issue with it, for reasons I don't
> understand (and I can't be bothered to spend more time on yet another
> CI automation pass that adds to my workload rather than reduce it)
> 
> 
> 
> 


  reply	other threads:[~2023-02-27 22:35 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-07  3:07 [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report Guillermo Antonio Palomino Sosa
2023-02-15  2:43 ` Yuwei Chen
2023-02-15  3:42   ` Michael D Kinney
2023-02-15  5:38     ` Yuwei Chen
2023-02-15  8:17       ` Ni, Ray
2023-02-15 23:12         ` Michael D Kinney
2023-02-16  0:50           ` Ni, Ray
2023-02-18  4:42             ` [edk2-devel] [PATCH " Guillermo Antonio Palomino Sosa
2023-02-27 17:40             ` [edk2-devel][PATCH " Guillermo Antonio Palomino Sosa
2023-02-27 18:57               ` Ard Biesheuvel
2023-02-27 22:35                 ` Michael D Kinney [this message]
2023-02-27 23:42                   ` Guillermo Antonio Palomino Sosa
2023-03-01  0:52                     ` Ni, Ray
2023-03-01  4:00                       ` Guillermo Antonio Palomino Sosa
2023-03-06 15:40                         ` Guillermo Antonio Palomino Sosa
2023-03-15  1:12                           ` Ni, Ray
2023-03-15 10:28                             ` Bob Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB4929CAE3368D912F37EB18C3D2AF9@CO1PR11MB4929.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox