From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C74BD941158 for ; Thu, 8 Feb 2024 05:54:01 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=CBu4Yn/+kE2ZPBpAQi00Lpd1aUWzEoo/obLsum+U/UI=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1707371640; v=1; b=p/phUgH8GffpbzImPDHZS2Q0/CzXwbGrkzfQUYdXMmWw95FnGmwyzQeK7LHduOmxXrCqQbxo rFD/QKJcnxwJ0FKCrNzdqT8WNRuuQtuZS92Tv4k0qHQRKtHPMl2+yta5VO0gflPaLmoAUoLcBAZ BzG6f583v7y7jZqbAZE33kSQ= X-Received: by 127.0.0.2 with SMTP id AOI9YY7687511xGZBs7nQf9x; Wed, 07 Feb 2024 21:54:00 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by mx.groups.io with SMTP id smtpd.web11.12105.1707371639796993944 for ; Wed, 07 Feb 2024 21:53:59 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10977"; a="1446270" X-IronPort-AV: E=Sophos;i="6.05,252,1701158400"; d="scan'208";a="1446270" X-Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2024 21:54:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,252,1701158400"; d="scan'208";a="6216444" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 Feb 2024 21:53:59 -0800 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 7 Feb 2024 21:53:58 -0800 X-Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 7 Feb 2024 21:53:58 -0800 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 7 Feb 2024 21:53:58 -0800 X-Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.40) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 7 Feb 2024 21:53:57 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aZ4pndtwtGBIoz+fk1g+cv2o01KJdnwYdFEjjH0uPCZJLGf3m3f0zVNtvwUqGqBvgtmYVpyX/IU6m3eLJW4MJjDIB39tMvf/RA/ZkPlQJwbWzxERlcjLdD7QBEg+OTdpJmmRAv+Yu5uXdi744Lm/qAUwaPj5KBIchGkM6i26QbL7iiUbegLkq/XWRYpbv4vr2QyQyKJJOOKUUwZAYsPgo2xEBdfahT6iv3dQ3xj0lGrWOoYwFxurbwEyAGwo0xGSHx5HqKmShhGCTtulNiyU/agn/VHhlfk9R6TgrqSmnBpqr20iX4iSQqcsJsLjiQQ2GN67Bw60OrbCOIBOg9QMBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M4O0ip8N4kdK4NAv5dyVuRoNm6miogZB3ltxWDtPf8k=; b=nqGWVrUqiyZKu1vHu/5KaE5ZB+a6ykdKbuob0V2fnXj7TdmrC7B6qyADtHMeCJawKTVEDTJSRfF766dvZ5QcRjwdR8wRZJnI+MJ0uvnVhj8HLkD4Fuss7S2TYu4y6rZXoM01jg8YyCgBmxMZMBnLEgQ4dkJgvL7/fvZwnF3WgJQas1gAHk0vO8Er4X62VJNeGf2UdDqZOCQ6kTDOsaiAxLA9HkQWcZO6bkcyuzxMdxOixSuDgMRD9No5ZsfEfMU1dpnIhUj9q2b2lIWZ5nhDdJmrjQRzduMl5C6ROK/aaQavwwCSjuNcCxvfxngHLlBIx9MBz3mkdnPGeG3RBgVfjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by SA1PR11MB6965.namprd11.prod.outlook.com (2603:10b6:806:2bf::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.36; Thu, 8 Feb 2024 05:53:55 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::7e42:1633:d0a6:9c00]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::7e42:1633:d0a6:9c00%6]) with mapi id 15.20.7249.037; Thu, 8 Feb 2024 05:53:55 +0000 From: "Michael D Kinney" To: "S, Ashraf Ali" , "Feng, Bob C" , "Chan, Amy" , "Chen, Christine" , "devel@edk2.groups.io" CC: Rebecca Cran , "Gao, Liming" , "Chaganty, Rangasai V" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuId from allskuset Thread-Topic: [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuId from allskuset Thread-Index: AQHaWlKc7fKrNwQbrkqVc0B2mgIUJ7D/8aLg Date: Thu, 8 Feb 2024 05:53:55 +0000 Message-ID: References: <2fcb6a95d99dffa093011850548712054ef7e813.1703518030.git.ashraf.ali.s@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|SA1PR11MB6965:EE_ x-ms-office365-filtering-correlation-id: 529e2266-9aa3-4750-4eb0-08dc286a561e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: fhdpEGj+HWWe8IFrVn10RlzUVeIRMKDhvc2FXUdtHVLKyjEaLgkt2A3vs2zhJApAU6Bh73ZtYLqIQpPCSQ5588o0fp/aOBfkyBSyG3g7YSun/mxoHgOGb8YfEEmW+qSIxepBWhb8IO7OPbJd4rq3hFNda7UswlOmGBT34iEFMU75eBSxueb9LnZPAtilHe+ri+C7YdpdHNbmOVpQP0LjHJAtK7DK+Q1Ilu4NJmDgWr0myagmdfw+seNRkGKzGWK7992C7u0adt+T5SkJVx6pcXqf7f2vAa0oMZeTYu/UFapXN0SsLrLCrBEh0I+Hmsoq1s1iJnB4Qju2+OGS/7rl7L3Ju40O0GO+Wi8zRjoBZSUBT+HYYEFcOM4Gs6oF29LppsrNDIkA+lxXmEtnkSqrdTxd8MRFazaeyJNtrY50AeWNhOalmjOt8fiGXBb2HLl81f++JQ2AARtvyyQN3MywN0JLgz3Y815mqbxgFlxQzTseGbfHGVNFQtQsK5uCWt5DSxSsSqhql2u9jqYxmPbOueZCUv8v3nm/h1seTMpjivTPYG12qkfzePF9K6XEOOqopdCTgNYW7joNW3qPodd33vjEz6v84aoagVPoL3y1Rwo= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cDvPUOaqlzexpZW02pyV1ULhniPHdTD8GhB+209brvSZXdq5uzgd+nBtLJX4?= =?us-ascii?Q?/pI2omR4ZlIeqmZ8ZCaiA8e72aJaWu9alpAOLgYP+Dbnsm+eTLupwY9PiMdU?= =?us-ascii?Q?0uBfIZvxeN5uWiZRCYIcEIHw9urDLNRbSu11sBrEqUoBghm7xSI0kBncsDAF?= =?us-ascii?Q?lE/Qv77ncIMbPcs4g5969Cy0P6ac92EV0W1oIpO/D/4t0MBjFwH7xgVltRT9?= =?us-ascii?Q?jXttcBkrq4K4hUv68T93/QOn111bm2IQajCmu/DcKC/WuVm25emqx8YpOmiw?= =?us-ascii?Q?SG/Yo2JvIFvdXU5GJKzdDIvqwqZNqmWAoopHaTOQgMYZUFOQ3AG7z7/oOXh3?= =?us-ascii?Q?XNKshLdmkCz2+07yst6vHmzg0q9s2YlAXaOsIi86F+yFZ8csXGbm0eS7MKd/?= =?us-ascii?Q?HH1igcYVHXII12zFX6mcVNDaHUNtlg/ok2Dte8cJXTQeDKZX2t8YRpyvvJj4?= =?us-ascii?Q?+VZNtmDl6xoR+Neumup0PulI7EBSbwafdzXg3MH4MvFd0B5xlxhljHKJXg0f?= =?us-ascii?Q?SkBagESp1ADjTZiXJKeh35287E4AmF+QWFso8VSF793j9uXkHSnhDDcJlYkc?= =?us-ascii?Q?SYMrRqBbSV6sMjd+yWWC10ctaty9w/MkhOlz5E5jymco3rXXoWbS/bnObVFc?= =?us-ascii?Q?QL5CB8LQkrdOJW96Y4D+B0zqs6HOq2LdmopdtY4zHyEf9jihvFzbvwdLOjie?= =?us-ascii?Q?Y02dJgjFIK46JpRbZ0Nrk9fH+OOjOHDwt4e651kisda/NlAJ500cyiKBaz/s?= =?us-ascii?Q?Oj6WRAfuEyN7lQyFiHqRSWS6XsTk+E79DBQe085HtldoWEEzzshmcRttHUy1?= =?us-ascii?Q?3DlsssSTjmzZEZyc9wQN6wk5ZjzG3Fc3fW4ftOqThtMC5d6Amhf5BD6+Azuj?= =?us-ascii?Q?3tWDPSxANF5Lue1F4tyeog74tRDp0GJPkT59boWpYtNYQYQ+KmMNId31tl1k?= =?us-ascii?Q?EOn1Hqj2CTEDaPVqE0Xv0QU0M4j669FtLiRhuIV+NRTl6agOEkax+24TWUfU?= =?us-ascii?Q?4ONtqJHNvE9kh3BPrUg5BRV2Nd1MyZOnz83FmU3piY4ARh5j3mGwGK1FyadB?= =?us-ascii?Q?uEqh1XyyaYliLKRkWzoX1cQ0Mhl58c78fu7vu0pUCluJOyjOmVW3LzZQ9VZs?= =?us-ascii?Q?d6RtZMYDgtyq2d/1LQnnLLqbLgnE/1PQV4MwKCpUQrEv5DMwDT3xSlycOM0V?= =?us-ascii?Q?W0wSFAjlKooW0VkpyPVjZhjhSTUWROpig/wnDHwlgJoDkXaWdgFAHSHdhMzy?= =?us-ascii?Q?QDE1zkudcu8veQVKgISmW+3f6cGdziWLmyaPGoxd9/a8O7to/TdnBfXrPZLm?= =?us-ascii?Q?527zps6I5m1lP4U/Fh8JpVOLe8dhqsVrYxVPTUDxl4tcjwpo6+Z266LF+Q8D?= =?us-ascii?Q?tYiNEgCel2d25V+r7riauyvMwOrs5WFZ9dJxMvby2K3kKqSx85E7t9QHUHLO?= =?us-ascii?Q?kx0z0baUlpusZstjim0648UlvEEzArm4tgUUE6RJbQxIK98TAqn0g7LyfC6e?= =?us-ascii?Q?Y2S0iL+SeYsKmp2NCpSoaJyWlRvp97r5kzOpEXgtKw7WcGYuWd6sFftIA3So?= =?us-ascii?Q?ocWandVznjoCdYFapQFg2vGwd5OTI9fswGPA4Wix?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 529e2266-9aa3-4750-4eb0-08dc286a561e X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2024 05:53:55.5833 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HTBLOWTHIJ1coXKNc7e/d5UZmWSKv3CQtAeGb7UMg+H7SZc8xN8h/ecl4kgkVG76mkjr+CDYMZYY7leaRS3PSMdM6PDIeIm+L2MiiXDhhXc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6965 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 5LgUoeqyVefJDic9GEhOlro8x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="p/phUgH8"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io I will merge it soon. Please work with Christine to get edk2-basetools CI working correctly. Mike > -----Original Message----- > From: S, Ashraf Ali > Sent: Wednesday, February 7, 2024 9:50 PM > To: Feng, Bob C ; Chan, Amy ; > Chen, Christine ; devel@edk2.groups.io > Cc: Rebecca Cran ; Gao, Liming > ; Chaganty, Rangasai V > ; Kinney, Michael D > > Subject: RE: [PATCH] BaseTools: Remove Duplicate sets of SkuName and > SkuId from allskuset >=20 > Hi >=20 > Is this patch merged! > PR under base-tools repo : https://github.com/tianocore/edk2- > basetools/pull/112 >=20 > Builds are failing, looks like it's not due to these changes. >=20 > Thanks., > S, Ashraf Ali >=20 > -----Original Message----- > From: Feng, Bob C > Sent: Tuesday, January 30, 2024 1:19 PM > To: Chan, Amy ; Chen, Christine > ; S, Ashraf Ali ; > devel@edk2.groups.io > Cc: Rebecca Cran ; Gao, Liming > ; Chaganty, Rangasai V > > Subject: RE: [PATCH] BaseTools: Remove Duplicate sets of SkuName and > SkuId from allskuset >=20 > Reviewed-by: Bob Feng >=20 > -----Original Message----- > From: Chan, Amy > Sent: Monday, January 8, 2024 11:54 AM > To: Chen, Christine ; S, Ashraf Ali > ; devel@edk2.groups.io > Cc: Rebecca Cran ; Gao, Liming > ; Feng, Bob C ; > Chaganty, Rangasai V > Subject: RE: [PATCH] BaseTools: Remove Duplicate sets of SkuName and > SkuId from allskuset >=20 > Reviewed-by: Amy Chan >=20 > > -----Original Message----- > > From: Chen, Christine > > Sent: Monday, January 8, 2024 8:29 AM > > To: S, Ashraf Ali ; devel@edk2.groups.io > > Cc: Rebecca Cran ; Gao, Liming > > ; Feng, Bob C ; Chan, > > Amy ; Chaganty, Rangasai V > > > > Subject: RE: [PATCH] BaseTools: Remove Duplicate sets of SkuName and > > SkuId from allskuset > > > > Reviewed-by: Yuwei Chen > > > > > -----Original Message----- > > > From: S, Ashraf Ali > > > Sent: Monday, December 25, 2023 11:28 PM > > > To: devel@edk2.groups.io > > > Cc: S, Ashraf Ali ; Chen, Christine > > > ; Rebecca Cran ; Gao, > > Liming > > > ; Feng, Bob C ; > > > Chan, Amy ; Chaganty, Rangasai V > > > > > > Subject: [PATCH] BaseTools: Remove Duplicate sets of SkuName and > > > SkuId from allskuset > > > > > > Currently when the platform has many SKUs then allskuset will be > > > having so many duplicate. and while parsing the allskuset will take > > > longer time while assing Pcd.SkuInfoList. > > > This patch is to eliminate those duplicate entires to reduce the > > > build time > > > > > > Cc: Yuwei Chen > > > Cc: Rebecca Cran > > > Cc: Liming Gao > > > Cc: Bob Feng > > > Cc: Amy Chan > > > Cc: Sai Chaganty > > > Signed-off-by: Ashraf Ali S > > > --- > > > BaseTools/Source/Python/AutoGen/PlatformAutoGen.py | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > > b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > > index 592d4824a4..dac81454a9 100644 > > > --- a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > > +++ b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > > @@ -707,6 +707,8 @@ class PlatformAutoGen(AutoGen): > > > self._DynamicPcdList.extend(list(OtherPcdArray)) > > > self._DynamicPcdList.sort() > > > allskuset =3D [(SkuName, Sku.SkuId) for pcd in > > > self._DynamicPcdList for (SkuName, Sku) in pcd.SkuInfoList.items()] > > > + # Remove duplicate sets in the list > > > + allskuset =3D list(set(allskuset)) > > > for pcd in self._DynamicPcdList: > > > if len(pcd.SkuInfoList) =3D=3D 1: > > > for (SkuName, SkuId) in allskuset: > > > -- > > > 2.39.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115265): https://edk2.groups.io/g/devel/message/115265 Mute This Topic: https://groups.io/mt/103360241/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-