From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: gaoliming <gaoliming@byosoft.com.cn>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Lu, XiaoyuX" <xiaoyux.lu@intel.com>,
"Jiang, Guomin" <guomin.jiang@intel.com>,
"Liu, Zhiguang" <zhiguang.liu@intel.com>,
"Feng, Bob C" <bob.c.feng@intel.com>,
"Chen, Christine" <yuwei.chen@intel.com>,
'Andrew Fish' <afish@apple.com>,
'Abner Chang' <abner.chang@hpe.com>
Subject: Re: [edk2-devel] [Patch 0/3] Remove fixed CPU architecture list assumptions
Date: Tue, 13 Apr 2021 02:39:05 +0000 [thread overview]
Message-ID: <CO1PR11MB4929CB3B3BB7DE8E0D24D971D24F9@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <00d901d73004$4a73bb60$df5b3220$@byosoft.com.cn>
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Monday, April 12, 2021 6:28 PM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>; Jiang,
> Guomin <guomin.jiang@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Feng, Bob C <bob.c.feng@intel.com>; Chen,
> Christine <yuwei.chen@intel.com>; 'Andrew Fish' <afish@apple.com>; 'Abner Chang' <abner.chang@hpe.com>
> Subject: 回复: [edk2-devel] [Patch 0/3] Remove fixed CPU architecture list assumptions
>
> Mike:
> Is this update for new ARCH support? With this patch set, new ARCH support
> doesn't need to modify BaseTools. Right?
Correct
>
> For this patch set 3/3 BaseTools/Source, I may suggest to split it to two
> patches, one is for C tools, another is for Python tools.
I agree. I will send V2.
>
> For other patch, they are good to me. Reviewed-by: Liming Gao
> <gaoliming@byosoft.com.cn>
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Michael D
> > Kinney
> > 发送时间: 2021年4月8日 14:33
> > 收件人: devel@edk2.groups.io
> > 抄送: Jiewen Yao <jiewen.yao@intel.com>; Jian J Wang
> > <jian.j.wang@intel.com>; Xiaoyu Lu <xiaoyux.lu@intel.com>; Guomin Jiang
> > <guomin.jiang@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> > Zhiguang Liu <zhiguang.liu@intel.com>; Bob Feng <bob.c.feng@intel.com>;
> > Yuwei Chen <yuwei.chen@intel.com>; Andrew Fish <afish@apple.com>;
> > Abner Chang <abner.chang@hpe.com>
> > 主题: [edk2-devel] [Patch 0/3] Remove fixed CPU architecture list
> > assumptions
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3308
> >
> > The EDK II Build Specifications do not restrict the set of
> > CPU architectures that can be supported. Remove places in
> > the EDK II that assume a fixed set of CPU architectures.
> >
> > Remove build breaks in the following tools and DEFINES when a check
> against
> > a fixed set of CPU architectures is made.
> >
> > * Build
> > * GenFds
> > * TargetTool
> > * GenFw
> > * SIXTY_FOUR_BIT and THIRTY_TWO_BIT
> > * EFI_IMAGE_MACHINE_TYPE_SUPPORTED
> > * EFI_IMAGE_MACHINE_CROSS_TYPE_SUPPORTED
> > * EFI_REMOVABLE_MEDIA_FILE_NAME
> >
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>Cc
> > Cc: Guomin Jiang <guomin.jiang@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Cc: Bob Feng <bob.c.feng@intel.com>
> > Cc: Yuwei Chen <yuwei.chen@intel.com>
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Abner Chang <abner.chang@hpe.com>
> > Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> >
> > Michael D Kinney (3):
> > MdePkg/Include: Allow CPU specific defines to be predefined
> > CryptoPkg/Library/Include: Allow CPU specific defines to be predefined
> > BaseTools/Source: Remove CPU architecture assumptions
> >
> > BaseTools/Source/C/GenFw/Elf32Convert.c | 5 ++---
> > BaseTools/Source/C/GenFw/Elf64Convert.c | 5 ++---
> > BaseTools/Source/Python/GenFds/FdfParser.py | 4 +---
> > BaseTools/Source/Python/TargetTool/TargetTool.py | 4 ++--
> > BaseTools/Source/Python/build/buildoptions.py | 4 ++--
> > CryptoPkg/Library/Include/CrtLibSupport.h | 2 ++
> > MdePkg/Include/Uefi/UefiBaseType.h | 4 +++-
> > MdePkg/Include/Uefi/UefiSpec.h | 4 +++-
> > 8 files changed, 17 insertions(+), 15 deletions(-)
> >
> > --
> > 2.31.1.windows.1
> >
> >
> >
> >
> >
>
>
next prev parent reply other threads:[~2021-04-13 2:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 6:32 [Patch 0/3] Remove fixed CPU architecture list assumptions Michael D Kinney
2021-04-08 6:32 ` [Patch 1/3] MdePkg/Include: Allow CPU specific defines to be predefined Michael D Kinney
2021-04-13 1:56 ` Abner Chang
2021-04-13 2:37 ` Michael D Kinney
2021-04-13 4:07 ` Abner Chang
2021-04-14 3:26 ` Michael D Kinney
2021-04-08 6:32 ` [Patch 2/3] CryptoPkg/Library/Include: " Michael D Kinney
2021-04-13 1:58 ` Abner Chang
2021-04-08 6:32 ` [Patch 3/3] BaseTools/Source: Remove CPU architecture assumptions Michael D Kinney
2021-04-13 2:06 ` Abner Chang
2021-04-13 1:28 ` 回复: [edk2-devel] [Patch 0/3] Remove fixed CPU architecture list assumptions gaoliming
2021-04-13 2:39 ` Michael D Kinney [this message]
2021-04-13 10:25 ` Bob Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB4929CB3B3BB7DE8E0D24D971D24F9@CO1PR11MB4929.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox