From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2EC9E941DB7 for ; Tue, 23 Jan 2024 22:14:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=3pqOBRaPHzQe6V1ITs44aaOKZsQPOpbjBJRgEQTRBJM=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706048064; v=1; b=rnpA9UpE29qXmAWctz2K7nQrxvYKmIeJbJZvUyDOP4dvrVn68p5appmyX81GXrlmTMac/Xv4 HQc/xaNYBhqu2Qzln93jtRqIKDASoPoHXER1bJzYq986OUycEWn0FrtYCrNTtynfp0EBsOGxqCI Cks2mS1dbrNxDzPL8xG4Hz5M= X-Received: by 127.0.0.2 with SMTP id S7e5YY7687511xjO37ULgllQ; Tue, 23 Jan 2024 14:14:24 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by mx.groups.io with SMTP id smtpd.web11.7759.1706048064211583772 for ; Tue, 23 Jan 2024 14:14:24 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="9034878" X-IronPort-AV: E=Sophos;i="6.05,215,1701158400"; d="scan'208";a="9034878" X-Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2024 14:14:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="929476635" X-IronPort-AV: E=Sophos;i="6.05,215,1701158400"; d="scan'208";a="929476635" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Jan 2024 14:14:22 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 23 Jan 2024 14:14:22 -0800 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 23 Jan 2024 14:14:22 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 23 Jan 2024 14:14:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PRXtwNY42oZS5gxEgw+nGpTh66jO7eXQ1PtMTE07cIteadGLrjZTx0n0pnSqk/6PVgY6iRAjBxPQJxEawcnzfuDwNwmNfU2MoOpYAC2E7D8J1N+HVOa5dgUxj0w4+mnrAKzNrGGxabUhUZLoSBGw/AX4OexjUeITgUC1BR4HRXrEICFqF9n5ZWCd+IBMDS4jYUoa+e+6VVeqN5xApUiIvKO/Izf6AzcIXMk5Q3B1RIIik+Was/L/LQzMJm4kj700kF9y1hRMr3Fu5h4owo75pYsNg08fVlu5oZ3cH4OWBork+MCVJ2fuVlP1oROW5ZeaL6jVtYxAOFlXLRFxhGRrSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yc0fm0/zbbgczbyz0PZlRjTTLC838fNUyDIyMAufuyk=; b=eL7K7o1eGRT6T0WVsRHWV1GFzOylUbkxWGZM5POGedRA6a7+nNvGAItwjN6Fu7gwQFJr61kgw5fmZh68pjoYkaV/qsmJpMtHuDObvzw6JUZdjyEyRbFen2HlMwGkq06n+vlj7t59O+kvJMqyT4EzA0tjHecgcQrB87ND0S50GH+NOUyxtE7X4QERCo5hPxcfhYsYBn5aaxKiL+zq5oqDXXWPeVb0YhyPhyvXLzctWMu3Ru0oOoD/2GMX0j0daYEud6Er52Z93Hz0mdVwaQy2NR7zijEkbtjAUmet8VNEN62L6kWVUkfiA6max1DzL0i54Q9cDYXQ3JupwBxuuwF9ig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by MW3PR11MB4554.namprd11.prod.outlook.com (2603:10b6:303:5d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.34; Tue, 23 Jan 2024 22:14:19 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::7e42:1633:d0a6:9c00]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::7e42:1633:d0a6:9c00%6]) with mapi id 15.20.7202.035; Tue, 23 Jan 2024 22:14:19 +0000 From: "Michael D Kinney" To: Jeff Brasen , "devel@edk2.groups.io" CC: "Gao, Liming" , "Liu, Zhiguang" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH] MdePkg: Add FdtLib gmock support Thread-Topic: [PATCH] MdePkg: Add FdtLib gmock support Thread-Index: AQHaLEjbufV0EKrZH06TVian7B9nHLDoN9gQ Date: Tue, 23 Jan 2024 22:14:18 +0000 Message-ID: References: <551bf2146720d609621b153dca073a1655489524.1702309338.git.jbrasen@nvidia.com> In-Reply-To: <551bf2146720d609621b153dca073a1655489524.1702309338.git.jbrasen@nvidia.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|MW3PR11MB4554:EE_ x-ms-office365-filtering-correlation-id: c851e281-97be-4801-5fa4-08dc1c60a4ee x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: iEYbc+vokEWQY5YNmn+LPSYE0FmLJbTD3NxXZvOgWeJx2QpRLCSIyaN2606t0mUMkBplOOQ0yk/cFxEmXFD1GF1WTYtYd1wnUXsJZ6YaQSQh2ZIG+Q/n1Sh6GcL78ba2Zqv84t2k1SG8xiQkHg2GjJQQQyRYpDytXHtXgQCuZE+24tGbQWahIuwaSgQs33dipcqShqe0+h5zGEMDlSUrOZbY20No/7tcBDVuXbQDblFxqbGjnXbi5Q+USENXsFtryGLPcLrpDhX7am7qcSdcmQZNO4tuuvGEG/y24/hiu/GpfhjQmtg7R3Tj2hdPps3lKjd3BNTcq99p2mk9aQuLrG3CBXpalfengVwdlBkZ2M+D9jsRcBTkIOldehzZAH7tT/J8HBcXn+vgxAhdpmoG4mDk0pm6O/0RHIiAQLPAIgYwcbXf4ISmUQoe41xi9Em6Z1w9uc50EnpCHyA3EVT5qZUHfhIGL0SDHbiZ84ysfyxwK+GkLR8xlLNI4k4j2a45botb2nu0mW1YnqcrTW/nPTyJxrunCCxvURJoYN9uItZV2L9+roHgiO7oNpyl+phaXQWH8U/rug5fF3NXOLRIdR641AjptX+FEYr5LdmffdWHR9lNJNBVlRC+9zQmaZiD x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oKsaJNXJf/9HhZBDFybTY6NFR868jpYmOecLIOFmp8EO6c0FkzJ9ZtVzLqJ9?= =?us-ascii?Q?DCLx+ukGTnO0joPRbDMh2uM/mv2qY2uxANXWOfuuLouKD9/gdVYWXVeBmqkN?= =?us-ascii?Q?WrLOqs18j924NermqmWHWwHc8x+xIU9nsCghWES/2gKtLAOpapZO591WlcJe?= =?us-ascii?Q?82zwPYTg/V5aBezS2Yq/gQhSKiblvVK7e7RZHVR8NtFVYXvVgfmr4ErKXgj4?= =?us-ascii?Q?qC2mIiDFzTAUk9r/2xTi90VW9J+xWspD9n9s5t7oy8a2IROKWDSOTXU8571O?= =?us-ascii?Q?JQQ8+AykEgJd4KExJrMGYaVQMheOst3Lyu9OqRyLSMQOjOiRFZyHFE85S4Ue?= =?us-ascii?Q?4tFp9Ezf9gaBPNzBPFFyTmGEwr4MTfNz3m0XIgJzM0BlHJ9+7sOYcEEpwKYu?= =?us-ascii?Q?pz+wSzhGsez63WzSyLQ0+YyWs0Ax3Xrn8qaVJvKp6MCKSgL9B6cp0wHsqQdl?= =?us-ascii?Q?Ku67qAoBjNnPQjSXPAee22K3Zf2TsJ2iJZtUwf2hNgbDsdjxGAuJxMbum0lt?= =?us-ascii?Q?3MylcNak02agEWMgUF2hJ1I2IcPJ6qTNMLxabtZL63OJirw5C5K4g/a+sIx0?= =?us-ascii?Q?cm/BbStg56LZd//AziMLrDWFh5v/xEGnt/4tW+DZGf/5f0SLJYAzHJqiQAYh?= =?us-ascii?Q?vbo7mTH/nFtB4c8JMVInbKSraAg2w5SBlDKBPIfIbhQotG5S3/zmgidbV05/?= =?us-ascii?Q?/5d2euVRAb7vsW1+jC/nJSNe9bZYRfZea0Rj+S+7u5zMXB8NW7mensS2Wyi8?= =?us-ascii?Q?6i68b/Wcl2w2HaQ/cT7Cvon3Ec9LjTB7lpdCfE8nX4YZjOYYDaUi+CaqSOZh?= =?us-ascii?Q?7etV2QTyuUuY9IAth4UWDZtSXp4AIhBvNPgRpJwM0YexV8w8WKL5pRa8eZ3M?= =?us-ascii?Q?k22KZ3HljaMAsRK/CJsXPO8pXwXB0A2xmHc1CXOWgF1Bm4WWiq2uQkHeMzdr?= =?us-ascii?Q?VWL7vPfYB0gpxInVfpViBWJ/g6QlCMubxKoSW17ystT7fJXUvfwXS2TZgJ8a?= =?us-ascii?Q?b8fuW3SWGIUt8Ee5MvW3UEeREZh7J3ZY+sZDjHCxvbhuMRzMI/2+Xhwj9wfj?= =?us-ascii?Q?/IBZi9P75+WQgRq9nnWYN6wURpjOnYVB75dLjMZCxFaasHsP2hlnr4l7RsCC?= =?us-ascii?Q?FsuZo996V1eOPT8CkJ1YUAxf7TsFalkc80OGM7DIqs4Z9K6ms0weGjfhM2DI?= =?us-ascii?Q?l9m4KAg+ofIO1K3Bg4uHhK1HtqGiHFxJKYT8A6HiULlsUtX6pX1SVp+L4/f2?= =?us-ascii?Q?MMi95PpQ2HOW+YDUWn1CSniyfCCYoJ1FfnCXf9//OZY6J2xMcd2GXhfbAsTG?= =?us-ascii?Q?7qUM2Gr/pxqvnnLkLSUX3xU57d+dxhBFundR41Pcw0KijXHKZ9VuB7OTdgrE?= =?us-ascii?Q?MtE3Ogs/e3yO/+y41AaO0I9EqQ0Xf9jlq6MrtN/mXPh8TBnYuvWC2Q3CZRX3?= =?us-ascii?Q?Gj9rXqezdjCcF8W7OxC/GFNJzg7ESK0PxsaU1hpTNypxv3YtzUQTP8ic2ZHo?= =?us-ascii?Q?x7Ka1DBm3nBSQcMGiX/F/fFR+HaKs+sCvG1aEGM+E48gv3B3n4TN9BgoruIt?= =?us-ascii?Q?reGOsMJum1wXMz5rTFYWGcFeA5gGLH0BI3mXdQeaBIN08MgK0Kas0b0U3UT4?= =?us-ascii?Q?Xg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c851e281-97be-4801-5fa4-08dc1c60a4ee X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2024 22:14:18.8897 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OS2VKWJQv7yTklVFvMLxjVDC5fJKcDE8U5vB8+bJ/PibpWi5hjJ71c+FIzHxSobOSew7o/hu6z/w23LVT/Ztf5de3AHgOynzLHeyPEopBNM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4554 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 5U0PZvW6N4inPMdl5VN3IiW3x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=rnpA9UpE; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Jeff, Thanks for this mock lib contribution. I few comments below. Thanks, Mike > -----Original Message----- > From: Jeff Brasen > Sent: Monday, December 11, 2023 7:43 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael D > ; Liu, Zhiguang ; > Jeff Brasen > Subject: [PATCH] MdePkg: Add FdtLib gmock support >=20 > Add Google Mock Library for FdtLib >=20 > Signed-off-by: Jeff Brasen > --- > .../Include/GoogleTest/Library/MockFdtLib.h | 165 ++++++++++++++++++ > .../GoogleTest/MockFdtLib/MockFdtLib.cpp | 34 ++++ > .../GoogleTest/MockFdtLib/MockFdtLib.inf | 28 +++ > 3 files changed, 227 insertions(+) > create mode 100644 > MdePkg/Test/Mock/Include/GoogleTest/Library/MockFdtLib.h > create mode 100644 > MdePkg/Test/Mock/Library/GoogleTest/MockFdtLib/MockFdtLib.cpp > create mode 100644 > MdePkg/Test/Mock/Library/GoogleTest/MockFdtLib/MockFdtLib.inf >=20 > diff --git a/MdePkg/Test/Mock/Include/GoogleTest/Library/MockFdtLib.h > b/MdePkg/Test/Mock/Include/GoogleTest/Library/MockFdtLib.h > new file mode 100644 > index 0000000000..c0aeaa25c0 > --- /dev/null > +++ b/MdePkg/Test/Mock/Include/GoogleTest/Library/MockFdtLib.h > @@ -0,0 +1,165 @@ > +/** @file > + Google Test mocks for FdtLib > + > + Copyright (c) 2023 NVIDIA CORPORATION & AFFILIATES. All rights > reserved. > + Copyright (c) 2023, Intel Corporation. All rights reserved. > + SPDX-License-Identifier: BSD-2-Clause-Patent > +**/ > + > +#ifndef MOCK_FDT_LIB_H_ > +#define MOCK_FDT_LIB_H_ > + > +#include > +#include > +extern "C" { > +#include > +#include I think the 2 includes above can be replaced with > +#include > +} > + > +struct MockFdtLib { > + MOCK_INTERFACE_DECLARATION (MockFdtLib); > + > + MOCK_FUNCTION_DECLARATION ( > + UINT16, > + Fdt16ToCpu, > + (IN UINT16 Value) > + ); > + MOCK_FUNCTION_DECLARATION ( > + UINT16, > + CpuToFdt16, > + (IN UINT16 Value) > + ); > + MOCK_FUNCTION_DECLARATION ( > + UINT32, > + Fdt32ToCpu, > + (IN UINT32 Value) > + ); > + MOCK_FUNCTION_DECLARATION ( > + UINT32, > + CpuToFdt32, > + (IN UINT32 Value) > + ); > + MOCK_FUNCTION_DECLARATION ( > + UINT64, > + Fdt64ToCpu, > + (IN UINT64 Value) > + ); > + MOCK_FUNCTION_DECLARATION ( > + UINT64, > + CpuToFdt64, > + (IN UINT64 Value) > + ); > + MOCK_FUNCTION_DECLARATION ( > + INT32, > + FdtCheckHeader, > + (IN CONST VOID *Fdt) > + ); > + MOCK_FUNCTION_DECLARATION ( > + INT32, > + FdtCreateEmptyTree, > + (IN VOID *Buffer, > + IN UINT32 BufferSize) > + ); > + MOCK_FUNCTION_DECLARATION ( > + INT32, > + FdtNextNode, > + (IN CONST VOID *Fdt, > + IN INT32 Offset, > + IN INT32 *Depth) > + ); > + MOCK_FUNCTION_DECLARATION ( > + INT32, > + FdtFirstSubnode, > + (IN CONST VOID *Fdt, > + IN INT32 Offset) > + ); > + MOCK_FUNCTION_DECLARATION ( > + INT32, > + FdtNextSubnode, > + (IN CONST VOID *Fdt, > + IN INT32 Offset) > + ); > + MOCK_FUNCTION_DECLARATION ( > + INT32, > + FdtSubnodeOffsetNameLen, > + (IN CONST VOID *Fdt, > + IN INT32 ParentOffset, > + IN CONST CHAR8 *Name, > + IN INT32 NameLength) > + ); > + MOCK_FUNCTION_DECLARATION ( > + INT32, > + FdtNodeOffsetByPropValue, > + (IN CONST VOID *Fdt, > + IN INT32 StartOffset, > + IN CONST CHAR8 *PropertyName, > + IN CONST VOID *PropertyValue, > + IN INT32 PropertyLength) > + ); > + MOCK_FUNCTION_DECLARATION ( > + CONST FDT_PROPERTY *, > + FdtGetProperty, > + (IN CONST VOID *Fdt, > + IN INT32 NodeOffset, > + IN CONST CHAR8 *Name, > + IN INT32 *Length) > + ); > + MOCK_FUNCTION_DECLARATION ( > + INT32, > + FdtFirstPropertyOffset, > + (IN CONST VOID *Fdt, > + IN INT32 NodeOffset) > + ); > + MOCK_FUNCTION_DECLARATION ( > + INT32, > + FdtNextPropertyOffset, > + (IN CONST VOID *Fdt, > + IN INT32 NodeOffset) > + ); > + MOCK_FUNCTION_DECLARATION ( > + CONST FDT_PROPERTY *, > + FdtGetPropertyByOffset, > + (IN CONST VOID *Fdt, > + IN INT32 Offset, > + IN INT32 *Length) > + ); > + MOCK_FUNCTION_DECLARATION ( > + CONST CHAR8 *, > + FdtGetString, > + (IN CONST VOID *Fdt, > + IN INT32 StrOffset, > + IN INT32 *Length OPTIONAL) > + ); > + MOCK_FUNCTION_DECLARATION ( > + INT32, > + FdtAddSubnode, > + (IN VOID *Fdt, > + IN INT32 ParentOffset, > + IN CONST CHAR8 *Name) > + ); > + MOCK_FUNCTION_DECLARATION ( > + INT32, > + FdtSetProp, > + (IN VOID *Fdt, > + IN INT32 NodeOffset, > + IN CONST CHAR8 *Name, > + IN CONST VOID *Value, > + IN UINT32 Length) > + ); > + MOCK_FUNCTION_DECLARATION ( > + CONST CHAR8 *, > + FdtGetName, > + (IN VOID *Fdt, > + IN INT32 NodeOffset, > + IN UINT32 *Length) > + ); > + MOCK_FUNCTION_DECLARATION ( > + INT32, > + FdtNodeDepth, > + (IN CONST VOID *Fdt, > + IN INT32 NodeOffset) > + ); > +}; > + > +#endif > diff --git > a/MdePkg/Test/Mock/Library/GoogleTest/MockFdtLib/MockFdtLib.cpp > b/MdePkg/Test/Mock/Library/GoogleTest/MockFdtLib/MockFdtLib.cpp > new file mode 100644 > index 0000000000..a955780d23 > --- /dev/null > +++ b/MdePkg/Test/Mock/Library/GoogleTest/MockFdtLib/MockFdtLib.cpp > @@ -0,0 +1,34 @@ > +/** @file > + Google Test mocks for FdtLib > + > + Copyright (c) 2023 NVIDIA CORPORATION & AFFILIATES. All rights > reserved. > + Copyright (c) 2023, Intel Corporation. All rights reserved. > + SPDX-License-Identifier: BSD-2-Clause-Patent > +**/ > + > +#include > + > +MOCK_INTERFACE_DEFINITION (MockFdtLib); > + > +MOCK_FUNCTION_DEFINITION (MockFdtLib, Fdt16ToCpu, 1, EFIAPI); > +MOCK_FUNCTION_DEFINITION (MockFdtLib, CpuToFdt16, 1, EFIAPI); > +MOCK_FUNCTION_DEFINITION (MockFdtLib, Fdt32ToCpu, 1, EFIAPI); > +MOCK_FUNCTION_DEFINITION (MockFdtLib, CpuToFdt32, 1, EFIAPI); > +MOCK_FUNCTION_DEFINITION (MockFdtLib, Fdt64ToCpu, 1, EFIAPI); > +MOCK_FUNCTION_DEFINITION (MockFdtLib, CpuToFdt64, 1, EFIAPI); > +MOCK_FUNCTION_DEFINITION (MockFdtLib, FdtCheckHeader, 1, EFIAPI); > +MOCK_FUNCTION_DEFINITION (MockFdtLib, FdtCreateEmptyTree, 2, EFIAPI); > +MOCK_FUNCTION_DEFINITION (MockFdtLib, FdtNextNode, 3, EFIAPI); > +MOCK_FUNCTION_DEFINITION (MockFdtLib, FdtFirstSubnode, 2, EFIAPI); > +MOCK_FUNCTION_DEFINITION (MockFdtLib, FdtNextSubnode, 2, EFIAPI); > +MOCK_FUNCTION_DEFINITION (MockFdtLib, FdtSubnodeOffsetNameLen, 4, > EFIAPI); > +MOCK_FUNCTION_DEFINITION (MockFdtLib, FdtNodeOffsetByPropValue, 5, > EFIAPI); > +MOCK_FUNCTION_DEFINITION (MockFdtLib, FdtGetProperty, 4, EFIAPI); > +MOCK_FUNCTION_DEFINITION (MockFdtLib, FdtFirstPropertyOffset, 2, > EFIAPI); > +MOCK_FUNCTION_DEFINITION (MockFdtLib, FdtNextPropertyOffset, 2, > EFIAPI); > +MOCK_FUNCTION_DEFINITION (MockFdtLib, FdtGetPropertyByOffset, 3, > EFIAPI); > +MOCK_FUNCTION_DEFINITION (MockFdtLib, FdtGetString, 3, EFIAPI); > +MOCK_FUNCTION_DEFINITION (MockFdtLib, FdtAddSubnode, 3, EFIAPI); > +MOCK_FUNCTION_DEFINITION (MockFdtLib, FdtSetProp, 5, EFIAPI); > +MOCK_FUNCTION_DEFINITION (MockFdtLib, FdtGetName, 3, EFIAPI); > +MOCK_FUNCTION_DEFINITION (MockFdtLib, FdtNodeDepth, 2, EFIAPI); > diff --git > a/MdePkg/Test/Mock/Library/GoogleTest/MockFdtLib/MockFdtLib.inf > b/MdePkg/Test/Mock/Library/GoogleTest/MockFdtLib/MockFdtLib.inf > new file mode 100644 > index 0000000000..cc5311eae4 > --- /dev/null > +++ b/MdePkg/Test/Mock/Library/GoogleTest/MockFdtLib/MockFdtLib.inf > @@ -0,0 +1,28 @@ > +## @file > +# Google Test mocks for FdtLib > +# > +# Copyright (c) 2023 NVIDIA CORPORATION & AFFILIATES. All rights > reserved. > +# Copyright (c) 2023, Intel Corporation. All rights reserved. > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +## > + > +[Defines] > + INF_VERSION =3D 0x00010005 > + BASE_NAME =3D MockHobLib Should be MockFdtLib > + FILE_GUID =3D 0f5471bc-fc2c-4cf4-b9f7-c1396d32831= c > + MODULE_TYPE =3D HOST_APPLICATION > + VERSION_STRING =3D 1.0 > + LIBRARY_CLASS =3D FdtLib > + > +[Sources] > + MockFdtLib.cpp > + > +[Packages] > + MdePkg/MdePkg.dec > + UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec > + > +[LibraryClasses] > + GoogleTestLib > + > +[BuildOptions] > + MSFT:*_*_*_CC_FLAGS =3D /EHsc Add /bigobj here as well. I have been working with some mock libs that exceed VS max number=20 of objects without this flag and I think it is safer to just make=20 this a standard flag in all mock lib INFs. > -- > 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114233): https://edk2.groups.io/g/devel/message/114233 Mute This Topic: https://groups.io/mt/103110868/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-