From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1680F941C72 for ; Thu, 7 Sep 2023 22:05:30 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=jgqUcK3IpgXrlpg3pUACTutNBzeonXPaY1Y5YpGkrqk=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694124329; v=1; b=bwYG1UlyLCkCfJUfB8d5donVN2bL3lIW5RKoWKfqPbnspDV3PAcgK4cgKU4+xLSobC4YZNUF XzfVndkjJNYA7PJJj1IVb4KdcWg2V7+v2REY2QMANy/2pQ7qZ4FMcGNedi540/9h6dfB0F5cEou z7REzFCLobLbWTSx7EDqgKf4= X-Received: by 127.0.0.2 with SMTP id 25paYY7687511xbPIx9mLwYo; Thu, 07 Sep 2023 15:05:29 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.26565.1694124328965890574 for ; Thu, 07 Sep 2023 15:05:29 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10826"; a="367751857" X-IronPort-AV: E=Sophos;i="6.02,236,1688454000"; d="scan'208";a="367751857" X-Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2023 15:05:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10826"; a="832373468" X-IronPort-AV: E=Sophos;i="6.02,236,1688454000"; d="scan'208";a="832373468" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by FMSMGA003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 Sep 2023 15:05:27 -0700 X-Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Thu, 7 Sep 2023 15:05:27 -0700 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Thu, 7 Sep 2023 15:05:27 -0700 X-Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.48) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 7 Sep 2023 15:05:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V87mXI6w+qDrtMW8JJZYNV/SrcuRSnVQ2LxDzX8CJIW7/P2o3G0pmWDyqdJPGf69nIBknTsVgSn8zraa4OjFqTjFFZE/k+UZNK7/9iUbyNHOmvOc3T5fKqHfiaEdZQicGvaHnoLtkTVv2qZhrqPSslE6KOpCAAvfmZEbtCBoQpIN5IraIM+ocSAMltYYZoYwbPF+9IW0lbWEHgSo0JMftnhWpx5rVI4d+AvloxV5BTWlOsFC00SFjrYt1zrqcmfpBpTvfe7SQkPtXt5FGA5nZwIDdyqiQQVz2c8+NmbZkWU/rLx/eiIRpA6+Wh5UKXDNYXPpL5GDPEzmbgVctJjShw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C0V6VEz+vwYGlGA6pRCHnvV2HDqeg8uFe/3UBYbDrag=; b=L51WX8d2Ga6YIio5Ke1fmlyr7GqC67Idcrxe7ALf652t5CkYlsdcMjP97wZf7tMWeCtUTKtvrIgQE6H38wTgXDODyVOzaRlzokMlx0NIpSoCdZxMwlhnfzEpvPLZBiCCdJiHBlRv5h5JsdpkLZBEdBOISxkzpBs7clcSk+3BL+aL2dD2L541A4obOTsElLs831+rh+L1GL3VbfFF8KWuYEmMJMUoyW/vNT0zTXQTw3P7/RWNp4WbxzcFQoRp4TsEj3pnyDV/m51JpOYCAjX08YYBEDyNubWw9oMUdk8dovE7dfP3K8izTkroLy57UAuWw867GbAfbp/LyCxzK3kyJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by SA1PR11MB8426.namprd11.prod.outlook.com (2603:10b6:806:38d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.30; Thu, 7 Sep 2023 22:05:25 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::eaa6:1c0:c33f:2a11]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::eaa6:1c0:c33f:2a11%2]) with mapi id 15.20.6745.034; Thu, 7 Sep 2023 22:05:24 +0000 From: "Michael D Kinney" To: "Lien, HoraceX" , "devel@edk2.groups.io" , "Gao, Liming" CC: "Liu, Zhiguang" , "Bi, Dandan" , "Zeng, Star" , "Gao, Zhichao" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is not match with SMBIOS version Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is not match with SMBIOS version Thread-Index: AQHZ22UDlonZ8eWV50a1a49r60TCnLAEkQEAgAD4/jCACZy7oIAA0LTw Date: Thu, 7 Sep 2023 22:05:24 +0000 Message-ID: References: <0439b4b435989b2604d325451ae0fa6b70bb0a20.1693386097.git.horacex.lien@intel.com> <1780B48BF009A270.23790@groups.io> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|SA1PR11MB8426:EE_ x-ms-office365-filtering-correlation-id: 94fee481-8fc7-4807-d828-08dbafee895b x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: Kl1tgYyLOLb1BlJ5dFovsnJZ89yHSvVAVRTt3lx8GfE4Xf+ToZ0cbBDHo+4N/zoVUuh+e/7i8TR+ctbsx8HAVGfDhC2LwiXD+fS7xyZ8Jsu6v9bBeHmu0QAJNOtB/CoRmfNruOlqrzmAs8ekvnTQEEJ47M8WN0Jbsaup2b3/9OlQwLz2n0n9X27MFNDRz9yTUsc/fiTwScacgiDefJZiueXCATq/49PMftFogDBYFmUVzQBQfGCsWq9iqgMQ0qiDgDVT0TeGdaWMwB5eQRptt7KFZv7jawOyT2XrvOH1PypebCN1+dKm5ET6aTeO9ODsIX5cyTlkHeA2Qe67uTfjjjHc42rm4jwOEikcPcXXA4pgyjZjrRGbpwrKC6D5v6KLmjGFsJZjXeuLvMDcs0RqoIZgv3brNhu/8yz3FYo7fiUoayqrn5Q0xLBA9JPx4fqeWaIPoWnTTLFHkG4c7cxmqpTW1IDj+48w/upyACVIMIiVv286GaHsfwiKsgzkg0bKt1ox4vGqtZWAxmYoPLBwDwtHYfhdPUSh2ueHpadw3pGsCKzADyjGpldBx6edjcYZejGbLQT3qs41g4R1p6W8EwQoRS5yGuEV+BH1XNh+13Vb96Kvmbh7hvHR6i3r6Eb0V7g/Fr4ANwaww+fo2I7suT7zar+UvArGRBm+1fVzRwU= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sVX9GjoRj2wkrz5Jkq4Njp8OOGm/P87uL7lDpyOttV227MGv0djiepWvWgot?= =?us-ascii?Q?JQ9uzqk7H1drCUyThVTotQ+/innb+ow+SQoty0JLbErhW4LlZ57y1smGwLPS?= =?us-ascii?Q?nFTCjH9D4nicTvgq8VAXxKr2XNnwndtbdbi+Odvr8VQ7mDX81YXQjBcLC7ol?= =?us-ascii?Q?/ruX8DibSIanr0FETHaJ/VmfJyGNmp0dUk31pHRTBWd3BzTlCBQG5JxcmkWY?= =?us-ascii?Q?wo0woEP7A6hjeEkaj1k1JI8iXMPHczDH1WIZ3zVruv9W4IxAi4c8uPunMreJ?= =?us-ascii?Q?R6YCsFNYAVQRI5i9JdQkCM/uCSiiaDNdakbA7xXtr3ZnK96rzy5EkZPZIcZ6?= =?us-ascii?Q?rBmsYaaPYeW4eZ+GaL1fP7iffsrVXyhcogJsoRpPLfA6X7mUIfCiA/DR4AsL?= =?us-ascii?Q?FaoLgSdNHnPXaQ4oZUtmMbqqorCWPLgLlS2kwLnZQkt6oBYzugjvvj+sxWC1?= =?us-ascii?Q?i/n1BGTjZ63yuZGLwEGY+1LjNhzMI9BLT4/FZKMpfyEcTISNhtCr4srHp+Im?= =?us-ascii?Q?ncOsiF6RP6sd/CIrLP+uiPRSJDLePdaKTBHJiuIvbzSWJiJCMF/AW/JXM7VC?= =?us-ascii?Q?AJ7En+ziX7RyQjXQg4DVscCpDBrqCYXYwRFDa9TMv31Xrvem1XXkxfT96qzx?= =?us-ascii?Q?EXOI8V07HDFiqQcqX13omPF6H1uV/LGzNQtXGAcavdbHn95SQKUocqCQlHvK?= =?us-ascii?Q?PCaAeH00R1zDg5UfMsu88qeCE+BJfmgFKsJAvZQQxEHppH+rFyquSzDN9v26?= =?us-ascii?Q?ijJee3uMZJyNHn3uTaNd52Bh5AdVwgizavqeRcqzRISrJDVB+1RkVLuDftM3?= =?us-ascii?Q?hVJ8UsZc3TezH3v+fjG/tZ5yBwjL9Y131TFbHiVPx61hwGCLpxa3Q+iZIHbp?= =?us-ascii?Q?yZnxtonCTK3X4402fg5C2SEIwy8Nq0S0mdnc3YrAJs3UXOknEt6PKVhvsUIe?= =?us-ascii?Q?yBoVzrflM1+Q8SjMM2rWX1anekExPyv5uB1hJMMMp1iua0L+uV1bHOEItj+0?= =?us-ascii?Q?w8WVS4YRJppGFn0Q2BEUcB3MyNin990/yHIyABhXqiT2N0OkN5K/aXYtXbKy?= =?us-ascii?Q?s+E6jIbaqeYj7kegsV3886QzsxenpEstpvcLTM8+FbEOyQ1CixiDz51G49MO?= =?us-ascii?Q?BASyFw/B+HnU35MhShX6xLGG4z5SyBp9LWyNoLmBCS71OyvuCeQWHxAwllfg?= =?us-ascii?Q?WN4WEFsrawrB6KCwlwn/2DsU1YbbS6RZ06TPz/lD9bKDIJxxi5ZUgIyB31Ii?= =?us-ascii?Q?mpO1XJMwh4KMlolLexqWRqY9/uAXsOW8SazZB14u/oU9MvTkHoO49UIXGdIc?= =?us-ascii?Q?9Cv+jjKGcauE51/glcB43c7AwDXhuiel7ahQlDFSJtWb8eYMLHetWlvZdhhz?= =?us-ascii?Q?dJ+kNHi4070ZYpiBIYftDo6YODhXSz+sm+m0MMBp6kjqSuAbg7VeNDfF3Pln?= =?us-ascii?Q?lMecC2XEoVPpwEvbZQxatlfjYSWuSkWAgBChwc1CaabhuIXPAOrcKqb5r+5z?= =?us-ascii?Q?T9S/gskRuf0yTCaODGCleC1lN1cQObNPf4vh+CzTvdgIWIeuLLECzcW2plB/?= =?us-ascii?Q?/I35Zw2Iy4JQm3YA1sGz45B8o9Hpdsj1HFhJXw7I7EacEaVAGUwoz7uUQisS?= =?us-ascii?Q?iA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94fee481-8fc7-4807-d828-08dbafee895b X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2023 22:05:24.4554 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FVHI0GpGaITOsvN9Ml+rM/ujk8wW1QXQwly47+xz5U309/VtEyfb9G47hU5nMHV/sBv3NNXrNRueOLUHA3UMDXxID2YzbCnhA6cd3Z1ChnA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8426 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: PHe6fVeyNQARbyTsHbOJsDntx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=bwYG1Uly; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io I was asking about the property of the global variables being used in this patch. Are they already guaranteed to be in BSD format and in range 0..9. If so, then no additional code changes would be required. However, it would be good=20 to add comments about the properties of those global variables and why they can be used to directly assign to fields that are required to be in BSD format. Mike > -----Original Message----- > From: Lien, HoraceX > Sent: Thursday, September 7, 2023 2:41 AM > To: devel@edk2.groups.io; Kinney, Michael D ; > Gao, Liming > Cc: Liu, Zhiguang ; Bi, Dandan > ; Zeng, Star ; Gao, Zhichao > ; Lien, HoraceX > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision > is not match with SMBIOS version >=20 > Hi Mike, >=20 > Could you please reply for me? > If you want to filter range 0-9, then I will send PR again. >=20 > Thanks, > Horace Lien >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Lien, > HoraceX > Sent: Friday, September 1, 2023 3:06 PM > To: Kinney, Michael D ; devel@edk2.groups.io > Cc: Liu, Zhiguang ; Bi, Dandan > ; Zeng, Star ; Gao, Zhichao > > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision > is not match with SMBIOS version >=20 > Hi Mike, >=20 > I have change code to > EntryPointStructureData.SmbiosBcdRevision =3D > ((mPrivateData.Smbios.MajorVersion & 0x0f) << 4) | > (mPrivateData.Smbios.MinorVersion & 0x0f); Add &0x0F to mask upper nibble > bit, do we still need to guarantee that range is between 0-9? Because the > old code only filtered 4 bits, instead of accurately filtering the number > range 0-9. >=20 > Thanks, > Horace Lien >=20 > -----Original Message----- > From: Kinney, Michael D > Sent: Thursday, August 31, 2023 11:56 PM > To: devel@edk2.groups.io; Lien, HoraceX > Cc: Liu, Zhiguang ; Bi, Dandan > ; Zeng, Star ; Gao, Zhichao > ; Kinney, Michael D > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision > is not match with SMBIOS version >=20 > Are mPrivateData.Smbios.MajorVersion and mPrivateData.Smbios.MinorVersion > guaranteed to be in range 0..9? >=20 > Mike >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of > > horacex.lien@intel.com > > Sent: Wednesday, August 30, 2023 2:13 AM > > To: devel@edk2.groups.io > > Cc: Lien, HoraceX ; Liu, Zhiguang > > ; Bi, Dandan ; Zeng, Star > > ; Gao, Zhichao > > Subject: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision > > is not match with SMBIOS version > > > > From: HoraceX Lien > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4544 > > > > These value of Major/Minor version are updated from SMBIOS memory > > data, but BCD Revision is updated from PCD PcdSmbiosVersion. > > We should also update PCD PcdSmbiosVersion from SMBIOS memory data, to > > ensure that get consistent version value. > > > > Cc: Zhiguang Liu > > Cc: Dandan Bi > > Cc: Star Zeng > > Cc: Zhichao Gao > > Signed-off-by: HoraceX Lien > > --- > > MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c > > b/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c > > index 1a86e69d3c..e3f6215033 100644 > > --- a/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c > > +++ b/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c > > @@ -1072,7 +1072,7 @@ SmbiosCreateTable ( > > DEBUG ((DEBUG_INFO, "SmbiosCreateTable: Initialize 32-bit entry > > point structure\n")); > > > > EntryPointStructureData.MajorVersion =3D > > mPrivateData.Smbios.MajorVersion; > > > > EntryPointStructureData.MinorVersion =3D > > mPrivateData.Smbios.MinorVersion; > > > > - EntryPointStructureData.SmbiosBcdRevision =3D (UINT8)((PcdGet16 > > (PcdSmbiosVersion) >> 4) & 0xf0) | (UINT8)(PcdGet16 (PcdSmbiosVersion) > > & 0x0f); > > > > + EntryPointStructureData.SmbiosBcdRevision =3D > > (mPrivateData.Smbios.MajorVersion << 4) | > > mPrivateData.Smbios.MinorVersion; > > > > PhysicalAddress =3D 0xffffffff; > > > > Status =3D gBS->AllocatePages ( > > > > > > AllocateMaxAddress, > > > > -- > > 2.31.1.windows.1 > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#108150): > > https://edk2.groups.io/g/devel/message/108150 > > Mute This Topic: https://groups.io/mt/101057293/1643496 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub > > [michael.d.kinney@intel.com] > > -=3D-=3D-=3D-=3D-=3D-=3D > > >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108425): https://edk2.groups.io/g/devel/message/108425 Mute This Topic: https://groups.io/mt/101057293/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-