Re: [edk2-devel] [PATCH v3 0/2] EDK2 Code First: PI Specification: Expand PI Status Codes

Re: [edk2-devel] [PATCH v3 0/2] EDK2 Code First: PI Specification: Expand PI Status Codes

[Kun Qin]

Hi community maintainers,

It has been a few weeks since the patches being sent out. Could anyone 
please provide any feedback on this code-first series so that we can 
keep the wheels rolling as the first step of N?

Thanks in advance.

Regards,
Kun

On 02/03/2022 11:03, Kun Qin via groups.io wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3794
> 
> This patch series is a rebase of previous submission:
> https://edk2.groups.io/g/devel/message/85335
> 
> In current Status Codes definitions of PI spec v1.7 errata, there are a
> few instances where the software could trigger system reboots while the
> corresponding case were not covered by the already defined status codes.
> 
> One scenario that OEMs would be interested is that fragmented memory map
> from boot to boot would fail to meet certain OS ACPI requirements (i.e.
> S4 resume boot requires consistent memory maps) and trigger system
> reboots. Yet the corresponding case was not covered by the already
> defined status codes.
> 
> The unexpected system reboots above could indicate decay of system health
> and reporting of such generic events would provide helpful information to
> OEMs to investigate/prevent system failures in general.
> 
> The change intends to expand definitions of `EFI_SW_EC_**` under Status
> Codes to cover more unexpected system reboot events, which could improve
> Status Code futility and readability.
> 
> Compared to previous series, v3 patch changes mainly include:
> a. Added BZ3794 prefix for newly added macro definitions;
> 
> Patch v3 branch: https://github.com/kuqin12/edk2/tree/BZ3794-expand_status_codes_v3
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> 
> Kun Qin (2):
>    EDK2 Code First: PI Specification: New error codes of Host Software
>      class
>    MdePkg: MmCommunication: Add new Host Software class Error Code to
>      MdePkg
> 
>   CodeFirst/BZ3794-SpecChange.md   | 55 ++++++++++++++++++++
>   MdePkg/Include/Pi/PiStatusCode.h |  1 +
>   2 files changed, 56 insertions(+)
>   create mode 100644 CodeFirst/BZ3794-SpecChange.md
> 

Re: [edk2-devel] [PATCH v3 0/2] EDK2 Code First: PI Specification: Expand PI Status Codes

[Michael D Kinney]

Hi Kun,

The EDK II Code First Process says the branch should be 
against the edk2-staging repo.  

Your patches are for the edk2 repo.

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Kun Qin
> Sent: Wednesday, February 16, 2022 6:13 PM
> To: devel@edk2.groups.io
> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <leif@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>
> Subject: Re: [edk2-devel] [PATCH v3 0/2] EDK2 Code First: PI Specification: Expand PI Status Codes
> 
> Hi community maintainers,
> 
> It has been a few weeks since the patches being sent out. Could anyone
> please provide any feedback on this code-first series so that we can
> keep the wheels rolling as the first step of N?
> 
> Thanks in advance.
> 
> Regards,
> Kun
> 
> On 02/03/2022 11:03, Kun Qin via groups.io wrote:
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3794
> >
> > This patch series is a rebase of previous submission:
> > https://edk2.groups.io/g/devel/message/85335
> >
> > In current Status Codes definitions of PI spec v1.7 errata, there are a
> > few instances where the software could trigger system reboots while the
> > corresponding case were not covered by the already defined status codes.
> >
> > One scenario that OEMs would be interested is that fragmented memory map
> > from boot to boot would fail to meet certain OS ACPI requirements (i.e.
> > S4 resume boot requires consistent memory maps) and trigger system
> > reboots. Yet the corresponding case was not covered by the already
> > defined status codes.
> >
> > The unexpected system reboots above could indicate decay of system health
> > and reporting of such generic events would provide helpful information to
> > OEMs to investigate/prevent system failures in general.
> >
> > The change intends to expand definitions of `EFI_SW_EC_**` under Status
> > Codes to cover more unexpected system reboot events, which could improve
> > Status Code futility and readability.
> >
> > Compared to previous series, v3 patch changes mainly include:
> > a. Added BZ3794 prefix for newly added macro definitions;
> >
> > Patch v3 branch: https://github.com/kuqin12/edk2/tree/BZ3794-expand_status_codes_v3
> >
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> >
> > Kun Qin (2):
> >    EDK2 Code First: PI Specification: New error codes of Host Software
> >      class
> >    MdePkg: MmCommunication: Add new Host Software class Error Code to
> >      MdePkg
> >
> >   CodeFirst/BZ3794-SpecChange.md   | 55 ++++++++++++++++++++
> >   MdePkg/Include/Pi/PiStatusCode.h |  1 +
> >   2 files changed, 56 insertions(+)
> >   create mode 100644 CodeFirst/BZ3794-SpecChange.md
> >
> 
> 
> 
>