Re: [edk2-devel] [PATCH v1 3/3] EmbeddedPkg: Only run in CI for GCC5

["Michael D Kinney" <michael.d.kinney@intel.com>]

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

> -----Original Message-----
> From: Michael Kubacki <mikuback@linux.microsoft.com>
> Sent: Tuesday, September 6, 2022 8:27 PM
> To: devel@edk2.groups.io
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Abner Chang <abner.chang@amd.com>;
> Daniel Schaefer <git@danielschaefer.me>; Sean Brogan <sean.brogan@microsoft.com>; Barkelew, Bret
> <bret.barkelew@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
> Subject: Re: [edk2-devel] [PATCH v1 3/3] EmbeddedPkg: Only run in CI for GCC5
> 
> I forgot to add .azurepipelines maintainers to this patch. To avoid
> resending the whole series to the list +Cc here and v2 will include the
> maintainers directly on this patch.
> 
> Thanks,
> Michael
> 
> On 9/6/2022 10:36 PM, Michael Kubacki wrote:
> > From: Michael Kubacki <michael.kubacki@microsoft.com>
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4046
> >
> > This package currently does not build on non-GCC toolchains.
> >
> > This change adds the package to edk2 CI so it can benefit from
> > ongoing CI and only tests the package against GCC.
> >
> > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Abner Chang <abner.chang@amd.com>
> > Cc: Daniel Schaefer <git@danielschaefer.me>
> > Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> > ---
> >   .azurepipelines/templates/pr-gate-build-job.yml | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
> > index 0e4ad019bf03..54a74a1a9873 100644
> > --- a/.azurepipelines/templates/pr-gate-build-job.yml
> > +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> > @@ -21,6 +21,10 @@ jobs:
> >     #Use matrix to speed up the build process
> >     strategy:
> >       matrix:
> > +      ${{ if eq(parameters.tool_chain_tag, 'GCC5') }}:
> > +        TARGET_GCC_ONLY:
> > +          Build.Pkgs: 'EmbeddedPkg'
> > +          Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
> >         TARGET_ARM_ARMPLATFORM:
> >           Build.Pkgs: 'ArmPkg,ArmPlatformPkg'
> >           Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'