From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id 304CDD801B0 for ; Tue, 16 Apr 2024 05:32:05 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=oi+YT9LqMBPasTXZg9yGQL96RiLuLFPctwYdDemfBA8=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1713245524; v=1; b=HC28bXauadWQ6oauhwP84pFKTw5hA2m2QrUYNXajAefrzvQ7g6Jzgc6nTbEDHOOIgT9I4K2U qzoC/PN+nDWcR2CauNu/VqQD4UAgH32uP6GZOriMgCHjb/sBESwa9VJcJAhRFmCiMm+RbmJb0Ic /QUG8p2uu6rj0goRm3fi3RfBAQG5kLc/B+CguVGWRcU6TSWLyQRgqQMg+kZXgBwsJWceJegDKTF CgP1A1fa+vNuKeqR26h1C7P8tHP9NO3sNf7WV5nvRlfyiZmOX+ydCj1PcRQ/TJ2p3FQ6+MWRGU5 2Mycwfp3F3jwSNcQvVqZA/gGyt5d20HqYPbcQBLVkXaCA== X-Received: by 127.0.0.2 with SMTP id bmFOYY7687511xzU18nqNRyb; Mon, 15 Apr 2024 22:32:04 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by mx.groups.io with SMTP id smtpd.web11.13019.1713245523943573627 for ; Mon, 15 Apr 2024 22:32:04 -0700 X-CSE-ConnectionGUID: GaGkkmGmTnmeqb63NvGxdQ== X-CSE-MsgGUID: /9C935VDRDaZmSP/ZchhLA== X-IronPort-AV: E=McAfee;i="6600,9927,11045"; a="8790075" X-IronPort-AV: E=Sophos;i="6.07,205,1708416000"; d="scan'208";a="8790075" X-Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2024 22:32:04 -0700 X-CSE-ConnectionGUID: jMC8HO5gRDOLyep59BzYKA== X-CSE-MsgGUID: TMGe0KETRgyTSwtJxCTcZQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,205,1708416000"; d="scan'208";a="22550132" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa006.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 Apr 2024 22:32:03 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 15 Apr 2024 22:32:02 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 15 Apr 2024 22:32:02 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 15 Apr 2024 22:32:02 -0700 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by MW3PR11MB4521.namprd11.prod.outlook.com (2603:10b6:303:55::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.31; Tue, 16 Apr 2024 05:31:59 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::e34e:4d18:b93e:c368]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::e34e:4d18:b93e:c368%5]) with mapi id 15.20.7472.027; Tue, 16 Apr 2024 05:31:59 +0000 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "Clark-williams, Zachary" , "Tan, Ming" CC: "Kasbekar, Saloni" , "Bi, Dandan" , "POLUDOV, FELIX" , "Liu, Liqi" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH] NetworkPkg/WifiConnectionManagerDxe: Update UI according to UEFI spec Thread-Topic: [edk2-devel] [PATCH] NetworkPkg/WifiConnectionManagerDxe: Update UI according to UEFI spec Thread-Index: AQHae/eHzbgErTDKTkKr9vPrjR/N0bFhyTQAgAi9jDA= Date: Tue, 16 Apr 2024 05:31:59 +0000 Message-ID: References: <20240322011611.7297-1-ming.tan@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|MW3PR11MB4521:EE_ x-ms-office365-filtering-correlation-id: 856157c3-ecae-4d11-b5ce-08dc5dd689f0 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 8I/eVK+3NNDHi3fTvqLVPrf9MFCnhnWy/I5QLB8Xn+elk9QnQDSBcdqO4T7Rffj4aMZ7aQKzs398hh5dQM4fNxwOUMlyY2a5/ZWOrcJ6lm5Tqi4F+iH+izF7/Jayv/nIKq8CD5x40Q5KRGXfP93+tJ/30AkijwKxaNXx+SWJTLXrb2JFdFJSRBLau03UrqhejrG/u8ONIs5MfcJAwvnb1h6YC4le8ccwGifYdha2b+FRTFJ2K26rs3pZ51KVkLCgNC1aqVgtwt7NWh3+DpaMgWCYc2SSFZvL9M0RiMwW2M6anBHc+7X4RXeOMzbIpk5RTG4iWnvXJT57MZNDi12lHr68qvwtSk/IlPVuAGFIT64NN2UMU0A/DufJufQQI2t35Cznbl0ADseiTDYzkIJAhZ9mbhoejOxz9VwhxdFEfQmxF1SRYaWVjxpjUDbFXDWXujk34M82+XRIVEryOdvjXMv3AEk4M0pqtL91CvuScb67/ECdvBWkRxO7xnPzLc6I1+QhN3qu+CgTnFYmgVfNWG/Nm+PcUsll1korRNVuYfjLWkkAIS790x/0bpA3wDd2Yg9HXIKDiYqMgqwShM7/F2cL6L37A63ThQNlpRkZXp2d+Q22Wi5THP6bCir4kd+7rsh+YcJqwBPsJv/7dlqAj4Q5qRFv4spPvya9aWNcoHwekS0FgP1h/TiwD8rKJbh4 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/8Pip3cB6tPkXwvvbYRxSjeid1PGpDEQCAGtioR1RNXqOlS5AKCAKw69cbK6?= =?us-ascii?Q?v4BRRZd8ipm7UINgfAMGfYfHv2IdpPVx73JZYm3ynd7tJTxBcEGhuEqP8dz1?= =?us-ascii?Q?hkj88iWghnXZj0Xi4XMIprEzDxkyIE4c4BRS4AplD4A2AvMXCbNcA0yQQFs+?= =?us-ascii?Q?S2qJiVEov1fL+ry/R+Irtq4mYF4JTqBbMvsNCN4cTZpC7SOH8Y1PXGrhiDba?= =?us-ascii?Q?otRBqGGSgXbkK92Esv7CepoKeeVO+iO0tgv3pGRB+cxqzbryAW9/CYvh4+9H?= =?us-ascii?Q?CsQAVe/DuQsgHJlYaDSAqzjS37Dv1xq7+kaoSepXJlCkRXTGr3JoxpsblKQR?= =?us-ascii?Q?zsRw2WYru1Pm7BO/8+mQ4hbogpYJK5LmM35OP+GVO53q57rTracOGRTNIGYK?= =?us-ascii?Q?iLlmtL379WyxV2S5AZzkErI6Y/1jy7vo4fR2taR0H5ZbHe5oJds7tV61+WBP?= =?us-ascii?Q?ZQMEIAwJvzMNqBq9K6l0POtSczTMPxFvn4oAKtvxdT9LDUihodkucrCBZrxN?= =?us-ascii?Q?uvp/AwP4UUD46HZzx2p0MHChDACoo/1DuxmOp9BfT4UePEupWY+M1wKUWTH/?= =?us-ascii?Q?BeFM6CSAH1m5IEUyBWWqOqA2fA7Eb8L+DHYZwi1VpByu/mh1iTz7iCBEq6Qo?= =?us-ascii?Q?c0K8Lc6mHhVrTjLAmOhM5Q515JpA7JzAkgEYgdfKpmXMXOjVrC+TTnqsJBXY?= =?us-ascii?Q?BmNCv224KtFxOLCqA9wy0lvUI/QN5oJqrpkIIbis9dwNdABzy0BI/TuXoUBz?= =?us-ascii?Q?RPPimAtnnksLSWY/zBs6Z+DPuE5HftWkxEy5ewPouIbEuY5OjYEV25IVO/6c?= =?us-ascii?Q?k58OyH3gtRfv/A1b90nd9tWO+6D+1OWfPXsu6MQdo1BW/hgpyg+zi7nmdd3S?= =?us-ascii?Q?bryK52ABINei3fyv+K5RK6BRYOeJ7Q3TqODeeeG0cGRKN46fmE8gdgyY6P/y?= =?us-ascii?Q?/XAEf0X4D5w5OAFAMS4NcSYtShxC7rJh9PXem83ApbMKQFJXP/+kU6O5vTrH?= =?us-ascii?Q?0GAbpwnTj5MqrhPg89a6Qvfy+dKKJYTIs0+VO6AJP+LWGuP/DTKstmFOUjHD?= =?us-ascii?Q?RRpXdbuO0KczX7lUytbMALnQbFcfxtZmnGchD4HoGduwUThxp9uClaytHD2s?= =?us-ascii?Q?ioDynkIK8Csn4uy9D/CUB9OedLSZ+NMTvuKE7PBqnYxzeI+VptKtiQKzrQHd?= =?us-ascii?Q?ZT7xBdhcQW0S/KXYeTtodkan6HiHWsei8IQ+h8oDVFGVldGTPe3rw8TJopoo?= =?us-ascii?Q?trw2DAMPAA+yi+YdazqyBEM5uJ0vkiLtZ2dhjX/8tLsic7xiZcf1SBPLlrRu?= =?us-ascii?Q?AT+b2IWoZe+EtSOvyHwXNvpevHxfetcXVsvs1sOTAinRjTCw94Chu6rvBzi1?= =?us-ascii?Q?pK6hejqzFU6pXB1NOoDXOvVUu09jCAwURzwLergq0bTGSEDTzAJ5OJ9S/7yh?= =?us-ascii?Q?I89e6yPiN1RoCCHOQmq6JoDPhyNlGiQ6aSfJuMZyWyNmH7oJilYoxJhv+Fjb?= =?us-ascii?Q?MrqeEEJI7ugjb12taNbxtx0MAU0NSYc5CkGmAbgOqp92XKd5Ii5Z30Znm+dK?= =?us-ascii?Q?oGMi12MlKp60Fcr8JGhaVDSM5txmDw9BuqKdrP0v9apvonB0ZD0gagkG5qTr?= =?us-ascii?Q?ug=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 856157c3-ecae-4d11-b5ce-08dc5dd689f0 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2024 05:31:59.7866 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1ynnD0fzH5x/0mAetB25G+llwg1sxN5CWJi143xn47OBqbr+5RHqvekaOnuMdIorGqZsV8xJrEl4XiY0UThorBuGIV2/BhZIL5HC/0HOAX4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4521 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 15 Apr 2024 22:32:04 -0700 Resent-From: michael.d.kinney@intel.com Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 6NgHAHcJDjvWlaVFXO3FE8UDx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=HC28bXau; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) Acked-by: Michael D Kinney > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Clark- > williams, Zachary > Sent: Wednesday, April 10, 2024 9:03 AM > To: Tan, Ming ; devel@edk2.groups.io > Cc: Kasbekar, Saloni ; Bi, Dandan > ; POLUDOV, FELIX ; Liu, Liqi > > Subject: Re: [edk2-devel] [PATCH] NetworkPkg/WifiConnectionManagerDxe: > Update UI according to UEFI spec >=20 > Reviewed-by: Zachary Clark-Williams >=20 > -----Original Message----- > From: Tan, Ming > Sent: Thursday, March 21, 2024 6:16 PM > To: devel@edk2.groups.io > Cc: Kasbekar, Saloni ; Clark-williams, > Zachary ; Bi, Dandan > ; POLUDOV, FELIX ; Liu, Liqi > > Subject: [PATCH] NetworkPkg/WifiConnectionManagerDxe: Update UI > according to UEFI spec >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4736 >=20 > In UEFI_Spec_2_10_Aug29.pdf page 1694 section 35.5.4 for > EFI_BROWSER_ACTION_FORM_OPEN: > NOTE: EFI_FORM_BROWSER2_PROTOCOL.BrowserCallback() cannot be used with > this browser action because question values have not been retrieved > yet. >=20 > So should not call HiiGetBrowserData() and HiiSetBrowserData() in > FORM_OPEN call back function. >=20 > Now use wifi list key and enroll cert key instead of the connect > action key, move wifi info display from open action to close action. >=20 > Cc: Saloni Kasbekar > Cc: Zachary Clark-williams > Cc: Dandan Bi > Cc: Felix Polyudov > Signed-off-by: Liqi Liu > Signed-off-by: Ming Tan > --- > PR: https://github.com/tianocore/edk2/pull/5487 >=20 > .../WifiConnectionMgrHiiConfigAccess.c | 113 ++++++++++++----- > - > 1 file changed, 74 insertions(+), 39 deletions(-) >=20 > diff --git > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrHiiConfigAccess > .c > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrHiiConfigAccess > .c > index 431fcbb33a..f242bdf056 100644 > --- > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrHiiConfigAccess > .c > +++ > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrHiiConfigAcce > +++ ss.c > @@ -1412,7 +1412,9 @@ WifiMgrDxeHiiConfigAccessCallback ( > return EFI_OUT_OF_RESOURCES; } - HiiGetBrowserData > (&gWifiConfigFormSetGuid, mVendorStorageName, BufferSize, (UINT8 > *)IfrNvData);+ if (Action !=3D EFI_BROWSER_ACTION_FORM_OPEN) {+ > HiiGetBrowserData (&gWifiConfigFormSetGuid, mVendorStorageName, > BufferSize, (UINT8 *)IfrNvData);+ } if (Action =3D=3D > EFI_BROWSER_ACTION_FORM_OPEN) { switch (QuestionId) {@@ -1438,43 > +1440,6 @@ WifiMgrDxeHiiConfigAccessCallback ( > break; - case KEY_CONNECT_ACTION:-- if (Private- > >CurrentNic->UserSelectedProfile =3D=3D NULL) {- break;- > }-- Profile =3D Private->CurrentNic->UserSelectedProfile;-- > //- // Enter the network connection configuration page- > // Recovery from restored data- //- if (HiiSetString > (Private->RegisteredHandle, STRING_TOKEN (STR_SSID), Profile->SSId, > NULL) =3D=3D 0) {- return EFI_OUT_OF_RESOURCES;- }-- > IfrNvData->SecurityType =3D Profile->SecurityType;- if > (HiiSetString (- Private->RegisteredHandle,- > STRING_TOKEN (STR_SECURITY_TYPE),- > mSecurityType[IfrNvData->SecurityType],- NULL- > ) =3D=3D 0)- {- return EFI_OUT_OF_RESOURCES;- }-- > if ((IfrNvData->SecurityType =3D=3D SECURITY_TYPE_WPA2_ENTERPRISE) ||- > (IfrNvData->SecurityType =3D=3D SECURITY_TYPE_WPA3_ENTERPRISE))- {= - > IfrNvData->EapAuthMethod =3D Profile->EapAuthMethod;- > IfrNvData->EapSecondAuthMethod =3D Profile->EapSecondAuthMethod;- > StrCpyS (IfrNvData->EapIdentity, EAP_IDENTITY_SIZE, Profile- > >EapIdentity);- }-- break;- case > KEY_ENROLLED_CERT_NAME: if (Private->CurrentNic- > >UserSelectedProfile =3D=3D NULL) {@@ -1524,6 +1489,43 @@ > WifiMgrDxeHiiConfigAccessCallback ( > } } else if (Action =3D=3D EFI_BROWSER_ACTION_FORM_CLOSE) { > switch (QuestionId) {+ case KEY_EAP_ENROLL_CERT_FROM_FILE:++ > if (Private->CurrentNic->UserSelectedProfile =3D=3D NULL) {+ > break;+ }++ Profile =3D Private->CurrentNic- > >UserSelectedProfile;++ //+ // Enter the network > connection configuration page+ // Recovery from restored data+ > //+ if (HiiSetString (Private->RegisteredHandle, STRING_TOKEN > (STR_SSID), Profile->SSId, NULL) =3D=3D 0) {+ return > EFI_OUT_OF_RESOURCES;+ }++ IfrNvData->SecurityType =3D > Profile->SecurityType;+ if (HiiSetString (+ > Private->RegisteredHandle,+ STRING_TOKEN > (STR_SECURITY_TYPE),+ mSecurityType[IfrNvData- > >SecurityType],+ NULL+ ) =3D=3D 0)+ {+ > return EFI_OUT_OF_RESOURCES;+ }++ if ( (IfrNvData- > >SecurityType =3D=3D SECURITY_TYPE_WPA2_ENTERPRISE)+ || > (IfrNvData->SecurityType =3D=3D SECURITY_TYPE_WPA3_ENTERPRISE))+ {= + > IfrNvData->EapAuthMethod =3D Profile->EapAuthMethod;+ > IfrNvData->EapSecondAuthMethod =3D Profile->EapSecondAuthMethod;+ > StrCpyS (IfrNvData->EapIdentity, EAP_IDENTITY_SIZE, Profile- > >EapIdentity);+ }++ break;+ case > KEY_CONNECT_ACTION: if (Private->CurrentNic- > >UserSelectedProfile =3D=3D NULL) {@@ -1909,6 +1911,39 @@ > WifiMgrDxeHiiConfigAccessCallback ( > NULL ); }++ if > (Private->CurrentNic->UserSelectedProfile =3D=3D NULL) {+ > break;+ }++ Profile =3D Private->CurrentNic- > >UserSelectedProfile;++ //+ // Enter the network > connection configuration page+ // Recovery from restored > data+ //+ if (HiiSetString (Private- > >RegisteredHandle, STRING_TOKEN (STR_SSID), Profile->SSId, NULL) =3D=3D 0= ) > {+ return EFI_OUT_OF_RESOURCES;+ }++ > IfrNvData->SecurityType =3D Profile->SecurityType;+ if > (HiiSetString (+ Private->RegisteredHandle,+ > STRING_TOKEN (STR_SECURITY_TYPE),+ > mSecurityType[IfrNvData->SecurityType],+ NULL+ > ) =3D=3D 0)+ {+ return EFI_OUT_OF_RESOURCES;+ > }++ if ( (IfrNvData->SecurityType =3D=3D > SECURITY_TYPE_WPA2_ENTERPRISE)+ || (IfrNvData- > >SecurityType =3D=3D SECURITY_TYPE_WPA3_ENTERPRISE))+ {+ > IfrNvData->EapAuthMethod =3D Profile->EapAuthMethod;+ > IfrNvData->EapSecondAuthMethod =3D Profile->EapSecondAuthMethod;+ > StrCpyS (IfrNvData->EapIdentity, EAP_IDENTITY_SIZE, Profile- > >EapIdentity);+ } } break;@@ -1944,7 +1979,7 > @@ WifiMgrDxeHiiConfigAccessCallback ( > } } - if (!EFI_ERROR (Status)) {+ if (!EFI_ERROR (Status) && > (Action !=3D EFI_BROWSER_ACTION_FORM_OPEN)) { // // Pass changed > uncommitted data back to Form Browser. //-- > 2.31.1.windows.1 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117849): https://edk2.groups.io/g/devel/message/117849 Mute This Topic: https://groups.io/mt/105077953/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-