Re: [edk2-devel] [edk2 Patch 2 1/1] EmbeddedPkg: compiler error due to arithmetic operation on void pointer

["Michael D Kinney" <michael.d.kinney@intel.com>]

Acked-by: Michael D Kinney <michael.d.kinney@intel.com>

Request to merge into edk2-stable202402 is approved.

PR opened: https://github.com/tianocore/edk2/pull/5363

Mike

> -----Original Message-----
> From: Ard Biesheuvel <ardb@kernel.org>
> Sent: Friday, February 9, 2024 3:57 AM
> To: Laszlo Ersek <lersek@redhat.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Liming Gao (Byosoft address)
> <gaoliming@byosoft.com.cn>
> Cc: Jayaprakash, N <n.jayaprakash@intel.com>; devel@edk2.groups.io;
> Rebecca Cran <rebecca@bsdio.com>; Leif Lindholm
> <quic_llindhol@quicinc.com>; Abner Chang <abner.chang@amd.com>
> Subject: Re: [edk2 Patch 2 1/1] EmbeddedPkg: compiler error due to
> arithmetic operation on void pointer
> 
> (cc Liming)
> 
> On Wed, 7 Feb 2024 at 20:00, Laszlo Ersek <lersek@redhat.com> wrote:
> >
> > On 2/6/24 17:19, Jayaprakash N wrote:
> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4668
> > >
> > > This commit fixes the issue reported in the BZ4668.
> > > The EmbeddedPkg fails to compile with a compiler error
> > > generated due to invalid/illegal arithmetic operation
> > > on void pointers. It has been fixed by using explicit
> > > type conversion of the void pointer to UINTN.
> > >
> > > Cc: Rebecca Cran <rebecca@bsdio.com>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Laszlo Ersek <lersek@redhat.com>
> > > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > > Cc: Abner Chang <abner.chang@amd.com>
> > > Cc: Jayaprakash N <n.jayaprakash@intel.com>
> > > Signed-off-by: Jayaprakash N <n.jayaprakash@intel.com>
> > > ---
> > >  .../Library/PrePiMemoryAllocationLib/MemoryAllocationLib.c      |
> 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git
> a/EmbeddedPkg/Library/PrePiMemoryAllocationLib/MemoryAllocationLib.c
> b/EmbeddedPkg/Library/PrePiMemoryAllocationLib/MemoryAllocationLib.c
> > > index fa81cc9d59..f4077c04a7 100644
> > > ---
> a/EmbeddedPkg/Library/PrePiMemoryAllocationLib/MemoryAllocationLib.c
> > > +++
> b/EmbeddedPkg/Library/PrePiMemoryAllocationLib/MemoryAllocationLib.c
> > > @@ -308,7 +308,7 @@ ReallocatePool (
> > >    if (OldBuffer != NULL) {
> > >      HandOffHob = GetHobList ();
> > >      ASSERT (((EFI_PHYSICAL_ADDRESS)(UINTN)OldBuffer >= HandOffHob-
> >EfiMemoryBottom));
> > > -    ASSERT (((EFI_PHYSICAL_ADDRESS)(UINTN)(OldBuffer + OldSize) <=
> HandOffHob->EfiFreeMemoryBottom));
> > > +    ASSERT (((EFI_PHYSICAL_ADDRESS)((UINTN)OldBuffer + OldSize) <=
> HandOffHob->EfiFreeMemoryBottom));
> > >    }
> > >
> > >    DEBUG_CODE_END ();
> >
> > Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> >
> 
> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> 
> Liming, Michael - please apply this for the stable tag


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115311): https://edk2.groups.io/g/devel/message/115311
Mute This Topic: https://groups.io/mt/104200842/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-