From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: [edk2-devel] GitHub PR Code Review process now active
Date: Tue, 28 May 2024 18:53:37 +0000 [thread overview]
Message-ID: <CO1PR11MB4929D9D5F35DDA618A6A141CD2F12@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
Hello,
The GitHub PR code review process is now active. Please
use the new PR based code review process for all new
submissions starting today.
* The Wiki has been updated with the process changes.
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process
Big thanks to Michael Kubacki for writing up all the
changes based on the RFC proposal and community discussions.
We will learn by using, so if you see anything missing or
incorrect or clarifications needed, please send feedback
here so the Wiki pages can be updated quickly for everyone.
* The edk2 repo settings have been updated to require
a GitHub PR code review approval before merging and
all conversations must be resolved before merging.
* A PR has been opened that removes the requirement for
Cc: tags in the commit messages and is the first PR
that will use the new process. This PR needs to be
reviewed and merged to support the revised commit
message format.
https://github.com/tianocore/edk2/pull/5688
https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format
* Please use "Draft" PRs to run CI without any reviews.
Once ready for reviews, convert from "Draft" to
"Ready for Review".
* For active code reviews that are almost complete and will
be ready for merge in the next few days, the submitter may
choose to either complete using the email review process,
or switch to the PR based code review process.
* For active code reviews that are expected to take more than
a few days to complete, please convert to a PR based code review.
Thanks,
Mike
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119311): https://edk2.groups.io/g/devel/message/119311
Mute This Topic: https://groups.io/mt/106355103/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next reply other threads:[~2024-05-28 18:53 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 18:53 Michael D Kinney [this message]
2024-05-29 6:38 ` [edk2-devel] GitHub PR Code Review process now active Gerd Hoffmann
2024-05-29 15:00 ` Michael D Kinney
2024-05-29 16:38 ` Gerd Hoffmann
2024-05-29 18:09 ` Michael D Kinney
2024-05-29 18:18 ` Rebecca Cran
2024-05-29 18:27 ` Michael D Kinney
2024-05-29 19:25 ` Michael Kubacki
2024-05-29 20:06 ` Michael D Kinney
2024-05-30 0:51 ` Michael Kubacki
2024-05-30 17:38 ` Saloni Kasbekar
2024-05-30 18:00 ` Michael D Kinney
2024-05-31 3:50 ` Michael D Kinney
2024-05-31 4:36 ` Michael Kubacki
2024-06-21 5:15 ` Dhaval Sharma
2024-06-21 5:25 ` Michael D Kinney
2024-05-30 8:32 ` Gerd Hoffmann
2024-05-30 14:10 ` Michael D Kinney
2024-05-29 10:40 ` Chang, Abner via groups.io
2024-05-29 14:44 ` Michael D Kinney
2024-05-29 14:48 ` Chang, Abner via groups.io
2024-05-30 0:41 ` Yao, Jiewen
2024-06-03 16:13 ` Neal Gompa
2024-06-03 16:26 ` Michael D Kinney
2024-06-03 18:46 ` Neal Gompa
2024-06-03 19:38 ` Michael D Kinney
2024-06-05 22:21 ` Michael D Kinney
2024-06-05 22:47 ` Rebecca Cran via groups.io
2024-06-05 23:27 ` Michael D Kinney
2024-06-16 22:08 ` Rebecca Cran
2024-06-06 1:21 ` Guo Dong
2024-06-06 1:37 ` Michael D Kinney
2024-06-04 13:23 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB4929D9D5F35DDA618A6A141CD2F12@CO1PR11MB4929.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox