From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id BB10C78003C for ; Tue, 18 Jun 2024 15:05:19 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=PJwrmz8L3pMN9B7QfihzhRPkr+J4k4xusGNfTFV9WQo=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1718723119; v=1; b=n8boqKsK2zTJuLDk9Mm8ZJmAaUt7nficokdGyPlLoEekObIPXkihED7ll9q9iJnAk+r3Eqmx 6n6GchfEBJdqPTzsVCEvGsPGMdKKqgLU/XA1xahQ8dCxvnx7ZYyZaCnwlPhqEQ7dtX+Ly6HRQw2 Gsk9yA0VeuMhs/LWXpq8Qr/cGmY/l8Hp1NOINah0+VMNoaHN7hmwJ6kYFjVwbmzB6xhYcn0QW6D 4SWuLihvpGSgoB1r+J5e3iOtlDrpazxtBsDEGeiEGPEBZl4EsfbM55FDFAMjfgIwAOhAdPlQtO4 WuwvqvA0W03PQLvTMW+fYJFtsZ5ttDa6XRYIlc8Dkv3iQ== X-Received: by 127.0.0.2 with SMTP id O0XNYY7687511xYcHUZzmtrB; Tue, 18 Jun 2024 08:05:18 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by mx.groups.io with SMTP id smtpd.web11.88731.1718723112629956870 for ; Tue, 18 Jun 2024 08:05:12 -0700 X-CSE-ConnectionGUID: QI4roLUQQ8SYyz1o/pjOpg== X-CSE-MsgGUID: pbvUPmNdTaOUlCmjWBRIZw== X-IronPort-AV: E=McAfee;i="6700,10204,11107"; a="15727755" X-IronPort-AV: E=Sophos;i="6.08,247,1712646000"; d="scan'208";a="15727755" X-Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2024 08:05:13 -0700 X-CSE-ConnectionGUID: oTHqqYPvRJKtei+33ACN/w== X-CSE-MsgGUID: 6I6qVQQWR5W0qjprVsebyw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,247,1712646000"; d="scan'208";a="46134522" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Jun 2024 08:05:12 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 18 Jun 2024 08:05:11 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 18 Jun 2024 08:05:11 -0700 X-Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.41) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 18 Jun 2024 08:05:09 -0700 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by PH8PR11MB8038.namprd11.prod.outlook.com (2603:10b6:510:25e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.19; Tue, 18 Jun 2024 15:05:02 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::a886:6510:729d:f9d0]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::a886:6510:729d:f9d0%4]) with mapi id 15.20.7698.017; Tue, 18 Jun 2024 15:05:02 +0000 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "Jayaprakash, N" CC: Rebecca Cran , "Kinney, Michael D" Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc : make python368.inf compile conditionally in AppPkg.dsc Thread-Topic: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc : make python368.inf compile conditionally in AppPkg.dsc Thread-Index: AQHawUuxgF9/greVdEqIh0igfatVq7HNnxvg Date: Tue, 18 Jun 2024 15:05:02 +0000 Message-ID: References: <20240618064850.883-1-n.jayaprakash@intel.com> <20240618064850.883-2-n.jayaprakash@intel.com> In-Reply-To: <20240618064850.883-2-n.jayaprakash@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|PH8PR11MB8038:EE_ x-ms-office365-filtering-correlation-id: 1bcd0dae-cc7c-47fe-7449-08dc8fa807c9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?OZPvBT1hcPovtB2o2C2L8rNtOctQDGbaxTkfm5RYeO2/1/rLafbSBIdbHGM5?= =?us-ascii?Q?DVQcmENXSAHlMhO9uIT0LTsOayhYQPZIyptp0NmSJFiNZEkZmBzBnq3zyees?= =?us-ascii?Q?Rv8yb1FPhEHEMjbtcdA0+vMYHKn8X4yIkOuwzI4JjQZ2crhWtaOB/nyvnFeD?= =?us-ascii?Q?MhruIFYXo5O0apvoaxsFSeNbkaL4m1WG/4WRHEzrM4mq/h+Xi2J3pSGfa5Y6?= =?us-ascii?Q?jEsqqeAb9kMgap0Nx0rtKAanYWU6G6/7uQxFZmLz8ewyOT73nrs+cc7oRS2x?= =?us-ascii?Q?VAfZgunX/4PbBuCSOp8HCcXocbYsCWN/TroSlmtCeAgqprODlz/HVYKphu2a?= =?us-ascii?Q?vsUZGal4nhj7TuTtCW4Ohjqabz2noQdmoUtt7ZmYxStWDwJyNFZX/coegQ8A?= =?us-ascii?Q?glcQAgW3lJ3lEHj2OFz01lv5yl9YeP901HqAldrYDOzeI4qPGaT8zm7T/Um4?= =?us-ascii?Q?31I98gFBk/GCdHZx/bexx1fhOPCgUgL9YVJcbh1O7BGMEWtcuuydYim8Svb7?= =?us-ascii?Q?iAi8C4lfhHFbsRJ8544Ni/YuGVCjq0aQEBjSesBPRZrFeW0VzpbOwU21OmMJ?= =?us-ascii?Q?nOdKpvY0oTnWqRjQ3DFjDgXdJ9PmcC+sFyJteZkmz1ADVNqX6impmyJY2lpY?= =?us-ascii?Q?x10bJvnPEjBCT06KBYVxcRVlopCQvpENhYCwIzD1eUY35d112fcTR3LGKF0D?= =?us-ascii?Q?Dn6bsNT31S1jySFSycXq5vwU0/JU5XrAT4dwtOxh3RR30HmZE8UY2YR9kNci?= =?us-ascii?Q?hfDp2HxQGKkX8VgrBF6TfQn3qiBslygxf50S4YQ74ca4wxqAa59KvCgJMqAR?= =?us-ascii?Q?EeueWylTN4RqBl6YC1riLNJNMcYoEFSyxS0IpGDrTRxE8Wv1YS46tEpDusWX?= =?us-ascii?Q?8x/3KxGFzq7M9Q3yckM8OfL5kCMC+3rA7vSB7T9oigdzjz5DzRYT84KjfygH?= =?us-ascii?Q?B6KWxj5cXpJqLpPj1n7Oi6M6mLJDSThM1rfF3kcDgO5LqfBLyGp2vs47f5wK?= =?us-ascii?Q?svdse6IJUoh63ypG2Xvinq+kXKscmQK70rmoNaSk2FLMoeLBl5TJIRWEbU64?= =?us-ascii?Q?PEh8xybel8bxvOS8wIuJmHtAX88iuvh60X+OLD13zQqcrE0SwlOUDZSEP13S?= =?us-ascii?Q?AsLBYSG7+8pTSox3GlG6TXSteVezPt85i+oe9A2NK75AWmb6kP8o72cZPbx4?= =?us-ascii?Q?Pi1Npqxp7v3q0k2BGq8gGUB4CK5sNYg8RGj7GrYx9iQ1f/6J52T0jVKF0t1J?= =?us-ascii?Q?H/+msHNX6RTLGouU9bCvxy9T3S9wgpUxZuKjuVZ0u8UvuS8DscSZsQlSGMUx?= =?us-ascii?Q?E8krHrMi2E1ZEszWQlhp4jjz?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1i3EaTbgzbtjyENPROTYPbaHS+EiVhIVZYZb9TjJFBTJ6tSThW6ja24tw8y5?= =?us-ascii?Q?dPqsMHi/fgaYMF0IA8Qad1vrQGQ18gzubNExL2GjMQr8wI5SwV7gB5cYzpKq?= =?us-ascii?Q?3zyeBbnsOINWL6C/7ENF93cyRXiTq1JLdkuuutlfjIGDgwX8q1O6XtEMRJk4?= =?us-ascii?Q?cL+z+UqHmAEyiuNQ8dTY0Y3REwJKBw6Y4XE9fID6I8T20jL3w4LXU+ulwjVk?= =?us-ascii?Q?0TOdEYUlOm5WhwQWaifl50D5HQTLvpEBCssdjPncLwZQZzppm+MCuke0Ed0U?= =?us-ascii?Q?1zx5070XTFm8pZpdMrWntcB6sIehZZ1Nkee2FmqDkI/9F+mhXxgaVOupkBG7?= =?us-ascii?Q?Ksh3wxX8nNr3Rt9Zq0i9MmsYOAOheX5AFi/5r/YflIItwYZOi9WYLH4fotYQ?= =?us-ascii?Q?4knJimhRjZjnbfnNwVauXMqOnRvQUImUhsK9IcMZLP8Jg2FeJ7Maeo6kCU9d?= =?us-ascii?Q?ps9WqO8sCV0JmocRoPrAJXuyHkYga0b6/fFMwCdDkMClWMrKatyJVxb126Zh?= =?us-ascii?Q?1TMOP33zWqR25fQAo05JeJgX01bbQGQRCJGFLqz/8VhYETFeMQiRo0wHQ7Ua?= =?us-ascii?Q?QibhXsfY7nLJhskil8FKt1u/bgyoAcY/sHf/N9my39pkbgDYq3CPuy3jozWS?= =?us-ascii?Q?0AHQGa3BHfdL+EJxGyEgK9OMsjRyL5HLN/ij9bW8HIC6Wm9wJ8+EIm8wteZO?= =?us-ascii?Q?axTfJhUcU/yU81gV8RCKVQr9u4yl/kmDlUUAiRjANdTV6fR8VzXQP7hz5aiL?= =?us-ascii?Q?51fNTOt5gbI+ztn34UzWHbF3RG4A/layuzwYxUetXt2GLEOq2ukrrr2xLANo?= =?us-ascii?Q?BhAoiZShVFGPoBJMd6EdmQb9feOQWlIz1MgkQb0QZk5vznCL8LRmsBdeHuqj?= =?us-ascii?Q?pqth5JHyn0PM//XTS6+ITy1q/bknvrn+Sywp4Nei2B7zl0VvrKWAyoGG9t9I?= =?us-ascii?Q?0QZ/WsWFmuA7UGKsuUvRTXq9ljpyQnfRNXg2a08b1l177mVyK1yZayYtxYyb?= =?us-ascii?Q?tumx84jvsDepY3fHdEZXHbgkMrmiVK5l39ShpCktPrJHMiaMZkXCSbtKcK56?= =?us-ascii?Q?u3js8xxfEbqYIuyeQGHvlEcJzLNrPsqfczoeE18Z8q9innnSiUrhzrdVrnlV?= =?us-ascii?Q?8OEFZji/vbmzcfg8/PDYXk4x6vzVZhf8AMNX181tRbpONyZMfuaNArhoCe15?= =?us-ascii?Q?Yo/yJt+M90CBwZ850pMkOGb25EbC66o1p1i101gz1ppL/Y/F+yksCYrUBEfh?= =?us-ascii?Q?DQFbsiDHJA8BGV+ynCMvbIjM1advz3AAnmhL2KqBCjoWLQSD5M5EsK9A3k3b?= =?us-ascii?Q?UKiLukaMyO0BIzlHkqeUsOOPmOgbsNwnmXtnFo5lfSsdM6ggk/nRFLiapDtV?= =?us-ascii?Q?dJMY42Rv8sYzZVuRYAYNeip93r94VkswWI0Sg0xzVrkZb70fDV/XlVWoJGRU?= =?us-ascii?Q?dyiG6xB4tJi2eYt9bGEjaJisfJz09oJBrQtEREA6OoB2SEIb8/YRFs4uGxoQ?= =?us-ascii?Q?I+bAk9/Vy2q2OEVFsh5GXRHEfr+UoZ564/epo5KIhFxHY5OQ529t5ZZ7Q6fd?= =?us-ascii?Q?xeCoQfE5Hk/DCwREpXagGVt4cSJRua2ZGeQL2fO3Co38ru3mVH/0+0mln9bv?= =?us-ascii?Q?Xw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1bcd0dae-cc7c-47fe-7449-08dc8fa807c9 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jun 2024 15:05:02.7540 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b8MhmeYLnH6HZnzg0rxI4F20+AHB7HqYB2UhEsRbmHFJKXU+eTp6ngrzOSF0vraO8I/wknDfR5QXda8SVaVc4FyoHGHXrdaX2m/OYxtXFLc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB8038 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 18 Jun 2024 08:05:12 -0700 Resent-From: michael.d.kinney@intel.com Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: O3399lPVGSEOJdPw5cZeMdnTx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=n8boqKsK; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Michael D Kinney > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Jayaprakas= h, N > Sent: Monday, June 17, 2024 11:46 PM > To: devel@edk2.groups.io > Cc: Jayaprakash, N ; Rebecca Cran > ; Kinney, Michael D > Subject: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc : make python368.in= f > compile conditionally in AppPkg.dsc >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4789 >=20 > This commit adds necessary changes to AppPkg.dsc file for > conditional compilation of python368.inf. To enable compilation > of python368.inf users need to pass an additional parameter > to the build command as -D BUILD_PYTHON368. > Also updated the Py368ReadMe.txt and the GCCCompilationBKMs.rst > to include this additional information for building python368.inf. >=20 > Cc: Rebecca Cran > Cc: Michael D Kinney > Cc: Jayaprakash N > Signed-off-by: Jayaprakash N > --- > AppPkg/AppPkg.dsc | 9 ++++++--- > .../Python/Python-3.6.8/GCCCompilationBKMs.rst | 6 ++---- > AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt | 9 +++------ > 3 files changed, 11 insertions(+), 13 deletions(-) >=20 > diff --git a/AppPkg/AppPkg.dsc b/AppPkg/AppPkg.dsc > index e5a6c5e..89f9f1d 100644 > --- a/AppPkg/AppPkg.dsc > +++ b/AppPkg/AppPkg.dsc > @@ -7,7 +7,7 @@ > # for important information about configuring this package for your > # environment. > # > -# Copyright (c) 2010 - 2021, Intel Corporation. All rights reserved. > +# Copyright (c) 2010 - 2024, Intel Corporation. All rights reserved. > # SPDX-License-Identifier: BSD-2-Clause-Patent > ## >=20 > @@ -120,8 +120,11 @@ > gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x80400040 > } >=20 > -#### Un-comment the following line to build Python 3.6.8. > -# AppPkg/Applications/Python/Python-3.6.8/Python368.inf > +#### Conditional compilation of python368.inf by passing -D BUILD_PYTHON= 368 > +#### through build command > + !if $(BUILD_PYTHON368) > + AppPkg/Applications/Python/Python-3.6.8/Python368.inf > + !endif >=20 > #### Un-comment the following line to build Lua. > # AppPkg/Applications/Lua/Lua.inf > diff --git a/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.r= st > b/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst > index 525bef8..0574977 100644 > --- a/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst > +++ b/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst > @@ -150,17 +150,15 @@ Copy the contents of edk2-libc to edk2 folder:: >=20 > 2.5. Build Python Interpreter using GCC > ---------------------------------------- > -Uncomment the line containing following inf file name in AppPkg/AppPkg.d= sc > file > -AppPkg/Applications/Python/Python-3.6.8/Python368.inf >=20 > Execute the below command to build the X64 version of the Python 3.6.8 > interpreter using GCC tool chain:: >=20 > bash$ cd AppPkg/Applications/Python/Python-3.6.8/ > bash$ python srcprep.py > bash$ cd ~/src/edk2 > - bash$ build -a X64 -b RELEASE -p AppPkg/AppPkg.dsc -m > AppPkg/Applications/Python/Python-3.6.8/Python368.inf > + bash$ build -a X64 -b RELEASE -p AppPkg/AppPkg.dsc -m > AppPkg/Applications/Python/Python-3.6.8/Python368.inf -D BUILD_PYTHON368 > or > - bash$ build -a X64 -b RELEASE -p AppPkg/AppPkg.dsc > + bash$ build -a X64 -b RELEASE -p AppPkg/AppPkg.dsc -D > BUILD_PYTHON368 >=20 >=20 > 2.5 Create Python UEFI package with all dependencies > diff --git a/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt > b/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt > index a6e65fe..5753443 100644 > --- a/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt > +++ b/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt > @@ -68,12 +68,9 @@ and that you can successfully build packages within th= at > distribution. > gc itertools math _operator > time >=20 > - C. Edit AppPkg/AppPkg.dsc to enable (uncomment) the Python368.inf lin= e > - within the [Components] section. > - > - D. Build AppPkg using the standard "build" command: > + C. Build AppPkg using the standard "build" command: > For example, to build Python for an X64 CPU architecture: > - build -a X64 -p AppPkg\AppPkg.dsc > + build -a X64 -p AppPkg\AppPkg.dsc -D BUILD_PYTHON368 >=20 > 4. Python-related paths and files > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D > @@ -133,7 +130,7 @@ system as follows: > 2. Uncomment BsdSocketLib and EfiSocketLib LibraryClasses in Python368= .inf > 3. Uncomment the statement #Modules/socketmodule.c in Python368.inf > 4. Build Python interpreter application using below command > - build -a X64 -p AppPkg\AppPkg.dsc > + build -a X64 -p AppPkg\AppPkg.dsc -D BUILD_PYTHON368 > 5. Copy Build\AppPkg\RELEASE_VS2017\X64\Python.efi to \Efi\Tools on yo= ur > target system. Replace "RELEASE_VS2017", in the source path, with > values appropriate for your tool chain. > -- > 2.45.1.windows.1 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119610): https://edk2.groups.io/g/devel/message/119610 Mute This Topic: https://groups.io/mt/106736573/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-