From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1F68D7803CE for ; Wed, 29 Nov 2023 18:08:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=UVEur5nRj53h/AeVw+QDb+hsDiR8WCycTLq1Y74LlPQ=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701281297; v=1; b=JGpxx86C1/s4dHBgrU/bD88Z9vgUSivZNjS04TxohvCG50SbDgvuvUsPW8o+cpYW5P0DIS8O v1Jf/r7aAjCf1IoQ9ij+YC7d3OiQFio37qR6nA2p4y/TBux2rHU7MEh0doPUgjMYl1HW1RFtVnf AM+3GBovCLs5nNNDqXhOTSME= X-Received: by 127.0.0.2 with SMTP id oDQ0YY7687511xdXgxvOR8Wv; Wed, 29 Nov 2023 10:08:17 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.45334.1701281296513095975 for ; Wed, 29 Nov 2023 10:08:16 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10909"; a="397098028" X-IronPort-AV: E=Sophos;i="6.04,237,1695711600"; d="scan'208";a="397098028" X-Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2023 10:08:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10909"; a="772762266" X-IronPort-AV: E=Sophos;i="6.04,237,1695711600"; d="scan'208";a="772762266" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 29 Nov 2023 10:08:14 -0800 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 29 Nov 2023 10:08:13 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 29 Nov 2023 10:08:13 -0800 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Wed, 29 Nov 2023 10:08:12 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Wed, 29 Nov 2023 10:08:12 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O8uAkNyny+ekazmScrNuQWxC/Wd14acZCSVDP2pEjiZGfGsMlBnPAxVRhDnvKAWcArqSj6voBkOBXH7xLWpMAP6/4Cz7ISOUa0J+ifYHy7C6P4/yr+wsGX1yDNAuHYK27TJKBUr+kruWApztay+ZMVOcgzrklTvgRTaah7sCvx54gznPasixsjfHQmfooYwIT99fU4oFMwlmiz44k+nPbE1rFQqHEPMLaX1wpJVpdPxgflvBYuDgVEyFqIG38h4F8hwhhyiss+3K5loxAbkHy68DffPq//W037YeXeIKBJRvEn8gSCWCOJeqTJHufy3RlkTMQ8ryWuyM0Md9ueYqUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iKc+8ZjaVqtEDCz6t9MQWppAwwYlWEeJRU0e2/gXyMk=; b=E/L70/ckf/av3QLpi1N5QGv3fJrrOKOQ1ylyvRfPYO48xcH4V4TpNyjHZv1GZ4TR6+Npxt3anGL90K3TDp6Zl8iQaE7kLaDxgc21DwnnBJR6ooRiNVntu3jMmixm5unpaTx+SbGdmNxxg6qDy7AQ4OCd/YKgPS/IJSZ3PyDjNMgXCbkBKBjTEcXXyHbl2+a6BLWGkDeUyulGUmdbsj/npIhOdBuXwMHaYkp4S/QRmIiUzY0whNkBOeL2iTDBChJ7W2U4n3uKE5undjgFxJLblrNmgU/Kk2lWnIHlx9hCUlFnKh9WABGhjam6OLlzguZOwN0IpTQKeRKZuSH0B+a/nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by CO1PR11MB5122.namprd11.prod.outlook.com (2603:10b6:303:95::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.23; Wed, 29 Nov 2023 18:08:11 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::4382:5b03:f13:88ff]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::4382:5b03:f13:88ff%5]) with mapi id 15.20.7046.023; Wed, 29 Nov 2023 18:08:10 +0000 From: "Michael D Kinney" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: Joey Vagedes , Laszlo Ersek , Sean Brogan , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH v1 1/1] .github/workflows/codeql.yml: Add emacs output Thread-Topic: [PATCH v1 1/1] .github/workflows/codeql.yml: Add emacs output Thread-Index: AQHaIuXKcE6slzSnvU2PbzT3tlVd9rCRmCgA Date: Wed, 29 Nov 2023 18:08:10 +0000 Message-ID: References: <20231129170105.1598-1-mikuback@linux.microsoft.com> In-Reply-To: <20231129170105.1598-1-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|CO1PR11MB5122:EE_ x-ms-office365-filtering-correlation-id: be4e17bd-66b3-4e95-a9ea-08dbf10625cc x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 9uxHVcqeOOPrUQEiCb5OBoluuBxfqSQ9/WFJqhMscLRD3zD1mCkOh53T1mu0TBgD0q1J8jNkuLlbKZH9/bshHogIN7R/C5S9L6LXVSARYwsRgOsDqWQJ8CW2M5p2JUBIcL2yR1idAgpUVlmWqIp27Grpvletv0HmsnJw2A5rBFgd+f5xrDNpoO1Q3jSv6fhFMIjbvC4jPTflUvaC4argPfyrsz1aSIxCpYfJr4rt6ng490gbz7JBqpkVTG9HAmxRbluhiLs+sbjyfdbc/rWxjTJcAkP636LqGvd3RGdZzedO82WpLcpK3Rh08vYypd7Oa0sw0Rnk/0GByesgL/GXSsavPLFsBFH6pTNjGurwSecKhxsshzRAYtQ4g7aSJlpaTAfkW1I797nz38/8V876f7Xk2w6vrTyTSQbMmdBF9ZkuRhWqUe/wV1g35toh3xfUIK/Y9Kfes7t/Cb0fMtvVJLL1adyoGwbMRxNFpdp+Qb54jmcUMHECmD4PW8sqEfwhrF38uo0e7INHIDrKAaRWWdVfxSYsouS0R+VqVSVx/csozMLBA9o1LXPKX7uLFSeKHIg8kkHZog5Wy4gTX0KDnVlDKY++f/TXm/wTpxCIw2AqLR9PqMFeQBAuMCLFiyBJjYmpc0gUTpYISkgnzmSAqQ== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bd58IaKwYnvXiYV6EXepMM4QT5W7U3n1sqSI8h9fmchpwbnOgZWLQp4//Doe?= =?us-ascii?Q?VYEUm+nLTZn3J6I0d8XsT1cvXi7mD1LxTboh6smrx+plXFiXvlcVC7IElBMC?= =?us-ascii?Q?VlHCyWBg5hOsQ+LijrRTap2WU5/5UnsudWqQaIC1vQgqCIknTKESkxV3Adwk?= =?us-ascii?Q?eUK0e7jK8ZsDWwriNB4SE/2znbN/OjTzj2WmBbIYHHQX3ej7GkXdDzCdfqo+?= =?us-ascii?Q?9LRSo90eandropSAIJ+07iffnmOav82yvyXn8wfOvB7BMk6nGJfxSl2VeSka?= =?us-ascii?Q?aRQXzV4YGiAGbwqZ2AFMwD0FO5xH0SnUVJcu4qSSzNTksxQFF2Opg+ljlqsx?= =?us-ascii?Q?t51mMHeX+lLW5PJmucuUT1jZ0pJI5DbsHdh3WnLNXUmo+Mh2LqZ1/R68yg23?= =?us-ascii?Q?ieAFrkyzf77qQ4WOe37K55ecmmnZvUJUqsJSi3XPMlLHqM/Irrq9r4XtNwna?= =?us-ascii?Q?1A6Avm9cwSAxipJ2Q203bUu2zqIguXN6SZH0/MsnSzL0kyWbEDr0aW/JRgUH?= =?us-ascii?Q?u8dtWWuZ1kwKyXXNQpX/sMyf53HEGoSdEUVYy3u+pQxxodxnfsY3bDSNk6qP?= =?us-ascii?Q?7cQWd0FAFAibnMqWt3J3CxYbHm4wqoxJUD2H4CZSEwAcreDgZjtDIknJ5oYV?= =?us-ascii?Q?a4La+kFCv/tGvxFDsgphM6WODllnICDZZbpKQoFONZ3H3GDeJJoJmwyMzEw6?= =?us-ascii?Q?Vw1b3vb7Araos8Ai7OcFog+1fi0jlcAc7FQLRSVa4yQ5pnrK8leju0aSeVzw?= =?us-ascii?Q?uLBLW8MylFNmh8W9hdWVkbLamgJxL0z3ETkTQXh7bX2n24xRMPoSh/DeJvsl?= =?us-ascii?Q?PZD4I58Hr7ZWRu1Vr1Z9QRsVGXWKd1skvIQTYoyXUV86NthtOGe8oQnFa+PK?= =?us-ascii?Q?J0DEkRQviuBdGrmU7Rq/8RiFSYD6J/5hWq4zGngljAzJ3VdGKTQgMjPFLdsp?= =?us-ascii?Q?ZvgGMEOV5QICtHXr51MKMuVZPaDg3Ix7Q6mWoJtpBe9jXmEHDUm504auM1Qg?= =?us-ascii?Q?JMq06oY0sStz6bHFrtDpDxtjB//nyHJq46lIQTOdeMC4qDaUY9Cx0WlkXpTE?= =?us-ascii?Q?ULbYazv40DyKRex6yCn/FeCG4JkoQepECKQDL9szTp81fDTI9BzBX/g6YUNI?= =?us-ascii?Q?8vs9ts4S6N+54IDj4BSO2WoLCH5owrylkpb3kx67QpqJ0QiXh3hFXOxwYLZo?= =?us-ascii?Q?y9e0qFT3IqcwrBSIPLGQGcrtukUPmXEGIbGKqLHmhzfedPFGEPofVgVTD6nO?= =?us-ascii?Q?IA5K2Ul1S7eAYrVx9ArzUjBhDkbyzwZQCTYQsDfDCK2s4Vnu3UBnofwidHiN?= =?us-ascii?Q?yKvcYHgdvwKJDnQGRc/Kd3Vvd12fghAjzJ2/TxaSxz2cXgRK8XPC9eQKUiTe?= =?us-ascii?Q?xFu/kXhNNpp9lEP3Ac/K7hl6vlG5kDOKj/RTV7JDTxIYmQ6K5UlIS+EB5+iu?= =?us-ascii?Q?ohejP23Q2estLuUZjO6uWE+Vp7SA8Oz1XA2WAQOeXtZcP7KKH9X7FcNXToG0?= =?us-ascii?Q?R7scW+4dL4VL2Nr5WAfUIbonKYnO4Nc+2XXm2wSVVIl5zJZQxpecFIXOBAJX?= =?us-ascii?Q?2Cdd144xz8Tk1j9eSTJ82vl8ct65znLXYPbH+80qB2kK69wMFXwCBI3ZfAq7?= =?us-ascii?Q?iw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: be4e17bd-66b3-4e95-a9ea-08dbf10625cc X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2023 18:08:10.8699 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6owc2kPXhw1yiuvF6dlKLsRhx/qNfJPWN7Xew33b5oMUnqgesiaJN/RFVZuGFJoyxMuoipWIL4q2RCBB+tT1vYaezjJS/CWMCaIi4+WEUJM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5122 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: F6jl32T9cMTWpv22RoBlIuoEx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=JGpxx86C; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Acked-by: Michael D Kinney > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Wednesday, November 29, 2023 9:01 AM > To: devel@edk2.groups.io > Cc: Joey Vagedes ; Laszlo Ersek > ; Kinney, Michael D ; Sean > Brogan > Subject: [PATCH v1 1/1] .github/workflows/codeql.yml: Add emacs output >=20 > From: Michael Kubacki >=20 > Updates the workflow to also output files that can be loaded in emacs > to show CodeQL issues (in addition to the existing SARIF output for > standard SARIF viewers). >=20 > The emacs files are in the SARIF zip file attached to each "CodeQL" > run (https://github.com/tianocore/edk2/actions/workflows/codeql.yml). >=20 > The file name ends with "-emacs.txt". An MdePkg example: > "codeql-db-mdepkg-debug-0-emacs.txt". >=20 > Cc: Joey Vagedes > Cc: Laszlo Ersek > Cc: Michael D Kinney > Cc: Sean Brogan > Signed-off-by: Michael Kubacki > --- >=20 > Notes: > An example CodeQL run with this change: >=20 > https://github.com/tianocore/edk2/actions/runs/7035482184 >=20 > .github/workflows/codeql.yml | 20 ++++++++++++++++---- > 1 file changed, 16 insertions(+), 4 deletions(-) >=20 > diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml > index 72ece9dcb446..e826e67eb912 100644 > --- a/.github/workflows/codeql.yml > +++ b/.github/workflows/codeql.yml > @@ -92,7 +92,7 @@ jobs: > git config --system core.longpaths true >=20 > - name: Install/Upgrade pip Modules > - run: pip install -r pip-requirements.txt --upgrade requests > + run: pip install -r pip-requirements.txt --upgrade requests sarif- > tools >=20 > - name: Determine CI Settings File Supported Operations > id: get_ci_file_operations > @@ -304,16 +304,26 @@ jobs: > PACKAGE_NAME: ${{ matrix.Package }} > shell: python > run: | > + import logging > import os > + from edk2toollib.utility_functions import RunCmd > + from io import StringIO > + from pathlib import Path >=20 > package =3D os.environ['PACKAGE_NAME'].strip().lower() > directory_name =3D 'codeql-analysis-' + package + '-debug' > file_name =3D 'codeql-db-' + package + '-debug-0.sarif' > - sarif_path =3D os.path.join('Build', directory_name, file_name) > + sarif_path =3D Path('Build', directory_name, file_name) >=20 > with open(os.environ['GITHUB_OUTPUT'], 'a') as fh: > - if os.path.isfile(sarif_path): > + if sarif_path.is_file(): > + emacs_file_path =3D sarif_path.with_name(sarif_path.stem= + > "-emacs.txt") > + out_stream_buffer =3D StringIO() > + exit_code =3D RunCmd("sarif", f"emacs {sarif_path} --out= put > {emacs_file_path}", > + outstream=3Dout_stream_buffer, > + logging_level=3Dlogging.NOTSET) > print(f'upload_sarif_file=3Dtrue', file=3Dfh) > + print(f'emacs_file_path=3D{emacs_file_path}', file=3Dfh) > print(f'sarif_file_path=3D{sarif_path}', file=3Dfh) > else: > print(f'upload_sarif_file=3Dfalse', file=3Dfh) > @@ -323,7 +333,9 @@ jobs: > if: steps.env_data.outputs.upload_sarif_file =3D=3D 'true' > with: > name: ${{ matrix.Package }}-CodeQL-SARIF > - path: ${{ steps.env_data.outputs.sarif_file_path }} > + path: | > + ${{ steps.env_data.outputs.emacs_file_path }} > + ${{ steps.env_data.outputs.sarif_file_path }} > retention-days: 14 > if-no-files-found: warn >=20 > -- > 2.43.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111854): https://edk2.groups.io/g/devel/message/111854 Mute This Topic: https://groups.io/mt/102875700/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-