From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Sheng, W" <w.sheng@intel.com>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
"Lu, Xiaoyu1" <xiaoyu1.lu@intel.com>,
"Jiang, Guomin" <guomin.jiang@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH v2] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1t
Date: Tue, 28 Feb 2023 03:26:05 +0000 [thread overview]
Message-ID: <CO1PR11MB4929DD20021B79CDA1C9796DD2AC9@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230228024357.343-1-w.sheng@intel.com>
Hi,
From this patch, it looks like the main change is selecting a
different submodule sha.
Do you know why crypto/bn/rsa_sup_mul.c is required with these changes?
What testing of this change has been done?
Thanks,
Mike
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sheng Wei
> Sent: Monday, February 27, 2023 6:44 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang, Guomin
> <guomin.jiang@intel.com>
> Subject: [edk2-devel] [PATCH v2] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1t
>
> Upgrade openssl to 1.1.1t
> Pick up bugfixes from the latest openssl release.
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Signed-off-by: Sheng Wei <w.sheng@intel.com>
> ---
> CryptoPkg/Library/OpensslLib/OpensslLib.inf | 1 +
> CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf | 1 +
> CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 1 +
> CryptoPkg/Library/OpensslLib/OpensslLibFull.inf | 1 +
> CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf | 1 +
> CryptoPkg/Library/OpensslLib/openssl | 2 +-
> 6 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> index 60c6c24b0a..1474df8125 100644
> --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> @@ -162,6 +162,7 @@
> $(OPENSSL_PATH)/crypto/bn/bn_srp.c
>
> $(OPENSSL_PATH)/crypto/bn/bn_word.c
>
> $(OPENSSL_PATH)/crypto/bn/bn_x931p.c
>
> + $(OPENSSL_PATH)/crypto/bn/rsa_sup_mul.c
>
> $(OPENSSL_PATH)/crypto/buffer/buf_err.c
>
> $(OPENSSL_PATH)/crypto/buffer/buffer.c
>
> $(OPENSSL_PATH)/crypto/cmac/cm_ameth.c
>
> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf b/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf
> index 103ef7bda2..3c5f6d5d17 100644
> --- a/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf
> +++ b/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf
> @@ -163,6 +163,7 @@
> $(OPENSSL_PATH)/crypto/bn/bn_srp.c
>
> $(OPENSSL_PATH)/crypto/bn/bn_word.c
>
> $(OPENSSL_PATH)/crypto/bn/bn_x931p.c
>
> + $(OPENSSL_PATH)/crypto/bn/rsa_sup_mul.c
>
> $(OPENSSL_PATH)/crypto/buffer/buf_err.c
>
> $(OPENSSL_PATH)/crypto/buffer/buffer.c
>
> $(OPENSSL_PATH)/crypto/cmac/cm_ameth.c
>
> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> index c4eaea888c..a9adb94720 100644
> --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> +++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> @@ -163,6 +163,7 @@
> $(OPENSSL_PATH)/crypto/bn/bn_srp.c
>
> $(OPENSSL_PATH)/crypto/bn/bn_word.c
>
> $(OPENSSL_PATH)/crypto/bn/bn_x931p.c
>
> + $(OPENSSL_PATH)/crypto/bn/rsa_sup_mul.c
>
> $(OPENSSL_PATH)/crypto/buffer/buf_err.c
>
> $(OPENSSL_PATH)/crypto/buffer/buffer.c
>
> $(OPENSSL_PATH)/crypto/cmac/cm_ameth.c
>
> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf b/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf
> index 309e43055c..4c2cbe9cf7 100644
> --- a/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf
> +++ b/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf
> @@ -167,6 +167,7 @@
> $(OPENSSL_PATH)/crypto/bn/bn_srp.c
>
> $(OPENSSL_PATH)/crypto/bn/bn_word.c
>
> $(OPENSSL_PATH)/crypto/bn/bn_x931p.c
>
> + $(OPENSSL_PATH)/crypto/bn/rsa_sup_mul.c
>
> $(OPENSSL_PATH)/crypto/buffer/buf_err.c
>
> $(OPENSSL_PATH)/crypto/buffer/buffer.c
>
> $(OPENSSL_PATH)/crypto/cmac/cm_ameth.c
>
> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf b/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf
> index 4eeeeb79bd..591c57fdc2 100644
> --- a/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf
> +++ b/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf
> @@ -168,6 +168,7 @@
> $(OPENSSL_PATH)/crypto/bn/bn_srp.c
>
> $(OPENSSL_PATH)/crypto/bn/bn_word.c
>
> $(OPENSSL_PATH)/crypto/bn/bn_x931p.c
>
> + $(OPENSSL_PATH)/crypto/bn/rsa_sup_mul.c
>
> $(OPENSSL_PATH)/crypto/buffer/buf_err.c
>
> $(OPENSSL_PATH)/crypto/buffer/buffer.c
>
> $(OPENSSL_PATH)/crypto/cmac/cm_ameth.c
>
> diff --git a/CryptoPkg/Library/OpensslLib/openssl b/CryptoPkg/Library/OpensslLib/openssl
> index 129058165d..830bf8e1e4 160000
> --- a/CryptoPkg/Library/OpensslLib/openssl
> +++ b/CryptoPkg/Library/OpensslLib/openssl
> @@ -1 +1 @@
> -Subproject commit 129058165d195e43a0ad10111b0c2e29bdf65980
> +Subproject commit 830bf8e1e4749ad65c51b6a1d0d769ae689404ba
> --
> 2.26.2.windows.1
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#100532): https://edk2.groups.io/g/devel/message/100532
> Mute This Topic: https://groups.io/mt/97282811/1643496
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [michael.d.kinney@intel.com]
> -=-=-=-=-=-=
>
next prev parent reply other threads:[~2023-02-28 3:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 2:43 [PATCH v2] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1t Sheng Wei
2023-02-28 3:26 ` Michael D Kinney [this message]
2023-03-10 5:58 ` Yao, Jiewen
2023-03-10 18:21 ` [edk2-devel] " Demeter, Miki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB4929DD20021B79CDA1C9796DD2AC9@CO1PR11MB4929.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox