Re: [edk2-devel] [PATCH 0/3] Add NULL IpmiCommandLib instance

["Michael D Kinney" <michael.d.kinney@intel.com>]

Hi Abner,

Since this is moving content from edk2-platforms to edk2, we need to make sure that migration
is coordinated with the edk2-platforms owners for the IPMPI feature and we have a transition plan
for all downstream platform DSC files to use the content from the new location.  These types
of changes can be very disruptive.

Also, since IPMI is an industry standard, it is allowed to add libraries that support industry
standards to the MdePkg.  How was MdeModulePkg selected vs MdePkg?

Thanks,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang, Abner via groups.io
> Sent: Tuesday, December 27, 2022 8:59 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Nickle Wang <nicklew@nvidia.com>; Igor
> Kulchytskyy <igork@ami.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>
> Subject: [edk2-devel] [PATCH 0/3] Add NULL IpmiCommandLib instance
> 
> From: Abner Chang <abner.chang@amd.com>
> 
> BZ# 4231
> This patch adds a NULL instance of IpmiCommandLib to remove
> the dependence between edk2 and edk2-platform packages.
> 
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> 
> Abner Chang (3):
>   MdeModulePkg/Include: Add IpmiCommandLib header file
>   MdeModulePkg/IpmiCommandLib: Add NULL instance library
>   MdeModulePkg: Add IpmiCommandLib
> 
>  MdeModulePkg/MdeModulePkg.dec                 |   4 +
>  MdeModulePkg/MdeModulePkg.dsc                 |   2 +
>  .../BaseIpmiCommandLibNull.inf                |  32 +
>  MdeModulePkg/Include/Library/IpmiCommandLib.h | 683 ++++++++++++++++++
>  .../IpmiCommandLibNetFnApp.c                  | 252 +++++++
>  .../IpmiCommandLibNetFnChassis.c              | 123 ++++
>  .../IpmiCommandLibNetFnStorage.c              | 248 +++++++
>  .../IpmiCommandLibNetFnTransport.c            | 100 +++
>  8 files changed, 1444 insertions(+)
>  create mode 100644 MdeModulePkg/Library/BaseIpmiCommandLibNull/BaseIpmiCommandLibNull.inf
>  create mode 100644 MdeModulePkg/Include/Library/IpmiCommandLib.h
>  create mode 100644 MdeModulePkg/Library/BaseIpmiCommandLibNull/IpmiCommandLibNetFnApp.c
>  create mode 100644 MdeModulePkg/Library/BaseIpmiCommandLibNull/IpmiCommandLibNetFnChassis.c
>  create mode 100644 MdeModulePkg/Library/BaseIpmiCommandLibNull/IpmiCommandLibNetFnStorage.c
>  create mode 100644 MdeModulePkg/Library/BaseIpmiCommandLibNull/IpmiCommandLibNetFnTransport.c
> 
> --
> 2.37.1.windows.1
> 
> 
> 
> 
>