From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7DC5CAC0EC4 for ; Fri, 21 Jul 2023 15:33:46 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=+kiR+/wuuoBCvrdgx3DNc457EvzaSzWt1JR/4FqcAYc=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-IronPort-AV:X-IronPort-AV:X-Received:X-ExtLoop1:X-IronPort-AV:X-IronPort-AV:X-Received:X-Received:X-Received:X-Received:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:X-Received:X-Received:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:x-ms-publictraffictype:x-ms-traffictypediagnostic:x-ms-office365-filtering-correlation-id:x-ms-exchange-senderadcheck:x-ms-exchange-antispam-relay:x-microsoft-antispam-message-info:x-ms-exchange-antispam-messagedata-chunkcount:x-ms-exchange-antispam-messagedata-0:MIME-Version:X-MS-Exchange-CrossTenant-AuthAs:X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-Network-Message-Id:X-MS-Exchange-CrossTenant-originalarrivaltime:X-MS-Exchange-CrossTenant-fromentityheader:X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:X-MS-Exchange-CrossTenant-userprincipalname:X-MS-Exchange-Transport-CrossTenantHeaders Stamped:X-OriginatorOrg:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:X-Gm-Message-State:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1689953625; v=1; b=AV5uFNZMYVINe8B9CiEqnt2cnR8fwjyKDrMkEvmC3iWi3G29759/Pt3J5FxfOF/yAE0ETvQ6 Gy96JljCg1tOALp3Wm6MwvPSqQhbPuEuGLJaxDSENurakeRFmD5brEXVKLsEycE3yfT9byz3XhR jRQUl23kyegDxr7EjppEgpA4= X-Received: by 127.0.0.2 with SMTP id bMHuYY7687511xY5DL4rIHxh; Fri, 21 Jul 2023 08:33:45 -0700 X-Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.10132.1689953624944911521 for ; Fri, 21 Jul 2023 08:33:45 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10778"; a="351928167" X-IronPort-AV: E=Sophos;i="6.01,222,1684825200"; d="scan'208";a="351928167" X-Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2023 08:33:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10778"; a="838595584" X-IronPort-AV: E=Sophos;i="6.01,222,1684825200"; d="scan'208";a="838595584" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 21 Jul 2023 08:33:36 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 21 Jul 2023 08:33:31 -0700 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Fri, 21 Jul 2023 08:33:31 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Fri, 21 Jul 2023 08:33:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ahDtNxsMxQ3eL4GsvZ563VtA3g7gXzZ8QEm3+lLYolfPXrwGEjLmm+73RFZW+2DhsaRnoEgGM8Nsf4aUNtQgmlnNlBTLL5knITB8IHeoe4Mbea1NIDip6qJ25asXBjYNC17COh54l2OSd4k90at+e8lTR3/xP9xxVwL0QH7goT3wEY815oFqSMEDwhQpu10QqEWQhVoMG2/FezQuYhMbPMvHmafTJ4bpJ+Zr2QWBEVVR0EtAsH378Mgfc09WvS9YufGvakWxTdGdrtfb1ewaFzKGDOyNBGM0HWSJqxwtBVzudgtYmC4Ej0189701AcEak67dHbyP/yg3hyeEEWG3oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HAW2RiMTiAyiatt7Pq1Kk89Ct0quAA+nyRvF3TjXaJw=; b=EmOMrZ6+yL+dnBJlfALPSCoDj5bNCBpBHwh/v4nY141M2dJVS0gL0Z1Tjlld62nee0yPGqzhdEP6dwvzsubWusZjxPuTQVa/p21t68+WEnfi4GRmmPuk2wUxKHXmUbeTnuO8hVyYffRypV0ow3D4J6cVk/AbDfop3kVvxuBG21NI8HwgC16AlKMrfxgU+tp3/pJ0i2io7pubncoKiBIuYSzg2Fxv7KLBvQzdOot+J+ki+8yWKm8zD2y5qzVf3dkD7vwgMDbAQ1wJjzTf/bd411ct8u9SLCDtIbSwZXOsO70WJVPqlvBXTWjkv8c6Ypj0dO+8kYNp1PzE2KHjqNVPwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by PH0PR11MB7496.namprd11.prod.outlook.com (2603:10b6:510:280::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.25; Fri, 21 Jul 2023 15:33:27 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::9c86:9394:6bb1:2e83]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::9c86:9394:6bb1:2e83%5]) with mapi id 15.20.6609.026; Fri, 21 Jul 2023 15:33:27 +0000 From: "Michael D Kinney" To: "Jayaprakash, N" , "devel@edk2.groups.io" CC: Rebecca Cran , "Kloper, Dimitry" , "Kloper, Dimitry" , "Kinney, Michael D" Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc/StdLib: Uninitialized global variable Thread-Topic: [edk2-libc Patch 1/1] edk2-libc/StdLib: Uninitialized global variable Thread-Index: AQHZu+fef4PVCHLUw0aAOkq9zv2t1a/EWP7Q Date: Fri, 21 Jul 2023 15:33:27 +0000 Message-ID: References: <20230721152652.1761-1-n.jayaprakash@intel.com> <20230721152652.1761-2-n.jayaprakash@intel.com> In-Reply-To: <20230721152652.1761-2-n.jayaprakash@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|PH0PR11MB7496:EE_ x-ms-office365-filtering-correlation-id: 4eb159e4-d101-42aa-c78f-08db89ffd462 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: M6FAnz26/COuy2qb1+7PySEo4InyWQDKQMrm7CEAqRYkCt6WqokkoICJnncHt4DwpBUht1Jssn/nP+xiNSGiuFtYNPOoqfsb6OZ8vfgmaSeaUMv8ea73+2BN+/0N+uCCmetLk+So17KLXwaz/N7BQFskQ8N8syNyh6CztsIJb5XBRO/lHI85Ngcji2NF1v7O9AJP4waNpz+9mtGbpenmWNVPTrSFf9OCoENE87mbd/hYGwBrgNBU21YiwqeI0//Qfc9uCu70TO1DSIHrgn4ZTyXJA60k5SK6W3TM8L+dNkirj34P50EwknQPU7sBAPcam3C2xpEsKZ/pVSdE8w9apxbucH1s18chEMPS83w6GUQ9gcEp3EvW2YDraQnDIQvZk3QnZfRBvKyARFZ3jJCf2GIZKRpXWiU4rS0C5itDG8gHbsHuNX/4ohpZe5HZS1gZ1D9DMzf6PuPFQbVmo9B5Cf5/3tTt3nOhe+DKWXz6h1wY9qZmHmUopq3aZ4m0bcoFc0jBkDZDhnjs0HY9syHQM7ir7iGO3y2aM+Z2OmUEEVb2NsTYMoJcq8QkXlLBbb2eeEVOdboQzdQ1VlNtQXdEmgl0B4NagpvoHsL5HFR5rG4= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dMyMBgz9W6V9Ti3W7kLUQ+O9zu9suTGzFIIi99mh2hNKweNRtoAYkiu+5Juf?= =?us-ascii?Q?JXhtNyaTWIZtsimmmoBfnTXh3rvHGUq8d1QYYob54CZc/Ehqexvsdfa2dmwW?= =?us-ascii?Q?kKb3nShZEXoLp4TixZVdc9xJL/oKsuYFOFtELMLqZYfz/jUo+zJnaKa1HMni?= =?us-ascii?Q?eisy/uZWy+mi8kqniMQhtug0bxSuPIXzAOTYPet3wdX36327afstmH8SMB4l?= =?us-ascii?Q?Tl5/mFJWSj1KECZw5uu5cfXiLr4/r4QstxxeScQcUR5kAx127wDBkKEOFaDs?= =?us-ascii?Q?RKvqLpuPYO4VDbGCbiMEqWjv42mmUrFQ+D44F3uupn4q7DVLC8ay18qZaR8b?= =?us-ascii?Q?78I/gEimmTAUdTNgjOQIRVTnZbm+SB0UG3jQYFjrkT2PrmXPGxwQBVd9eD0V?= =?us-ascii?Q?WRr2hmXhvTVvqd0ngVY0DMGCK5SSPm5VHylUg6uB/FZ69A0iFygtXGIDI/Ym?= =?us-ascii?Q?V4pocqFlAKr+Kalbe+lWPTE5LuqlU1bvjQz2VODWR8KxBhXt7U27AnHl9HKZ?= =?us-ascii?Q?Wc9XgjlT98lJ8MyfRZMYFUKBTdygP8vjnxk55Mzg4YX/3PAxGT2LQFQid2Ca?= =?us-ascii?Q?xZIyuczo4FMoXx02Ab/nkJhNipqMguL+pppDcgQXwG2P/+umkTgZK+4NpyHq?= =?us-ascii?Q?Yus8amw+1Q6r9xuSfTpq7y+QP/Rxzetzy1L1uL7LvugejF1N4WyKXmPOTrqn?= =?us-ascii?Q?oOp1d3ObW28KmYdD0rFST74r9zr6wutTr8GWkLSoBlXzWFL3SaO1zUNXs8Am?= =?us-ascii?Q?kZc92faGdK6ew4XedXgjTUxFe9PYUGZmjHwBT1pNwGr2C+wbYO4wxFAnOq4g?= =?us-ascii?Q?DFzZdddwBBiRnMW5pebTk9mYpHPAjeSmm6HaEqfFjJ0hC+kVIg9ckZMkgnX2?= =?us-ascii?Q?n2VOZJaj2lADnF4ot4H3y1j3C5pJvrfJPhlGPT6hYWqXBljgpJzFL/2Ayv+Q?= =?us-ascii?Q?6QcNQcs1Aewhf91jzxcGJbwgzJYUZwhxfVXjlHPJp488KaPptAaDfNPM+fHN?= =?us-ascii?Q?vpywfNYMRRZiyW11wz72ziD+AfULUVTciKft3hnw/rkx597L05+POlVDZiSn?= =?us-ascii?Q?0wNosAHefCZeRFv3LtIXQdFPG/n9B00M6Lm4VHM1+UnSneWajbc+J0VDiVme?= =?us-ascii?Q?s0TsSaNZ+56HR1moxL0EwaE+06BYeigngsRfXWatatHPhYPk/tg9X7Fz6MDz?= =?us-ascii?Q?QZXXvUyGCt21ZY1Kbbh3rs1QA0DtKBj2ad9XOJys6XJ3ce+G/uFZupKxRuv4?= =?us-ascii?Q?xgYnVOdfB+xopFCarnP8wIVz/6+N6KMSTB4JSNTPxzT6VX4gxuD66wCns1Iw?= =?us-ascii?Q?xiqKw3479P9JVpM4kxWiAhKIMkdwVya6dO06JU9xMwYYgBIEJHfNjgz5KZp4?= =?us-ascii?Q?5CL9F1WI03Dj/x8r0PwLY2Ee5gUWy4ouzOka0SjelKzBPI2XOgUJMvIncCFU?= =?us-ascii?Q?3P2lIsNGg/FNPoX0WiqVICr8kvjYLVwv066JSHSJdjPItgMOAaZG/1rmd8PR?= =?us-ascii?Q?t14lFI8GyADyS0Qgk97I/BfX7EPLhoFx9tKGcftnIHFpyjLKhweQAX9t/4o0?= =?us-ascii?Q?s9kSspEy71a2Nqn5CUfGg+c9PhT3j7MJBa2TRU/dNFpZnkgQtilLDbUO73Ns?= =?us-ascii?Q?kg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4eb159e4-d101-42aa-c78f-08db89ffd462 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2023 15:33:27.5963 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zJEK3hWkALJTMYEkzaNb9q8mQN/WpdOXS5SZPA5cwPDmo6aXY6XKHWP4a8/LE8s1MCJ1jPmApBATsOQl8wRCEy7fr8mtsQexcdDRwgz+Z8w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7496 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: njEnRaSqyOzBwc5Sycxp75Blx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=AV5uFNZM; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi JP, I have not seen co-authored-by tag used before. If Dimitry is the author, then please update git commit so Dimitry is the author and remove that tag. Also, please make sure that names do not contain ','. Should be: Dimity Kloper Thanks, Mike > -----Original Message----- > From: Jayaprakash, N > Sent: Friday, July 21, 2023 8:27 AM > To: devel@edk2.groups.io > Cc: Jayaprakash, N ; Rebecca Cran > ; Kinney, Michael D ; > Kloper; Kloper, Dimitry > Subject: [edk2-libc Patch 1/1] edk2-libc/StdLib: Uninitialized global > variable >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4506 >=20 > res_init() is called from different places in sockets library. It > depends > on global _res variable containing a state. The problem is that > if __BIND_RES_TEXT macro is not defined, _res is not initialized. > Depending on compiler and build optimization this can fill the > variable with garbage that is later used by res_init(). > Fix is trivial - explicitly initialize _res. >=20 > Cc: Rebecca Cran > Cc: Michael D Kinney > Co-authored-by: Kloper, Dimitry > Signed-off-by: Jayaprakash N > --- > StdLib/BsdSocketLib/res_init.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/StdLib/BsdSocketLib/res_init.c > b/StdLib/BsdSocketLib/res_init.c > index 613a76a..fbc53c5 100644 > --- a/StdLib/BsdSocketLib/res_init.c > +++ b/StdLib/BsdSocketLib/res_init.c > @@ -121,11 +121,11 @@ static u_int32_t net_mask __P((struct in_addr)); > */ >=20 > struct __res_state _res > -# if defined(__BIND_RES_TEXT) > - =3D { RES_TIMEOUT, } /* Motorola, et al. */ > -# endif > - ; > - > +#if defined(__BIND_RES_TEXT) > + =3D { RES_TIMEOUT, }; /* Motorola, et al. */ > +#else > + =3D {0}; > +#endif >=20 > /* > * Set up default settings. If the configuration file exist, the > values > -- > 2.40.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107127): https://edk2.groups.io/g/devel/message/107127 Mute This Topic: https://groups.io/mt/100278658/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-