Re: [edk2-devel] [PATCH 1/2] SimicsOpenBoardPkg: Fix bug in DSDT

["Michael D Kinney" <michael.d.kinney@intel.com>]

Looks like obvious syntax fix.

Reviewed-by: Michael D Kinney <michael.d.kinneyintel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni, Ray
> Sent: Monday, April 10, 2023 7:53 PM
> To: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Cc: devel@edk2.groups.io; Guenzel, Robert <robert.guenzel@intel.com>
> Subject: Re: [edk2-devel] [PATCH 1/2] SimicsOpenBoardPkg: Fix bug in DSDT
> 
> Nate, can you help to give the R-B and push?
> 
> Thanks,
> Ray
> 
> > -----Original Message-----
> > From: Ni, Ray
> > Sent: Saturday, October 8, 2022 3:32 PM
> > To: devel@edk2.groups.io; Guenzel, Robert <robert.guenzel@intel.com>
> > Subject: RE: [PATCH 1/2] SimicsOpenBoardPkg: Fix bug in DSDT
> >
> > Thanks for fixing that.
> > Reviewed-by: Ray Ni <ray.ni@intel.com>
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > Guenzel,
> > > Robert
> > > Sent: Friday, October 7, 2022 5:27 PM
> > > To: devel@edk2.groups.io
> > > Cc: Guenzel, Robert <robert.guenzel@intel.com>
> > > Subject: [edk2-devel] [PATCH 1/2] SimicsOpenBoardPkg: Fix bug in DSDT
> > >
> > >
> > > The DSDT had a syntax error that was not detected by older iasl versions.
> > > This commit fixes the Syntax error.
> > >
> > > Signed-off-by: Robert Guenzel <robert.guenzel@intel.com>
> > > ---
> > >  Platform/Intel/SimicsOpenBoardPkg/AcpiTables/Dsdt.asl | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/Dsdt.asl
> > > b/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/Dsdt.asl
> > > index 8a6c3792..3421c9e8 100644
> > > --- a/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/Dsdt.asl
> > > +++ b/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/Dsdt.asl
> > > @@ -372,7 +372,7 @@ DefinitionBlock ("Dsdt.aml", "DSDT", 1, "INTEL ",
> > > "SIMICS  ", 4) {
> > >
> > >              Package () {0x000EFFFF, 0x00, 0, 16},
> > >              Package () {0x000EFFFF, 0x01, 0, 17},
> > > -            Package () {0x000EFFFF, 0x02, 0C, 18},
> > > +            Package () {0x000EFFFF, 0x02, 0, 18},
> > >              Package () {0x000EFFFF, 0x03, 0, 19},
> > >
> > >              Package () {0x000FFFFF, 0x00, 0, 16},
> > > --
> > > 2.34.1
> > >
> > > Intel Deutschland GmbH
> > > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> > > Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> > > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
> > > Chairperson of the Supervisory Board: Nicole Lau
> > > Registered Office: Munich
> > > Commercial Register: Amtsgericht Muenchen HRB 186928
> > >
> > >
> > >
> > >
> > >
> 
> 
> 
> 
>