Reviewed-by: Michael D Kinney michael.d.kinney@intel.com Yes. I will submit PR. Mike From: devel@edk2.groups.io On Behalf Of Bret Barkelew via groups.io Sent: Friday, April 30, 2021 2:16 PM To: devel@edk2.groups.io; Getnat Ejigu Cc: Kinney, Michael D ; Sean Brogan Subject: Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU Mike, Can you stage the PR for this? Thanks! - Bret From: Bret Barkelew via groups.io Sent: Friday, April 30, 2021 2:16 PM To: Getnat Ejigu; devel@edk2.groups.io Cc: Kinney, Michael D; Sean Brogan Subject: Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU Reviewed-by: Bret Barkelew > - Bret From: Getnat Ejigu Sent: Friday, April 30, 2021 2:07 PM To: devel@edk2.groups.io Cc: Kinney, Michael D; Sean Brogan; Bret Barkelew Subject: [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU Sample unit tests in UnitTestFrameworkPkg hangs when running in OVMF/QEMU environment. Build target is X64/GCC5. Fixing this issue by adding EFIAPI to ReportPrint() function that use VA_ARGS. Signed-off-by: Getnat Ejigu > Cc: Michael D Kinney > Cc: Sean Brogan > Cc: Bret Barkelew > --- UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c | 1 + UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c | 1 + UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c | 1 + 3 files changed, 3 insertions(+) diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c index 66c9db457d80..7f7443a23391 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c @@ -11,6 +11,7 @@ #include VOID +EFIAPI ReportPrint ( IN CONST CHAR8 *Format, ... diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c index cfb0c5972bd1..db5402d6a210 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c @@ -12,6 +12,7 @@ #include VOID +EFIAPI ReportPrint ( IN CONST CHAR8 *Format, ... diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c index 1402d0ef83e2..1d62c6a37117 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c @@ -11,6 +11,7 @@ #include VOID +EFIAPI ReportPrint ( IN CONST CHAR8 *Format, ... -- 2.25.1