From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: Rebecca Cran <rebecca@bsdio.com>,
Ard Biesheuvel <ardb@kernel.org>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Andrew Fish <afish@apple.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 1/1] Add a .editorconfig file to tell editors basic formatting details
Date: Fri, 8 Sep 2023 19:19:41 +0000 [thread overview]
Message-ID: <CO1PR11MB4929E6C78AC6F8E143DB7797D2EDA@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <fcab7674-1bd6-1aaf-a891-e711ad927a1a@bsdio.com>
Merged: https://github.com/tianocore/edk2/commit/d42ad81e2247bc6f1c30ef7be5fafc6fcfa0dfb9
> -----Original Message-----
> From: Rebecca Cran <rebecca@bsdio.com>
> Sent: Friday, September 8, 2023 10:08 AM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; Ard Biesheuvel
> <ardb@kernel.org>; devel@edk2.groups.io
> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm
> <quic_llindhol@quicinc.com>
> Subject: Re: [edk2-devel] [PATCH v2 1/1] Add a .editorconfig file to tell
> editors basic formatting details
>
> Looks good.
>
>
> $ file .editorconfig
> .editorconfig: ASCII text, with CRLF line terminators
>
>
> On 9/8/23 10:31, Kinney, Michael D wrote:
> > I already have PR opened. https://github.com/tianocore/edk2/pull/4811
> >
> > Can you verify the line endings are correct?
> >
> > Mike
> >
> >
> >> -----Original Message-----
> >> From: Ard Biesheuvel <ardb@kernel.org>
> >> Sent: Friday, September 8, 2023 9:21 AM
> >> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> >> Cc: Rebecca Cran <rebecca@bsdio.com>; Andrew Fish <afish@apple.com>;
> Leif
> >> Lindholm <quic_llindhol@quicinc.com>
> >> Subject: Re: [edk2-devel] [PATCH v2 1/1] Add a .editorconfig file to
> tell
> >> editors basic formatting details
> >>
> >> On Fri, 8 Sept 2023 at 17:54, Michael D Kinney
> >> <michael.d.kinney@intel.com> wrote:
> >>> Acked-by: Michael D Kinney <michael.d.kinney@intel.com>
> >>>
> >> Thanks
> >>
> >> I can merge this but note that we'll need to convert it to CR-LF
> >> first. (My VIM editor with editorconfig integration seems perfectly
> >> happy with that)
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108460): https://edk2.groups.io/g/devel/message/108460
Mute This Topic: https://groups.io/mt/97321658/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2023-09-08 19:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 18:19 [PATCH v2 1/1] Add a .editorconfig file to tell editors basic formatting details Rebecca Cran
2023-03-01 22:11 ` Ard Biesheuvel
2023-09-08 15:14 ` [edk2-devel] " Ard Biesheuvel
2023-09-08 15:54 ` Michael D Kinney
2023-09-08 16:21 ` Ard Biesheuvel
2023-09-08 16:31 ` Rebecca Cran
2023-09-08 16:31 ` Michael D Kinney
2023-09-08 17:07 ` Rebecca Cran
2023-09-08 19:19 ` Michael D Kinney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB4929E6C78AC6F8E143DB7797D2EDA@CO1PR11MB4929.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox